[Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #50 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Trying to give this one a go.

1) Terminology

issue is not supposed to be used according to our terminology list. We prefer
checkout. But... I am not sure what the better term for the person doing the
checkout would be here. In some other cases we have used "manager"
(accountlines). But if we wanted to record the person doing the checkin at some
point, this won't work. For the pref... RecordStaffUserOnCheckout or similar
could work. Overall not an easy one.

I'll only be asking for changes in the GUI.

+            - "When issuing an item, "
+            - pref: RecordIssuer
+              choices:
+                  yes: "record"
+                  no: "don't record"
+            - "the user who issued the item."

Please change to "staff user" and "issu*" to "check* out".

Everywhere else looks good.

2) Database update and installer don't match up

for old_issues.issuer we have default null in kohastructure.sql, but not in the
database update.

Maybe this has been discussed, but why not default null on issues.issuer? On
first glance it would make sense for me as we will also use NULL on all the old
entries.

3) Name display

+                    <a
href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% checkout.issuer | uri
%]">
+                    [% checkout.issued_by.firstname | html %] [%
checkout.issued_by.surname | html %]

I think we should use patron-title.inc here if possible.


4) Tests fail :(

I've run the database update and dbic manually, but the tests are failing:

Test Summary Report
-------------------
t/db_dependent/Circulation.t   (Wstat: 65280 Tests: 51 Failed: 1)
  Failed test:  51
  Non-zero exit status: 255
t/db_dependent/Koha/Checkouts.t (Wstat: 65280 Tests: 7 Failed: 1)
  Failed test:  7
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 8 tests but ran 7.
t/db_dependent/Koha/Patrons.t  (Wstat: 512 Tests: 28 Failed: 1)
  Failed test:  28
  Non-zero exit status: 2
  Parse errors: Bad plan.  You planned 41 tests but ran 28.

# Subtest: issuer
    1..3
    ok 1 - Koha::Checkout->issued_by should return a Koha::Patron
    ok 2 - Koha::Checkout->issued_by should return the correct patron
    # Looks like you planned 3 tests but ran 2.
not ok 7 - issuer

>From the verbose output:

#   Failed test 'issuer'
#   at t/db_dependent/Koha/Checkouts.t line 152.
Can't call method "issuer" on an undefined value at
t/db_dependent/Koha/Checkouts.t line 148.
# Looks like your test exited with 255 just after 7.
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 2/8 subtests 

item-level_itypes set but no itemtype set for item (1508) at
/home/vagrant/kohaclone/Koha/Schema/Result/Item.pm line 789.
DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
execute failed: Cannot add or update a child row: a foreign key constraint
fails (`koha_kohadev`.`items`, CONSTRAINT `items_ibfk_3` FOREIGN KEY
(`holdingbranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) [for
Statement "UPDATE `items` SET `datelastborrowed` = ?, `holdingbranch` = ?,
`issues` = ?, `onloan` = ? WHERE ( `itemnumber` = ? )" with ParamValues:
0='2020-10-02', 1="Branch4T", 2=1, 3='2020-10-01', 4=1508] at
/home/vagrant/kohaclone/Koha/Object.pm line 166
    # No tests run!
not ok 28 - No tests run for subtest "get_overdues"

#   Failed test 'No tests run for subtest "get_overdues"'
#   at t/db_dependent/Koha/Patrons.t line 1454.
Broken FK constraint# Looks like your test exited with 2 just after 28.
Dubious, test returned 2 (wstat 512, 0x200)
Failed 14/41 subtests 

I hope I didn't mess up the rebase, so not attaching my patches here (had fixed
a conflict in one of the test files).

-- 
You are receiving this mail because:
You are watching all bug changes.