[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556

--- Comment #62 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
(In reply to Martin Renvoize from comment #60)
> However, sorry Joonas, but t/db_dependent/api/v1/holds.t is failing.. and
> ideally I'd love to see some basic tests for the new set_* methods
> introduced in Koha::Hold.  They're trivial methods, but having a unit test
> that proves they correctly set the three fields for each of the methods will
> help prevent future regressions.

thanks, fixed the api test. I added the same test to set_processing and
set_transfer methods by calling $hold->suspend_hold as there was originally
with the set_waiting method. That should check what the function already does
(just set the found status). Do you think it is still required to explicitly
check the found status for these (even though it indirectly is checked by
suspend_hold call)?

-- 
You are receiving this mail because:
You are watching all bug changes.