[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659

--- Comment #4 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
This bug seem to have been already existing when the
AllowRenewalIfOtherItemsAvailable syspref was introduced in bug 11634. Already
back then there was incorrect check

> if ( CanItemBeReserved( $b, $i ) ) {

and that was partly due to rebase issue caused by bug 13116 being pushed on the
same day and even if there was no rebase issue there would have been the issue
that if the maxreserves limit were hit but not exceeded this would have allowed
the renewal incorrectly. So just adding the ->{status} eq 'OK'; fix would have
fixed the rebase issue that happened many years ago but in addition to that I
decided in this patch now also fix the issue if for example maxreserves is 1
and patron has one hold it should now block the renewal for the other patron.

-- 
You are receiving this mail because:
You are watching all bug changes.