[Koha-bugs] [Bug 26683] Fix Modules::RequireFilenameMatchesPackage Perl Critic Violations

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26683

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
Koha::Z3950Responder::RPN test plan:

0. Open 2 terminals

Terminal 1:
1. koha-z3950-responder --stop kohadev
2. perl misc/z3950_responder.pl

Terminal 2:
3. yaz-client 127.0.0.1:2100/biblios
4. #Note connection accepted
5. find @or @1=4 Bruce @1=4 Damian
6. #Note Number of hits: 9
7. #Iterate through results using "show" and notice the 245 has either Bruce or
Damian in it

Note that this just makes sure the koha-z3950-responder is still running. It
doesn't actually test that the Net::Z3950::RPN::* modules are actually doing
anything it seems. 

Ere Maijala might be the best person to verify this, since he's the one who
added Koha::Z3950Responder::RPN in Bug 13937 for "Add support for SRU and
Elasticsearch"

Before I added the 3rd patch "Load localized Net::Z3950::RPN::* modules", the
t/db_dependent/Koha/Z3950Responder/GenericSession.t test was failing, but now
it's passing.

--

(It's a shame we don't have a "lib" directory that contains all our Perl
modules, but that would require renaming too many files, so I don't see that
ever happening...)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.