[Koha-bugs] [Bug 26534] Add Font Awesome icon to help identify staff patrons

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534

--- Comment #39 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Fridolin SOMERS from comment #38)
> Oh now I see that my code :
> [% SET patron_is_staff = patron.has_permission({ 'catalogue' => 1 }) %]
> 
> Could have used existing var [% IF ( CAN_user_catalogue ) %].
> 
> Do I change ?

tl:dr; Keep is as is.

In this case, I actually like the addition of the patron_is_staff variable as
it makes it clear we're not so much looking for 'cataglogue' as we're trying to
just distinguish if the user is staff or not (In the future, we might
eventually add role based access control).. also, CAN_user_catalogue is at the
currently logged in user level, rather than on the patron we're interested in..
isn't it.

-- 
You are receiving this mail because:
You are watching all bug changes.