[Koha-bugs] [Bug 26719] Replace MSG_NO_RECORD_SELECTED with translatable string

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Oct 16 21:43:30 CEST 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26719

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #111932|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 111933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111933&action=edit
Bug 26719: Replace MSG_NO_RECORD_SELECTED with translatable string

This patch cleans up some loose ends left by Bug 25351, replacing
instances where the undefined variable MSG_NO_RECORD_SELECTED is used.

To test, apply the patch and perform a catalog search in the OPAC.

- On the search results page, without checking any checkboxes, use the
  "Select titles to..." menu to try to add to cart and add to a list. In
  each case you should get a "No item was selected" message.
- View a list which contains one or more titles. Click the "Remove
  from list" link. You should get a "No item was selected" link.

Other instances have been corrected even though they will only be
triggered if something has broken. For instance, toolbar items in the
cart window which are disabled shouldn't register the click that might
trigger the error. And selecting an item for an item-level hold
shouldn't ever give a warning because at least one radio button should
always be selected.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list