[Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

--- Comment #108 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
(In reply to Joonas Kylmälä from comment #98)
> Hi Emmi,
> 
> thanks for the rebases. I did code review and everything is looking really
> good! I have some trouble setting up my koha-testing-docker right now so I
> still need to go over the test plan for these patches. Could you meanwhile
> 
> a) Add your Rebased-by: Emmi Takkinen <emmi.takkinen at outlook.com> git
> trailer so that there will be a "paper trail" of you doing changes, now it
> basically reads that Lari did everything and also that the people
> signing-off here would have signed-off these changes but in actuality they
> have not. Please Add the Rebased-by trailer after the signed-off-by lines so
> that we know they were tested in a earlier revision and give credit for the
> people doing that.
> 
> b) Rebase one more time. There was minor merge conflict with one of the
> patches.

Rebased and fixed minor merge conflict with tests. Added git trailer after
sign-offs (followed instruction here:
https://wiki.koha-community.org/wiki/Commit_messages)

-- 
You are receiving this mail because:
You are watching all bug changes.