[Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #60 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Nick,

I think there are some small things:

1) We are missing unit tests for the changes to SearchField.pm and
Elasticsearch.pm

2) I believe the </tr> removed needs to be added back after the ELSE:

                       <td>
+                        [% IF search_field.mandatory %]
+                            <input type="text" name="search_field_label"
value="[% search_field.label | html %]" readonly />
+                        [% ELSE %]
                             <input type="text" name="search_field_label"
value="[% search_field.label | html %]" />
-                      </td>
+                        [% END %]
+
                       <td>

3) Database update

+    if( !column_exists( 'search_field', 'mandatory' ) ) {
+        $dbh->do( "ALTER TABLE search_field ADD COLUMN mandatory tinyint(1)
NULL DEFAULT NULL" );
+    }

Please add AFTER opac to make sure we always end up with the same sequence of
columsn :)

Functionality wise this appears to work ok. 

I think we'd need to work out which other fields we deem mandatory as a next
step?

-- 
You are receiving this mail because:
You are watching all bug changes.