[Koha-bugs] [Bug 23971] Add logging for basket related actions

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971

--- Comment #49 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
(In reply to Tomás Cohen Arazi from comment #48)
> - Bug 26582 is PQA, should we rebase this one on top of it? I can help (it
> means moving the tests to the relevant file, etc). This is mainly a question
> for the RM.
I think there's more to it than that. Looking at my code, currently the logging
is embedded within C4::Acquisision::CloseBasket. So I'd need to move that to
Koha::Acquisition::Basket::close. This isn't a problem, I just wanted to
highlight it in case it would be problematic. Having logging as a side-effect
in this way feels slightly weird, but it seems like it's less potentially error
prone than having to explicitly log at all the places where
Koha::Acquisition::Basket::close is called.

So, I think I'd have to move the logging as described above and modify the unit
tests accordingly.

> - I don't see tests for Koha::EDI related to the added APPROVE_BASKET
> action. They should be in t/db_dependent/Koha/EDI.t
> 
As discussed on Slack, to be able to test this very, very small bit of
functionality (is the approval of a basket logged) we'd have to implement a
large amount of EDI testing infrastructure that doesn't currently exist, this
seems out of scope to me.

I'm not going to do anything more on this until we're all happy with how to
move forward :-)

-- 
You are receiving this mail because:
You are watching all bug changes.