[Koha-bugs] [Bug 24412] Attach waiting hold to desk
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Fri Oct 23 15:30:23 CEST 2020
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412
--- Comment #103 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm pretty much ready to PQA this.. once I have an answer to a couple of minor
queries.
1/ Are you sure you want to delete a reserve that's attached to a desk when the
desk is deleted.. rather than setting the desk_id to null? This may need a tiny
followup ;)
2/ Would there ever be a requirement for desks to be 'required'.. in which case
we should probably introduce a pref and check to enforce this. This can be a
separate bug.
3/ Would there ever be a case where the librarian may want to override the desk
at the time of setting the reserve as waiting? This could also be in a
followup bug.
4/ I'm contemplating asking for a check in the set_waiting that ensures we set
a desk that corresponds to the branchcode to ensure we don't get mixed data.
I'm generally really happy with this development though, it's looking great.
Good Job!
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list