[Koha-bugs] [Bug 24412] Attach waiting hold to desk

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #108 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Martin Renvoize from comment #103)
> I'm pretty much ready to PQA this.. once I have an answer to a couple of
> minor queries.
> 
> 1/ Are you sure you want to delete a reserve that's attached to a desk when
> the desk is deleted.. rather than setting the desk_id to null? This may need
> a tiny followup ;)

I resolved this in my own QA follow-up

> 
> 2/ Would there ever be a requirement for desks to be 'required'.. in which
> case we should probably introduce a pref and check to enforce this. This can
> be a separate bug.

I decided this wouldn't be the case.  We need to allow AddReserve to continue
passing through no desk for the 'Automatically set holds to waiting' option of
'ReservesNeedReturns'. It might be nice to have the option of using
'Processing' for that case in the future however.

> 
> 3/ Would there ever be a case where the librarian may want to override the
> desk at the time of setting the reserve as waiting?  This could also be in a
> followup bug.

Another one for another bug in the future.

> 4/ I'm contemplating asking for a check in the set_waiting that ensures we
> set a desk that corresponds to the branchcode to ensure we don't get mixed
> data.

This is over the top at this time I think.

After all that.. I'm Passing QA!

-- 
You are receiving this mail because:
You are watching all bug changes.