[Koha-bugs] [Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Nick Clemens from comment #17)
> I was unsure at first about not being able to add a reason without sending
> the notice, however, it seems like you just won't add a reason if you don't
> want to send.
> 
> You can also force the reason and prevent sending by wrapping the notice in
> a conditional:
> [% UNLESS hold.cancellation_reason == 'INSANITY' %]
> ...
> [% END %]

Totally agree, at first o felt it a bit odd you couldn't add a reason without
sending the notice but I came to the same conclusion regarding doing it at the
TT template conditional level. I think if we wanted a nicer way to allow
addition of a reason without triggering the notice we should do that as its own
bug as we're just using the logic introduced in the dependancy bug here.

Thanks for the testing and QA everyone. 😀

-- 
You are receiving this mail because:
You are watching all bug changes.