[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |nick at bywatersolutions.com

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Trying to read the code, but there is a lot happening here, I feel this needs
unit tests

The check for 'OK' makes sense, but some of the other statuses like
'itemAlreadyOnHold' short circuit other checks, so while it saves us time in
CanItemBeReserved to bail out, I think in this instance we are actually trying
to determine "CanItemFillHold", CheckReserves seems to cover some, but not all
cases

-- 
You are receiving this mail because:
You are watching all bug changes.