[Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

--- Comment #110 from Lari Taskula <lari.taskula at hypernova.fi> ---
(In reply to Joonas Kylmälä from comment #109)
> What do the last two commits do
> ===============================
> 
> Bug 18595: Disable digest checkbox when forced on:
>  - This one maybe I don't understand because of the first error caused by
> missing email. Specifically I don't understand in which situation the digest
> checkbox should be disabled.
There are libraries that wish to only send notifications as digests. IIRC, the
only way to achieve this was to configure it directly in the database via
"message_transports" table by removing rows where "is_digest" is 0. This patch
disables digest checkbox elements in such cases.

> Bug 18595: Validate days_in_advance
>  - What does this do exactly? I see it change days_in_advance=NULL but what
> is the reason behind that?
It's been 3 years since I provided these patches so I can't exactly remember
why and where but some patron messaging preferences had invalid values for
borrower_message_preferences.days_in_advance column and it caused plenty of
"Internal Server Error" messages in production. No idea whether it came from
Koha bugs at some point in the history, or from sysadmins themselves, but I
suppose it's safer to do a little database cleanup and run such query because
it simply nulls days_in_advance for every option that does not allow it.

-- 
You are receiving this mail because:
You are watching all bug changes.