[Koha-bugs] [Bug 26831] Replace 'list-invites' parameter with system preference in cleanup_database.pl cronjob

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |In Discussion

--- Comment #2 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Hi Katrin,

I've done a bit of investigation and found bug 13287  , and wondered if our
approach to the --list-invites parameter in the cleanup_database.pl cron job
should change?

Looking at that bug, I saw instead of replacing the cron parameter with a
system preference, they used both:

* If both parameter and syspref are set then prioritise the parameter value
* If only syspref is set then use syspref value
* If only parameter set then use parameter value
* If neither syspref nor parameter value is set then don't do anything

If we go with this approach, then at least existing installs can to continue to
call the cleanup_database.pl cronjob, with the list-invites parameter, without
a change of behaviour. What are your thoughts on this?

I thought it good to have a discussion about this, before I start writing the
unit tests!

Thanks,
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.