[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814

--- Comment #27 from Lari Taskula <lari.taskula at hypernova.fi> ---
What options should circulation rules have for onsite-checkout?
Option 1:
"No"    circulation_rules.onsite_checkout => 0
"Yes"   circulation_rules.onsite_checkout => 1

or

Option 2:
"All"   circulation_rules.onsite_checkout => undef
"No"    circulation_rules.onsite_checkout => 0
"Yes"   circulation_rules.onsite_checkout => 1

The problem has to do with how we process circulation_rules scopes and the "*"
aka undef value.

1. With option 1 it becomes impossible to share rules for normal and on-site
checkouts and likely requires a lot of rule duplication. Also, how would we
handle cases where the value for onsite-checkout is not known as there is no
'*' rule? Just use the "No" option?

2. My reasoning for option 2 was that it would enable sharing of rules between
those two checkout types. For example, sharing a fine rule:

branch | onsite | ccode | itype | name            | value
*      | *      | *     | *     | fine            | 5
*      | 1      | *     | *     | renewalsallowed | 1
*      | 0      | *     | *     | renewalsallowed | 5

But it seems such flexibility is not supported by the current graphical user
interface because it just sets all the rules in that row for that scope, even
if you don't touch them (to test: simply create a new rule using a new scope
and press Save, and you will see all rule columns were added into
circulation_rules). So we cannot share the rules unless we do it directly in
the database. Not sure how it works in the upcoming GUI.

-- 
You are receiving this mail because:
You are watching all bug changes.