[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Alexis Ripetti <alexis.ripetti at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #57 from Alexis Ripetti <alexis.ripetti at inLibro.com> ---
So, I fixed the test that does not pass.
I also put the changes in the good patch.
When I apply both patches, I got this :

<pre>
not ok 8

    #   Failed test at t/db_dependent/Circulation.t line 2102.
    #          got: '2020-11-17'
    #     expected: '2020-11-25'
    # Looks like you failed 1 test of 8.
not ok 28 - AddReturn + CumulativeRestrictionPeriods

#   Failed test 'AddReturn + CumulativeRestrictionPeriods'
#   at t/db_dependent/Circulation.t line 2103.
</pre>

Is this the one who should fail ?

I also got this :

<pre>
not ok 14 - Hourly rental charge calculated correctly with
rentalcharge_hourly_calendar = 0 (168h * 0.25u)

    #   Failed test 'Hourly rental charge calculated correctly with
rentalcharge_hourly_calendar = 0 (168h * 0.25u)'
    #   at t/db_dependent/Circulation.t line 3554.
    #          got: '47.75'
    #     expected: '42'
    ok 15 - Hourly rental charge calculated correctly with
rentalcharge_hourly_calendar = 0, for renewal (312h - 168h * 0.25u)
    not ok 16 - Hourly rental charge calculated correctly with
rentalcharge_hourly_calendar = 1 and closed Saturday (168h - 24h * 0.25u)

    #   Failed test 'Hourly rental charge calculated correctly with
rentalcharge_hourly_calendar = 1 and closed Saturday (168h - 24h * 0.25u)'
    #   at t/db_dependent/Circulation.t line 3568.
    #          got: '35.75'
    #     expected: '36'
    ok 17 - Hourly rental charge calculated correctly with
rentalcharge_hourly_calendar = 1 and closed Saturday, for renewal (312h - 168h
- 24h * 0.25u
    not ok 18 - Hourly rental charge calculated correctly with
rentalcharge_hourly_calendar = 1 (168h - 0h * 0.25u

    #   Failed test 'Hourly rental charge calculated correctly with
rentalcharge_hourly_calendar = 1 (168h - 0h * 0.25u'
    #   at t/db_dependent/Circulation.t line 3582.
    #          got: '41.75'
    #     expected: '42'
    ok 19 - Hourly rental charge calculated correctly with
rentalcharge_hourly_calendar = 1, for renewal (312h - 168h - 0h * 0.25u)
    # Looks like you failed 3 tests of 19.
not ok 42 - Incremented fee tests

#   Failed test 'Incremented fee tests'
#   at t/db_dependent/Circulation.t line 3592.
</pre>

These failed tests are also here when I do not apply both patches.
Do you get the same errors?

-- 
You are receiving this mail because:
You are watching all bug changes.