From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 00:15:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2020 22:15:11 +0000 Subject: [Koha-bugs] [Bug 25448] Update German (de-DE) framework files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25448 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105308|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 109385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109385&action=edit Bug 25448: Update German (de-DE) framework files The updated files have been auto-generated based on the po files and downloaded from https://translate.koha-community.org/files/ To test: - Make sure German language is installed, see: https://wiki.koha-community.org/wiki/Installation_of_additional_languages_for_OPAC_and_INTRANET_staff_client - Run the web installer and choose de-DE - Select all sample files - Make sure they all install without any errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 00:15:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2020 22:15:56 +0000 Subject: [Koha-bugs] [Bug 25448] Update German (de-DE) framework files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25448 --- Comment #4 from Katrin Fischer --- Hi Jonathan, thx for catching this! It looks like an issue with how the files are generated - the string is translated in pootle, but in the files it's not. I have changed this one line manually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 01:15:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2020 23:15:25 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #202 from David Cook --- (In reply to Marcel de Rooy from comment #168) > I will add my signoff line in the expectation that things like improving > configuration and future extension for other MQ use will be handled later on. Cheers, Marcel! I'll certainly be contributing patches once this main patch set is pushed. I have ideas and enthusiasm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 01:33:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2020 23:33:23 +0000 Subject: [Koha-bugs] [Bug 25698] Curbside Pickup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25698 --- Comment #15 from David Cook --- That Equinox news item was a bit confusing, although it makes more sense when read after the previous news item at https://www.equinoxinitiative.org/fe_highlightitem.php?sid=10155f3ecfef0033d446 which actually references this bug report and how Kyle (of Bywater) started the plugin. I am also really pumped for Galen's contribution to that plugin. Lack of DBIC integration in plugins has been a pain when I've been writing them, so this offers a nice change. (Although we might want to create some Koha::Plugin::* code to make it easier for any plugin to use the functionality without copying the boiler plate if possible.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 01:42:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2020 23:42:02 +0000 Subject: [Koha-bugs] [Bug 26299] Help text for OPAC SMS number should be less North American-centric In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 --- Comment #5 from David Cook --- (In reply to Jonathan Druart from comment #4) > Nick, are you ok with this? Alternatively, we could provide a printf pattern for rendering the numbers in a more localized way I suppose? Seems like Template::Toolkit has a few options on that front. Since the OPAC is public-facing, I could see wanting to make it seem more polished than the Staff Interface... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 01:43:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2020 23:43:55 +0000 Subject: [Koha-bugs] [Bug 24663] OPACPublic must be tested for all opac scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24663 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 01:59:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2020 23:59:11 +0000 Subject: [Koha-bugs] [Bug 26170] Create "system" patrons that cannot be (easily) deleted via the web UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26170 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23634 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 01:59:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2020 23:59:11 +0000 Subject: [Koha-bugs] [Bug 23634] Privilege escalation vulnerability for staff users with 'edit_borrowers' permission and 'OpacResetPassword' enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23634 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26170 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 02:03:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 00:03:34 +0000 Subject: [Koha-bugs] [Bug 26170] Create "system" patrons that cannot be (easily) deleted via the web UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26170 --- Comment #6 from David Cook --- Bug 23634 provides similar logic to what will be needed here. But instead of "$patron->is_superlibrarian && ! $user->is_superlibrarian", it'll be "$patron->is_system_user && ! $user->is_superlibrarian". Now I just need to decide how to denote a system user. On Bug 23634, Martin mentions that we don't have role based access control (RBAC) and that's true, but maybe that should change. Although RBAC can get complicated. While you could calculate and cache the permissions for a logged in user session, that could get more challenging for the $patron that isn't logged in... I suppose maybe it wouldn't be too hard to do $patron->has_role('system'), especially leveraging a L1 cache. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 02:18:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 00:18:29 +0000 Subject: [Koha-bugs] [Bug 26326] Add Koha Objects for Record Import Matches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26326 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 02:24:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 00:24:31 +0000 Subject: [Koha-bugs] [Bug 26328] New: barcode.pl: ValueBuilder::incremental should cast barcode to unsigned integer Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26328 Bug ID: 26328 Summary: barcode.pl: ValueBuilder::incremental should cast barcode to unsigned integer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: pablo.bianchi at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When using barcode.pl or barcode_manual.pl:, if a barcode is "85350E65", because of the "E" the value builder interprets it as having exponential notation: "8.535e69". This happens on C4::Barcodes::ValueBuilder::incremental, on get_barcode(). When it says SELECT MAX(ABS(barcode)) FROM items; probably should be instead SELECT MAX(ABS(CAST(barcode AS UNSIGNED))) FROM items; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 02:38:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 00:38:30 +0000 Subject: [Koha-bugs] [Bug 26329] New: opac-tags.pl hardmax should be configurable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26329 Bug ID: 26329 Summary: opac-tags.pl hardmax should be configurable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org opac-tags.pl has a default hard max number of tags of 100. This should be configured with a system preference like "OpacTagHardMax" so that libraries can specify their own value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 02:42:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 00:42:53 +0000 Subject: [Koha-bugs] [Bug 26320] Crash when click search button with empty key word In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26320 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- (In reply to Jonathan Druart from comment #1) > I get an alert "Please enter one or more search terms first.", maybe you > don't have javascript enabled? I have the same experience as Jonathan. Tested on Chrome and IE 11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 02:55:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 00:55:06 +0000 Subject: [Koha-bugs] [Bug 26328] barcode.pl: ValueBuilder::incremental should cast barcode to unsigned integer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26328 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- That's an interesting one. Your suggestion returns a value of 9223372036854775807. I would say that is an undesirable outcome as well. It's probably better to use something like this: SELECT MAX(ABS(barcode)) FROM items WHERE barcode REGEXP '^[0-9]+$'; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 04:10:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 02:10:04 +0000 Subject: [Koha-bugs] [Bug 26328] barcode.pl: ValueBuilder::incremental should cast barcode to unsigned integer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26328 --- Comment #2 from Pablo AB --- You are right. On my tests: SELECT barcode FROM items ORDER BY ABS(CAST(barcode AS UNSIGNED)) DESC LIMIT 5; 770101E1 → 770101 (CAST on SELECT) SELECT barcode FROM items ORDER BY ABS(barcode) DESC LIMIT 5; 85350E65 → 8.535e69 (ABS on SELECT) Your proposal seems the way to go. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 04:15:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 02:15:15 +0000 Subject: [Koha-bugs] [Bug 26328] barcode.pl: ValueBuilder::incremental should filter non-natural numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26328 Pablo AB changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|barcode.pl: |barcode.pl: |ValueBuilder::incremental |ValueBuilder::incremental |should cast barcode to |should filter non-natural |unsigned integer |numbers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 05:20:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 03:20:06 +0000 Subject: [Koha-bugs] [Bug 26330] New: Subfields constraints editor should hide all new others subfields Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330 Bug ID: 26330 Summary: Subfields constraints editor should hide all new others subfields Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: pablo.bianchi at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 109386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109386&action=edit Screenshot of the issue To describe items with more detail a librarian needed more subfields on 952 tag, so after using the few available ASCII letters and numbers started using Greek letters, alpha (α), beta (β), gamma (γ)... Then while editing any subfield, currently selected is shown and then all the other new ones (full-page screenshot attached). The problem seems related to the fact that under subfieldtabs id all divs but the selected should have style="display: none;". This is working only with all the ones matching [0-9a-z]. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 07:18:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 05:18:54 +0000 Subject: [Koha-bugs] [Bug 26331] New: svc/letters/preview is not executable which prevents CGI functioning Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26331 Bug ID: 26331 Summary: svc/letters/preview is not executable which prevents CGI functioning Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org svc/leters/preview is not marked as executable, so it will generate a 500 error when running in CGI. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 07:21:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 05:21:19 +0000 Subject: [Koha-bugs] [Bug 26331] svc/letters/preview is not executable which prevents CGI functioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26331 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 07:21:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 05:21:22 +0000 Subject: [Koha-bugs] [Bug 26331] svc/letters/preview is not executable which prevents CGI functioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26331 --- Comment #1 from David Cook --- Created attachment 109387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109387&action=edit Bug 26331: Make svc/letters/preview executable Without this patch, you can't preview letters when running Koha in CGI mode. To test: 1. Run Koha as CGI (and not Plack) 2. Go to /cgi-bin/koha/tools/letter.pl?op=add_form&branchcode=&module=circulation&code=CHECKIN 3. Try to preview the notice (using a valid barcode) 4. Note in the browser console that svc/letters/preview is generating a 500 error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 08:04:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 06:04:39 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #203 from Julian Maurice --- All errors from QA script are gone :) One minor annoyance: when you apply all patches except those with "DO NOT PUSH", it fail at some point: Application de Bug 22417: UpdateDB entry Application de Bug 22417: DBIX Schema changes Application de Bug 22417: Add Koha::BackgroundJob[s] Application de Bug 22417: Add Koha::BackgroundJob::BatchUpdateBiblio Application de Bug 22417: Add Koha::BackgroundJob::BatchUpdateAuthority Application de Bug 22417: Add GUI to watch the progress of jobs Application de Bug 22417: Adapt the batch_record_modification tool Application de Bug 22417: Add the ability to cancel a job Utilisation de l'information de l'index pour reconstruire un arbre de base... A new_koha_job.pl Retour à un patch de la base et fusion à 3 points... CONFLIT (modification/suppression) : new_koha_job.pl supprimé dans HEAD et modifié dans Bug 22417: Add the ability to cancel a job. Version Bug 22417: Add the ability to cancel a job de new_koha_job.pl laissée dans l'arbre. error: Échec d'intégration des modifications. le patch a échoué à 0001 Bug 22417: Add the ability to cancel a job It may be good to do a little cleanup on these patches, and maybe squash followup patches ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 09:29:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 07:29:20 +0000 Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357 --- Comment #55 from Ere Maijala --- Indeed my proposal was just to add elision filtering to the default ES index config without any code changes. The first patch still does that, but since then there have been additional ideas incorporated. I think that it would make sense to create separate bugs for them. Then it would only leave us with the question of whether we include elision filtering in the default configuration or just document this as a possibility. Either way is fine for me since in Finland we'll need to customize the default config regardless. I'm not sure how to reach consensus on this. I believe including filtering by default would make sense regardless of whether the catalog contains French titles since it helps searching e.g. author names too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 09:31:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 07:31:30 +0000 Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357 --- Comment #56 from Katrin Fischer --- +1 for default filtering. It's how it works now in the default and we haven't seen questions or complaints about this. To me it appears to be the expected behaviour. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 09:31:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 07:31:48 +0000 Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357 --- Comment #57 from Katrin Fischer --- (In reply to Katrin Fischer from comment #56) > +1 for default filtering. It's how it works now in the default and we > haven't seen questions or complaints about this. To me it appears to be the > expected behaviour. And welcome back, Ere :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 09:41:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 07:41:29 +0000 Subject: [Koha-bugs] [Bug 12617] Koha should let admins to configure automatically generated password complexity/difficulty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12617 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107382|0 |1 is obsolete| | Attachment #107384|0 |1 is obsolete| | --- Comment #9 from Emmi Takkinen --- Created attachment 109388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109388&action=edit Bug 12617: Koha should let admins to configure automatically generated password complexity/difficulty Rebased and reworked patch against bug 23816. Changes made 'PasswordLengthsForCategories' syspref obsolete so patch for it is dropped. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 09:42:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 07:42:15 +0000 Subject: [Koha-bugs] [Bug 12617] Koha should let admins to configure automatically generated password complexity/difficulty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12617 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107383|0 |1 is obsolete| | --- Comment #10 from Emmi Takkinen --- Created attachment 109389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109389&action=edit Bug 12617: Add new regex patterns to password_check.inc Rebased and reworked patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 09:42:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 07:42:31 +0000 Subject: [Koha-bugs] [Bug 12617] Koha should let admins to configure automatically generated password complexity/difficulty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12617 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 09:44:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 07:44:33 +0000 Subject: [Koha-bugs] [Bug 25101] Add ability to skip previewing results when batch extending due dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 --- Comment #20 from Jonathan Druart --- I am not a native English speaker but for me the 2 sentences have opposite sense. The hint from Katrin's patch is "This is recommended when changing very large numbers of due dates." Which means: you should check it if you are processing a lot of issues. It's the reverse, if the checkbox is checked we are going to display the preview screen, which will fail if the amount of due dates is too large. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 09:46:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 07:46:51 +0000 Subject: [Koha-bugs] [Bug 25101] Add ability to skip previewing results when batch extending due dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 --- Comment #21 from Katrin Fischer --- A new day, maybe the fix is simple: "This is not recommended when changing very large numbers of due dates." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 09:57:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 07:57:35 +0000 Subject: [Koha-bugs] [Bug 26045] Search/History.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26045 --- Comment #1 from Jonathan Druart --- 20.05_U16 #57 (Docker_2) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 10:01:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 08:01:49 +0000 Subject: [Koha-bugs] [Bug 26031] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26031 --- Comment #16 from Jonathan Druart --- Koha_20.05_U18 #61 (Docker_3) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 10:17:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 08:17:35 +0000 Subject: [Koha-bugs] [Bug 26332] New: Koha::Account::pay incorrectly defaults to '0' for manager_id Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26332 Bug ID: 26332 Summary: Koha::Account::pay incorrectly defaults to '0' for manager_id Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Since bug 22008 we have a foreign key constraint for manager_id against the borrowers table; However, we neglected to update the 'pay' routing in Koha::Account to reflect this non-required field and left it to default to '0' which may not be a borrower at all. We should allow 'undef' to be passed into 'pay' unaltered when the interface is anything other than 'staff'.. as it may reflect a SIP or OPAC payment where no staff member is required to be present. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 10:17:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 08:17:41 +0000 Subject: [Koha-bugs] [Bug 26332] Koha::Account::pay incorrectly defaults to '0' for manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26332 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 10:17:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 08:17:54 +0000 Subject: [Koha-bugs] [Bug 26332] Koha::Account::pay incorrectly defaults to '0' for manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26332 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22008 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 [Bug 22008] accountlines.manager_id is missing a foreign key constraint -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 10:17:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 08:17:54 +0000 Subject: [Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26332 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26332 [Bug 26332] Koha::Account::pay incorrectly defaults to '0' for manager_id -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 10:18:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 08:18:07 +0000 Subject: [Koha-bugs] [Bug 26332] Koha::Account::pay incorrectly defaults to '0' for manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26332 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 10:18:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 08:18:07 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26332 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26332 [Bug 26332] Koha::Account::pay incorrectly defaults to '0' for manager_id -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 10:29:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 08:29:06 +0000 Subject: [Koha-bugs] [Bug 26332] Koha::Account::pay incorrectly defaults to '0' for manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26332 --- Comment #1 from Martin Renvoize --- Hmm.. The data in question is coming from the userenv.. so in theory should always be set and not require a fallback at all. I think this perhaps highlights an issue in some plugin code not setting userenv properly in my case.. but I still feel we should not be defaulting back to '0' and exploding.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:01:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:01:53 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #204 from Jonathan Druart --- Created attachment 109390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109390&action=edit Bug 22417: Remove $dbh in Koha::BackgroundJob::* Also remove unused $job_type var -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:01:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:01:59 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #205 from Jonathan Druart --- Created attachment 109391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109391&action=edit Bug 22417: Add tests Finally! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:36:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:36:18 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109319|0 |1 is obsolete| | Attachment #109320|0 |1 is obsolete| | Attachment #109321|0 |1 is obsolete| | Attachment #109322|0 |1 is obsolete| | Attachment #109323|0 |1 is obsolete| | Attachment #109324|0 |1 is obsolete| | Attachment #109325|0 |1 is obsolete| | Attachment #109326|0 |1 is obsolete| | Attachment #109327|0 |1 is obsolete| | Attachment #109328|0 |1 is obsolete| | Attachment #109329|0 |1 is obsolete| | Attachment #109330|0 |1 is obsolete| | Attachment #109331|0 |1 is obsolete| | Attachment #109332|0 |1 is obsolete| | Attachment #109333|0 |1 is obsolete| | Attachment #109334|0 |1 is obsolete| | Attachment #109335|0 |1 is obsolete| | Attachment #109336|0 |1 is obsolete| | Attachment #109337|0 |1 is obsolete| | Attachment #109338|0 |1 is obsolete| | Attachment #109339|0 |1 is obsolete| | Attachment #109340|0 |1 is obsolete| | Attachment #109341|0 |1 is obsolete| | Attachment #109342|0 |1 is obsolete| | Attachment #109343|0 |1 is obsolete| | Attachment #109344|0 |1 is obsolete| | Attachment #109345|0 |1 is obsolete| | Attachment #109350|0 |1 is obsolete| | Attachment #109351|0 |1 is obsolete| | Attachment #109355|0 |1 is obsolete| | Attachment #109390|0 |1 is obsolete| | Attachment #109391|0 |1 is obsolete| | --- Comment #206 from Jonathan Druart --- Created attachment 109392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109392&action=edit Bug 22417: UpdateDB entry TODO: - Add the FK on borrowernumber Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Cook Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:36:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:36:24 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #207 from Jonathan Druart --- Created attachment 109393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109393&action=edit Bug 22417: DBIX Schema changes Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Cook Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:36:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:36:29 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #208 from Jonathan Druart --- Created attachment 109394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109394&action=edit Bug 22417: Add Koha::BackgroundJob[s] Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Cook Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:36:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:36:34 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #209 from Jonathan Druart --- Created attachment 109395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109395&action=edit Bug 22417: Add Koha::BackgroundJob::BatchUpdateBiblio Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Cook Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:36:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:36:39 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #210 from Jonathan Druart --- Created attachment 109396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109396&action=edit Bug 22417: Add Koha::BackgroundJob::BatchUpdateAuthority This is not ready yet! Note that this is too close to Koha::BackgroundJob::BatchUpdateBiblio, we will want to refactor bit of code. Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Cook Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:36:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:36:44 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #211 from Jonathan Druart --- Created attachment 109397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109397&action=edit Bug 22417: Add GUI to watch the progress of jobs Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Cook Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:36:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:36:50 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #212 from Jonathan Druart --- Created attachment 109398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109398&action=edit Bug 22417: Adapt the batch_record_modification tool Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Cook Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:36:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:36:55 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #213 from Jonathan Druart --- Created attachment 109399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109399&action=edit Bug 22417: Add the ability to cancel a job Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Cook Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:37:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:37:00 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #214 from Jonathan Druart --- Created attachment 109400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109400&action=edit Bug 22417: Fix borrowernumber values Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Cook Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:37:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:37:06 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #215 from Jonathan Druart --- Created attachment 109401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109401&action=edit Bug 22417: Add debian script koha-worker Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Cook Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:37:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:37:11 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #216 from Jonathan Druart --- Created attachment 109402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109402&action=edit Bug 22417: Switch to STOMP apt install rabbitmq-server service rabbitmq-server start rabbitmq-plugins enable rabbitmq_stomp apt install libnet-stomp-perl cp debian/scripts/koha-functions.sh /usr/share/koha/bin/koha-functions.sh cp debian/scripts/koha-worker /usr/bin/ koha-worker --start kohadev tail -f /var/log/rabbitmq/* Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Cook Signed-off-by: Marcel de Rooy Bug 22417: Remove useless use statement Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:37:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:37:17 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #217 from Jonathan Druart --- Created attachment 109403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109403&action=edit Bug 22417: Handle errors Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Cook Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:37:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:37:22 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #218 from Jonathan Druart --- Created attachment 109404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109404&action=edit Bug 22417: Try to display pending jobs - only work if worker not started ie. no subscription yet This needs to be fixed (if possible), or removed from the patchset Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Cook Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:37:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:37:28 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #219 from Jonathan Druart --- Created attachment 109405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109405&action=edit Bug 22417: Fix the batch authority tool Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Cook Signed-off-by: Marcel de Rooy Bug 22417: Add a note about the existence of the DB row Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Cook Signed-off-by: Marcel de Rooy Bug 22417: (follow-up) Fix the batch authority tool Signed-off-by: David Cook Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:37:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:37:33 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #220 from Jonathan Druart --- Created attachment 109406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109406&action=edit Bug 22417: Restore the concept of namespace Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Cook Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:37:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:37:38 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #221 from Jonathan Druart --- Created attachment 109407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109407&action=edit Bug 22417: Restore the 'add to list' feature This feature has been added recently by bug 18127. It highlights the need of a post processing hook. Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Cook Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:37:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:37:44 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #222 from Jonathan Druart --- Created attachment 109408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109408&action=edit Bug 22417: Add the new permission manage_background_jobs QA: Please answer the question in admin/background_jobs.pl Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Cook Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:37:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:37:49 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #223 from Jonathan Druart --- Created attachment 109409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109409&action=edit Bug 22417: Send message to /queue This cannot be: /queue/$namespace/$job_type I got: '/koha_kohadev/batch_biblio_record_modification' is not a valid queue destination So keeping the dash in $namespace-$job_type Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Cook Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:37:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:37:55 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #224 from Jonathan Druart --- Created attachment 109410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109410&action=edit Bug 22417: Remove record_type from BatchUpdate* We don't need to pass it to the job, they each know which record type they are dealing with Signed-off-by: David Cook Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:38:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:38:00 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #225 from Jonathan Druart --- Created attachment 109411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109411&action=edit Bug 22417: Let owner of a job see the progress A owner of a job should be able to see the progress of this job. Signed-off-by: David Cook Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:38:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:38:05 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #226 from Jonathan Druart --- Created attachment 109412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109412&action=edit Bug 22417: Remove FIXME in the template Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:38:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:38:10 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #227 from Jonathan Druart --- Created attachment 109413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109413&action=edit Bug 22417: Add missing POD and html filters Also remove "authnotrequired => 0," -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:38:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:38:16 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #228 from Jonathan Druart --- Created attachment 109414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109414&action=edit Bug 22417: Add new Net::Stomp dependency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:38:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:38:21 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #229 from Jonathan Druart --- Created attachment 109415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109415&action=edit Bug 22417: Fix spelling resizeable vs resizable For the record, codespell does not raise the problem within ktd with 1.17.1 but appears with 1.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:38:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:38:27 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #230 from Jonathan Druart --- Created attachment 109416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109416&action=edit Bug 22417: Remove $dbh in Koha::BackgroundJob::* Also remove unused $job_type var -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:38:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:38:34 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #231 from Jonathan Druart --- Created attachment 109417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109417&action=edit Bug 22417: Add tests Finally! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:39:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:39:54 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #232 from Jonathan Druart --- Created attachment 109418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109418&action=edit Bug 22417: [DO NOT PUSH] Add simple worker and add_job scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 11:42:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 09:42:21 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #233 from Jonathan Druart --- I squashed some patches (the easy ones), more squashes could be done but changes will have to be split (so more work and not much added value IMO). I put the 2 test scripts on a separate commit (for history). Julian, do you want to have another look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 12:00:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 10:00:28 +0000 Subject: [Koha-bugs] [Bug 26299] Help text for OPAC SMS number should be less North American-centric In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 --- Comment #6 from Nick Clemens --- (In reply to Jonathan Druart from comment #4) > Nick, are you ok with this? I checked with our educators - their concern is that it not start with 1, which is the indicator of 'long distance' calls here. 9785550123 would be better as it won't end up being a real phone number https://en.wikipedia.org/wiki/555_(telephone_number) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 12:23:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 10:23:01 +0000 Subject: [Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 --- Comment #92 from Jonathan Druart --- Created attachment 109419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109419&action=edit Bug 19889: Add new attribute to the REST API definition It fixes t/db_dependent/api/v1/items.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 12:23:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 10:23:20 +0000 Subject: [Koha-bugs] [Bug 25504] Wrong API spec breaks plack without meaningful error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25504 --- Comment #26 from Jonathan Druart --- Created attachment 109420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109420&action=edit Bug 25504: Fix failing tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 12:25:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 10:25:29 +0000 Subject: [Koha-bugs] [Bug 25504] Wrong API spec breaks plack without meaningful error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25504 --- Comment #27 from Jonathan Druart --- (In reply to Jonathan Druart from comment #26) > Created attachment 109420 [details] [review] > Bug 25504: Fix failing tests Pushed to master for 20.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 12:25:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 10:25:34 +0000 Subject: [Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 --- Comment #93 from Jonathan Druart --- (In reply to Jonathan Druart from comment #92) > Created attachment 109419 [details] [review] > Bug 19889: Add new attribute to the REST API definition > > It fixes t/db_dependent/api/v1/items.t Pushed to master for 20.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 12:26:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 10:26:11 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 12:41:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 10:41:54 +0000 Subject: [Koha-bugs] [Bug 26316] Add the option to un-lost an item on claim return resolution In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26316 --- Comment #1 from Kelly McElligott --- Tomas, I understand the purpose of doing this for claim returned, however, I do see a larger need for the entire LOST status to have this functionality. It would be nice to not have only one LOST status have the capability to remove the LOST status and not the others. A great deal of libraries would appreciate the ability to remove the LOST status without having to check it in and go through the credit process. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 12:51:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 10:51:04 +0000 Subject: [Koha-bugs] [Bug 26308] Normal view (vue normale) is not displayed in French In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26308 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Caroline, the problem should be fixed for 19.11.x too apparently, and maybe 19.05 (needs to be confirmed). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 12:53:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 10:53:38 +0000 Subject: [Koha-bugs] [Bug 19382] Add ability to block guarantees based on fees owed by guarantor and other guarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382 --- Comment #27 from Jonathan Druart --- With only the 2 first patches applied: 153 is( $child_1->relationships_debt({ only_this_guarantor => 0, include_guarantors => 0, include_this_patron => 0 }), 10, 'Family debt is correct' ); 157 is( $child_1->relationships_debt({ only_this_guarantor => 1, include_guarantors => 0, include_this_patron => 0 }), 0, 'Family debt is correct' ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 13:07:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 11:07:36 +0000 Subject: [Koha-bugs] [Bug 26320] Crash when click search button with empty key word In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26320 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 13:10:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 11:10:15 +0000 Subject: [Koha-bugs] [Bug 25624] Update patrons category script should allow finding null and not null and wildcards In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 13:10:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 11:10:18 +0000 Subject: [Koha-bugs] [Bug 25624] Update patrons category script should allow finding null and not null and wildcards In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109370|0 |1 is obsolete| | --- Comment #17 from Nick Clemens --- Created attachment 109421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109421&action=edit Bug 25624: Add more flexibily with --where and literal search Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 13:35:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 11:35:26 +0000 Subject: [Koha-bugs] [Bug 26330] jQueryUI tabs don't work with non-Latin-1 characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Subfields constraints |jQueryUI tabs don't work |editor should hide all new |with non-Latin-1 characters |others subfields | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 13:43:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 11:43:22 +0000 Subject: [Koha-bugs] [Bug 26333] New: "In" analytics link incorrectly formed when "UseControlNumber" set to "Don't use" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26333 Bug ID: 26333 Summary: "In" analytics link incorrectly formed when "UseControlNumber" set to "Don't use" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The "In" links for analytics don't work if not using control numbers To test: - Pick any serial record in your database, make sure 001 is set - Go to new > new child record - Fill in 245 and save - Click on the "In" link, it will not find the record - Look at the link, it is performing a title,phrase search but populating the link with both the author and title -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 13:43:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 11:43:33 +0000 Subject: [Koha-bugs] [Bug 26333] "In" analytics link incorrectly formed when "UseControlNumber" set to "Don't use" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26333 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 14:07:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 12:07:51 +0000 Subject: [Koha-bugs] [Bug 26330] jQueryUI tabs don't work with non-Latin-1 characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 14:07:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 12:07:54 +0000 Subject: [Koha-bugs] [Bug 26330] jQueryUI tabs don't work with non-Latin-1 characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330 --- Comment #1 from Owen Leonard --- Created attachment 109422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109422&action=edit Bug 26330: Change encoding of text used as tab triggers in MARC subfield constraints This patch changes the encoding of the data being used to define jQueryUI tabs on the MARC subfield constraints page. A jQueryUI bug prevents non-Latin-1 characters from being used when defining tab controls. Using Template:Toolkit's "uri" filter converts the data to usable characters. To test, apply the patch and go to Administration -> MARC frameworks -> MARC structure -> tag 952 -> Edit subfields. - Under the "New" tab, add a subfield code which is outside the basic Latin character set, e.g. £, §, æ. - Save changes. - Edit any subfield code to load the subfield constraints page again. - Test that the subfield code tabs work correctly: Clicking each tab should load only the corresponding panel. - Test a variety of tabs including the one you created with the non-Latin character. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 14:24:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 12:24:09 +0000 Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26334 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26334 [Bug 26334] Move translatable strings out of members-menu.inc into members-menu.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 14:24:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 12:24:09 +0000 Subject: [Koha-bugs] [Bug 26334] New: Move translatable strings out of members-menu.inc into members-menu.js Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26334 Bug ID: 26334 Summary: Move translatable strings out of members-menu.inc into members-menu.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 21156 Strings defined for translation in members-menu.inc can now be wrapped in the new translation function and put in members-menu.js. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 14:24:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 12:24:25 +0000 Subject: [Koha-bugs] [Bug 25624] Update patrons category script should allow finding null and not null and wildcards In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |andrew at bywatersolutions.com --- Comment #18 from Andrew Fuerste-Henry --- I get a SQL error whenever I run this without a --where defined. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 14:35:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 12:35:20 +0000 Subject: [Koha-bugs] [Bug 26313] "Show analytics" link doesn't work with Elasticsearch and UseControlNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 14:35:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 12:35:24 +0000 Subject: [Koha-bugs] [Bug 26313] "Show analytics" link doesn't work with Elasticsearch and UseControlNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 --- Comment #1 from Nick Clemens --- Created attachment 109423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109423&action=edit Bug 26313: "Show analytics" link must use uppercase for booleans In elasticsearch we only treat AND and OR as boolean operators if they are capitalized To test: - Turn SearchEngine to Elasticsearch and make sure it works - Pick any serial record in your database, make sure 001 is set - Go to new > new child record - Fill in 245 and save - Click on the "In" link, it should bring you to the parent record - Click on "Show analytics" => there will be no result - Apply patch - restart and reload - Try again - It works! - Switch SearchEngine syspref to 'Zebra' - Test again - It still works! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 14:35:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 12:35:37 +0000 Subject: [Koha-bugs] [Bug 26313] "Show analytics" link doesn't work with Elasticsearch and UseControlNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 14:36:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 12:36:50 +0000 Subject: [Koha-bugs] [Bug 19382] Add ability to block guarantees based on fees owed by guarantor and other guarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382 --- Comment #28 from Kyle M Hall --- (In reply to Jonathan Druart from comment #27) > With only the 2 first patches applied: > > 153 is( $child_1->relationships_debt({ only_this_guarantor => 0, > include_guarantors => 0, include_this_patron => 0 }), 10, 'Family debt is > correct' ); In this case, we are not specifying only_this_guarantor, and we are specifying not to include this patron, and not to include the guarantors themselves, so the code will total the charges from the guarantors other guarantees. Since the sibling owes 10, the returned value is 10. > 157 is( $child_1->relationships_debt({ only_this_guarantor => 1, > include_guarantors => 0, include_this_patron => 0 }), 0, 'Family debt is > correct' ); This one is much simpler, since only_this_guarantor is specified, but the patron is not a guarantor, there are no guarantors to check. No guarantors means no guarantees so the total returned is 0. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 14:42:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 12:42:24 +0000 Subject: [Koha-bugs] [Bug 26313] "Show analytics" link doesn't work with Elasticsearch and UseControlNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 --- Comment #2 from Tomás Cohen Arazi --- Well, this is interesting. Shouldn't we make the query parser handle things without case sensitivity? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 14:44:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 12:44:49 +0000 Subject: [Koha-bugs] [Bug 25101] Add ability to skip previewing results when batch extending due dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 --- Comment #22 from Kyle M Hall --- (In reply to Jonathan Druart from comment #20) > I am not a native English speaker but for me the 2 sentences have opposite > sense. > > The hint from Katrin's patch is > "This is recommended when changing very large numbers of due dates." > > Which means: you should check it if you are processing a lot of issues. > > It's the reverse, if the checkbox is checked we are going to display the > preview screen, which will fail if the amount of due dates is too large. Ah! That wasn't clicking for me, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 14:45:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 12:45:02 +0000 Subject: [Koha-bugs] [Bug 25101] Add ability to skip previewing results when batch extending due dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 --- Comment #23 from Kyle M Hall --- (In reply to Katrin Fischer from comment #21) > A new day, maybe the fix is simple: > > "This is not recommended when changing very large numbers of due dates." Perfect! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 14:50:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 12:50:04 +0000 Subject: [Koha-bugs] [Bug 26334] Move translatable strings out of members-menu.inc into members-menu.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26334 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 14:50:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 12:50:07 +0000 Subject: [Koha-bugs] [Bug 26334] Move translatable strings out of members-menu.inc into members-menu.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26334 --- Comment #1 from Owen Leonard --- Created attachment 109424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109424&action=edit Bug 26334: Move translatable strings out of members-menu.inc into members-menu.js This patch moves translatable strings out of members-menu.inc into members-menu.js where they can be translated using the double-underscore i18n function. To test, apply the patch and go to Patrons. - Expand the search options in the search header by clicking the [+] link. - Select "Date of birth" from the "Search fields" dropdown. - A tooltip should appear above the search form, "Dates of birth should be entered in the format..." with your current date format. - Remove all "Adult" type patron categories but one. - Check out to a child patron. - From the "More" menu choose "Update child to adult patron." - You should see a confirmation. - From the checkout screen, from the "More" menu, choose "Renew patron" - You should get a confirmation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 14:58:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 12:58:37 +0000 Subject: [Koha-bugs] [Bug 25101] Add ability to skip previewing results when batch extending due dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 14:58:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 12:58:40 +0000 Subject: [Koha-bugs] [Bug 25101] Add ability to skip previewing results when batch extending due dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 --- Comment #24 from Kyle M Hall --- Created attachment 109425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109425&action=edit Bug 25101: (QA follow-up) Fix hint for new option -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:04:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:04:48 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #267 from Jonathan Druart --- Remote branch has been rebased against master, few tweaks made: * new commit "Bug 20271: Fix - is_current is nullable" * Only 1 "DBIC changes" commit and a separate "Declare is_current as boolean in schema" to deal with is_boolean. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:08:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:08:25 +0000 Subject: [Koha-bugs] [Bug 26335] New: Aku Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26335 Bug ID: 26335 Summary: Aku Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: xaihaxor at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 109426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109426&action=edit Sayank Sayang kamu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:10:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:10:56 +0000 Subject: [Koha-bugs] [Bug 26336] New: Cannot import items if items ignored when staging Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26336 Bug ID: 26336 Summary: Cannot import items if items ignored when staging Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When staging marc records you have the option to process or ignore items. If you choose to ignore you can change the option after staging, however, items are not processed unless they are parsed in initial staging To test: 0 - Check the count of import_items SELECT COUNT(*) FROM import_items; 1 - Import a marc file with items , process the items 2 - Check the count of import items, it has increased 3 - Stage the file again, do not process items 4 - Count of import_items has not increased 5 - Manage the stage batch, process items and reapply 6 - Check the count of import_items, no change 7 - Import the file, no items are processed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:13:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:13:33 +0000 Subject: [Koha-bugs] [Bug 25624] Update patrons category script should allow finding null and not null and wildcards In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:13:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:13:37 +0000 Subject: [Koha-bugs] [Bug 25624] Update patrons category script should allow finding null and not null and wildcards In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107291|0 |1 is obsolete| | Attachment #107292|0 |1 is obsolete| | Attachment #109421|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart --- Created attachment 109427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109427&action=edit Bug 25624: Add --where option to update_patrons_category.pl The script did not allow to find empty fields or use wildcards With this new option we will now have the ability to filter patrons by some of their attributes. Test plan: 1 - Run the script with no parameters and verify the help explains the parameters 2 - Try the script with one or more --where parameters, like: --where "firstname='koha'" 3 - Test null values --where "firstname IS NULL" 4 - Test like values with wildcards --where "firstname LIKE '%a%' 5 - Test like with the word null to find fields containing the word rather than being unset -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:13:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:13:53 +0000 Subject: [Koha-bugs] [Bug 25624] Update patrons category script should allow finding null and not null and wildcards In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|alex.arnaud at biblibre.com | Assignee|nick at bywatersolutions.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:18:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:18:37 +0000 Subject: [Koha-bugs] [Bug 26313] "Show analytics" link doesn't work with Elasticsearch and UseControlNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 --- Comment #3 from Katrin Fischer --- (In reply to Tomás Cohen Arazi from comment #2) > Well, this is interesting. Shouldn't we make the query parser handle things > without case sensitivity? I see an advantage of this behaviour. If a record title contains 'and' or 'or' they won't get seen as boolean operators (= less accidental booleans). I believe that this is an issue with Zebra currently, but couldn't locate the right bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:20:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:20:08 +0000 Subject: [Koha-bugs] [Bug 26335] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26335 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Summary|Aku |SPAM Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:22:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:22:28 +0000 Subject: [Koha-bugs] [Bug 26308] Normal view (vue normale) is not displayed in French In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26308 --- Comment #4 from Caroline Cyr La Rose --- Hi Jonathan, I did the same corrections on Pootle for 19.11, 19.05 and 18.11. Caroline -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:25:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:25:26 +0000 Subject: [Koha-bugs] [Bug 26332] Koha::Account::pay incorrectly defaults to '0' for manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26332 --- Comment #2 from Martin Renvoize --- Created attachment 109430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109430&action=edit Bug 26332: Remove hard coded '0' for manager_id This patch removes the fallback to '0' for the manager_id in Koha::Account::pay. This will only affect plugins that contain a background callback that doesn't set the user environment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:29:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:29:21 +0000 Subject: [Koha-bugs] [Bug 26337] New: Remove unused authorities script should skip merge Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26337 Bug ID: 26337 Summary: Remove unused authorities script should skip merge Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Remove unused authorities checks if an authority is used If not it calls DelAuthority DelAuthority checks if the authority is used and removes it from records if it is. We should pass 'skip_merge' when calling form this script as we have already checked the usage here -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:29:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:29:44 +0000 Subject: [Koha-bugs] [Bug 26337] Remove unused authorities script should skip merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26337 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Severity|enhancement |normal CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:33:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:33:57 +0000 Subject: [Koha-bugs] [Bug 19382] Add ability to block guarantees based on fees owed by guarantor and other guarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com --- Comment #29 from Jonathan Druart --- This is confusing to me. First, child_1 is not a guarantor so only_this_guarantor should not modify the returned value. Then, in the same logic, only_this_guarantor should not have any effects if include_guarantors is not set. Asking Tomas and Martin for additional feedbacks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:37:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:37:03 +0000 Subject: [Koha-bugs] [Bug 26337] Remove unused authorities script should skip merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26337 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:37:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:37:05 +0000 Subject: [Koha-bugs] [Bug 26337] Remove unused authorities script should skip merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26337 --- Comment #1 from Nick Clemens --- Created attachment 109431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109431&action=edit Bug 26337: Pass skip_merge to DelAuthority when removing unsused authorities This script checks that an authority is not being used before deleting it. We do not need to check biblios for the authority id as we have already verified it is unused. TO test: 1 - Reset db to koha test database 2 - perl misc/migration_tools/remove_unused_authorities.pl -t 3 - Note a number of unsued authorities 4 - perl misc/migration_tools/remove_unused_authorities.pl -c 5 - Note authorities are removed 6 - Reset db 7 - Apply patch 8 - perl misc/migration_tools/remove_unused_authorities.pl -t 9 - Note results are the same 10 - perl misc/migration_tools/remove_unused_authorities.pl -c 11 - Note results are the same -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:37:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:37:31 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #234 from Julian Maurice --- Sorry, there is a new error from QA script: FAIL t/lib/Koha/BackgroundJob/BatchTest.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 Once it is fixed, I think it safe to change status back to Passed QA, since 2 QAers already added their signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:40:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:40:22 +0000 Subject: [Koha-bugs] [Bug 26338] New: Show tool plugins run in tools home Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26338 Bug ID: 26338 Summary: Show tool plugins run in tools home Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In tools home there is a link to the table showing tool plugins. Would be great to be able to run a tool plugin directly from tools home. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:40:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:40:30 +0000 Subject: [Koha-bugs] [Bug 26338] Show tool plugins run in tools home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26338 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:40:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:40:40 +0000 Subject: [Koha-bugs] [Bug 26339] New: Move translatable strings out of addorderiso2709.tt into addorderiso2709.js Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26339 Bug ID: 26339 Summary: Move translatable strings out of addorderiso2709.tt into addorderiso2709.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 21156 Strings defined for translation in addorderiso2709.tt can now be wrapped in the new translation function and put in addorderiso2709.js. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:40:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:40:40 +0000 Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26339 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26339 [Bug 26339] Move translatable strings out of addorderiso2709.tt into addorderiso2709.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:42:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:42:02 +0000 Subject: [Koha-bugs] [Bug 26338] Show tool plugins run in tools home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26338 --- Comment #1 from Fridolin SOMERS --- Created attachment 109432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109432&action=edit Screenshot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:42:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:42:47 +0000 Subject: [Koha-bugs] [Bug 26338] Show tool plugins run in tools home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26338 --- Comment #2 from Fridolin SOMERS --- (In reply to Fridolin SOMERS from comment #1) > Created attachment 109432 [details] > Screenshot With the example of plugin Carrousel https://inlibro.com/instructions-carrousel/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:48:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:48:22 +0000 Subject: [Koha-bugs] [Bug 26338] Show tool plugins run in tools home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26338 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:48:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:48:24 +0000 Subject: [Koha-bugs] [Bug 26338] Show tool plugins run in tools home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26338 --- Comment #3 from Fridolin SOMERS --- Created attachment 109433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109433&action=edit Bug 26338: Show tool plugins run in tools home In tools home there is a link to the table showing tool plugins. Would be great to be able to run a tool plugin directly from tools home. Also adds the behavior than if there is no tool plugin, "Tool plugins" section is not displayed in tools home. No need of a link that goes to an empty table ;) Test plan : 1) Enable plugins, dont install any 2) Go to "Tools" module : /cgi-bin/koha/tools/tools-home.pl 3) Check you dont see "Tool plugins" 4) Install a tool plugin like Carrousel https://inlibro.com/instructions-carrousel/ 5) Refresh /cgi-bin/koha/tools/tools-home.pl 6) Check you see "Tool plugins" and a link to Carrousel 7) Click on link to Carrousel => You see plugin run 8) Disable Carrousel plugin 9) Refresh /cgi-bin/koha/tools/tools-home.pl 10) Check you dont see "Tool plugins" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:49:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:49:48 +0000 Subject: [Koha-bugs] [Bug 26336] Cannot import items if items ignored when staging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26336 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:49:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:49:51 +0000 Subject: [Koha-bugs] [Bug 26338] Show tool plugins run in tools home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26338 --- Comment #4 from Katrin Fischer --- I think I'd remove the "run plugin" bit. And maybe make it a list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:49:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:49:51 +0000 Subject: [Koha-bugs] [Bug 26336] Cannot import items if items ignored when staging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26336 --- Comment #1 from Jonathan Druart --- Created attachment 109434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109434&action=edit Bug 26336: Disable 'Item processing' dropdown if no item If there is no item to process and they have been ignored during the stage step, we should not let the user modify the dropdown value Test plan: 0 - Check the count of import_items SELECT COUNT(*) FROM import_items; 1 - Import a marc file with items , process the items 2 - Check the count of import items, it has increased 3 - Stage the file again, do not process items 4 - Count of import_items has not increased 5 - Manage the stage batch Confirm that you cannot modify the "Item processing" value -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:50:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:50:09 +0000 Subject: [Koha-bugs] [Bug 26336] Cannot import items if items ignored when staging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26336 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- Is that what you are looking for? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:50:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:50:32 +0000 Subject: [Koha-bugs] [Bug 26308] Normal view (vue normale) is not displayed in French In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26308 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #5 from Jonathan Druart --- Great, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:52:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:52:14 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #235 from Jonathan Druart --- I removed the POD for this test module on purpose, I don't think it makes much sense to have POD there, we already have similar POD in the 3 other modules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:57:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:57:17 +0000 Subject: [Koha-bugs] [Bug 26308] Normal view (vue normale) is not displayed in French In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26308 --- Comment #6 from Joel --- Indeed, manually editing fr-CA-marc-MARC21.po and doing a koha-translate -u fr-CA did the trick. Thanks everyone for your help! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 15:59:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 13:59:26 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #236 from Jonathan Druart --- I have 2 questions: We need apt install rabbitmq-server rabbitmq-plugins enable rabbitmq_stomp service rabbitmq-server restart we can have rabbitmq-server inside control.in, but what about the 2 other commands? Should we have them part of the install process or in koha-common (like we try to guess if the plugin is enabled, otherwise we enable it and restart rabbitmq)? Also, shouldn't we add a rabbitmq status indicator on the about page? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:01:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:01:01 +0000 Subject: [Koha-bugs] [Bug 26339] Move translatable strings out of addorderiso2709.tt into addorderiso2709.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26339 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:01:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:01:03 +0000 Subject: [Koha-bugs] [Bug 26339] Move translatable strings out of addorderiso2709.tt into addorderiso2709.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26339 --- Comment #1 from Owen Leonard --- Created attachment 109435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109435&action=edit Bug 26339: Move translatable strings out of addorderiso2709.tt into addorderiso2709.js This patch moves strings defined for translation in addorderiso2709.tt into addorderiso2709.js for translation using the new double-underscore i81n function. To test, apply the patch and go to Acquisitions -> Vendor -> Basket -> Add orders from MARC file. - Click "Add orders" next to a staged file. - Without making any selections, click "Save." You should get an error, "There is no record selected." - Select a record and click "Save." You should get an error, "Some budgets are not defined in item records." - Enter a non-numeric value in the "Quantity" field and click "Save." You should get an error, "1 quantity values are not filled in or are not numbers." TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js for translation, e.g.: msgid "Some budgets are not defined in item records" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:01:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:01:42 +0000 Subject: [Koha-bugs] [Bug 25624] Update patrons category script should allow finding null and not null and wildcards In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #20 from Andrew Fuerste-Henry --- Now I'm getting a different SQL error when running this with a --where, a --field, or neither: perl misc/cronjobs/update_patrons_category.pl -f PT -t B --where "firstname='koha'" -v No actions will be taken (test mode) Will update patrons from PT to B with conditions below (if any) DBD::mysql::st execute failed: Unknown column 'me.exclude_from_local_holds_priority' in 'field list' [for Statement "SELECT `me`.`categorycode`, `me`.`description`, `me`.`enrolmentperiod`, `me`.`enrolmentperioddate`, `me`.`upperagelimit`, `me`.`dateofbirthrequired`, `me`.`finetype`, `me`.`bulk`, `me`.`enrolmentfee`, `me`.`overduenoticerequired`, `me`.`issuelimit`, `me`.`reservefee`, `me`.`hidelostitems`, `me`.`category_type`, `me`.`BlockExpiredPatronOpacActions`, `me`.`default_privacy`, `me`.`checkprevcheckout`, `me`.`reset_password`, `me`.`change_password`, `me`.`exclude_from_local_holds_priority` FROM `categories` `me` WHERE ( `me`.`categorycode` = ? )" with ParamValues: 0='PT'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.exclude_from_local_holds_priority' in 'field list' at /kohadevbox/koha/Koha/Objects.pm line 96 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:03:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:03:33 +0000 Subject: [Koha-bugs] [Bug 26332] Koha::Account::pay incorrectly defaults to '0' for manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26332 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:04:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:04:39 +0000 Subject: [Koha-bugs] [Bug 26334] Move translatable strings out of members-menu.inc into members-menu.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26334 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109424|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 109436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109436&action=edit Bug 26334: Move translatable strings out of members-menu.inc into members-menu.js This patch moves translatable strings out of members-menu.inc into members-menu.js where they can be translated using the double-underscore i18n function. To test, apply the patch and go to Patrons. - Expand the search options in the search header by clicking the [+] link. - Select "Date of birth" from the "Search fields" dropdown. - A tooltip should appear above the search form, "Dates of birth should be entered in the format..." with your current date format. - Remove all "Adult" type patron categories but one. - Check out to a child patron. - From the "More" menu choose "Update child to adult patron." - You should see a confirmation. - From the checkout screen, from the "More" menu, choose "Renew patron" - You should get a confirmation. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/members-menu.js for translation, e.g.: msgid "Are you sure you want to renew this patron's registration?" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:04:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:04:43 +0000 Subject: [Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |ASSIGNED Version(s)|20.11.00 | released in| | --- Comment #16 from Jonathan Druart --- Patches have been reverted from master. commit 4009bb04ad857ef042bba9a4d690dd21d84ac3dd Revert "Bug 25242: Improve column wrapping and overflow for tables" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:09:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:09:46 +0000 Subject: [Koha-bugs] [Bug 25624] Update patrons category script should allow finding null and not null and wildcards In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 --- Comment #21 from Jonathan Druart --- I think you are missing a DB update. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:13:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:13:08 +0000 Subject: [Koha-bugs] [Bug 25448] Update German (de-DE) framework files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25448 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:13:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:13:11 +0000 Subject: [Koha-bugs] [Bug 25448] Update German (de-DE) framework files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25448 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109385|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 109437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109437&action=edit Bug 25448: Update German (de-DE) framework files The updated files have been auto-generated based on the po files and downloaded from https://translate.koha-community.org/files/ To test: - Make sure German language is installed, see: https://wiki.koha-community.org/wiki/Installation_of_additional_languages_for_OPAC_and_INTRANET_staff_client - Run the web installer and choose de-DE - Select all sample files - Make sure they all install without any errors Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:14:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:14:10 +0000 Subject: [Koha-bugs] [Bug 25448] Update German (de-DE) framework files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25448 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Jonathan Druart --- Trivial, skipping QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:18:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:18:01 +0000 Subject: [Koha-bugs] [Bug 21284] ILS-DI: Allow GetPatronInfo to tell if a loaned item is on hold by someone else. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21284 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:18:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:18:03 +0000 Subject: [Koha-bugs] [Bug 21284] ILS-DI: Allow GetPatronInfo to tell if a loaned item is on hold by someone else. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21284 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78269|0 |1 is obsolete| | --- Comment #9 from Fridolin SOMERS --- Created attachment 109438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109438&action=edit Bug 21284: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:18:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:18:16 +0000 Subject: [Koha-bugs] [Bug 21284] ILS-DI: Allow GetPatronInfo to tell if a loaned item is on hold by someone else. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21284 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90326|0 |1 is obsolete| | --- Comment #10 from Fridolin SOMERS --- Created attachment 109439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109439&action=edit Bug 21284: ILS-DI: Allow GetPatronInfo to tell if a loaned item is on hold by someone else. This patch adds two entries in the loans section of GetPatronInfo's response: - itemonhold: number of holds on this specific item. - recordonhold: number of holds on the record. Test plan: - Call GetPatronInfo on a user with a loan that has no holds - Check that itemonhold and recordonhold entries are equal to zero - Add holds on biblio and/or item level - Check that itemonhold and recordonhold are incremented accordingly Please note that a hold on item level counts as a hold on record level, but not vice-versa. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:18:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:18:49 +0000 Subject: [Koha-bugs] [Bug 21284] ILS-DI: Allow GetPatronInfo to tell if a loaned item is on hold by someone else. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21284 --- Comment #11 from Fridolin SOMERS --- /me only did a quick rebase on current master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:20:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:20:25 +0000 Subject: [Koha-bugs] [Bug 25624] Update patrons category script should allow finding null and not null and wildcards In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:20:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:20:28 +0000 Subject: [Koha-bugs] [Bug 25624] Update patrons category script should allow finding null and not null and wildcards In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109427|0 |1 is obsolete| | --- Comment #22 from Andrew Fuerste-Henry --- Created attachment 109440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109440&action=edit Bug 25624: Add --where option to update_patrons_category.pl The script did not allow to find empty fields or use wildcards With this new option we will now have the ability to filter patrons by some of their attributes. Test plan: 1 - Run the script with no parameters and verify the help explains the parameters 2 - Try the script with one or more --where parameters, like: --where "firstname='koha'" 3 - Test null values --where "firstname IS NULL" 4 - Test like values with wildcards --where "firstname LIKE '%a%' 5 - Test like with the word null to find fields containing the word rather than being unset Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:20:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:20:58 +0000 Subject: [Koha-bugs] [Bug 26340] New: Printing labels without zero(s) in the start of labels Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Bug ID: 26340 Summary: Printing labels without zero(s) in the start of labels Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: ivan.dziuba at inlibro.com QA Contact: testopia at bugs.koha-community.org TO TEST: 1. Go Tools > Label creator 2. Click +New -> Barcode range 3. Print barcode range with zero(s) in the start (Ex. from 00011881 to 00012000 ) 4. Select a template to be applied:: Code à barre 48467 Select a layout to be applied: Code à barres 5. Export 6. Open PDF The prefix is not displayed. We should see 00011881 on the labels, but we see 11881, 11882, ... without zeros in the start of labels. This patch fix it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:21:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:21:10 +0000 Subject: [Koha-bugs] [Bug 25624] Update patrons category script should allow finding null and not null and wildcards In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 --- Comment #23 from Andrew Fuerste-Henry --- Whoops, yes. Sorry about that! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:28:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:28:38 +0000 Subject: [Koha-bugs] [Bug 25624] Update patrons category script should allow finding null and not null and wildcards In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 --- Comment #24 from Jonathan Druart --- (In reply to Andrew Fuerste-Henry from comment #23) > Whoops, yes. Sorry about that! haha, no worries. Thanks Andrew! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:30:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:30:29 +0000 Subject: [Koha-bugs] [Bug 26340] Printing labels without zero(s) in the start of labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Ivan Dziuba changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.05 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:31:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:31:40 +0000 Subject: [Koha-bugs] [Bug 26340] Printing labels without zero(s) in the start of labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 --- Comment #1 from Ivan Dziuba --- Created attachment 109441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109441&action=edit Bug 26340: Printing labels without zero(s) in the start of labels -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:36:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:36:19 +0000 Subject: [Koha-bugs] [Bug 26340] Printing labels without zero(s) in the start of labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Ivan Dziuba changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:36:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:36:22 +0000 Subject: [Koha-bugs] [Bug 26340] Printing labels without zero(s) in the start of labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Ivan Dziuba changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109441|0 |1 is obsolete| | --- Comment #2 from Ivan Dziuba --- Created attachment 109442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109442&action=edit Bug 26340: Printing labels without zero(s) in the start of labels TO TEST: 1. Go Tools > Label creator 2. Click +New -> Barcode range 3. Print barcode range with zero(s) in the start (Ex. from 00011881 to 00012000 ) 4. Select a template to be applied:: Code à barre 48467 Select a layout to be applied: Code à barres 5. Export 6. Open PDF The prefix is not displayed. We should see 00011881 on the labels, but we see 11881, 11882, ... without zeros in the start of labels. This patch fix it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:38:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:38:49 +0000 Subject: [Koha-bugs] [Bug 26341] New: Database update for bug 21443 is not idempotent Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26341 Bug ID: 26341 Summary: Database update for bug 21443 is not idempotent Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If the database update for bug 21443 is run, and the library changes any of the hourly or daily rental fees following the calendar, a second run of the database update will overwrite those changes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:39:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:39:03 +0000 Subject: [Koha-bugs] [Bug 26341] Database update for bug 21443 is not idempotent and will destroy settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26341 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Database update for bug |Database update for bug |21443 is not idempotent |21443 is not idempotent and | |will destroy settings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:40:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:40:26 +0000 Subject: [Koha-bugs] [Bug 26340] Printing labels without zero(s) in the start of labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Ivan Dziuba changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin at inLibro.com, | |ivan.dziuba at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:41:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:41:14 +0000 Subject: [Koha-bugs] [Bug 26340] Printing labels without zero(s) in the start of labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Ivan Dziuba changed: What |Removed |Added ---------------------------------------------------------------------------- CC|ivan.dziuba at inlibro.com |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:43:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:43:32 +0000 Subject: [Koha-bugs] [Bug 26341] Database update for bug 21443 is not idempotent and will destroy settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26341 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21443 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443 [Bug 21443] Add ability to exclude holidays when calculating rentals fees by time period -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:43:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:43:32 +0000 Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when calculating rentals fees by time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26341 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26341 [Bug 26341] Database update for bug 21443 is not idempotent and will destroy settings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:43:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:43:53 +0000 Subject: [Koha-bugs] [Bug 26341] Database update for bug 21443 is not idempotent and will destroy settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26341 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 16:43:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 14:43:56 +0000 Subject: [Koha-bugs] [Bug 26341] Database update for bug 21443 is not idempotent and will destroy settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26341 --- Comment #1 from Kyle M Hall --- Created attachment 109443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109443&action=edit Bug 26341: Database update for bug 21443 is not idempotent and will destroy settings If the database update for bug 21443 is run, and the library changes any of the hourly or daily rental fees following the calendar, a second run of the database update will overwrite those changes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 17:07:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 15:07:44 +0000 Subject: [Koha-bugs] [Bug 26342] New: Suspended hold not marked filled when patron checks out item Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26342 Bug ID: 26342 Summary: Suspended hold not marked filled when patron checks out item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To recreate: - place an item-level hold - suspend the hold - without unsuspending or capturing the hold, check the item out to the patron - the suspended hold remains on the patron account If a hold is not suspended (and not captured) and the patron checks the item out, the hold is marked as filled. Should we do the same on suspended holds? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 17:09:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 15:09:58 +0000 Subject: [Koha-bugs] [Bug 26342] Suspended hold not marked filled when patron checks out item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26342 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 17:19:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 15:19:21 +0000 Subject: [Koha-bugs] [Bug 26343] New: Blank columns in patron import csv clears existing data when overwriting Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26343 Bug ID: 26343 Summary: Blank columns in patron import csv clears existing data when overwriting Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org When importing/overlaying patrons, if you have any blank columns in the csv, any existing data in a patron record is cleared. There should be an option as to whether or not you intend to clear the data using blank columns or not. To recreate: 1. Create patron with several items of data, such as address, city, phone. 2. Create a csv with username, address, and a blank column for phone 3. Import patron file, using the overwrite function 4. See that the phone info is now blank in the patron record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 18:01:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 16:01:09 +0000 Subject: [Koha-bugs] [Bug 25619] Add ability to adjust expiration date for waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619 Rhiana changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rmcompton at arlingtonva.us --- Comment #5 from Rhiana --- This is a great idea and would greatly benefit our patrons - especially now given the pandemic but I also see plenty of need after the fact. It could be used to support a number of programs and/or services. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 18:07:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 16:07:22 +0000 Subject: [Koha-bugs] [Bug 19967] Search patrons with non-Latin languages is broken if DefaultPatronSearchFields includes date or datetime field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19967 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #6 from Katrin Fischer --- We have retested this in our test installationf or 20.05 and can no longer replicate the problem. Closing WORKSFORME! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 18:11:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 16:11:53 +0000 Subject: [Koha-bugs] [Bug 26330] jQueryUI tabs don't work with non-Latin-1 characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330 --- Comment #2 from Pablo AB --- Wow that was fast! :) One thing to note is that not any character outside the basic Latin character should be accepted, as mentioned in Bug 9874 about ampersand. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 18:14:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 16:14:14 +0000 Subject: [Koha-bugs] [Bug 26344] New: Move translatable strings out of templates into patrons.js Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26344 Bug ID: 26344 Summary: Move translatable strings out of templates into patrons.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 21156 Strings defined in templates for use in autocomplete/patrons.js can now be wrapped in the new translation function. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 18:14:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 16:14:14 +0000 Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26344 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26344 [Bug 26344] Move translatable strings out of templates into patrons.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 18:16:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 16:16:03 +0000 Subject: [Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 --- Comment #17 from Martin Renvoize --- Created attachment 109444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109444&action=edit Bug 25242: Improve column wrapping for holdingst This patch attempts to improve the column wrapping for the holdingst datatable and sets the tabel to fixed width to prevent overlapping with other content on high zoom levels/low width screen sizes. Test plan 1/ Build the OPAC CSS from the updated SCSS 2/ Navigate to an item with holdings visible in the OPAC 3/ 'Play' with various window sizes and zoom levels. 4/ The table should not overlap with right navigation content 5/ Signoff NOTE: This is an alternative patch to those pushed and reverted that attempted to provide a global fix to overlap issues. This patch specifically targets just the holdings table in the opac detail view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 18:16:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 16:16:40 +0000 Subject: [Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108438|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 18:18:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 16:18:59 +0000 Subject: [Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108574|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 18:37:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 16:37:08 +0000 Subject: [Koha-bugs] [Bug 26336] Cannot import items if items ignored when staging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26336 --- Comment #3 from Nick Clemens --- Created attachment 109445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109445&action=edit Bug 26336: Add hint before and remove select after staging with no items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 18:37:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 16:37:29 +0000 Subject: [Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108439|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 18:39:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 16:39:34 +0000 Subject: [Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 18:39:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 16:39:55 +0000 Subject: [Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242 --- Comment #18 from Martin Renvoize --- Here we go again.. Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 19:54:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 17:54:49 +0000 Subject: [Koha-bugs] [Bug 26313] "Show analytics" link doesn't work with Elasticsearch and UseControlNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 --- Comment #4 from Tomás Cohen Arazi --- I agree! Let's push this forward!! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 20:17:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 18:17:47 +0000 Subject: [Koha-bugs] [Bug 26337] Remove unused authorities script should skip merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26337 Eric Phetteplace changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace at cca.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 20:23:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 18:23:00 +0000 Subject: [Koha-bugs] [Bug 26344] Move translatable strings out of templates into patrons.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26344 --- Comment #1 from Owen Leonard --- I didn't notice it when I first started working on this, but the JavaScript in question is at this location: koha-tmpl/intranet-tmpl/js/autocomplete/patrons.js Whereas the translation script only process JavaScript in: koha-tmpl/intranet-tmpl/prog/* So my patch won't work! Is there a reason why we don't translate JS in intranet-tmpl/js ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 20:49:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 18:49:09 +0000 Subject: [Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 --- Comment #65 from Katrin Fischer --- (In reply to Jonathan Druart from comment #64) > I am sorry but I get the same problem: > > Applying: Bug 25630: (follow-up) Fix capitalization and terminology for > system preferences > error: sha1 information is lacking or useless > (koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref). > > Can you push a remote branch somewhere? It applied cleanly for me right now - I will push up fresh patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 20:51:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 18:51:14 +0000 Subject: [Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 20:51:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 18:51:20 +0000 Subject: [Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108910|0 |1 is obsolete| | --- Comment #66 from Katrin Fischer --- Created attachment 109446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109446&action=edit Bug 25630: Fix capitalization and terminology for Staff interface system preferences This changes "staff client" to "staff interface" and fixes capitalization in a couple of cases. For terminology changes see: https://wiki.koha-community.org/wiki/Terminology#S To test: - Read through the preferences of the "staff interface" tab. - Staff interface should be used consistently. - Firefox "PlugIn" was changed to "add-on" reflecting Mozilla's own terminology. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 20:51:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 18:51:25 +0000 Subject: [Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108911|0 |1 is obsolete| | --- Comment #67 from Katrin Fischer --- Created attachment 109447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109447&action=edit Bug 25630: Fix capitalization and terminology fixes for Searching system preferences - Rephrases LoadSearchHistoryToTheFirstLoggedUser system preference - Consistently use "staff interface" - Add ending punctuation to some preferences To test: - Read through the Searching system preferences - Verify consistent use of staff interface - Verify LoadSearchHistoryToTheFirstLoggedUser description is improved Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 20:51:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 18:51:30 +0000 Subject: [Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108912|0 |1 is obsolete| | --- Comment #68 from Katrin Fischer --- Created attachment 109448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109448&action=edit Bug 25630: Fix capitalization and terminology for Acquisitions and Tools system preferences - Adds some ending punctuation - Fixes capitalization - Consistent use of "staff interface" To test: - Verify: - NewsAuthorDisplay - EmailPurchaseSuggestions - UseACQFrameworkForBiblioRecords - AcqItemSetSubfieldsWhenReceived - AcqItemSetSubfieldsWhenReceiptIsCancelled - OrderPriceRounding - read correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 20:51:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 18:51:34 +0000 Subject: [Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108913|0 |1 is obsolete| | --- Comment #69 from Katrin Fischer --- Created attachment 109449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109449&action=edit Bug 25630: Fix capitalization and terminology for Enhanced content and Web services system preferences - Fixes capitalization, including URL and OPAC - Consistent use of "staff interface" - Ending punctuation - Spelling: web service To test: - Verify: - Enhanced content page heading - Babeltheque_url_js - Babeltheque_url_update - FRBRizeEditions - BakerTaylorEnabled - NovelistSelectStaffProfile - NovelistSelectStaffEnabled - CustomCoverImages - LocalCoverImages - IntranetCoce - AutoShareWithMana - OAI-PMH:AutoUpdateSets - IdRef - read correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 20:51:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 18:51:39 +0000 Subject: [Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108914|0 |1 is obsolete| | --- Comment #70 from Katrin Fischer --- Created attachment 109450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109450&action=edit Bug 25630: Fix capitalization and terminology for Patrons system preferences - Consistent use of 'staff interface' - Ending punctuation - Rearranged/rephrased for better readability To test: - Verify: - patronimages - PatronsPerPage (rearranged) - PatronQuickAddFields (rearranged) - PrefillGuaranteeField (punctuation) - borrowerRelationship (punctuation) - GDPR_Policy - CollapseFieldsPatronAddForm - read correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 20:51:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 18:51:45 +0000 Subject: [Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108915|0 |1 is obsolete| | --- Comment #71 from Katrin Fischer --- Created attachment 109451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109451&action=edit Bug 25630: Fix capitalization and terminology for OPAC system preferences - Ending punctuation (p) - Capitalization (c) - Terminology: library instead of branch, patron instead of borrower, system preferences instead of syspref To test: - Verify: - OPACUserSummary (p, rephrase: mainpage) - HighlightOwnItemsOnOPACWhich (library) - OPACXSLTListsDisplay (p) - OPACXSLTResultsDisplay (p) - OPACXSLTDetailsDisplay (p) - OpacNoItemTypeImages (p) - NotHighlightedWords (p) - opaclayoutstylesheet (CSS) - OPACReportProblem (c) - OpacBrowser (p) - OpacCloud (p) - SocialNetworks (p) - QuoteOfTheDay (c,p) - OpacNewsLibrarySelect (library) - OPACFineNoRenewalsIncludeCredits (p) - AllowPurchaseSuggestionBranchChoice (p) - OpacHiddenItemsExceptions (p, patron) - OpacAllowPublicListCreation (p) - OpacAllowSharingPrivateLists (p) - BlockExpiredPatronOpacActions (whitespace) - MaxOpenSuggestions (p) - AnonSuggestions (p) - OPACPrivacy (p, whitespace) - AnonymousPatron (c,p) - TrackClicks (p) - RestrictedPageLocalIPs (p) - RestrictedPageTitle (p) - OpacAdvSearchOptions (p) - OpacAdvSearchMoreOptions (p) - PayPal* (p) - OPACUserSummary (mainpage to OPAC start page) - read correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 20:51:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 18:51:50 +0000 Subject: [Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108916|0 |1 is obsolete| | --- Comment #72 from Katrin Fischer --- Created attachment 109452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109452&action=edit Bug 25630: Fix capitalization and terminology for Logs and I18N system preferences - (Ending) punctuation (p) - Capitalization (p) - Terminology To test: - Verify: - alphabet (p) - TranslateNotics (c) - IllLog (p) - ReturnLog (returned to checked in) - DumpTemplateVars* (HTML) - read correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 20:51:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 18:51:56 +0000 Subject: [Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108917|0 |1 is obsolete| | --- Comment #73 from Katrin Fischer --- Created attachment 109453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109453&action=edit Bug 25630: Fix capitalization and terminology for Circulation system preferences - (Ending) punctuation (p) - Terminology - Capitalization (c) To test: - Verify: - CircSidebar (c) - itemBarcodeInputFilter (from to form) - HoldsToPullStartDate (preference to system preference) - NoticeCSS (c) - UpdateTotalIssuesOnCirc (issues to checkouts) - ExportRemovefields (p) - AllowItemsOnHoldCheckoutSIP (c) - OnSiteCheckoutAutoCheck (onsite to on-site) - AllowOfflineCirculation (plugin to add-on) - AllowFineOverride (add 'system preference') - AutomaticItemReturn (returned to checked in) - UseTransportCostMatrix (branches to libraries) - AllowReturnToBranch (materials to items, return to checkin) - RenewalSendNotice (clarify 'messaging preference for 'Item checkout') - TransfersMaxDaysWarning (c) - noissuescharge (books to items) - *NoissuesCharge (add 'system preference') - ReturnBeforeExpiry (books to items) - NoticeBcc (p) - OverdueNoticeCalendar (c, p) - OverduesBlockCirc (p) - DefaultLongOverdueChargeValue (whitespace after :) - OPACFineNoRenewalsBlockAutoRenew (c) - RenewAccruingItemWhenPaid (p, c, syspref to system preference) - RenewAccruingItemInOpac (p, c, syspref to system preference) - HoldsSplitQueue (staff interface) - StaffSearchResultsDisplayBranch (staff interface, rephrase) - HidePersonalPatronDetailOnCirculation (rephrase) - StoreLastBorrower (add 'system preferences') - HoldsSplitQueue (& to and, staff interface) - HouseboundModule (p) - StockRotation (p) - ArticleRequests* (p) - ClaimReturnedLostValue (rephrase) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 20:52:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 18:52:00 +0000 Subject: [Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108918|0 |1 is obsolete| | --- Comment #74 from Katrin Fischer --- Created attachment 109454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109454&action=edit Bug 25630: Fix capitalization and terminology for Authorities and Cataloging system preferences - Punctuation (p) - Terminology - Capitalization (c) To test: - Verify: - AuthDisplayHierarchy (biblio to bibliographic) - MARCAuthorityControlField008 (p) - UNIMARCAuthorityField100 (p) - LinkerModule (c) - LinkerOptions (p) - SpineLabelShowPrintOnBibDetails (bib to bibliographic) - DefaultLanguageField008 (p) - DefaultCountryField008 (p) - SubfieldsToAllowForRestricted* (p, rephrase) - URLLinkText (added 'and items' - new with 20.05) - IntranetBiblioDefaultView (c) - MergeReportFields (rephrase) - BibtexExportAdditionalFields (marc to MARC) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 20:52:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 18:52:05 +0000 Subject: [Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108919|0 |1 is obsolete| | --- Comment #75 from Katrin Fischer --- Created attachment 109455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109455&action=edit Bug 25630: Fix capitalization and terminology for Accounting, Administration and Serials system preferences - Punctuation (p) - Terminology - Capitalization (c) To test: - Verify: - AccountAutoReconcile (Do not to Don't for consistency with other prefs) - IndependentBranchesPatronModifications (p) - IndependentBranchesTransfers (p) - GoogleOpenIDConnect (google to Google) - UsageStatsLibrariesInfo (c) - opacSerialDefaultTab (c) - StaffSerialIssueDisplayCount (staff interface) - SubscriptionDuplicateDroppedInput (c) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 20:52:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 18:52:10 +0000 Subject: [Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108920|0 |1 is obsolete| | --- Comment #76 from Katrin Fischer --- Created attachment 109456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109456&action=edit Bug 25630: (follow-up) Fix capitalization and terminology for system preferences Additional capitalization, punctuation, terminolgy and improvements to text for system preferences: - Punctuation (such as full stops at the end of sentences) - Capitalization - Terminology (staff interface, use of "Don't" instead of "Do not") - Rearranged/rephrased for better readability To test: - Verify that the changes listed are consistent and make sense. - Check that on the staff interface home page that the window title says "Koha staff interface". - Verify that in system preferences the name of the tab for Staff interface displays correctly, and that clicking on it brings up the staff interface preferences. - For Patrons > CollapseFieldsPatronAddForm check that the edit and add patron form works correctly (edit a patron, add a new patron, check that labels display correctly). Staff interface home page ------------------------- - Change the page title in browser from "Koha staff client" to "Koha staff interface". Administration -------------- Google OpenID Connect: . GoogleOpenIDConnectAutoRegister: change "Don't Allow" to "Don't allow" and change "users" to "patrons". . GoogleOpenIDConnectDefaultBranch: move the input field to the end of the sentence. . GoogleOpenIDConnectDefaultCategory: move the input field to the end of the sentence. . GoogleOpenIDConnectDomain: reword to "Restrict Google OpenID Connect to domain (or subdomain of this domain): ____. Leave blank for all Google domains.". Interface options: . SendAllEmailsTo: add a full stop. Share anonymous usage statistics: . UsageStatsLibrariesInfo: change "Do not share" to "Don't share"; add a full stop; for note "Don't share" should be "No". . most preferences: for note "Don't share" should be "No" (don't share) (for preferences UsageStatsCountry, UsageStatsGeolocation, UsageStatsLibrariesInfo, UsageStatsLibraryName, UsageStatsLibraryType, and UsageStatsLibraryUrl), various edits to make more readable and consistent. Authorities ----------- General . AuthorityControlledIndicators: change "biblio field" to "bibliographic field". . AutoCreateAuthorities: change "do not generate" to "don't generate". Linker: . CatalogModuleRelink: change "Do not" to "Don't". . LinkerKeepStale: change "Do not" to "Don't". . LinkerModule: change "Default" to "default". . LinkerOptions: add a full stop. . LinkerRelink: change "Do not" to "Don't". Cataloguing ----------- Display: . MergeReportFields: change "example:" to "Example:" Exporting: . BibtexExportAdditionalFields and RisExportAdditionalFields: change "Include following" to "Include the following"; add ":" at end of sentence, change "specificy" to "specify", and add full stops at end of complete sentences. Interface: . EnableAdvancedCatalogingEditor: format NOTE in bold. Record structure: . AlternateHoldingsField: change "(This" to "(this", change "; for instance" to ", for example", remove full stop. , MarcFieldForCreatorId: format NOTE in bold. . SubfieldsToAllowForRestrictedBatchmod: change "pref" to "system preference". Circulation ----------- Batch checkout: . BatchCheckoutsValidCategories: add a full stop. Checkin policy: . CalculateFinesOnReturn: only bold "NOTE", not the whole sentence (x2). . StoreLastBorrower: change "opacreadinghistory/AnonymousPatron" to "the opacreadinghistory and AnonymousPatron". . UpdateItemLocationOnCheckin: change note "for these locations only can location and permanent_location differ," to "for these locations the location and permanent_location can differ," . UpdateNotForLoanStatusOnCheckin: change "E.g.," to "For example," Checkout policy: . AgeRestrictionMarker: change "E.g.," to ". For example," . AllFinesNeedOverride: change "system preference noissuescharge" to "the noissuescharge system preference". . AllowFineOverride: add "the" before "noissuescharge". . AllowRenewalLimitOverride: change "with respect to" to "for". . AutoRemoveOverduesRestrictions: change "Do not" to "Don't". . DefaultLongOverdueChargeValue: change "user" to "patron". . ItemsDeniedRenewal: change . "e.g.," to "For example:", format the note the same as other notes with NOTE in bold. . OnSiteCheckoutsForce: change "on-site" to "on-site checkout", "(Even" to "(even", and "user" to "patron". . RentalFeesCheckoutConfirmation: change "do not ask" to "don't ask". . RestrictionBlockRenewing: change "If patron" to "If a patron", change "Allow" and "Block" to "allow" and "block". . UseTransportCostMatrix: "Transport" to "the transport". Interface: . AllowOfflineCirculation: change "Do not enable" to "Don't enable". . ExportRemoveFields: add a full stop. . ShowAllCheckins: change "Do not show" to "Don't show". . UpdateTotalIssuesOnCirc: change "Do not" to "Don't". Interlibrary loans: . CirculateILL: add a full stop. . ILLCheckAvailability: add a full stop. Self check-in module (sci-main.pl): . SelfCheckInModule: change "module. (available" to "module (available", add a full stop. Self check-out module (sco-main.pl): . AutoSelfCheckAllowed: change "automatically login" to "automatically log in". . WebBasedSelfCheck: change "system. (available" to "system (available", add a full stop. Enhanced content ---------------- Novelist Select: . NovelistSelectStaffView: change "staff" to "staff interface". Babelthèque: . Babeltheque_url_js: rewitten . from "______ Defined the URL for the Babeltheque javascript file (eg. http://www.babeltheque.com/bw_XX.js)" . to "Use this URL for the Babelthèque javascript file: ________ (e.g. http://www.babeltheque.com/bw_XX.js)." . Babeltheque_url_update: rewritten . from "______ Defined the URL for the Babeltheque update periodically (eq. http://www.babeltheque.com/.../file.csv.bz2)." . to "Use this URL for the Babelthèque periodic update: _______ (e.g. http://www.babeltheque.com/.../file.csv.bz2)." I18N/L10N --------- . dateformat and TimeFormat: Change "Note" to "NOTE" to be consistent with other notes, change tag to as it is more semantically correct. Logs ---- Debugging: . DumpTemplateVarsIntranet: change "variable" to "variables" and "staff intranet" to "staff interface". . DumpTemplateVarsOpac: change "variable" to "variables". Logging: . AuthFailureLog: add full stop. . AuthSuccessLog: add full stop. OPAC ---- Appearance: . BiblioDefaultView: change "bib" to "bibliographic". . HighlightOwnItemsOnOPAC: change ". (Non-XSLT Only)" to " (non-XSLT only).". . OpacAdditionalStylesheet: change "specified" to "specific". . OPACDisplay856uAsImage: change all options in the drop down list so they start in lowercase. . OpacHighlightedWords: change ";" to a full stop, add a full stop at the end. . OPACHoldingsDefaultSortField: add a full stop. . OpacMaxItemsToDisplay: change "user" to "patron". . OPACMySummaryHTML: change "user" to "patron". . OpacSeparateHoldings: change "user's to "patron's". . OpacStarRatings: change "user" to "patron" for the drop down option. . OPACShowUnusedAuthorities: change "Do not show" to "Don't show". . OPACUserSummary: change "user's to "patron's", change "fines" to "charges". . OPACXSLT*: change "Leave" to "leave". . Remove empty row at bottom of appearance options. Features: . OpacBrowser: change "OPAC" to "the OPAC". . OpacBrowseSearch: reword as "[Enable/Disable] interface for browsing all holdings (Elasticsearch only)." . OpacCloud: change "OPAC" to "the OPAC". . OPACDetailQRCode: change "Don't enable" to "Disable". . OPACFinesTab: change "Fines" to "charges", change "the My Accouunt" to "their account". (Should now show as "..patrons to access the charges tab on their account page on the OPAC." . OpacHoldNotes: change "Do not allow" to "Don't allow", change "users" to "patrons". . OpacResetPassword: change "users" to "patrons", add full stop. . SocialNetworks: change "in opac" to "on the OPAC". Note: Also deleted lines with # in front of them for the OpacBrowser and OpacCloud system preferences in the Policy section - these look like duplicated entries to me (previously lines 600-611). Policy: . OPACFineNoRenewalsIncludeCredits: change "users" to "patrons". Self registration and modification: . PatronSelfRegistrationConfirmEmail: change "Do not require" to "Don't require", change "users" to "patrons". . PatronSelfRegistrationEmailMustBeUnique: change "Do not consider" to "Don't consider". . PatronSelfRegistrationPrefillForm: change "Do not display and prefill" to "Don't display and prefill". Patrons ------- General: . AllowPatronToControlAutorenewal: add full stop. Notices and notifications: . EnhancedMessagingPreferences: change "Staff" to "staff". - FallbackToSMSIfNoEmail: change "Send" to "sending". Patron forms: . BorrowerUnwantedField: add full stop. . CollapseFieldsPatronAddForm: . Dropdown list changes: .. "Organization/Patron identity" => "Patron identity". .. "OPAC/Staff login" to "OPAC/Staff interface login". . Requires changes to the memberentrygen.tt - check that the add and edit form for a patron dispaly correctly: .. change "Contact" to "Contact information". .. change "Library set-up" to "Library setup". .. change "OPAC/Staff login" to "OPAC/Staff interface login". Patron relationships: . PrefillGuaranteeField: change drop down list option "Main address - street number" to "Main address - Street number" to match with format of other entries. Security: . RequireStrongPassword: change "More" to "more". Searching --------- Search form: . AdvancedSearchTypes: change "staff-side" to "staff interface". . expandedSearchOption: change "staff" to "staff interface". Serials ------- . makePreviousSerialAvailable: change "Do not make" to Don't make"; "syspref" to "system preference". . PreserveSerialNotes: change "Do not" to "Don't". . RoutingListNote: change "Include following" to "Include the following" Staff interface --------------- Tab label and link: . This tab was previously labelled "Staff client". . Change tab label on the left hand side from "Staff client" to "Staff interface". . Change URL when selected from "preferences.pl?tab=staff_client" to "preferences.pl?tab=staff_interface". . Check that the link works as expected. Appearance: . IntranetFavicon: change "Staff" to "staff". Tools ----- Reports: . NumSavedReports: change "Saved reports page" to "saved reports page". Web services ------------ IdRef: . IdRef: change "allows to request" to "allows requests for". Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 21:24:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 19:24:30 +0000 Subject: [Koha-bugs] [Bug 26313] "Show analytics" link doesn't work with Elasticsearch and UseControlNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 --- Comment #5 from Katrin Fischer --- I'll sign off and provide a few missing changes (OPAC). Tomas, can you then take over for QA? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 21:30:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 19:30:18 +0000 Subject: [Koha-bugs] [Bug 26345] New: new Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26345 Bug ID: 26345 Summary: new Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jeff96hcs at yahoo.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 21:31:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 19:31:07 +0000 Subject: [Koha-bugs] [Bug 25469] Typo: Item does not belongs to your library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25469 jeff96hcs at yahoo.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeff96hcs at yahoo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 21:55:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 19:55:09 +0000 Subject: [Koha-bugs] [Bug 26313] "Show analytics" link doesn't work with Elasticsearch and UseControlNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 21:55:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 19:55:13 +0000 Subject: [Koha-bugs] [Bug 26313] "Show analytics" link doesn't work with Elasticsearch and UseControlNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109423|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 109457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109457&action=edit Bug 26313: "Show analytics" link must use uppercase for booleans In elasticsearch we only treat AND and OR as boolean operators if they are capitalized To test: - Turn SearchEngine to Elasticsearch and make sure it works - Pick any serial record in your database, make sure 001 is set - Go to new > new child record - Fill in 245 and save - Click on the "In" link, it should bring you to the parent record - Click on "Show analytics" => there will be no result - Apply patch - restart and reload - Try again - It works! - Switch SearchEngine syspref to 'Zebra' - Test again - It still works! Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 21:55:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 19:55:17 +0000 Subject: [Koha-bugs] [Bug 26313] "Show analytics" link doesn't work with Elasticsearch and UseControlNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 --- Comment #7 from Katrin Fischer --- Created attachment 109458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109458&action=edit Bug 26313: (follow-up) Fix OPAC and "Show volumes" links Elasticsearch requires the booleans in search requests to be uppercase. This fixes the "Show analytics" link in OPAC (same as first patch for intranet) and the "Show volume" link. To test both patches: Set UseControlNumber = Use 1) "Show analytics" - Turn SearchEngine to Elasticsearch and make sure it works - Pick any serial record in your database, make sure 001 is set - Go to new > new child record - Fill in 245 and save - For both staff and OPAC: - Click on the "In" link, it should bring you to the parent record - Click on "Show analytics", it should show your analytical record - Switch to "Zebra" - verify links still work. 2) "Show volumes" - Turn SearchEngine to Elasticsearch again - Pick any serial record in your database, make sure 001 is set - Set LDR, pos. 19 = a - Set - Note 001 value - Find another record and edit it - Set LDR, pos. 19 = a or b, LDR 7 not a or b (m will work) - Set 773$ title of set record $w 001 of set record - For both staff and OPAC: - Click on the "In: link, it should bring up your set record - Click on the "Show volumes" link, it should bring up the volume - Switch to "Zebra" - verify all links still work. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 21:55:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 19:55:55 +0000 Subject: [Koha-bugs] [Bug 26313] "Show analytics" and "Show volumes" links doyn't work with Elasticsearch and UseControlNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"Show analytics" link |"Show analytics" and "Show |doesn't work with |volumes" links doyn't work |Elasticsearch and |with Elasticsearch and |UseControlNumber |UseControlNumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 21:56:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 19:56:01 +0000 Subject: [Koha-bugs] [Bug 26313] "Show analytics" and "Show volumes" links don't work with Elasticsearch and UseControlNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"Show analytics" and "Show |"Show analytics" and "Show |volumes" links doyn't work |volumes" links don't work |with Elasticsearch and |with Elasticsearch and |UseControlNumber |UseControlNumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 21:56:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 19:56:20 +0000 Subject: [Koha-bugs] [Bug 26313] "Show analytics" and "Show volumes" links don't work with Elasticsearch and UseControlNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 22:01:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 20:01:08 +0000 Subject: [Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|5959 |26131 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5959 [Bug 5959] Add search link for analytics to serial records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26131 [Bug 26131] console errors when attempting to open SCO related system preferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 22:01:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 20:01:08 +0000 Subject: [Koha-bugs] [Bug 5959] Add search link for analytics to serial records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5959 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15851 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 22:01:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 20:01:08 +0000 Subject: [Koha-bugs] [Bug 26131] console errors when attempting to open SCO related system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26131 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15851 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 22:14:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 20:14:04 +0000 Subject: [Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109267|0 |1 is obsolete| | --- Comment #73 from Katrin Fischer --- Created attachment 109459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109459&action=edit Bug 15851: Display analytics links for more cases The current XSLT displays the link to linked analytics only for serials. This patch makes it show for all the relevant position 7 on the leader values. I left out a and b as recommended by expert librarians on my team, but I can revert that if required. The current implementation adds a new CSS class for each case, so libraries willing to keep the current behaviour or just have more granular control on the cases they want the link to display, just can. This patch makes sense with the follow-up one, which will display the link only if there are really related records. To test: 1. Open a non-serial record, notice there's no link to analytics 2. Apply this patch and reload => SUCCESS: There's an 'Analytics' link 3. Inspect the produced HTML => SUCCESS: A special class with analytic_* value has been added, and thus we now can control its display through CSS 4. Sign off :-D Sponsored-by: Orex Digital Signed-off-by: Hugo Agud Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 22:14:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 20:14:10 +0000 Subject: [Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109268|0 |1 is obsolete| | --- Comment #74 from Katrin Fischer --- Created attachment 109460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109460&action=edit Bug 15851: Only display the analytics link when required This patch makes opac-detail.pl query for analytics the same way it would do with the generated link (i.e. based on UseControlNumber) and passes a flag to the XSLT so it displays (or not) the 'Analytics' link. To test: 1. Apply the first patch 2. Have a known record without analytics 3. Open the record in the OPAC => FAIL: It shows the 'Analytics' link 4. Have a record known to have analytics and open in OPAC, on a separate tab => SUCCESS: It shows the 'Analytics' link 5. Apply this patch and restart_all 6. Reload the tabs => SUCCESS: It shows the link where it has to, and hides it where it shouldn't be displayed 7. Sign off :-D Sponsored-by: Orex Digital Signed-off-by: Hugo Agud Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 22:14:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 20:14:15 +0000 Subject: [Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109269|0 |1 is obsolete| | --- Comment #75 from Katrin Fischer --- Created attachment 109461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109461&action=edit Bug 15851: (follow-up) Only display the analytics link when required (staff) This patch replicates the introduced behaviour, for the admin interface. To test, follow the test plan from the OPAC, but on the intranet. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 22:14:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 20:14:21 +0000 Subject: [Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 --- Comment #76 from Katrin Fischer --- Created attachment 109462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109462&action=edit Bug 15851: (QA follow-up) Fix booleans to uppercase to make this work for Elasticsearch and UseControlNumber Same test plan as before, but with UseControlNumber = Use and Elasticsearch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 22:16:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 20:16:19 +0000 Subject: [Koha-bugs] [Bug 26345] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26345 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|new |SPAM Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 22:31:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 20:31:05 +0000 Subject: [Koha-bugs] [Bug 26091] Add column configuration and export options to catalog statistics report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26091 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Who signed the| |This patch adds the export patch off| |and print options as well | |as "on the fly" column | |configuration to the | |Catalog statistics wizard. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 23:57:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 21:57:53 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 23:58:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 21:58:03 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109312|0 |1 is obsolete| | --- Comment #566 from Aleisha Amohia --- Created attachment 109463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109463&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 23:58:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 21:58:12 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109313|0 |1 is obsolete| | --- Comment #567 from Aleisha Amohia --- Created attachment 109464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109464&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 23:58:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 21:58:23 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109314|0 |1 is obsolete| | --- Comment #568 from Aleisha Amohia --- Created attachment 109465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109465&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 23:58:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 21:58:33 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109315|0 |1 is obsolete| | --- Comment #569 from Aleisha Amohia --- Created attachment 109466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109466&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 23:58:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 21:58:44 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109316|0 |1 is obsolete| | --- Comment #570 from Aleisha Amohia --- Created attachment 109467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109467&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 23:58:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 21:58:56 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109317|0 |1 is obsolete| | --- Comment #571 from Aleisha Amohia --- Created attachment 109468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109468&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 1 23:59:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 21:59:08 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109318|0 |1 is obsolete| | --- Comment #572 from Aleisha Amohia --- Created attachment 109469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109469&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls Test plan in Comment 482. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 00:01:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 22:01:40 +0000 Subject: [Koha-bugs] [Bug 26301] Self-checkout blocks renew for overdues even when OverduesBlockRenewing allows it in opac-user.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26301 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 00:30:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 22:30:19 +0000 Subject: [Koha-bugs] [Bug 26136] Prevent double submit of checkin form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26136 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.11.00, 20.05.03 |20.11.00, 20.05.03, released in| |19.11.10 --- Comment #7 from Aleisha Amohia --- managed to reproduce somewhere else, so have backported to 19.11.x for 19.11.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 00:32:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 22:32:13 +0000 Subject: [Koha-bugs] [Bug 26270] XISBN.t is failing since today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26270 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 00:33:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Sep 2020 22:33:19 +0000 Subject: [Koha-bugs] [Bug 26270] XISBN.t is failing since today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26270 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 19.11.10 released in| | --- Comment #12 from Aleisha Amohia --- backported to 19.11.x for 19.11.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 06:30:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 04:30:24 +0000 Subject: [Koha-bugs] [Bug 26305] Warn IE users of Staff Interface that it is no longer supported and to use a support browser instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26305 --- Comment #3 from David Cook --- I haven't gotten any responses on Bugzilla or via the listserv, but I will start running this locally very soon. I'm happy to report back on our local experience. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 06:31:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 04:31:25 +0000 Subject: [Koha-bugs] [Bug 26305] Warn IE users of Staff Interface that it is no longer supported and to use a support browser instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26305 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25803 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 06:31:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 04:31:25 +0000 Subject: [Koha-bugs] [Bug 25803] Internet Explorer: unable to save patron edits or view patron checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25803 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26305 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 06:31:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 04:31:58 +0000 Subject: [Koha-bugs] [Bug 25803] Internet Explorer: unable to save patron edits or view patron checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25803 --- Comment #7 from David Cook --- I get support calls about this on a weekly basis, so I'm going to apply Bug 26305 locally, so that staff users get a warning that IE 11 won't work for them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 06:33:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 04:33:15 +0000 Subject: [Koha-bugs] [Bug 26328] barcode.pl: ValueBuilder::incremental should filter non-natural numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26328 --- Comment #3 from David Cook --- I have a long TODO list, but I can look at adding a patch for this down the road. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 06:42:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 04:42:13 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #237 from David Cook --- (In reply to Jonathan Druart from comment #236) > I have 2 questions: > > We need > apt install rabbitmq-server > rabbitmq-plugins enable rabbitmq_stomp > service rabbitmq-server restart > > we can have rabbitmq-server inside control.in, but what about the 2 other > commands? > > Should we have them part of the install process or in koha-common (like we > try to guess if the plugin is enabled, otherwise we enable it and restart > rabbitmq)? > I think that we should probably treat rabbitmq setup the same way we treat mysql installation; that is, as a separate step. The Koha server(s) should only be concerned with the network connection to RabbitMQ. The sysadmin should be responsible for configuring RabbitMQ apart from that. (Same day, we might change our mind about that, in that case I'd say probably require Koha to use the RabbitMQ REST API (plugin). While it's not necessarily an out-of-the-box solution, I think it is a reasonable one.) > Also, shouldn't we add a rabbitmq status indicator on the about page? +1 I would really like this -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 06:46:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 04:46:43 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #238 from David Cook --- (In reply to David Cook from comment #237) > I think that we should probably treat rabbitmq setup the same way we treat > mysql installation; that is, as a separate step. > To that end, I think that we should "suggest" rather than "require" rabbitmq-server in the debian/control file. When running koha-testing-docker, we'll have a separate container for rabbitmq. We won't have it installed locally. Production deployments may also have a 2+ instance RabbitMQ cluster (using either round robin DNS or a load balancer or both). Those won't be local to the Koha server(s) either. So Koha can only interact with RabbitMQ over a network. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 06:53:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 04:53:54 +0000 Subject: [Koha-bugs] [Bug 26299] Help text for OPAC SMS number should be less North American-centric In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 --- Comment #7 from David Cook --- (In reply to Nick Clemens from comment #6) > (In reply to Jonathan Druart from comment #4) > > Nick, are you ok with this? > > I checked with our educators - their concern is that it not start with 1, > which is the indicator of 'long distance' calls here. > > 9785550123 would be better as it won't end up being a real phone number > https://en.wikipedia.org/wiki/555_(telephone_number) That's an interesting point. Maybe we should just change the wording (in both interfaces) to something like... "Please enter numbers only. Prefix the number with + if including the country code." After that, the Javascript validation messages should provide enough formatting information? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 06:55:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 04:55:42 +0000 Subject: [Koha-bugs] [Bug 26299] Help text for OPAC SMS number should be less North American-centric In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 --- Comment #8 from David Cook --- I mention the + in part because I don't think we actually mention that anywhere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 06:55:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 04:55:48 +0000 Subject: [Koha-bugs] [Bug 26299] Help text for OPAC SMS number should be less North American-centric In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26285 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 06:55:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 04:55:48 +0000 Subject: [Koha-bugs] [Bug 26285] Use country code + number (E.164) validation for SMS numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26285 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26299 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 07:43:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 05:43:16 +0000 Subject: [Koha-bugs] [Bug 19967] Search patrons with non-Latin languages is broken if DefaultPatronSearchFields includes date or datetime field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19967 --- Comment #7 from Ulrich Kleiber --- We have completely switched to MariaDB -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 08:07:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 06:07:56 +0000 Subject: [Koha-bugs] [Bug 26346] New: Add option to make a public list editable by library staff only Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Bug ID: 26346 Summary: Add option to make a public list editable by library staff only Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: bolshawh at parliament.uk QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Currently there are three options for who can add or remove items from a public list: - "Nobody" - "Owner Only" - "Anybody seeing this list" It would be useful to have a "staff only" option as well so that all users could see the list but only library staff could add or remove items from the list. At the moment we have to either rely on a single member of staff to update and maintain a public list or give everyone edit rights and risk users accidentally or deliberately editing a list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 09:06:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 07:06:34 +0000 Subject: [Koha-bugs] [Bug 26041] Accessibility: The date picker calendar is not keyboard accessible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26041 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108664|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 09:06:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 07:06:44 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #239 from Katrin Fischer --- MySQL/MariaDB is very standard, RabbitMQ is not... I am far from understanding the whole discussion here, but from the use cases and "need" for this I have heard about, I wonder if this can be really kept an optional feature. And if it turns mandatory, are we adding a new hurdle to installing Koha if we keep it all separate for the sysadmin to deal with? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 09:09:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 07:09:08 +0000 Subject: [Koha-bugs] [Bug 26041] Accessibility: The date picker calendar is not keyboard accessible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26041 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107274|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 109470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109470&action=edit Bug 26041: Enable keyboard navigation without 'ctrl' This patch enables keyboard navigation using the arrow keys without the need to hold the control key for the jQuery UI datepicker. Test plan 1/ Navigate to an item in the opac and attempt to place a hold 2/ On the resultant screen, use keyboard navigation to trigger the 'Show more options' dropdown. 3/ Focus on one of the date inputs using keyboard navigation. 4/ Use 'ctrl + arrow' keys to navigate the datepicker. 5/ Note that prior to the patch using 'bare' arrow keys does not trigger anything 6/ Apply the patch and confirm that the datepicker can now be naviated using the arrow keys without holding the ctrl key. 7/ Confirm that using the ctrl key combinations continue to work as expected too. 8/ Signoff Signed-off-by: Brandon J -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 09:11:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 07:11:33 +0000 Subject: [Koha-bugs] [Bug 26041] Accessibility: The date picker calendar is not keyboard accessible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26041 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #15 from Martin Renvoize --- I have obsoleted the final patch with agreement from the sponsor. Removing the readonly attribute had the side effect of also interrupting the flow for keybarod navigation as the same field would be editable twice in sequence (once via text entry and a second time via the datepicker widget). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 09:22:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 07:22:34 +0000 Subject: [Koha-bugs] [Bug 26347] New: Wrong publication pattern locale on months Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26347 Bug ID: 26347 Summary: Wrong publication pattern locale on months Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: hagud at orex.es QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Configuring publication patterns with locale ca-ES we have discovered that months are wrong translated january = gener and now it is translating = de gener februry = febrer and now it is translating = febrer march.....etc locale should use just months not full name -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 09:31:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 07:31:57 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #240 from Julian Maurice --- It would be great if RabbitMQ was made optional, perhaps by adding a very basic task queue implementation (for instance with only 1 worker allowed to avoid many problems of a task queue) that will be used if RabbitMQ is not configured ? But that would still require sysadmins to add a "service" (systemd service, start/stop script, ...) for the worker, so there would be manual steps anyway. Is there a way to make background jobs work automatically on the next upgrade ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 10:56:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 08:56:49 +0000 Subject: [Koha-bugs] [Bug 26082] Follow up to bug 23463 - need to call Koha::Item store to get itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26082 --- Comment #6 from Martin Renvoize --- 20.05 will need this ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 11:00:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 09:00:33 +0000 Subject: [Koha-bugs] [Bug 26348] New: Create Account Button Does Not Send Account Verification Email Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26348 Bug ID: 26348 Summary: Create Account Button Does Not Send Account Verification Email Change sponsored?: --- Product: Koha Version: 20.05 Hardware: PC OS: Windows Status: NEW Severity: normal Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: jeff96hcs at yahoo.com QA Contact: testopia at bugs.koha-community.org Prerequisites: Must reach the page that says "A confirmation email has been sent containing a link to continue creating an account. The link will expire if an account is not created within 3 days." Steps to Reproduce: - Click "New Account" in main tab to go to create account page - Go to lower right corner of page. Enter e-mail address in text prompt, check the checkbox saying "I have read Bugzilla Etiquette and the Mozilla Community Participation Guidelines and agree to abide by them." - Click "Create Account" Button Actual Results: You arrive at the page that says "A confirmation email has been sent containing a link to continue creating an account. The link will expire if an account is not created within 3 days." However, no confirmation email appears in the inbox or spam of the entered email address Expected Results: You arrive at the page that says "A confirmation email has been sent containing a link to continue creating an account. The link will expire if an account is not created within 3 days." A confirmation email should already appear in the inbox or spam of the entered email address -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 11:01:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 09:01:52 +0000 Subject: [Koha-bugs] [Bug 26348] Create Account Button Does Not Send Account Verification Email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26348 --- Comment #1 from jeff96hcs at yahoo.com --- Created attachment 109471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109471&action=edit Email does NOT appear in spam -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 11:02:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 09:02:35 +0000 Subject: [Koha-bugs] [Bug 26348] Create Account Button Does Not Send Account Verification Email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26348 --- Comment #2 from jeff96hcs at yahoo.com --- Created attachment 109472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109472&action=edit Email does NOT appear in inbox -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 11:02:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 09:02:58 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #241 from Jonathan Druart --- (In reply to Julian Maurice from comment #240) > It would be great if RabbitMQ was made optional, perhaps by adding a very > basic task queue implementation (for instance with only 1 worker allowed to > avoid many problems of a task queue) that will be used if RabbitMQ is not > configured ? > But that would still require sysadmins to add a "service" (systemd service, > start/stop script, ...) for the worker, so there would be manual steps > anyway. > > Is there a way to make background jobs work automatically on the next > upgrade ? There is the a start/stop script provided with the debian package (debian/scripts/koha-worker). It will start the daemon like we do with other services. There is no extra steps needed for that part. The only bit to make it works is the 3 lines I pasted earlier: apt install rabbitmq-server # done with the deb dependency rabbitmq-plugins enable rabbitmq_stomp service rabbitmq-server restart And maybe that could be a postinst task (?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 11:03:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 09:03:33 +0000 Subject: [Koha-bugs] [Bug 26348] Create Account Button Does Not Send Account Verification Email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26348 --- Comment #3 from jeff96hcs at yahoo.com --- Created attachment 109473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109473&action=edit The page that confirms that a confirmation email was sent to create new account -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 11:17:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 09:17:31 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #242 from Jonathan Druart --- Created attachment 109474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109474&action=edit Bug 22417: Add rabbitmq status indicator on the about page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 11:41:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 09:41:08 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #243 from Julian Maurice --- (In reply to Jonathan Druart from comment #241) > (In reply to Julian Maurice from comment #240) > > It would be great if RabbitMQ was made optional, perhaps by adding a very > > basic task queue implementation (for instance with only 1 worker allowed to > > avoid many problems of a task queue) that will be used if RabbitMQ is not > > configured ? > > But that would still require sysadmins to add a "service" (systemd service, > > start/stop script, ...) for the worker, so there would be manual steps > > anyway. > > > > Is there a way to make background jobs work automatically on the next > > upgrade ? > > There is the a start/stop script provided with the debian package > (debian/scripts/koha-worker). It will start the daemon like we do with other > services. There is no extra steps needed for that part. What about non-package installs ? It's probably not possible to automate everything, but a minimal systemd service file for the worker would be a good start I think. So when you update/install Koha you just have to copy the file to /etc/systemd/system and adjust paths/users/.. It has certainly helped me in the past with other softwares I installed. Can be done in another bug report, but what do you think about this ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 11:55:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 09:55:51 +0000 Subject: [Koha-bugs] [Bug 26349] New: Add new column number of successful login done by the patron Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26349 Bug ID: 26349 Summary: Add new column number of successful login done by the patron Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: amitddng135 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently we are capturing lastseen date of the user. Once of our customer request to see total number of login done by the user -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 11:56:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 09:56:20 +0000 Subject: [Koha-bugs] [Bug 26349] Add new column number of successful login done by the patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26349 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amit.gupta at informaticsgloba | |l.com, | |amitddng135 at gmail.com Assignee|koha-bugs at lists.koha-commun |amitddng135 at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 11:59:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 09:59:33 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109474|0 |1 is obsolete| | --- Comment #244 from Jonathan Druart --- Created attachment 109475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109475&action=edit Bug 22417: Add rabbitmq status indicator on the about page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 11:59:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 09:59:38 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #245 from Jonathan Druart --- Created attachment 109476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109476&action=edit Bug 22417: Remove list of pending jobs This was not accurate as it was only retrieving jobs for batch_biblio_record_modification We will need to improve that later if needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 11:59:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 09:59:43 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #246 from Jonathan Druart --- Created attachment 109477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109477&action=edit Bug 22417: Process the jobs even if the message broker is not reachable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 12:02:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 10:02:04 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #247 from Jonathan Druart --- This last patch adds the ability to process the jobs even if the message broker is not installed/configured correctly. I am not sure it is a good idea, we will want to make the message broker mandatory at some point anyway (for messages not in the DB for instance). And so we are only postponing the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 12:03:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 10:03:06 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #248 from Jonathan Druart --- (In reply to Julian Maurice from comment #243) > (In reply to Jonathan Druart from comment #241) > > (In reply to Julian Maurice from comment #240) > > > It would be great if RabbitMQ was made optional, perhaps by adding a very > > > basic task queue implementation (for instance with only 1 worker allowed to > > > avoid many problems of a task queue) that will be used if RabbitMQ is not > > > configured ? > > > But that would still require sysadmins to add a "service" (systemd service, > > > start/stop script, ...) for the worker, so there would be manual steps > > > anyway. > > > > > > Is there a way to make background jobs work automatically on the next > > > upgrade ? > > > > There is the a start/stop script provided with the debian package > > (debian/scripts/koha-worker). It will start the daemon like we do with other > > services. There is no extra steps needed for that part. > > What about non-package installs ? > It's probably not possible to automate everything, but a minimal systemd > service file for the worker would be a good start I think. So when you > update/install Koha you just have to copy the file to /etc/systemd/system > and adjust paths/users/.. It has certainly helped me in the past with other > softwares I installed. > Can be done in another bug report, but what do you think about this ? Yes, that could be a good idea! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 12:05:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 10:05:19 +0000 Subject: [Koha-bugs] [Bug 26349] Add new column number of successful login done by the patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26349 --- Comment #1 from Katrin Fischer --- You can now log successful/unsuccessful login attempts (see log prefs). Maybe a report could work here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 12:06:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 10:06:23 +0000 Subject: [Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 --- Comment #77 from Jonathan Druart --- - - "(Leave this field empty to send messages to their normal recipient)" + - "(Leave this field empty to send messages to their normal recipient.)" Period should be after the parenthesis I'd say -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 12:10:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 10:10:41 +0000 Subject: [Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 --- Comment #78 from Jonathan Druart --- (In reply to Jonathan Druart from comment #77) > - - "(Leave this field empty to send messages to their normal > recipient)" > + - "(Leave this field empty to send messages to their normal > recipient.)" > > Period should be after the parenthesis I'd say Hum, maybe not actually, the full entry is: Email to redirect all messages to: [pref] (Leave this field empty to send messages to their normal recipient.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 12:16:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 10:16:02 +0000 Subject: [Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 --- Comment #79 from Katrin Fischer --- (In reply to Jonathan Druart from comment #78) > (In reply to Jonathan Druart from comment #77) > > - - "(Leave this field empty to send messages to their normal > > recipient)" > > + - "(Leave this field empty to send messages to their normal > > recipient.)" > > > > Period should be after the parenthesis I'd say > > Hum, maybe not actually, the full entry is: > > Email to redirect all messages to: [pref] (Leave this field empty to send > messages to their normal recipient.) I think in this case within the () is correct, as the whole sentence is inside the () and not starting outside of it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 12:16:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 10:16:16 +0000 Subject: [Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #63 from Jonathan Druart --- Please rebase (conflict with bug 19889). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 12:25:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 10:25:00 +0000 Subject: [Koha-bugs] [Bug 14251] Allow use of CSS in discharge letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org --- Comment #10 from Dobrica Pavlinusic --- (In reply to Claudio from comment #1) > Hi Nicole, is it possible to add the current date in the discharge letter? I might be a little late, but you can use <> to include current date. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 12:33:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 10:33:36 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108230|0 |1 is obsolete| | --- Comment #83 from Martin Renvoize --- Created attachment 109478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109478&action=edit Bug 25261: Add system preference Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 12:33:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 10:33:40 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108231|0 |1 is obsolete| | --- Comment #84 from Martin Renvoize --- Created attachment 109479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109479&action=edit Bug 25261: Require confirmation of multiple parts items Test plan 1/ Catalogue an item to contain multiple parts by populating 'Materials specified (bound volume or other part)' 2/ Enable the new system preference 'CircConfirmParts' 3/ Attempt to checkout the item created in step 1 to a user and note that confirmation is now required. 4/ Checkout the item 5/ Attempt to checkin the item you have just checked out and note that confirmation is required. 6/ Signoff Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 12:33:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 10:33:44 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108232|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize --- Created attachment 109480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109480&action=edit Bug 25261: Checkout confirmation depending on syspref With this follow-up patch, the intended confirmation of checkin based on CircConfirmParts value is effective. Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 12:33:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 10:33:48 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108233|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize --- Created attachment 109481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109481&action=edit Bug 25261: (follow-up) Rename CircConfirmParts to CircConfirmItemParts This clarifies the preference name to make it clear we are talking about the 'parts' that make up an 'item'. 'Part' is a well known term in british english libraries and I think perhaps 'Materials' may be confused with other terms? Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 12:33:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 10:33:52 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108234|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize --- Created attachment 109482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109482&action=edit Bug 25261: (follow-up) item.material may contain non-numerics Whilst QAing bug 13547 it was highlighted to me the at the 952$3 field, and thus the item.materials field, may contain arbitrary notes about the material rather than just numeric values. As such we need to check for the field being defined as aposed to greater than '0'. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 12:33:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 10:33:56 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108235|0 |1 is obsolete| | --- Comment #88 from Martin Renvoize --- Created attachment 109483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109483&action=edit Bug 25261: (QA follow-up) Add unit tests Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 12:34:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 10:34:00 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108236|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize --- Created attachment 109484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109484&action=edit Bug 25261: (QA follow-up) Simplify tests and conditions Use build_sample_item in tests Simplify tests for the confirmation Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 12:34:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 10:34:04 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108237|0 |1 is obsolete| | --- Comment #90 from Martin Renvoize --- Created attachment 109485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109485&action=edit Bug 25261: (QA follow-up) Non-confirm on return This patch updates the confirmation from an alert to a dismissable modal which allows for optionally not checking the item in Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 12:34:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 10:34:08 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108238|0 |1 is obsolete| | --- Comment #91 from Martin Renvoize --- Created attachment 109486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109486&action=edit Bug 25261: (QA follow-up) Add confirmation to issues table The issues table allows for checkins and was not appropriately requireing confirmation for the multi-part confirmation added in this bug. Test plan 1/ Enable the feature as per previous patches 2/ Checkot an item with attached materials 3/ Navigate to a page that display your users issues table (the checkout page is a reasonable example) 4/ You should have the option to select items for return in the table (If not, use the column settings to enable the feature) 5/ Select at least the item with attached materials to return 6/ Upon clicking the return buttton you should find that items without additional materials are returned as expected, but rows with additional materials turn yellow and contain a message and additional checkbox for confirmation in the table. 7/ Ensure the checkbox is selected and click the return button again 8/ This item should have been returned. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 12:34:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 10:34:12 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108239|0 |1 is obsolete| | --- Comment #92 from Martin Renvoize --- Created attachment 109487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109487&action=edit Bug 25261: (QA follow-up) Catch check in SIP Checkout Test plan 1/ Enable the feature as per previous patches 2/ Attempt to checkout an item with materials attached via a SIP unit 3/ Note that the checkut is blocked with the message 'Item must be issued at a circulation desk' 4/ Signoff Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 12:34:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 10:34:16 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108240|0 |1 is obsolete| | --- Comment #93 from Martin Renvoize --- Created attachment 109488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109488&action=edit Bug 25261: (QA follow-up) Add handling to SCO Test plan 1/ Enable the feature as per previous patches 2/ Attempt to checkout an item with materials attached via the SCO 3/ Note that the checkut is blocked with the message 'Item must be issued at a circulation desk' 4/ Signoff Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 12:34:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 10:34:20 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108241|0 |1 is obsolete| | --- Comment #94 from Martin Renvoize --- Created attachment 109489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109489&action=edit Bug 25261: (QA follow-up) Catch check in SIP Checkin Test plan 1/ Enable the feature as per previous patches 2/ Attempt to return an item with materials attached via a SIP unit 3/ Note that the return is blocked with an alert type of '99' 4/ Signoff Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 12:34:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 10:34:24 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108242|0 |1 is obsolete| | --- Comment #95 from Martin Renvoize --- Created attachment 109490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109490&action=edit Bug 25261: (QA follow-up) Add handling to SCI Test plan 1/ Enable the feature as per previous patches 2/ Attempt to return an item with materials attached via the SCI 3/ Note that the return is blocked with the message '(The item cannot be returned at a self service terminal, please see library staff for assistance)' 4/ Signoff Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 12:34:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 10:34:42 +0000 Subject: [Koha-bugs] [Bug 26348] Create Account Button Does Not Send Account Verification Email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26348 --- Comment #4 from Owen Leonard --- Have you checked to see if the message in the "message_queue" table? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 12:39:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 10:39:48 +0000 Subject: [Koha-bugs] [Bug 26348] Create Account Button Does Not Send Account Verification Email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26348 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #5 from Katrin Fischer --- Hi Jeff, this is the Koha project - an Open source library system. >From your screenshots and the description I am not sure you meant to file the bug here. We don't ask for "I have read Bugzilla Etiquette and the Mozilla Community..." here. Our test reads: "To create a Bugzilla account, all you need to do is to enter a legitimate email address. You will receive an email at this address to confirm the creation of your account. You will not be able to log in until you receive the email. If it doesn't arrive within a reasonable amount of time, you may contact the maintainer of this Bugzilla installation at chris at bigballofwax.co.nz." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 12:48:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 10:48:34 +0000 Subject: [Koha-bugs] [Bug 25698] Curbside Pickup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25698 --- Comment #16 from Kyle M Hall --- (In reply to David Cook from comment #15) > That Equinox news item was a bit confusing, although it makes more sense > when read after the previous news item at > https://www.equinoxinitiative.org/fe_highlightitem. > php?sid=10155f3ecfef0033d446 which actually references this bug report and > how Kyle (of Bywater) started the plugin. > > I am also really pumped for Galen's contribution to that plugin. Lack of > DBIC integration in plugins has been a pain when I've been writing them, so > this offers a nice change. (Although we might want to create some > Koha::Plugin::* code to make it easier for any plugin to use the > functionality without copying the boiler plate if possible.) Agreed. It would certainly be reasonable to have the plugin base to look for a 'lib' directory in the bundle directory, locate all pm files, require the files, and run register_class for all modules starting with Koha::Schema::Result. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 12:53:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 10:53:15 +0000 Subject: [Koha-bugs] [Bug 26350] New: Librarians can request discharge on behalf of patron Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 Bug ID: 26350 Summary: Librarians can request discharge on behalf of patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: dpavlin at rot13.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com While deploying discharges in our library we figured out that librarians need ability to request discharge document on behalf of patrons from intranet page. It was logical to add another option on Discharge patron tab. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:02:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:02:10 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109478|0 |1 is obsolete| | --- Comment #96 from Martin Renvoize --- Created attachment 109491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109491&action=edit Bug 25261: Add system preference Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:02:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:02:15 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109479|0 |1 is obsolete| | --- Comment #97 from Martin Renvoize --- Created attachment 109492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109492&action=edit Bug 25261: Require confirmation of multiple parts items Test plan 1/ Catalogue an item to contain multiple parts by populating 'Materials specified (bound volume or other part)' 2/ Enable the new system preference 'CircConfirmParts' 3/ Attempt to checkout the item created in step 1 to a user and note that confirmation is now required. 4/ Checkout the item 5/ Attempt to checkin the item you have just checked out and note that confirmation is required. 6/ Signoff Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:02:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:02:19 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109480|0 |1 is obsolete| | --- Comment #98 from Martin Renvoize --- Created attachment 109493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109493&action=edit Bug 25261: Checkout confirmation depending on syspref With this follow-up patch, the intended confirmation of checkin based on CircConfirmParts value is effective. Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:02:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:02:23 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109481|0 |1 is obsolete| | --- Comment #99 from Martin Renvoize --- Created attachment 109494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109494&action=edit Bug 25261: (follow-up) Rename CircConfirmParts to CircConfirmItemParts This clarifies the preference name to make it clear we are talking about the 'parts' that make up an 'item'. 'Part' is a well known term in british english libraries and I think perhaps 'Materials' may be confused with other terms? Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:02:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:02:27 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109482|0 |1 is obsolete| | --- Comment #100 from Martin Renvoize --- Created attachment 109495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109495&action=edit Bug 25261: (follow-up) item.material may contain non-numerics Whilst QAing bug 13547 it was highlighted to me the at the 952$3 field, and thus the item.materials field, may contain arbitrary notes about the material rather than just numeric values. As such we need to check for the field being defined as aposed to greater than '0'. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:02:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:02:32 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109483|0 |1 is obsolete| | --- Comment #101 from Martin Renvoize --- Created attachment 109496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109496&action=edit Bug 25261: (QA follow-up) Add unit tests Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:02:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:02:36 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109484|0 |1 is obsolete| | --- Comment #102 from Martin Renvoize --- Created attachment 109497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109497&action=edit Bug 25261: (QA follow-up) Simplify tests and conditions Use build_sample_item in tests Simplify tests for the confirmation Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:02:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:02:40 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109485|0 |1 is obsolete| | --- Comment #103 from Martin Renvoize --- Created attachment 109498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109498&action=edit Bug 25261: (QA follow-up) Non-confirm on return This patch updates the confirmation from an alert to a dismissable modal which allows for optionally not checking the item in Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:02:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:02:44 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109486|0 |1 is obsolete| | --- Comment #104 from Martin Renvoize --- Created attachment 109499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109499&action=edit Bug 25261: (QA follow-up) Add confirmation to issues table The issues table allows for checkins and was not appropriately requireing confirmation for the multi-part confirmation added in this bug. Test plan 1/ Enable the feature as per previous patches 2/ Checkot an item with attached materials 3/ Navigate to a page that display your users issues table (the checkout page is a reasonable example) 4/ You should have the option to select items for return in the table (If not, use the column settings to enable the feature) 5/ Select at least the item with attached materials to return 6/ Upon clicking the return buttton you should find that items without additional materials are returned as expected, but rows with additional materials turn yellow and contain a message and additional checkbox for confirmation in the table. 7/ Ensure the checkbox is selected and click the return button again 8/ This item should have been returned. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:02:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:02:48 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109487|0 |1 is obsolete| | --- Comment #105 from Martin Renvoize --- Created attachment 109500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109500&action=edit Bug 25261: (QA follow-up) Catch check in SIP Checkout Test plan 1/ Enable the feature as per previous patches 2/ Attempt to checkout an item with materials attached via a SIP unit 3/ Note that the checkut is blocked with the message 'Item must be issued at a circulation desk' 4/ Signoff Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:02:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:02:53 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109488|0 |1 is obsolete| | --- Comment #106 from Martin Renvoize --- Created attachment 109501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109501&action=edit Bug 25261: (QA follow-up) Add handling to SCO Test plan 1/ Enable the feature as per previous patches 2/ Attempt to checkout an item with materials attached via the SCO 3/ Note that the checkut is blocked with the message 'Item must be issued at a circulation desk' 4/ Signoff Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:02:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:02:59 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109489|0 |1 is obsolete| | --- Comment #107 from Martin Renvoize --- Created attachment 109502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109502&action=edit Bug 25261: (QA follow-up) Catch check in SIP Checkin Test plan 1/ Enable the feature as per previous patches 2/ Attempt to return an item with materials attached via a SIP unit 3/ Note that the return is blocked with an alert type of '99' 4/ Signoff Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:03:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:03:03 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109490|0 |1 is obsolete| | --- Comment #108 from Martin Renvoize --- Created attachment 109503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109503&action=edit Bug 25261: (QA follow-up) Add handling to SCI Test plan 1/ Enable the feature as per previous patches 2/ Attempt to return an item with materials attached via the SCI 3/ Note that the return is blocked with the message '(The item cannot be returned at a self service terminal, please see library staff for assistance)' 4/ Signoff Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:03:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:03:07 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #109 from Martin Renvoize --- Created attachment 109504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109504&action=edit Bug 25261: (QA follow-up) Capitalize return of needsconfirm This patch capitalizes the 'ADDITIONAL_MATERIALS' key in the needsconfirm hash return value for CanBookBeIssued to restore consistency with previous code and ensure SIP Checkout works as expected. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:04:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:04:08 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #110 from Martin Renvoize --- Final patch should restore consistency in the return value for CanBookBeIssued such that SIP Checkout will perform as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:17:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:17:56 +0000 Subject: [Koha-bugs] [Bug 26327] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:17:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:17:59 +0000 Subject: [Koha-bugs] [Bug 26327] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109376|0 |1 is obsolete| | Attachment #109377|0 |1 is obsolete| | Attachment #109378|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 109505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109505&action=edit Bug 26327: Add ->library method to Koha::*Checkout This patch adds a 'library' relationship to the Issue and OldIssue resultsets, to be used in the Koha::*Checkout classes corresponding accessors. This way we will be able to eventually embed and filter on library fields on the API. The ->library method is then added to the classes- To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old.t t/db_dependent/Koha/Checkout.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:18:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:18:43 +0000 Subject: [Koha-bugs] [Bug 26327] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #6 from Kyle M Hall --- Created attachment 109506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109506&action=edit Bug 26327: Include transacting library in fines This patch introduces a new column on the fines table to display the checkout library when the fine is tied to a checkout. To test: 1. Have an overdue item that generated a fee 2. Look at the 'Accounting' tab, 'Make a payment' => FAIL: There's no information about the library 3. Apply this patch 4. Restart all 5. Reload and repeat 2 => SUCCESS: There's a column with the library name! 6. Identify the issue_id for the mentioned checkout and: $ koha-mysql kohadev > UPDATE old_issues SET branchcode='TOM' WHERE issue_id=11; (i.e. set the branchcode to an invalid value, to emulate a deleted branch). 7. Reload => SUCCESS: It doesn't explode, it doesn't display a library name. 8. Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:18:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:18:46 +0000 Subject: [Koha-bugs] [Bug 26327] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #7 from Kyle M Hall --- Created attachment 109507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109507&action=edit Bug 26327: Add to columns settings Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:19:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:19:29 +0000 Subject: [Koha-bugs] [Bug 26327] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #8 from Kyle M Hall --- Looks good! Wondering if we should include the column in boraccount.pl as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:22:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:22:01 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #111 from Martin Renvoize --- Created attachment 109508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109508&action=edit Bug 25261: (QA follow-up) Restore previously returned list Test plan 0 - Enable ShowAllCheckins 1 - Check in several regular items 2 - Check in an item with parts 3 - Confirm the checkin in 4 - The list of checkins contains all the previous checkins and the multi-part checkin too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:22:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:22:42 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #112 from Martin Renvoize --- All issues highlighted in QA should now be resolved :), Thanks for testing Nick :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:26:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:26:55 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #249 from Julian Maurice --- (In reply to Jonathan Druart from comment #247) > This last patch adds the ability to process the jobs even if the message > broker is not installed/configured correctly. > > I am not sure it is a good idea, we will want to make the message broker > mandatory at some point anyway (for messages not in the DB for instance). > And so we are only postponing the problem. IMO we should not rely on the connection status (RabbitMQ is reachable or not) but instead on the configuration (RabbitMQ is configured or not). For instance, if configuration for RabbitMQ exists in $KOHA_CONF, use that, and if it is not reachable then die. And if there is no configuration, use the "dumb" worker system. That would allow people to just use the dumb system if it works for them, and if not sufficient they can "upgrade" by installing and configuring RabbitMQ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:38:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:38:53 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #250 from Marcel de Rooy --- (In reply to Julian Maurice from comment #249) > (In reply to Jonathan Druart from comment #247) > > This last patch adds the ability to process the jobs even if the message > > broker is not installed/configured correctly. > > > > I am not sure it is a good idea, we will want to make the message broker > > mandatory at some point anyway (for messages not in the DB for instance). > > And so we are only postponing the problem. > > IMO we should not rely on the connection status (RabbitMQ is reachable or > not) but instead on the configuration (RabbitMQ is configured or not). > For instance, if configuration for RabbitMQ exists in $KOHA_CONF, use that, > and if it is not reachable then die. And if there is no configuration, use > the "dumb" worker system. > That would allow people to just use the dumb system if it works for them, > and if not sufficient they can "upgrade" by installing and configuring > RabbitMQ If we feel that RabbitMQ is not ready for primary processes like the batch record modify in this patch set, we should remove that part. I would not promote a hybrid solution that falls back to code without MQ. It should just be stable enough to operate on and seen as an essential component. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:39:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:39:43 +0000 Subject: [Koha-bugs] [Bug 24466] AllowHoldsOnPatronsPossessions and the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24466 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Magnus Enger --- This should be fixed by the patches on bug 22806, I think. *** This bug has been marked as a duplicate of bug 22806 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:39:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:39:43 +0000 Subject: [Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #44 from Magnus Enger --- *** Bug 24466 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:47:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:47:16 +0000 Subject: [Koha-bugs] [Bug 25541] Add ability to prevent checkin via SIP of items with holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #9 from Martin Renvoize --- Minor niggle.. I'm not sure about the variable name 'no_holds_checkin'.. I think something like 'holds_block_checkin' might clarify it's meaning a bit? Otherwise, this generally looks good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:56:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:56:42 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #251 from Jonathan Druart --- (In reply to Julian Maurice from comment #249) > IMO we should not rely on the connection status (RabbitMQ is reachable or > not) but instead on the configuration (RabbitMQ is configured or not). > For instance, if configuration for RabbitMQ exists in $KOHA_CONF, use that, > and if it is not reachable then die. And if there is no configuration, use > the "dumb" worker system. > That would allow people to just use the dumb system if it works for them, > and if not sufficient they can "upgrade" by installing and configuring > RabbitMQ So far there is no configuration, the default parameters are used and hardcoded in the connection method. (In reply to Marcel de Rooy from comment #250) > If we feel that RabbitMQ is not ready for primary processes like the batch > record modify in this patch set, we should remove that part. I would not > promote a hybrid solution that falls back to code without MQ. It should just > be stable enough to operate on and seen as an essential component. I am against removing background jobs like batch record modify, it's the main point of this first step. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 13:58:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 11:58:56 +0000 Subject: [Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #45 from Magnus Enger --- (In reply to Arthur Suzuki from comment #43) > Made a text proposal on the appropriate field on bugzilla (in the mean time) I think that is the right thing to do. There are scripts that make sure "Text to go in the release notes" actually goes into the release notes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:05:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:05:03 +0000 Subject: [Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #46 from Magnus Enger --- Does this have to be "Needs Signoff" because of the QA followup patch, or can it go back to QA directly? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:10:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:10:04 +0000 Subject: [Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publicationdate and add updated_on as timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 --- Comment #35 from Jonathan Druart --- Comment on attachment 109192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109192 Bug 21066: Database revision Review of attachment 109192: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21066&attachment=109192) ----------------------------------------------------------------- ::: installer/data/mysql/kohastructure.sql @@ +1723,4 @@ > `title` varchar(250) NOT NULL default '', -- title of the news article > `content` MEDIUMTEXT NOT NULL, -- the body of your news article > `lang` varchar(50) NOT NULL default '', -- location for the article (koha is the staff client, slip is the circulation receipt and language codes are for the opac) > + `publicationdate` date DEFAULT NULL, -- publication date Should not it be published_on? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:11:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:11:24 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #252 from Julian Maurice --- (In reply to Marcel de Rooy from comment #250) > If we feel that RabbitMQ is not ready for primary processes like the batch > record modify in this patch set, we should remove that part. I would not > promote a hybrid solution that falls back to code without MQ. It should just > be stable enough to operate on and seen as an essential component. It's not about stability. I'm sure RabbitMQ is stable enough for this. It's about not adding another mandatory dependency when we don't need it. Do I really need a message queue if I run 1 background job per day ? Of course a MQ will be useful to some. I'm not advocating against it. I'm only saying a fallback would be nice for those who only run jobs occasionally. Also the upgrade path would be simpler ("just make sure the script worker.pl is always running and you're good") -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:14:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:14:24 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #253 from Julian Maurice --- (In reply to Jonathan Druart from comment #251) > So far there is no configuration, the default parameters are used and > hardcoded in the connection method. That should probably be changed if, as someone already mentioned, one want to install rabbitmq on another server, or in a different docker container, ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:16:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:16:26 +0000 Subject: [Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publicationdate and add updated_on as timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #36 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #35) > Comment on attachment 109192 [details] [review] > Bug 21066: Database revision > > Review of attachment 109192 [details] [review]: > ----------------------------------------------------------------- > > ::: installer/data/mysql/kohastructure.sql > @@ +1723,4 @@ > > `title` varchar(250) NOT NULL default '', -- title of the news article > > `content` MEDIUMTEXT NOT NULL, -- the body of your news article > > `lang` varchar(50) NOT NULL default '', -- location for the article (koha is the staff client, slip is the circulation receipt and language codes are for the opac) > > + `publicationdate` date DEFAULT NULL, -- publication date > > Should not it be published_on? I agree. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:20:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:20:53 +0000 Subject: [Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publicationdate and add updated_on as timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 --- Comment #37 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #35) > Should not it be published_on? These patches date from 2018. Have gone through QA. I think this tiny change is quite arbitrary and should not block this patch set now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:26:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:26:03 +0000 Subject: [Koha-bugs] [Bug 26313] "Show analytics" and "Show volumes" links don't work with Elasticsearch and UseControlNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:26:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:26:08 +0000 Subject: [Koha-bugs] [Bug 26313] "Show analytics" and "Show volumes" links don't work with Elasticsearch and UseControlNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109457|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:26:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:26:11 +0000 Subject: [Koha-bugs] [Bug 26313] "Show analytics" and "Show volumes" links don't work with Elasticsearch and UseControlNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109458|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:26:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:26:37 +0000 Subject: [Koha-bugs] [Bug 26313] "Show analytics" and "Show volumes" links don't work with Elasticsearch and UseControlNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 109509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109509&action=edit Bug 26313: "Show analytics" link must use uppercase for booleans In elasticsearch we only treat AND and OR as boolean operators if they are capitalized To test: - Turn SearchEngine to Elasticsearch and make sure it works - Pick any serial record in your database, make sure 001 is set - Go to new > new child record - Fill in 245 and save - Click on the "In" link, it should bring you to the parent record - Click on "Show analytics" => there will be no result - Apply patch - restart and reload - Try again - It works! - Switch SearchEngine syspref to 'Zebra' - Test again - It still works! Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:26:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:26:43 +0000 Subject: [Koha-bugs] [Bug 26313] "Show analytics" and "Show volumes" links don't work with Elasticsearch and UseControlNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 109510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109510&action=edit Bug 26313: (follow-up) Fix OPAC and "Show volumes" links Elasticsearch requires the booleans in search requests to be uppercase. This fixes the "Show analytics" link in OPAC (same as first patch for intranet) and the "Show volume" link. To test both patches: Set UseControlNumber = Use 1) "Show analytics" - Turn SearchEngine to Elasticsearch and make sure it works - Pick any serial record in your database, make sure 001 is set - Go to new > new child record - Fill in 245 and save - For both staff and OPAC: - Click on the "In" link, it should bring you to the parent record - Click on "Show analytics", it should show your analytical record - Switch to "Zebra" - verify links still work. 2) "Show volumes" - Turn SearchEngine to Elasticsearch again - Pick any serial record in your database, make sure 001 is set - Set LDR, pos. 19 = a - Set - Note 001 value - Find another record and edit it - Set LDR, pos. 19 = a or b, LDR 7 not a or b (m will work) - Set 773$ title of set record $w 001 of set record - For both staff and OPAC: - Click on the "In: link, it should bring up your set record - Click on the "Show volumes" link, it should bring up the volume - Switch to "Zebra" - verify all links still work. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:29:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:29:45 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #254 from Jonathan Druart --- (In reply to Julian Maurice from comment #252) > (In reply to Marcel de Rooy from comment #250) > > If we feel that RabbitMQ is not ready for primary processes like the batch > > record modify in this patch set, we should remove that part. I would not > > promote a hybrid solution that falls back to code without MQ. It should just > > be stable enough to operate on and seen as an essential component. > > It's not about stability. I'm sure RabbitMQ is stable enough for this. > It's about not adding another mandatory dependency when we don't need it. Do > I really need a message queue if I run 1 background job per day ? > Of course a MQ will be useful to some. I'm not advocating against it. I'm > only saying a fallback would be nice for those who only run jobs > occasionally. > Also the upgrade path would be simpler ("just make sure the script worker.pl > is always running and you're good") So you think the last patch is the (kind of) way to go? (In reply to Julian Maurice from comment #253) > (In reply to Jonathan Druart from comment #251) > > So far there is no configuration, the default parameters are used and > > hardcoded in the connection method. > > That should probably be changed if, as someone already mentioned, one want > to install rabbitmq on another server, or in a different docker container, > ... Yes, see bug 25674 ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:30:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:30:29 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:31:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:31:47 +0000 Subject: [Koha-bugs] [Bug 26350] Librarians can request discharge on behalf of patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:31:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:31:49 +0000 Subject: [Koha-bugs] [Bug 26350] Librarians can request discharge on behalf of patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 --- Comment #1 from Dobrica Pavlinusic --- Created attachment 109511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109511&action=edit Bug 26350: Librarians can request discharge on behalf of patron While deploying discharges in our library we figured out that librarians need ability to request discharge document on behalf of patrons from intranet page. It was logical to add another option on Discharge patron tab. It nicely addresses Bug 16466 since it shows status of pending discharge instead of button to issue new discharge. To test: 1. apply patch 2. make sure that useDischarge is enabled in administration 3. verify that "Request new discharge" button is availabe, click on it 4. after page reload, message "Patron has pending discharge request." will appear 5. click on "Generate discharge" to approve discharge and generate pdf (this is unchanged compared to exsting workflow) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:33:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:33:25 +0000 Subject: [Koha-bugs] [Bug 26350] Librarians can request discharge on behalf of patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16466 URL| |/cgi-bin/koha/members/disch | |arge.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:33:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:33:25 +0000 Subject: [Koha-bugs] [Bug 16466] Patron discharge page should show pending requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16466 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26350 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:35:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:35:09 +0000 Subject: [Koha-bugs] [Bug 16466] Patron discharge page should show pending requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16466 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org Status|NEW |In Discussion --- Comment #2 from Dobrica Pavlinusic --- As part of Bug 26350 I implemented notice about pending discharge. Since Koha can have only 1 pending discharge correctly (I figured out that the hard way :-) this bug can be closed if Bug 26350 is accepted. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:36:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:36:55 +0000 Subject: [Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publicationdate and add updated_on as timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 --- Comment #38 from Jonathan Druart --- Created attachment 109514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109514&action=edit Bug 21066: DBRev 20.06.00.033 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:37:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:37:00 +0000 Subject: [Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publicationdate and add updated_on as timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 --- Comment #39 from Jonathan Druart --- Created attachment 109515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109515&action=edit Bug 21066: Rename publicationdate with published_on -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:37:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:37:02 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #255 from Marcel de Rooy --- I hope that the last patch is not the design pattern for introduction of a MQ in Koha. No blocker for me, just amazement ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:37:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:37:24 +0000 Subject: [Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publicationdate and add updated_on as timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 --- Comment #40 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #37) > (In reply to Jonathan Druart from comment #35) > > Should not it be published_on? > > These patches date from 2018. Have gone through QA. I think this tiny change > is quite arbitrary and should not block this patch set now. I don't want to block it. Do you agree with the renaming? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:37:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:37:55 +0000 Subject: [Koha-bugs] [Bug 26350] Librarians can request discharge on behalf of patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109511|0 |1 is obsolete| | --- Comment #2 from Dobrica Pavlinusic --- Created attachment 109516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109516&action=edit Bug 26350: Librarians can request discharge on behalf of patron While deploying discharges in our library we figured out that librarians need ability to request discharge document on behalf of patrons from intranet page. It was logical to add another option on Discharge patron tab. It nicely addresses Bug 16466 since it shows status of pending discharge instead of button to issue new discharge. To test: 1. apply patch 2. make sure that useDischarge is enabled in administration 3. verify that "Request new discharge" button is availabe, click on it 4. after page reload, message "Patron has pending discharge request." will appear 5. click on "Generate discharge" to approve discharge and generate pdf (this is unchanged compared to exsting workflow) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:38:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:38:45 +0000 Subject: [Koha-bugs] [Bug 26350] Librarians can request discharge on behalf of patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 --- Comment #3 from Dobrica Pavlinusic --- Removed one extra empty line in second version of patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:40:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:40:27 +0000 Subject: [Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publicationdate and add updated_on as timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 --- Comment #41 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #40) > (In reply to Marcel de Rooy from comment #37) > > (In reply to Jonathan Druart from comment #35) > > > Should not it be published_on? > > > > These patches date from 2018. Have gone through QA. I think this tiny change > > is quite arbitrary and should not block this patch set now. > > I don't want to block it. Do you agree with the renaming? Yes, no problem glancing thru the patch diagonally.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:41:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:41:55 +0000 Subject: [Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #43 from Nick Clemens --- (In reply to Katrin Fischer from comment #42) > I am still learning about Elasticsearch. In order to test this patch set, I > applied the patches and tried do reindex. > > When I run the reindex with -d, I have an error that doesn't appear without > the patches: > > kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ > ./misc/search_tools/rebuild_elasticsearch.pl -d > One or more ElasticSearch errors occurred when indexing documents at > ./misc/search_tools/rebuild_elasticsearch.pl line 302. > > > The sorting appears to work really well. Record #115 "Perl hacks" has a malformed 008 - this causes the error. The error does not occur when using ES6. I think this is okay as we expect errors if records have issues. We can use compare_es_to_db.pl to identify the records, or see bug 26310 for option to get more debug info -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:50:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:50:55 +0000 Subject: [Koha-bugs] [Bug 25541] Add ability to prevent checkin via SIP of items with holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 --- Comment #10 from Kyle M Hall --- (In reply to Martin Renvoize from comment #9) > Minor niggle.. I'm not sure about the variable name 'no_holds_checkin'.. I > think something like 'holds_block_checkin' might clarify it's meaning a bit? Agreed, that's a much better name. Followup incoming... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:52:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:52:53 +0000 Subject: [Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:52:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:52:57 +0000 Subject: [Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109249|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:53:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:53:01 +0000 Subject: [Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109250|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:53:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:53:04 +0000 Subject: [Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109251|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:53:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:53:08 +0000 Subject: [Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109252|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:53:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:53:12 +0000 Subject: [Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109253|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:53:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:53:17 +0000 Subject: [Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109254|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:53:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:53:21 +0000 Subject: [Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109255|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:53:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:53:25 +0000 Subject: [Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109256|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:53:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:53:30 +0000 Subject: [Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109257|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:54:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:54:23 +0000 Subject: [Koha-bugs] [Bug 25541] Add ability to prevent checkin via SIP of items with holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 --- Comment #11 from Kyle M Hall --- Created attachment 109519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109519&action=edit Bug 25541: (QA follow-up) Rename no_holds_checkin to holds_block_checkin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:54:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:54:31 +0000 Subject: [Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:54:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:54:37 +0000 Subject: [Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 --- Comment #64 from Tomás Cohen Arazi --- Created attachment 109520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109520&action=edit Bug 23816: Update kohastructure and atomic update Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:54:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:54:42 +0000 Subject: [Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 --- Comment #65 from Tomás Cohen Arazi --- Created attachment 109521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109521&action=edit Bug 23816: [DO NOT PUSH] Update category schema Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:54:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:54:46 +0000 Subject: [Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 --- Comment #66 from Tomás Cohen Arazi --- Created attachment 109522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109522&action=edit Bug 23816: (follow-up) Define boolean column in shcema Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:54:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:54:52 +0000 Subject: [Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 --- Comment #67 from Tomás Cohen Arazi --- Created attachment 109523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109523&action=edit Bug 23816: Add tests Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:54:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:54:58 +0000 Subject: [Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 --- Comment #68 from Tomás Cohen Arazi --- Created attachment 109524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109524&action=edit Bug 23816: Add minimum password length and require strong password overrides by category This patch adds the capability to override minPasswordLenth and RequireStrongPassword settings by category To test: 1. koha-shell kohadev 2. koha-mysql kohadev 3. drop database koha_kohadev; 4. create database koha_kohadev; 5. go to admin page and start webinstaller. There continue the steps until onboarding. 6. reach step 3 of onboarding and create a new administrator patron CHECH => Password control woks as normal (Minimum length 3 and strong required) 7. finish Koha installation and enter admin with your new administrator 8. set minPasswordLength to 3 and RequireStrongPassword to “Don’t require” 9. Create a new category (CAT2 from now on.. CAT1 is the category you made in onboarding process) and set minimum password length to 8 and require strong password 10. Create two new patrons, one with CAT1(patron1) and one with CAT2 (patron2) CHECK => In both cases, try different combinations of length and strength. For patron1 the only requirement is to have 3 letters, but for patron2 the minimum length will be 8 and will require strong password. CHECK => Try changing patron category before saving. Password requirements will change with category change. 11. Edit CAT1 and set minimum password length to 5 12. Go to patron1 details page, and change password. CHECH => Now password minimum length is 5, but still it doesn’t require strong password 13. Edit CAT1, leave blank minimum password length and set require strong password to yes. 14. Go to patron1 details page, and change password. CHECH => Password minimum length is back to 3, but now strong password is required 15. Set minimum password length in CAT2 to 12. 16. Go to patron2 details page, and click to fill a random generated password CHECK => generated password should be 12 characters length 17. Set PatronSelfRegistration to Allow in admin settings 18. Go to OPAC and fill self registration from. CHECK => Play with patron category. For each change in category, password requirements are modified. CHECK => Set CAT1 as patron category, set ‘aA1’ as password (or another valid password for CAT1) and before hitting submit button, change to CAT2. Form should enter invalid state, and CAT2 password requirements should be displayed as error in password input. 19. Create a patron for CAT1 and another for CAT2, leaving password blank CHECK => For CAT1’s patron, generated password length is 8 (minimum length for generated passwords), but for CAT2’s patron should be 12 20. In admin set PatronSelfRegistrationVerifyByEmail to require 21. Fill self registration form again with CAT2 as category CHECK => Password requirements works as previous case. 22. Leave password blank and click submit 23. select * from message_queue; 24. Copy the link in the message and paste it in OPAC CHECH => Generated password is 12 characters long. (Copy user id for next steps) 25. In admin set OpacResetPassword to Allow 26. Go back to OPAC, reload and click on “Forgot password?” link 27. Paste user id and click submit 28. Repeat steps 23 and 24 CHECK => Info message says “Your password must contain at least 12 characters, including UPPERCASE, lowercase and numbers.” CHECK => enter an invalid password and you’ll get the same message in warning. 29. Login OPAC with the last user and your newly created password 30. Go to “Change your password” option CHECK => Info message says “Your password must contain at least 12 characters, including UPPERCASE, lowercase and numbers.” CHECK => enter an invalid password and you’ll get the same message in below “New password” input. 31. prove t/db_dependent/AuthUtils.t t/db_dependent/Koha/Patron/Category.t 32. Sign off Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:55:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:55:04 +0000 Subject: [Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 --- Comment #69 from Tomás Cohen Arazi --- Created attachment 109525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109525&action=edit Bug 23816: Set default value in tests We tell TestBuilder to generate the categories with NULL (and rely on the sysprefs) Signed-off-by: Agustin Moyano https://bugs.koha-community.org/show_bug.cgi?id=23826 Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:55:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:55:08 +0000 Subject: [Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 --- Comment #70 from Tomás Cohen Arazi --- Created attachment 109526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109526&action=edit Bug 23816: trivial code simplification Ease readability Signed-off-by: Agustin Moyano https://bugs.koha-community.org/show_bug.cgi?id=23826 Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:55:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:55:13 +0000 Subject: [Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 --- Comment #71 from Tomás Cohen Arazi --- Created attachment 109527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109527&action=edit Bug 23816: (follow-up) Fix many things This patch: * reverts changes on misc/admin/set_password.pl * makes category param mandatory for AuthUtils::is_valid_password and AuthUtils::generate_password * changes onboarding.pl to set category param in AuthUtils::is_valid_password * Completes t/db_dependent/AuthUtils.t and drops t/AuthUtils.t * Removes offending and replaces it by https://bugs.koha-community.org/show_bug.cgi?id=23826 Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:55:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:55:18 +0000 Subject: [Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 --- Comment #72 from Tomás Cohen Arazi --- Created attachment 109528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109528&action=edit Bug 23816: (QA follow-up) Use existing form validation to validate min password length The pattern check didn't work for me, but I figured we might want to use the same validation as for the other numeric fields on the form instead (upper age limit, etc.) Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:55:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:55:52 +0000 Subject: [Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 14:58:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 12:58:41 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #256 from Julian Maurice --- Hi Marcel, > I would not promote a hybrid solution that falls back to code without MQ Ok, but why ? > I hope that the last patch is not the design pattern for introduction of a MQ in Koha Ok, but why ? Why would it be such a terrible design to have the ability to run background jobs without a message queue ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:03:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:03:52 +0000 Subject: [Koha-bugs] [Bug 26350] Librarians can request discharge on behalf of patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:06:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:06:13 +0000 Subject: [Koha-bugs] [Bug 25101] Add ability to skip previewing results when batch extending due dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109292|0 |1 is obsolete| | Attachment #109293|0 |1 is obsolete| | Attachment #109294|0 |1 is obsolete| | Attachment #109425|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Created attachment 109529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109529&action=edit Bug 25101: Add ability to skip previewing results when batch extending due dates For sites with very large amounts of due dates to extend ( tens of thousands ), it can take a very long time of the results to load ( if at all ). It would be good to have a way to bypass the confirmation screen, instead directly updating the due dates before displaying the results. Test Plan: 1) Apply this patch 2) Browse to tools/batch_extend_due_dates.pl 3) Note the new "Preview results" checkbox 4) Submit form with the checkbox unchecked, due dates should be updated without previewing the checkouts 5) Submit form with the checkbox checked, tool should function as it did previously Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Bug 25101: (QA follow-up) Add hint to new option Adds a hint about the large numbers behind the new checkbox option. Signed-off-by: Katrin Fischer Bug 25101: (QA follow-up) Fix hint for new option -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:06:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:06:17 +0000 Subject: [Koha-bugs] [Bug 25101] Add ability to skip previewing results when batch extending due dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 --- Comment #26 from Jonathan Druart --- Created attachment 109530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109530&action=edit Bug 25101: (follow-up) Tick preview checkbox on by default This would prevent any unintended batch renewals as it is easy to miss the option in the screen. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:07:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:07:32 +0000 Subject: [Koha-bugs] [Bug 26327] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #9 from Tomás Cohen Arazi --- (In reply to Kyle M Hall from comment #8) > Looks good! Wondering if we should include the column in boraccount.pl as > well. That's a great idea, Kyle. I'm submitting a follow-up. Can you review it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:08:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:08:07 +0000 Subject: [Koha-bugs] [Bug 26327] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 109531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109531&action=edit Bug 26327: (follow-up) Add transacting library to the transactions tab Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:19:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:19:01 +0000 Subject: [Koha-bugs] [Bug 26327] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #11 from Tomás Cohen Arazi --- I have one doubt about this patches that add new columns to existing tables: should we make the new columns hidden by default? It is a trivial follow-up patch but I was wondering if we had a policy for this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:24:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:24:53 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #268 from Jonathan Druart --- This is now "in discussion". More eyes and feedback are needed urgently. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:30:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:30:49 +0000 Subject: [Koha-bugs] [Bug 26308] Normal view (vue normale) is not displayed in French In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26308 --- Comment #7 from Caroline Cyr La Rose --- Katrin or Jonathan, do you know if   is a problem also in other .po? I only corrected fr-CA-MARC-marc21.po, but I'm wondering if I should remove all instances in all files... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:31:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:31:16 +0000 Subject: [Koha-bugs] [Bug 26351] New: Add plugin hooks to transform item barcodes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Bug ID: 26351 Summary: Add plugin hooks to transform item barcodes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Moved from bug 25712 Some of our partners have unusual barcode requirements that have required us to transform scanned barcodes using javascript. This is not the most reliable method. It would make more sense to have Koha transform the barcodes on the backend using a plugin. We should add hooks to transform and generate new item and patron barcodes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:33:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:33:18 +0000 Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #1 from Kyle M Hall --- Created attachment 109532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109532&action=edit Bug 26351: Add plugin hooks to transform item barcodes Some of our partners have unusual barcode requirements that have required us to transform scanned barcodes using javascript. This is not the most reliable method. It would make more sense to have Koha transform the barcodes on the backend using a plugin. We should add hooks to transform and generate new item and patron barcodes. Test Plan: 1) Apply this patch 2) Download and install the Barcode Transformer plugin https://github.com/bywatersolutions/koha-plugin-barcode-transformer/releases/ 3) Go to the plugin configuration page, set the configuration to the example configuration from the same page 4) In the item barcode field on the checkin and checkout pages, and anywhere else you can scan an item barcode, type in some valid barcodes, but prefix them with X and postfix them with Y, e.g. X123456Y 5) Note the letters are removed by Koha! Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:34:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:34:00 +0000 Subject: [Koha-bugs] [Bug 26308] Normal view (vue normale) is not displayed in French In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26308 --- Comment #8 from Katrin Fischer --- (In reply to Caroline Cyr La Rose from comment #7) > Katrin or Jonathan, do you know if   is a problem also in other .po? I > only corrected fr-CA-MARC-marc21.po, but I'm wondering if I should remove > all instances in all files... I believe it's a problem for the ones that are used to generate strings in XML files. This shoudl be the UNIMARC po file only. But I haven't tested it out explicitly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:34:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:34:05 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #257 from Marcel de Rooy --- (In reply to Julian Maurice from comment #256) > > I would not promote a hybrid solution that falls back to code without MQ > Ok, but why ? Duplication of code. Maintenance, bugs etc. > > I hope that the last patch is not the design pattern for introduction of a MQ in Koha > Ok, but why ? See above. > Why would it be such a terrible design to have the ability to run background > jobs without a message queue ? Actually not. As you say, we could run without MQ. But since we want a message queue anyway, this could be a nice first start. What I do not like, is writing two blocks: code with MQ en code without. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:34:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:34:31 +0000 Subject: [Koha-bugs] [Bug 26352] New: Add plugin hooks to transform patron barcodes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352 Bug ID: 26352 Summary: Add plugin hooks to transform patron barcodes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Moved from bug 25712 Some of our partners have unusual barcode requirements that have required us to transform scanned barcodes using javascript. This is not the most reliable method. It would make more sense to have Koha transform the barcodes on the backend using a plugin. We should add hooks to transform and generate new item and patron barcodes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:34:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:34:36 +0000 Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:35:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:35:03 +0000 Subject: [Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352 --- Comment #1 from Kyle M Hall --- Created attachment 109533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109533&action=edit Bug 26352: Add plugin hooks to transform patron barcodes Some of our partners have unusual barcode requirements that have required us to transform scanned barcodes using javascript. This is not the most reliable method. It would make more sense to have Koha transform the barcodes on the backend using a plugin. We should add hooks to transform and generate new item and patron barcodes. Test Plan: 1) Apply this patch 2) Download and install the Barcode Transformer plugin https://github.com/bywatersolutions/koha-plugin-barcode-transformer/releases/download/v1.0.1/koha-plugin-barcode-transformer-v1.0.1.kpz 3) Go to the plugin configuration page, set the configuration to the example configuration from the same page 4) In the patron search and anywhere else you can scan a patron cardnumber, type in some cardnumbers but prefix them with A and postfix them with A or B, e.g. A12345A, A12345B 5) Note the letters are removed by Koha! 6) Try a cardnumber like X123456Y 7) Note Koha converts it to Z13456Z Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:35:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:35:08 +0000 Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:35:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:35:12 +0000 Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:35:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:35:19 +0000 Subject: [Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:35:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:35:34 +0000 Subject: [Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:35:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:35:38 +0000 Subject: [Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:35:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:35:46 +0000 Subject: [Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26351 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 [Bug 26351] Add plugin hooks to transform item barcodes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:35:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:35:46 +0000 Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26352 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352 [Bug 26352] Add plugin hooks to transform patron barcodes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:35:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:35:49 +0000 Subject: [Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publicationdate and add updated_on as timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:35:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:35:51 +0000 Subject: [Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publicationdate and add updated_on as timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 --- Comment #42 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:35:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:35:53 +0000 Subject: [Koha-bugs] [Bug 24147] Objects.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24147 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:35:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:35:54 +0000 Subject: [Koha-bugs] [Bug 24147] Objects.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24147 --- Comment #9 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:35:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:35:56 +0000 Subject: [Koha-bugs] [Bug 25101] Add ability to skip previewing results when batch extending due dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:35:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:35:58 +0000 Subject: [Koha-bugs] [Bug 25101] Add ability to skip previewing results when batch extending due dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25101 --- Comment #27 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:36:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:36:00 +0000 Subject: [Koha-bugs] [Bug 25448] Update German (de-DE) framework files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25448 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:36:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:36:02 +0000 Subject: [Koha-bugs] [Bug 25448] Update German (de-DE) framework files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25448 --- Comment #7 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:36:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:36:04 +0000 Subject: [Koha-bugs] [Bug 25584] When a 'return claim' is added, the button disappears, but the claim date doesn't show up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:36:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:36:06 +0000 Subject: [Koha-bugs] [Bug 25584] When a 'return claim' is added, the button disappears, but the claim date doesn't show up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25584 --- Comment #8 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:36:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:36:08 +0000 Subject: [Koha-bugs] [Bug 26324] Spelling error resizeable vs resizable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26324 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:36:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:36:09 +0000 Subject: [Koha-bugs] [Bug 26324] Spelling error resizeable vs resizable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26324 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:36:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:36:21 +0000 Subject: [Koha-bugs] [Bug 25712] Add plugin hooks to transform patron and item barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25712 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |MOVED Status|Failed QA |RESOLVED --- Comment #13 from Kyle M Hall --- Moved to bugs 26351 and 26352 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:37:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:37:57 +0000 Subject: [Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publicationdate and add updated_on as timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 --- Comment #43 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #42) > Pushed to master for 20.11, thanks to everybody involved! Cool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:39:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:39:40 +0000 Subject: [Koha-bugs] [Bug 26308] Normal view (vue normale) is not displayed in French In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26308 --- Comment #9 from Caroline Cyr La Rose --- afaik, UNIMARC is not used here. So unless someone complains, I won't spend time on that file :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:40:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:40:09 +0000 Subject: [Koha-bugs] [Bug 21066] Replace opac_news.timestamp by published_on and add updated_on as timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Replace opac_news.timestamp |Replace opac_news.timestamp |by publicationdate and add |by published_on and add |updated_on as timestamp |updated_on as timestamp -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:42:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:42:19 +0000 Subject: [Koha-bugs] [Bug 25541] Add ability to prevent checkin via SIP of items with holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107791|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 109534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109534&action=edit Bug 25541: Add ability to prevent checkin via SIP of items with holds Some libraries would like patrons to be unable to return items with holds via SIP. Instead, the screen message should indicate that the patron should return that item at the circ desk so a librarian can use it to fill the next hold right away and place it on the hold shelf. Test Plan: 1) Apply this patch. 2) Place a hold for an item. 3) Enable the new SIP option no_holds_checkin for a SIP account. 4) Restart the SIP server. 5) Check in the item using the SIP CLI tool using the SIP account for which you set the new option. 6) Note the checkin fails with a screen message indicating you should return the item to the circulation desk. Signed-off-by: Peter Lau Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:42:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:42:22 +0000 Subject: [Koha-bugs] [Bug 25541] Add ability to prevent checkin via SIP of items with holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108626|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 109535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109535&action=edit Bug 25541: Add new param to debian sip config Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:42:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:42:26 +0000 Subject: [Koha-bugs] [Bug 25541] Add ability to prevent checkin via SIP of items with holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109519|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 109536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109536&action=edit Bug 25541: (QA follow-up) Rename no_holds_checkin to holds_block_checkin Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:42:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:42:29 +0000 Subject: [Koha-bugs] [Bug 25541] Add ability to prevent checkin via SIP of items with holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 --- Comment #15 from Martin Renvoize --- Created attachment 109537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109537&action=edit Bug 25541: (QA follow-up) Defualt to disabled + Correct message This patch defaults the 'holds_block_checkin' configuration to disabled (to maintain current behaviour on upgrades). It also updates a copy/paste for siplog logging to make the message triggered by this action unique as expected. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:43:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:43:12 +0000 Subject: [Koha-bugs] [Bug 25265] Elasticsearch - Batch editing items on a biblio can lead to incorrect index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25265 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |andrew at bywatersolutions.com --- Comment #13 from Andrew Fuerste-Henry --- Patch doesn't apply. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:43:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:43:51 +0000 Subject: [Koha-bugs] [Bug 25541] Add ability to prevent checkin via SIP of items with holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #16 from Martin Renvoize --- Works well. I took the liberty of adding a final QA followup to correct a copy/paste of the log message and, as Tomas highlighted, correct the default behaviour to allow check-ins as is currently the case. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:49:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:49:59 +0000 Subject: [Koha-bugs] [Bug 25541] Add ability to prevent checkin via SIP of items with holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen at gmail.com |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:57:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:57:32 +0000 Subject: [Koha-bugs] [Bug 25265] Elasticsearch - Batch editing items on a biblio can lead to incorrect index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25265 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 15:57:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 13:57:35 +0000 Subject: [Koha-bugs] [Bug 25265] Elasticsearch - Batch editing items on a biblio can lead to incorrect index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25265 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107867|0 |1 is obsolete| | --- Comment #14 from Nick Clemens --- Created attachment 109538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109538&action=edit Bug 25265: Prevent double reindex of the same item in batchmod When batch editing, 2 reindex calls are sent to ES/Zebra. We can easily avoid that reusing the skip_modzebra_update Additionally we should only send one request for biblio, and we should only do it if we succeed As the hwole batch mod is in a transaction it is possible to fail in which case Zebra queue is reset, but ES indexes have already been set In addition to the skip param this patchset makes ModZebra take lists of biblionumbers or records so that multiple records can be passed in one call Test plan: 1 - Have a bib with several items, none marked 'not for loan' 2 - Do a staff search that returns this biblio 3 - Items show as available 4 - Click on title to go to details page 5 - Edit->Item in a batch 6 - Set the not for loan status for all items 7 - Repeat your search 8 - Items show as not for loan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 16:16:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 14:16:01 +0000 Subject: [Koha-bugs] [Bug 26353] New: Report with malfunction after update to Koha 20.05 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26353 Bug ID: 26353 Summary: Report with malfunction after update to Koha 20.05 Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: jcautomatizacion at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 109541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109541&action=edit Report with malfunction We recently updated to version 20 of Koha, and a report is generating a malfunction, it runs until a timeout appears. The report was updated and does not generate SQL error, but does not return results. I attach code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 16:27:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 14:27:56 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #258 from Julian Maurice --- (In reply to Marcel de Rooy from comment #257) > Actually not. As you say, we could run without MQ. But since we want a > message queue anyway, this could be a nice first start. That's a thing that is still not clear for me. For what other purpose do we need a message queue ? > What I do not like, is writing two blocks: code with MQ en code without. I do not like it either, but compared to forcing hundreds of users to install a new dependency, it doesn't look too bad. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 16:32:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 14:32:39 +0000 Subject: [Koha-bugs] [Bug 26285] Use country code + number (E.164) validation for SMS numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26285 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 16:34:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 14:34:01 +0000 Subject: [Koha-bugs] [Bug 26285] Use country code + number (E.164) validation for SMS numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26285 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109034|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 109542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109542&action=edit Bug 26285: Follow E.164 pattern for validating SMS numbers Currently, Koha is not correctly validating SMS numbers using E.164. This causes Australian phone numbers without a country code to fail validation. This patch uses the E.164 pattern of 1-3 digits for country code, prefixed by a + symbol, and followed by up to 12 digits for the remainder of the phone number. To test: 0. Don't apply patch yet 1. Set "SMSSendDriver" to "Anything" 2. Go to http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 3. Type in 0455555555 and note "Please enter a valid phone number." message in browser 6. Apply the patch 7. Go to http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 8. Type in 0455555555 and note no validation error 9. Type in +61455555555 and note no validation error 10. Type in 123456789012 and note no validation error 11. Type in 1234567890123 and note "Please enter a valid phone number." error 12. Type in +900123456789012 and note no validation error 13. Type in 900123456789012 and note "Please enter a valid phone number." error Signed-off-by: Sally Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 16:34:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 14:34:04 +0000 Subject: [Koha-bugs] [Bug 26285] Use country code + number (E.164) validation for SMS numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26285 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109135|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 109543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109543&action=edit Bug 26285: Follow E.164 pattern for OPAC too This patch uses the E.164 pattern for phone numbers for the OPAC (and not just the staff interface). To test: 0) Follow the same plan as the staff interface, but go to /cgi-bin/koha/opac-messaging.pl after logging into the OPAC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 16:34:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 14:34:46 +0000 Subject: [Koha-bugs] [Bug 26285] Use country code + number (E.164) validation for SMS numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26285 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #12 from Martin Renvoize --- Works as expected for me.. and I believe is now consistent OPAC and Staff side. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 16:34:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 14:34:51 +0000 Subject: [Koha-bugs] [Bug 26285] Use country code + number (E.164) validation for SMS numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26285 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 16:39:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 14:39:12 +0000 Subject: [Koha-bugs] [Bug 26041] Accessibility: The date picker calendar is not keyboard accessible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26041 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 16:39:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 14:39:15 +0000 Subject: [Koha-bugs] [Bug 26041] Accessibility: The date picker calendar is not keyboard accessible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26041 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109470|0 |1 is obsolete| | --- Comment #16 from Owen Leonard --- Created attachment 109544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109544&action=edit Bug 26041: Enable keyboard navigation without 'ctrl' This patch enables keyboard navigation using the arrow keys without the need to hold the control key for the jQuery UI datepicker. Test plan 1/ Navigate to an item in the opac and attempt to place a hold 2/ On the resultant screen, use keyboard navigation to trigger the 'Show more options' dropdown. 3/ Focus on one of the date inputs using keyboard navigation. 4/ Use 'ctrl + arrow' keys to navigate the datepicker. 5/ Note that prior to the patch using 'bare' arrow keys does not trigger anything 6/ Apply the patch and confirm that the datepicker can now be naviated using the arrow keys without holding the ctrl key. 7/ Confirm that using the ctrl key combinations continue to work as expected too. 8/ Signoff Signed-off-by: Brandon J Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 16:40:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 14:40:12 +0000 Subject: [Koha-bugs] [Bug 26350] Librarians can request discharge on behalf of patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dpavlin at rot13.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 16:43:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 14:43:34 +0000 Subject: [Koha-bugs] [Bug 26024] Purge undone of zebraqueue in cleanup_database.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26024 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25710 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 16:43:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 14:43:34 +0000 Subject: [Koha-bugs] [Bug 25710] On ElasticSearch only system zebraqueue table is never purged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25710 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26024 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 16:44:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 14:44:08 +0000 Subject: [Koha-bugs] [Bug 21820] Zebraqueue should not be added to when only Elasticsearch is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21820 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 16:44:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 14:44:32 +0000 Subject: [Koha-bugs] [Bug 21820] Zebraqueue should not be added to when only Elasticsearch is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21820 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26024 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 16:44:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 14:44:32 +0000 Subject: [Koha-bugs] [Bug 26024] Purge undone of zebraqueue in cleanup_database.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26024 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21820 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 16:44:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 14:44:34 +0000 Subject: [Koha-bugs] [Bug 26265] Makefile.PL is missing pos directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 --- Comment #29 from Lucas Gass --- The entire patchset has been backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 16:46:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 14:46:01 +0000 Subject: [Koha-bugs] [Bug 21820] Zebraqueue should not be added to when only Elasticsearch is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21820 --- Comment #2 from Fridolin SOMERS --- (In reply to Katrin Fischer from comment #1) > So I think maybe a new preference or option? Or a new value to SearchEngine : ES alone, ES + Zebra, Zebra alone -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 16:51:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 14:51:16 +0000 Subject: [Koha-bugs] [Bug 26270] XISBN.t is failing since today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26270 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #13 from Lucas Gass --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 16:51:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 14:51:37 +0000 Subject: [Koha-bugs] [Bug 26270] XISBN.t is failing since today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26270 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.11.00, 19.11.10 |20.11.00, 20.05.04, released in| |19.11.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 16:52:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 14:52:02 +0000 Subject: [Koha-bugs] [Bug 26024] Purge undone of zebraqueue in cleanup_database.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26024 --- Comment #4 from Fridolin SOMERS --- Ok thats Bug 21820 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 16:53:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 14:53:27 +0000 Subject: [Koha-bugs] [Bug 26327] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #12 from Katrin Fischer --- (In reply to Tomás Cohen Arazi from comment #11) > I have one doubt about this patches that add new columns to existing tables: > should we make the new columns hidden by default? It is a trivial follow-up > patch but I was wondering if we had a policy for this. I feel like it might be beneficial to show it - it's easy to hide and it hightlights a change. In the past, we didn't have the table configuration and new columns always showed up... so maybe it's not that much of a change. I can see why we would want to hide it too - maybe need more opinions, but don't see this as a blocker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 16:54:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 14:54:34 +0000 Subject: [Koha-bugs] [Bug 26327] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #13 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #12) > (In reply to Tomás Cohen Arazi from comment #11) > > I have one doubt about this patches that add new columns to existing tables: > > should we make the new columns hidden by default? It is a trivial follow-up > > patch but I was wondering if we had a policy for this. > > I feel like it might be beneficial to show it - it's easy to hide and it > hightlights a change. In the past, we didn't have the table configuration > and new columns always showed up... so maybe it's not that much of a change. > > I can see why we would want to hide it too - maybe need more opinions, but > don't see this as a blocker. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 16:56:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 14:56:52 +0000 Subject: [Koha-bugs] [Bug 26354] New: Prevent submission of patron modification request unless changes are actually made Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26354 Bug ID: 26354 Summary: Prevent submission of patron modification request unless changes are actually made Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org I think there should be an preference to not be able to submit a request unless information has been changed. We frequently get modification requests with no changes made at all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 16:57:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 14:57:11 +0000 Subject: [Koha-bugs] [Bug 25063] OPAC Renewal Option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25063 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26354 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 16:57:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 14:57:11 +0000 Subject: [Koha-bugs] [Bug 26354] Prevent submission of patron modification request unless changes are actually made In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26354 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25063 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:00:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:00:10 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #259 from Jonathan Druart --- (In reply to Julian Maurice from comment #258) > (In reply to Marcel de Rooy from comment #257) > > Actually not. As you say, we could run without MQ. But since we want a > > message queue anyway, this could be a nice first start. > That's a thing that is still not clear for me. For what other purpose do we > need a message queue ? For now: all background jobs, and a task scheduler. But that can be extended to other things if we want (like indexing, sending emails, etc.). With a configuration system we could add the capacity to define rules like "execute all the background jobs that does XXX", or "don't execute background jobs during opening hours". Also we could have several workers, each doing something specific, and have them running on a dedicated server. > > What I do not like, is writing two blocks: code with MQ en code without. > I do not like it either, but compared to forcing hundreds of users to > install a new dependency, it doesn't look too bad. The idea was to not reinvent the wheel and use one solution that demonstrated its effectiveness. We could write our own server if we wish. In this implementation (there have been others previously) I decided to make things as simple as possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:01:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:01:53 +0000 Subject: [Koha-bugs] [Bug 26355] New: Tie account renewals to patron modification requests Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Bug ID: 26355 Summary: Tie account renewals to patron modification requests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org Allow patrons renewal reminders to link to the patron modification requests, asking them to review their information and make any any necessary updates if necessary, but acknowledging that the information is up to date. Create a check-box stating that they have reviewed all their information, and it is accurate and up to date (if no changes are made). Perhaps this check-box only shows when their account is due for renewal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:02:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:02:11 +0000 Subject: [Koha-bugs] [Bug 26350] Librarians can request discharge on behalf of patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:02:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:02:13 +0000 Subject: [Koha-bugs] [Bug 25063] OPAC Renewal Option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25063 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26355 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:02:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:02:13 +0000 Subject: [Koha-bugs] [Bug 26355] Tie account renewals to patron modification requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25063 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:02:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:02:14 +0000 Subject: [Koha-bugs] [Bug 26350] Librarians can request discharge on behalf of patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109516|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 109545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109545&action=edit Bug 26350: Librarians can request discharge on behalf of patron While deploying discharges in our library we figured out that librarians need ability to request discharge document on behalf of patrons from intranet page. It was logical to add another option on Discharge patron tab. It nicely addresses Bug 16466 since it shows status of pending discharge instead of button to issue new discharge. To test: 1. apply patch 2. make sure that useDischarge is enabled in administration 3. verify that "Request new discharge" button is availabe, click on it 4. after page reload, message "Patron has pending discharge request." will appear 5. click on "Generate discharge" to approve discharge and generate pdf (this is unchanged compared to exsting workflow) Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:04:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:04:05 +0000 Subject: [Koha-bugs] [Bug 26355] Tie account renewals to patron modification requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #1 from Christopher Brannon --- I suggest this being an option, because some libraries might require fees or a view of a current ID before renewing. Maybe the option can include whether certain patron categories allow self renewal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:04:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:04:50 +0000 Subject: [Koha-bugs] [Bug 26355] Tie account renewals to patron modification requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:05:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:05:01 +0000 Subject: [Koha-bugs] [Bug 26354] Prevent submission of patron modification request unless changes are actually made In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26354 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:06:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:06:40 +0000 Subject: [Koha-bugs] [Bug 26356] New: Search by first and last name takes a long time Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26356 Bug ID: 26356 Summary: Search by first and last name takes a long time Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: jcautomatizacion at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 109546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109546&action=edit Search by first and last name takes a long time Currently when performing a search by user in Koha using first and last name, the system takes more than 22 minutes to execute the search, while the identification number does not delay, what can this inconvenience be?. Attachment dispatch script reported that performs search and delay. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:08:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:08:02 +0000 Subject: [Koha-bugs] [Bug 26357] New: Create preference for staff notification of patron self-renewals Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26357 Bug ID: 26357 Summary: Create preference for staff notification of patron self-renewals Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Have a preference to whether or not patron modification requests include patron modifications that are simply renewal updates that acknowledge that no information has changed in the account. This relies on bug 26355. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:08:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:08:31 +0000 Subject: [Koha-bugs] [Bug 26357] Create preference for staff notification of patron self-renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26357 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26355 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 [Bug 26355] Tie account renewals to patron modification requests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:08:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:08:31 +0000 Subject: [Koha-bugs] [Bug 26355] Tie account renewals to patron modification requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26357 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26357 [Bug 26357] Create preference for staff notification of patron self-renewals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:08:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:08:40 +0000 Subject: [Koha-bugs] [Bug 25063] OPAC Renewal Option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25063 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26357 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:08:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:08:40 +0000 Subject: [Koha-bugs] [Bug 26357] Create preference for staff notification of patron self-renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26357 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25063 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:09:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:09:18 +0000 Subject: [Koha-bugs] [Bug 26356] Search by first and last name takes a long time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26356 --- Comment #1 from Katrin Fischer --- how many patrons do you have in your database? Which Koha version? What was the search term like? (not asking for personal information, but maybe a similar made up one) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:10:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:10:40 +0000 Subject: [Koha-bugs] [Bug 25063] OPAC Renewal Option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25063 --- Comment #5 from Christopher Brannon --- I've broken this down into separate bugs. Look at see also. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:11:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:11:10 +0000 Subject: [Koha-bugs] [Bug 26357] Create preference for staff notification of patron self-renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26357 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:17:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:17:25 +0000 Subject: [Koha-bugs] [Bug 26354] Prevent submission of patron modification request unless changes are actually made In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26354 --- Comment #1 from Owen Leonard --- I see two angles on this--perhaps both? 1. We check for changes to the form and ask the user if they really mean to submit a form without having made changes. 2. We silently reject submissions with no changes. Somehow this seems nicer than telling the user they can't submit the form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:23:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:23:03 +0000 Subject: [Koha-bugs] [Bug 26358] New: Allow patrons to renew their Accounts on the OPAC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26358 Bug ID: 26358 Summary: Allow patrons to renew their Accounts on the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently Koha can notify patrons of their upcoming expiration date for their library card. At this time, only a staff member can renew a patron's account. And although a lot of libraries would like to have this fall on the library's responsibility, some libraries would like to have patrons be able to renew their account themselves. Could there be a way for patrons to renew their account on the OPAC - once they receive the email from Koha, a notification could appear on the Patron's summary (like it does in the staff client) to renew? If a patron can renew on the OPAC (sys pref would be nice), then a renewal happens and the staff client is updated with an Approval/Denying process. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:23:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:23:58 +0000 Subject: [Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109533|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 109547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109547&action=edit Bug 26352: Add plugin hooks to transform patron barcodes Some of our partners have unusual barcode requirements that have required us to transform scanned barcodes using javascript. This is not the most reliable method. It would make more sense to have Koha transform the barcodes on the backend using a plugin. We should add hooks to transform and generate new item and patron barcodes. Test Plan: 1) Apply this patch 2) Download and install the Barcode Transformer plugin https://github.com/bywatersolutions/koha-plugin-barcode-transformer/releases/download/v1.0.1/koha-plugin-barcode-transformer-v1.0.1.kpz 3) Go to the plugin configuration page, set the configuration to the example configuration from the same page 4) In the patron search and anywhere else you can scan a patron cardnumber, type in some cardnumbers but prefix them with A and postfix them with A or B, e.g. A12345A, A12345B 5) Note the letters are removed by Koha! 6) Try a cardnumber like X123456Y 7) Note Koha converts it to Z13456Z Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:24:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:24:04 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #113 from Nick Clemens --- (In reply to Katrin Fischer from comment #81) > Could someone help me out here by at least testing the SIP bit? I can take > care of the other parts. SIP bits are all good with latest patches - do you plan to test the rest? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:27:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:27:30 +0000 Subject: [Koha-bugs] [Bug 26356] Search by first and last name takes a long time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26356 --- Comment #2 from Owen Leonard --- Based on this and the other report you posted today, Bug 26353, it sounds like you have a server issue which is outside the scope of the help we can provide via Bugzilla. I suggest you seek help on the Koha mailing list (http://koha-community.org/support/koha-mailing-lists/), in the #koha IRC channel (http://koha-community.org/get-involved/irc/) or seek paid support here: https://koha-community.org/support/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:27:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:27:36 +0000 Subject: [Koha-bugs] [Bug 26358] Allow patrons to renew their Accounts on the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26358 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |lisetteslatah at gmail.com --- Comment #1 from Lisette Scheer --- *** This bug has been marked as a duplicate of bug 26355 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:27:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:27:36 +0000 Subject: [Koha-bugs] [Bug 26355] Tie account renewals to patron modification requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com --- Comment #2 from Lisette Scheer --- *** Bug 26358 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:29:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:29:26 +0000 Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109532|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 109548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109548&action=edit Bug 26351: Add plugin hooks to transform item barcodes Some of our partners have unusual barcode requirements that have required us to transform scanned barcodes using javascript. This is not the most reliable method. It would make more sense to have Koha transform the barcodes on the backend using a plugin. We should add hooks to transform and generate new item and patron barcodes. Test Plan: 1) Apply this patch 2) Download and install the Barcode Transformer plugin https://github.com/bywatersolutions/koha-plugin-barcode-transformer/releases/ 3) Go to the plugin configuration page, set the configuration to the example configuration from the same page 4) In the item barcode field on the checkin and checkout pages, and anywhere else you can scan an item barcode, type in some valid barcodes, but prefix them with X and postfix them with Y, e.g. X123456Y 5) Note the letters are removed by Koha! Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:34:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:34:28 +0000 Subject: [Koha-bugs] [Bug 24197] Custom destination for failed overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103465|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 109549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109549&action=edit Bug 24197: Added new local use syspref which sets the email address that failed overdue notices are set to. Test plan: 1. Set no email addresses in patron record then checkout items to the patron making the due date in the past 2. Visit patron's home library page: Administration > Libraries Set a branch email and in global system preferences observe there is no syspref named RedirectAddressForFailedOverdueNotices 3. Manually run overdue_notices.pl 4. Check the message_queue database table and observe there is a print overdue notice and a email notice with to_address of the branch email address 5. Apply patch 6. Run database update: cd installer/data/mysql sudo koha-shell ./updatedb.pl 7. Confirm there is a new system preference named: RedirectAddressForFailedOverdueNotices Give it a different email address to that in the branch email. 7. Repeat steps 1,3,4 and observe that the failed overdue notices have been sent to the email defined in RedirectAddressForFailedOverdueNotices Sponsored-By: Catalyst IT Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:34:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:34:31 +0000 Subject: [Koha-bugs] [Bug 24197] Custom destination for failed overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103466|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 109550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109550&action=edit Bug 24197: Changed use of 'branch' terminology to 'library' Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:34:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:34:35 +0000 Subject: [Koha-bugs] [Bug 24197] Custom destination for failed overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 --- Comment #14 from Martin Renvoize --- Created attachment 109551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109551&action=edit Bug 24197: (QA follow-up) Embelished syspref description As requested, I have embelished the syspref description to more accurately depict the fallback sequence for email delivery. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:34:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:34:50 +0000 Subject: [Koha-bugs] [Bug 24197] Custom destination for failed overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:35:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:35:09 +0000 Subject: [Koha-bugs] [Bug 24197] Custom destination for failed overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit | |y.org | --- Comment #15 from Martin Renvoize --- Patch rescued, ready for second QA run. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:37:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:37:59 +0000 Subject: [Koha-bugs] [Bug 26263] Style error on OPAC search results when item-level_itypes is set to bibliographic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26263 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED --- Comment #7 from Martin Renvoize --- Marking as resolved as we reverted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:38:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:38:32 +0000 Subject: [Koha-bugs] [Bug 26263] Style error on OPAC search results when item-level_itypes is set to bibliographic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26263 --- Comment #8 from Martin Renvoize --- Note.. I still think the colwidth is better with this patch even with prior patch reverted.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:43:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:43:24 +0000 Subject: [Koha-bugs] [Bug 26268] Remove items.paidfor once and for all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 --- Comment #13 from Martin Renvoize --- (In reply to Katrin Fischer from comment #12) > I see that there is a lot of history here, but I am not quite following yet. > > 1) Before dropping the column: Did we move the information stored there in > previous developments? Nope, we didn't drop the data.. we just started using the fields it used to be populated by inconsistently to construct the display on on the fly. The data in the field is no longer maintained and historically wasn't accurate so I think we should be OK to drop it regardless. > > If we didn't, we might just want to print a warning if there is any content > to be found in the db and ask people to drop themselves. It has been done in > the past with some of the columns in borrowers (ethnicity?) I think. If > there is no data, we can drop it in the update. > > 2) Looking for "paidfor" I found some more references this patch is not > taking care of: As noted above, this is where we now construct the data on the fly. `$item->{paidfor} = { patron => $patron, created_on => $payment_offset->created_on }` is an assignment for the template rather than a getter or setter for the DB data. > > catalogue/moredetail.pl: # Add paidfor info > catalogue/moredetail.pl: $item->{paidfor} = { patron => > $patron, created_on => $payment_offset->created_on }; > > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt: > [% IF ( ITEM_DAT.paidfor ) %]
  • Paid for?: [% > INCLUDE 'patron-title.inc' patron=ITEM_DAT.paidfor.patron > hide_patron_infos_if_needed=1 %] on [% ITEM_DAT.paidfor.created_on | > $KohaDates %]
  • [% END %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:44:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:44:51 +0000 Subject: [Koha-bugs] [Bug 26356] Search by first and last name takes a long time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26356 --- Comment #3 from Jonathan Cuéllar --- (In reply to Katrin Fischer from comment #1) > how many patrons do you have in your database? Which Koha version? > > What was the search term like? (not asking for personal information, but > maybe a similar made up one) how many patrons do you have in your database? There are more than 51653 records in the borrowers table Which Koha version? Koha 20.05 What was the search term like? I do the search using my name, Jonathan Cuellar -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:48:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:48:08 +0000 Subject: [Koha-bugs] [Bug 26354] Prevent submission of patron modification request unless changes are actually made In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26354 --- Comment #2 from Christopher Brannon --- (In reply to Owen Leonard from comment #1) > I see two angles on this--perhaps both? > > 1. We check for changes to the form and ask the user if they really mean to > submit a form without having made changes. > > 2. We silently reject submissions with no changes. Somehow this seems nicer > than telling the user they can't submit the form. What about a modal, summarizing the changes? If there are no changes, it says "No changes have been made." Thoughts? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:52:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:52:50 +0000 Subject: [Koha-bugs] [Bug 26355] Tie account renewals to patron modification requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Martha Fuerst changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mfuerst at hmcpl.org --- Comment #3 from Martha Fuerst --- We're also interested in this enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:58:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:58:25 +0000 Subject: [Koha-bugs] [Bug 26355] Tie account renewals to patron modification requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #4 from Martha Fuerst --- I'd also like the option to be able to review the request for renewal before granting it. Seems like a reasonable option for a potential syspref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 17:58:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 15:58:29 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #260 from Julian Maurice --- (In reply to Jonathan Druart from comment #259) > (In reply to Julian Maurice from comment #258) > > (In reply to Marcel de Rooy from comment #257) > > > Actually not. As you say, we could run without MQ. But since we want a > > > message queue anyway, this could be a nice first start. > > That's a thing that is still not clear for me. For what other purpose do we > > need a message queue ? > > For now: all background jobs, and a task scheduler. I'm curious about how we would implement a task scheduler with a message queue. Would that be with something like https://github.com/rabbitmq/rabbitmq-delayed-message-exchange ? > But that can be extended to other things if we want (like indexing, sending > emails, etc.). Indexing and sending emails can be implemented as a background job too. How do these tasks differ from a task like BatchUpdateBiblio ? > With a configuration system we could add the capacity to define rules like > "execute all the background jobs that does XXX", or "don't execute > background jobs during opening hours". Also we could have several workers, > each doing something specific, and have them running on a dedicated server. The ability to have multiple workers is really great, but how will you run them on another server ? You would need to have the whole Koha code duplicated on this other server, right ? > > > What I do not like, is writing two blocks: code with MQ en code without. > > I do not like it either, but compared to forcing hundreds of users to > > install a new dependency, it doesn't look too bad. > > The idea was to not reinvent the wheel and use one solution that > demonstrated its effectiveness. We could write our own server if we wish. > In this implementation (there have been others previously) I decided to make > things as simple as possible. Do you mean our own message broker ? Because I certainly do not wish that. All I'm suggesting is to make the dependency to RabbitMQ (or any other MQ) optional, for small installations that won't benefit from it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 18:03:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 16:03:01 +0000 Subject: [Koha-bugs] [Bug 26355] Tie account renewals to patron modification requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #5 from Christopher Brannon --- (In reply to Martha Fuerst from comment #4) > I'd also like the option to be able to review the request for renewal before > granting it. Seems like a reasonable option for a potential syspref. Martha, see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26357, which depends on this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 18:17:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 16:17:08 +0000 Subject: [Koha-bugs] [Bug 26356] Search by first and last name takes a long time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26356 --- Comment #4 from Jonathan Cuéllar --- (In reply to Owen Leonard from comment #2) > Based on this and the other report you posted today, Bug 26353, it sounds > like you have a server issue which is outside the scope of the help we can > provide via Bugzilla. > > I suggest you seek help on the Koha mailing list > (http://koha-community.org/support/koha-mailing-lists/), in the #koha IRC > channel (http://koha-community.org/get-involved/irc/) or seek paid support > here: https://koha-community.org/support/ I don't think the problem is server-side, knowing that the reports were working, additionally I am more focused on why the query generates so many OR borrower ... OR borrower ... Or borrower, and if there is any way to monitor the SQL generated by the platform. I appreciate the help you can give me. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 18:40:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 16:40:30 +0000 Subject: [Koha-bugs] [Bug 26357] Create preference for staff notification of patron self-renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26357 Martha Fuerst changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mfuerst at hmcpl.org --- Comment #1 from Martha Fuerst --- We are interested in this. Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 18:48:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 16:48:19 +0000 Subject: [Koha-bugs] [Bug 26355] Tie account renewals to patron modification requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Margaret Hade changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |margaret at bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 19:34:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 17:34:04 +0000 Subject: [Koha-bugs] [Bug 24197] Custom destination for failed overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 19:34:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 17:34:06 +0000 Subject: [Koha-bugs] [Bug 24197] Custom destination for failed overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109549|0 |1 is obsolete| | --- Comment #16 from Nick Clemens --- Created attachment 109552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109552&action=edit Bug 24197: Added new local use syspref which sets the email address that failed overdue notices are set to. Test plan: 1. Set no email addresses in patron record then checkout items to the patron making the due date in the past 2. Visit patron's home library page: Administration > Libraries Set a branch email and in global system preferences observe there is no syspref named RedirectAddressForFailedOverdueNotices 3. Manually run overdue_notices.pl 4. Check the message_queue database table and observe there is a print overdue notice and a email notice with to_address of the branch email address 5. Apply patch 6. Run database update: cd installer/data/mysql sudo koha-shell ./updatedb.pl 7. Confirm there is a new system preference named: RedirectAddressForFailedOverdueNotices Give it a different email address to that in the branch email. 7. Repeat steps 1,3,4 and observe that the failed overdue notices have been sent to the email defined in RedirectAddressForFailedOverdueNotices Sponsored-By: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 19:34:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 17:34:11 +0000 Subject: [Koha-bugs] [Bug 24197] Custom destination for failed overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109550|0 |1 is obsolete| | --- Comment #17 from Nick Clemens --- Created attachment 109553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109553&action=edit Bug 24197: Changed use of 'branch' terminology to 'library' Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 19:34:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 17:34:14 +0000 Subject: [Koha-bugs] [Bug 24197] Custom destination for failed overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109551|0 |1 is obsolete| | --- Comment #18 from Nick Clemens --- Created attachment 109554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109554&action=edit Bug 24197: (QA follow-up) Embelished syspref description As requested, I have embelished the syspref description to more accurately depict the fallback sequence for email delivery. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 19:34:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 17:34:18 +0000 Subject: [Koha-bugs] [Bug 24197] Custom destination for failed overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 --- Comment #19 from Nick Clemens --- Created attachment 109555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109555&action=edit Bug 24197: (QA follow-up) Shorten syspref name to AddressForFailedEmailNotices If you define the address we use it, if not we fallback, it's not really a redirect, and that just makes the name longer. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 19:38:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 17:38:38 +0000 Subject: [Koha-bugs] [Bug 25265] Elasticsearch - Batch editing items on a biblio can lead to incorrect index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25265 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 19:38:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 17:38:42 +0000 Subject: [Koha-bugs] [Bug 25265] Elasticsearch - Batch editing items on a biblio can lead to incorrect index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25265 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109538|0 |1 is obsolete| | --- Comment #15 from Andrew Fuerste-Henry --- Created attachment 109556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109556&action=edit Bug 25265: Prevent double reindex of the same item in batchmod When batch editing, 2 reindex calls are sent to ES/Zebra. We can easily avoid that reusing the skip_modzebra_update Additionally we should only send one request for biblio, and we should only do it if we succeed As the hwole batch mod is in a transaction it is possible to fail in which case Zebra queue is reset, but ES indexes have already been set In addition to the skip param this patchset makes ModZebra take lists of biblionumbers or records so that multiple records can be passed in one call Test plan: 1 - Have a bib with several items, none marked 'not for loan' 2 - Do a staff search that returns this biblio 3 - Items show as available 4 - Click on title to go to details page 5 - Edit->Item in a batch 6 - Set the not for loan status for all items 7 - Repeat your search 8 - Items show as not for loan Signed-off-by: Bob Bennhoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 19:41:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 17:41:37 +0000 Subject: [Koha-bugs] [Bug 24197] Custom destination for failed overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #20 from Nick Clemens --- Last patch can be accepted or ignored, just trying to keep pref names under control :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 19:45:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 17:45:19 +0000 Subject: [Koha-bugs] [Bug 26350] Librarians can request discharge on behalf of patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 19:45:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 17:45:22 +0000 Subject: [Koha-bugs] [Bug 26350] Librarians can request discharge on behalf of patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109545|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 109557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109557&action=edit Bug 26350: Librarians can request discharge on behalf of patron While deploying discharges in our library we figured out that librarians need ability to request discharge document on behalf of patrons from intranet page. It was logical to add another option on Discharge patron tab. It nicely addresses Bug 16466 since it shows status of pending discharge instead of button to issue new discharge. To test: 1. apply patch 2. make sure that useDischarge is enabled in administration 3. verify that "Request new discharge" button is availabe, click on it 4. after page reload, message "Patron has pending discharge request." will appear 5. click on "Generate discharge" to approve discharge and generate pdf (this is unchanged compared to exsting workflow) Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 19:55:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 17:55:07 +0000 Subject: [Koha-bugs] [Bug 26041] Accessibility: The date picker calendar is not keyboard accessible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26041 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 19:55:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 17:55:10 +0000 Subject: [Koha-bugs] [Bug 26041] Accessibility: The date picker calendar is not keyboard accessible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26041 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109544|0 |1 is obsolete| | --- Comment #17 from Nick Clemens --- Created attachment 109558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109558&action=edit Bug 26041: Enable keyboard navigation without 'ctrl' This patch enables keyboard navigation using the arrow keys without the need to hold the control key for the jQuery UI datepicker. Test plan 1/ Navigate to an item in the opac and attempt to place a hold 2/ On the resultant screen, use keyboard navigation to trigger the 'Show more options' dropdown. 3/ Focus on one of the date inputs using keyboard navigation. 4/ Use 'ctrl + arrow' keys to navigate the datepicker. 5/ Note that prior to the patch using 'bare' arrow keys does not trigger anything 6/ Apply the patch and confirm that the datepicker can now be naviated using the arrow keys without holding the ctrl key. 7/ Confirm that using the ctrl key combinations continue to work as expected too. 8/ Signoff Signed-off-by: Brandon J Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 20:27:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 18:27:52 +0000 Subject: [Koha-bugs] [Bug 26308] Normal view (vue normale) is not displayed in French In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26308 --- Comment #10 from Katrin Fischer --- (In reply to Caroline Cyr La Rose from comment #9) > afaik, UNIMARC is not used here. So unless someone complains, I won't spend > time on that file :) Oops. Sorry, MARC21 and NORMARC would have the same problem :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 20:29:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 18:29:18 +0000 Subject: [Koha-bugs] [Bug 26350] Librarians can request discharge on behalf of patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 --- Comment #6 from Katrin Fischer --- This went through so fast... I didn't even get a chance to say hi to Dobrica yet! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 20:32:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 18:32:59 +0000 Subject: [Koha-bugs] [Bug 26308] Normal view (vue normale) is not displayed in French In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26308 --- Comment #11 from Caroline Cyr La Rose --- (In reply to Katrin Fischer from comment #10) > (In reply to Caroline Cyr La Rose from comment #9) > > afaik, UNIMARC is not used here. So unless someone complains, I won't spend > > time on that file :) > > Oops. Sorry, MARC21 and NORMARC would have the same problem :( Same. :) afaik, only MARC21 is used here in Canada. So I'll leave it like that and correct it if someone complains. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 20:33:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 18:33:57 +0000 Subject: [Koha-bugs] [Bug 25005] Admin Rights issue for Suggestion to Purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25005 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #8 from Christopher Brannon --- Can this be ported to 19.11? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 20:58:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 18:58:06 +0000 Subject: [Koha-bugs] [Bug 26359] New: SIP blocking messages should include a date Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26359 Bug ID: 26359 Summary: SIP blocking messages should include a date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com I think it would be beneficial to the patron and 3rd party vendors if blocking messages included the date the block went into effect. I would suggest that PATRON EXPIRED should be enhanced to PATRON EXPIRED: 12/05/1992 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 21:04:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 19:04:52 +0000 Subject: [Koha-bugs] [Bug 26360] New: Patron restriction should include a common header Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26360 Bug ID: 26360 Summary: Patron restriction should include a common header Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com It is difficult for 3rd parties to trap a patron restriction reason because it is not easily identifiable. [AF] => Array ( [0] => Greetings from Koha. -- Patron needs to speak to a staff member. [1] => COEUR ) In this case, the explanation for the restriction is "Patron blocked for looking stupid." There is no common header for a restriction. I would suggest that restrictions be preceded by PATRON RESTRICTED:. So, the above example would look like: [AF] => Array ( [0] => Greetings from Koha. -- PATRON RESTRICTED: Patron needs to speak to a staff member. [1] => COEUR ) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 21:36:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 19:36:45 +0000 Subject: [Koha-bugs] [Bug 26356] Search by first and last name takes a long time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26356 --- Comment #5 from Katrin Fischer --- People reading bugs are not that many, on the mailing list you will reach a wider audience and probably achieve more help in confirming the issue. It can help to get a clearer picture of the issue as well and help in fixing if there is a code problem behind things. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 22:15:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 20:15:33 +0000 Subject: [Koha-bugs] [Bug 22789] Establish non-priority holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 22:20:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 20:20:21 +0000 Subject: [Koha-bugs] [Bug 23678] Cancel Holds in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24599 --- Comment #2 from Tomás Cohen Arazi --- Linking to bug 24599, as we need a spec for batch actions on holds, including cancelling them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 22:20:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 20:20:21 +0000 Subject: [Koha-bugs] [Bug 24599] Add endpoints for bulk processing of holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24599 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23678 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 23:20:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 21:20:28 +0000 Subject: [Koha-bugs] [Bug 21781] message_transport_type should allow fallbacks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105328|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 23:20:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 21:20:54 +0000 Subject: [Koha-bugs] [Bug 21781] message_transport_type should allow fallbacks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 --- Comment #7 from Alex Buckley --- Created attachment 109559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109559&action=edit Bug 21781: Fallback to SMS if no email address where email address hardcoded Extend use of FallbackToSMSIfNoEmail syspref to fallback to SMS if no patron email address outside of it's current usage sending suggestion notices. Test plan for C4/Acquisition.pm: 1. Input a value into SMSSendDriver syspref 2. Create a patron with sms (under Member messaging preferences) and no email address 3. In Acquistions module make currency, active budget, fund, vendor 4. Create a basket 5. Add to basket. Click to add 'From a new (empty) record' 6. Under 'Patrons' header add a user and search for your patron (added in #1) 7. Submit new order 8. Receive the order: 'Close this basket' 'Receive shipment' Submit invoice page Select 'Receive' link on right hand side of page Tick checkbox to add 1 quantity of item and Save 9. Revisit your patrons page and in the 'Notices' tab you'll see a 'Order received' notice with type of 'email' 11. Apply patch and restart plack 12. Repeat steps 4-9 and observe the 'Order received' notice has a type of SMS Test plan for amendment to circ/pendingreserves.pl (patch has been applied in 'Test plan for C4/Acquisition.pm): 1. Set 'FallbackToSMSIfNoEmail' syspref to 'Disable' 2. Set CanMarkHoldsToPullAsLost syspref to 'Allow to mark items as lost and notify the patron' 3. Using the patron from test plan for C4/Acquisitions.pm (i.e. sms alert number and no email) place a hold on an item currently available 4. Visit Circulation > Holds to pull 5. Select 'Mark lost and notify patron' 6. Return to patron page look in 'Notices' tab and observe 'Hold has been cancelled' notice has type of 'email' 7. Change 'FallbackToSMSIfNoEmail' to 'Enable' and repeat steps 3,4,5,6 and observe the new 'Hold has been cancelled' notice has type 'sms' Test plan for amendment to misc/cronjobs/automatic_renewals.pl (patch has been applied already): 1. Set 'FallbackToSMSIfNoEmail' syspref to 'Disable' 2. Enable automatic renewals in Administration > Circulation and fine rules 3. Checkout an item to our patron and set due date in the past 4. cd into misc/cronjobs 5. Jump into koha-shell and run automatic_renewals.pl cronjob sudo koha-shell ./automatic_renewals.pl --confirm --send-notices 6. Observe in patron records 'Notices' tab there is a 'Auto renewals' notice with type 'email' 7. Set 'FallbackToSMSIfNoEmail' syspref to 'Enable' and repeat steps 3,4,5,6 and observe the new 'Auto renewals' notice is type 'sms' Test plan for amendment to misc/cronjobs/membership_expiry.pl (patch has been applied already): 1. Set 'FallbackToSMSIfNoEmail' syspref to 'Disable' 2. Set 'MembershipExpiryDaysNotice' to '1' 3. Edit our patrons record setting 'Expiry date' to 1 day in future 4. cd to misc/cronjobs directory 5. Jump into koha-shell and run membership_expiry.pl cronjob: sudo koha-shell ./membership_expiry.pl -c 6. Visit the patron record's 'Notices' tab and observe 'Account expiration' notice with type 'email' 7. Change 'FallbackToSMSIfNoEmail' syspref to 'Enable' 8. Reset patrons epxiration date to 1 day in future 9. Repeat step 4,5,6 and observe new 'Account expiration' notice is type 'sms' Test plan for opac/opac-shareshelf.pl (patch has been applied already): 1. Set 'FallbackToSMSIfNoEmail' syspref to 'Disable' 2. Set 'OpacAllowSharingPrivateLists' syspref to 'Allow' 3. Ensure OPACBaseURL is set 4. In OPAC log in as the patron with set smsalertnumber and no email 5. Create a private list, select 'Share' link, input email address and submit 6. Back in staff client make a new patron record 7. Return to OPAC and login as patron from step #5 8. Query database: select content from message_queue where letter_code='SHARE_INVITE'; 9. Click on the link in the message_queue notice 10. OPAC loads 11. Query database again: select to_address, message_transport_type from message_queue where letter_code='SHARE_ACCEPT'; 12. Observe there is no 'Share on list accepted' notice 13. Set 'FallbackToSMSIfNoEmail' to 'Enable' and repeat steps 4,5,7,8, 9,10,11,12 and observe there is a 'Share on list accepted' notice with to_address = smsalertnumber and message_transport_type is 'sms' 14. Set 'FallbackToSMSIfNoEmail' to 'disable' and edit the patron with smsalertnumber set and no email setting an email address and repeat steps 4,5,7,8,9,10,11,12 and observe there is a 'Share on list accepted' notice with the to_address of the email you set and message_transport_type of 'email' Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 23:21:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 21:21:11 +0000 Subject: [Koha-bugs] [Bug 21781] message_transport_type should allow fallbacks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 --- Comment #8 from Alex Buckley --- Rebased against master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 23:28:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 21:28:11 +0000 Subject: [Koha-bugs] [Bug 25460] Update OAI set (and optionally embed item information) when adding/editing/deleting items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25460 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104987|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 23:28:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 21:28:40 +0000 Subject: [Koha-bugs] [Bug 25460] Update OAI set (and optionally embed item information) when adding/editing/deleting items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25460 --- Comment #6 from Alex Buckley --- Created attachment 109560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109560&action=edit Bug 25460: Update OAI sets when adding/editing/deleting item records Also adds syspref to optionally choose to embed item information in record when adding/editing bibliographic and item records. Test plan: 1. Enable OAI-PMH and OAI-PMH:AutoUpdateSets sysprefs 2. Create a biblio record with 1 item with CCODE of NFIC 3. In Administration > OAI Sets configuration create a set and define the mapping: Field: 952, Subfield: 8, Operator: is equal to, Value: FIC 4. Run the build_oai_sets.pl script: cd misc/migration_tools sudo koha-shell ./build_oai_sets.pl -i 5. Check what items are in the OAI set: sudo koha-mysql select * from oai_sets_biblios; 6. Observe your bib from step 2 is not in the set 7. [ITEM EDIT] Edit the item to have CCODE of FIC repeat step 5 and observe biblio is still not in OAI set 8. [ITEM ADD] Add a new item with CCODE of FIC and repeat step 5 and observe biblio still not in OAI set 9. [ITEM DELETE] Delete one of your 2 items and repeat step 5 and observe biblio still not in OAI set 10. Apply patch, update database and restart plack (instruction below on the latter 2 actions): cd installer/data/mysql sudo koha-shell ./updatedatabase.pl sudo koha-plack --restart 11. Enable new syspref OAI-PMH:AutoUpdateSetsEmbedItemData 12. [ITEM ADD] Repeat step 8 and observe biblio is now in the OAI set 13. [ITEM EDIT] Edit both items to have a CCODE of NFIC and repeat step 5 and observe bib now not in set 14. [ITEM EDIT] Edit one of the items to have CCODE of FIC and repeat step 5 and observe bib now in set 15. [ITEM DELETE] Delete all items off bib and repeat step 5 and observe bib no longer in set Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 23:28:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 21:28:54 +0000 Subject: [Koha-bugs] [Bug 25460] Update OAI set (and optionally embed item information) when adding/editing/deleting items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25460 --- Comment #7 from Alex Buckley --- Rebased against master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 2 23:56:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 21:56:22 +0000 Subject: [Koha-bugs] [Bug 16314] Show upload link for upload plugin in basic MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16314 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106784|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 109561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109561&action=edit Bug 16314: Show upload link for upload plugin in basic MARC editor This patch updates the basic MARC editor to provide a plugin name variable to the template, allowing us to make a check on the name and conditionally show an upload link if the "upload.pl" cataloging plugin is selected. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go do Administration -> MARC bibliographic framework -> MARC structure -> 856 -> Edit subfields. - Edit the "u" subfield and select "upload.pl" as the plugin under "Other options." - Go to Cataloging and create or edit a MARC record. - Under tab 8 look for the 856 tag, subfield u. There should be an "Upload" link corresponding to the form field. - Click the upload link to confirm that it triggers a popup window with the upload form. - Confirm that other similar plugin links (for instance 100$a, 600$a) display the old "tag editor" icon. Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 00:13:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 22:13:00 +0000 Subject: [Koha-bugs] [Bug 16314] Show upload link for upload plugin in basic MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16314 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 00:36:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 22:36:52 +0000 Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105245|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 00:37:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 22:37:01 +0000 Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105243|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 00:37:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 22:37:10 +0000 Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105242|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 00:37:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 22:37:19 +0000 Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105239|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 00:37:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 22:37:29 +0000 Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105238|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 00:37:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 22:37:50 +0000 Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #11 from Alex Buckley --- Created attachment 109562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109562&action=edit Bug 25560: Database and installer changes -- Adds boolean flag itemtypes.updatenotforloanstatusoncheckin Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 00:38:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 22:38:09 +0000 Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #12 from Alex Buckley --- Created attachment 109563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109563&action=edit Bug 25560: Updated schema file Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 00:38:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 22:38:37 +0000 Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #13 from Alex Buckley --- Created attachment 109564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109564&action=edit Bug 25560: Template & syspref yaml changes Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 00:39:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 22:39:05 +0000 Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #14 from Alex Buckley --- Created attachment 109565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109565&action=edit Bug 25560: Exclude itemtypes from UpdateNotForLoanStatusOnCheckin Adds a boolean flag itemtypes.updatenotforloanstatusoncheckin, enabled by default. When disabled (if the UpdateNoForLoanStatusOnCheckin syspref is configured) when an item of the type if checked in the notforloan status does not update. This enhancement respects the 'item-level_itypes' syspref, so will look at the authoritative item type when determining to update the notforloan status. Test plan: 1. Paste into UpdateNotForLoanStatusOnCheckin syspref 0 : 1 2. Issue and return an item and observe the item's notforloan status updates 3. Apply patch & update database cd installer/data/mysql sudo koha-shell ./updatedatabase.pl 4. Restart plack 5. Go to BK (Book) item type page (Administration > Item types > BK). 6. Observe the 'Update not for loan status on check-in' checkbox is selected by default. Untick it. 7. Make sure the 'item-level_itypes' syspref is set to 'specific item' 8. Issue and return a BK item (item level itype='BK') and observe item's notforloan status does not update 9. Issue and return a CR (Continuing Resources) item (item level itype='CR') and observe the item's notforloan status updates 10. Change 'item-level_itypes' syspref to 'bibliographic record' 11. Issue and return an item (with biblio-level itemtype='BK' & item-level itype='CR') and observe the item's notforloan status does not update 12. Issue and return an item (with biblio-level itemtype='CR' & item-level itype='BK') and observe the item's notforloan status updates Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 00:39:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 22:39:26 +0000 Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #15 from Alex Buckley --- Created attachment 109566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109566&action=edit Bug 25560: Unit tests Test plan: 1. Run tests sudo koha-shell prove xt prove t prove t/db_dependent/Circulation/issue.t prove t/db_dependent/Koha/Object.t Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 00:39:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 22:39:55 +0000 Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #16 from Alex Buckley --- Rebased against master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 00:41:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 22:41:21 +0000 Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109566|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 00:41:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 22:41:42 +0000 Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #17 from Alex Buckley --- Created attachment 109567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109567&action=edit Bug 25560: Unit tests Test plan: 1. Run tests sudo koha-shell prove xt prove t prove t/db_dependent/Circulation/issue.t prove t/db_dependent/Koha/Object.t Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 00:55:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 22:55:43 +0000 Subject: [Koha-bugs] [Bug 26361] New: JS error on returns.tt in 20.05 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26361 Bug ID: 26361 Summary: JS error on returns.tt in 20.05 Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To recreate: -Be on 20.05.x -Go to returns.tt -See the error Uncaught SyntaxError: expected expression, got keyword 'var'. -Check the page source and you will see that: var columns_settings = [% TablesSettings.GetColumns( 'circ', 'returns', 'checkedintable', 'json' ) | $raw %] is being evaluated to: var columns_settings = -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 01:07:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 23:07:49 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #261 from David Cook --- (In reply to Katrin Fischer from comment #239) > MySQL/MariaDB is very standard, RabbitMQ is not... I am far from > understanding the whole discussion here, but from the use cases and "need" > for this I have heard about, I wonder if this can be really kept an optional > feature. And if it turns mandatory, are we adding a new hurdle to installing > Koha if we keep it all separate for the sysadmin to deal with? I wasn't saying it should be optional. I was saying that it must not be installed locally on the same server as Koha. It makes no operational sense. A new hurdle is also just a reality of building a better performing system. I'm happy to provide user-friendly documentation on the Wiki so that it's simple to install and configure RabbitMQ. It's really not difficult at all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 01:10:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 23:10:07 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #262 from David Cook --- (In reply to Julian Maurice from comment #243) > What about non-package installs ? > It's probably not possible to automate everything, but a minimal systemd > service file for the worker would be a good start I think. So when you > update/install Koha you just have to copy the file to /etc/systemd/system > and adjust paths/users/.. It has certainly helped me in the past with other > softwares I installed. > Can be done in another bug report, but what do you think about this ? As I've noted elsewhere, I'm already using RabbitMQ with Koha locally, and I use a systemd template service definition, which makes it really easy to set up individual systemd units per Koha instance. I'm happy to contribute a community friendly version of this. But I think we can do that as a high-priority follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 01:17:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 23:17:05 +0000 Subject: [Koha-bugs] [Bug 26361] JS error on returns.tt in 20.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26361 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 01:17:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 23:17:52 +0000 Subject: [Koha-bugs] [Bug 26361] JS error on returns.tt in 20.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26361 --- Comment #1 from Lucas Gass --- Unfortunately I think 20.05.03 was packaged with this error -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 01:38:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 23:38:16 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #263 from David Cook --- (In reply to Julian Maurice from comment #260) > I'm curious about how we would implement a task scheduler with a message > queue. Would that be with something like > https://github.com/rabbitmq/rabbitmq-delayed-message-exchange ? > Jonathan has previously suggested that plugin (https://www.rabbitmq.com/blog/2015/04/16/scheduling-messages-with-rabbitmq/). It could work. Task schedulers are a passion of mine, and there are also other ways of doing them with a message queue. Typically, you'll see to-purpose software like Celery (https://docs.celeryproject.org/en/stable/index.html) or BigBen (https://github.com/walmartlabs/bigben) that provide task schedulers that use message queues. I've also studied the source code of Perl libraries like AnyEvent, POE, Mojo::IOLoop, etc as well as the native implementation of timers in the Golang programming language. Ultimately, task schedulers are all about running a process (or a thread) that sleeps until a task is scheduled to run. It then triggers some kind of event. In Golang or Perl, that's whatever function you defined. In Celery or BigBen, it will be to send a message through the message queue to worker processes. I've written my own task schedulers in Perl and in Golang, and I'm happy to provide one for Koha later. It's not required right now, but I know what to do to implement one. (In reply to Julian Maurice from comment #260) > The ability to have multiple workers is really great, but how will you run > them on another server ? You would need to have the whole Koha code > duplicated on this other server, right ? > Not necessarily. If we write code well, we could write workers that could run on standalone servers/containers. We just need to get out of the monolith mindset. This would possibly involve building up the HTTP API further, which is a goal we already have anyway. For Koha packages, we could also package that worker code into distinct packages, which makes it easy to install on other servers/containers. I plan to do more work on this front in the future for Koha. (In reply to Julian Maurice from comment #260) > Do you mean our own message broker ? Because I certainly do not wish that. > All I'm suggesting is to make the dependency to RabbitMQ (or any other MQ) > optional, for small installations that won't benefit from it. Except even small installations *will* benefit from using a message queue. Right now, Koha - even when running Plack - depends on CGI. Using RabbitMQ provides a standard way of breaking our remaining dependency on CGI scripts for long-running tasks. As time passes, more and more of Koha will use the message queue as well. There are many long-running jobs, which would benefit from being placed into the background. This change is about building capacity and improving performance. Koha is about being all things to all people, and really all people need asynchronous processing, especially as users demand smoother user experiences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 01:45:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 23:45:03 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #264 from David Cook --- (In reply to Katrin Fischer from comment #239) > MySQL/MariaDB is very standard, RabbitMQ is not... I just want to add that message queues like RabbitMQ, ActiveMQ, Amazon SQS, etc are common in the software world. Both ActiveMQ and Amazon SQS have been around for over 15 years. They're not uncommon in the library software world either. Both DSpace and Fedora Commons come with embedded ActiveMQ servers. (Since those are Java apps, they have the advantage of being able to embed Java-based apps like ActiveMQ and Solr.) Using Plack and RabbitMQ actually helps Koha to catch-up with other (open source) library systems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 01:58:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Sep 2020 23:58:01 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #265 from David Cook --- I promise this is my last comment for now ;). I ask that people trust Tomas, Jonathan, and myself. Only the Batch Record Modification tool has been altered so far. That's not a tool critical to daily library operations. If there are issues, we can sort them out in the future with no major disruptions to library operations. If there are concerns about installations and dependencies, then I'm happy to help people with the practical aspect of that and hopefully show that they have no reason to be concerned. I run Koha from packages on Debian and Ubuntu, I run Koha from source install on OpenSuse, and I run Koha from git install on OpenSuse. I also have already implemented RabbitMQ for every one of those Koha instances, and have a custom Koha web tool which uses RabbitMQ to send messages to a custom Koha worker that is set up using a Systemd unit file. I acknowledge that I'm passionate and experienced, so maybe I'm not thinking about what it will be like for an inexperienced and more tentative Koha installer, but there really is no reason to fear RabbitMQ. Essentially, you install it, and then you forget about it. It just works. (And if you're really stuck, I'm happy to field any questions.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 02:02:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 00:02:04 +0000 Subject: [Koha-bugs] [Bug 26285] Use country code + number (E.164) validation for SMS numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26285 --- Comment #13 from David Cook --- (In reply to Martin Renvoize from comment #12) > Works as expected for me.. and I believe is now consistent OPAC and Staff > side. > > Passing QA Cheers Martin :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 02:18:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 00:18:31 +0000 Subject: [Koha-bugs] [Bug 26356] Search by first and last name takes a long time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26356 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #6 from David Cook --- (In reply to Jonathan Cuéllar from comment #0) > I don't think the problem is server-side, knowing that the reports were > working, additionally I am more focused on why the query generates so many > OR borrower ... OR borrower ... Or borrower, and if there is any way to > monitor the SQL generated by the platform. I appreciate the help you can > give me. Mmm very interesting. I don't have time to comprehensively look into this, but it appears that the SQL has so many "OR borrower" strings because Koha found patrons with attributes that matched your search terms... That server-side code is problematic. If you had too many matches (eg around 30,000-40,000), you'd probably actually crash Koha (as there limits on the length of SQL queries). I've actually seen this issue in other relational database-driven systems. But... if you're searching "jonathan cuellar" and you're getting that many matches off attributes, then it sounds like an issue with your data. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 02:19:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 00:19:27 +0000 Subject: [Koha-bugs] [Bug 26356] Search by first and last name takes a long time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26356 --- Comment #7 from David Cook --- (In reply to Jonathan Cuéllar from comment #0) > Currently when performing a search by user in Koha using first and last > name, the system takes more than 22 minutes to execute the search I find it doubtful that it took 22 minutes. Did you mean 22 seconds? The web server would typically time out after 5 minutes, so I don't know how it possibly could have taken 22 minutes for an out-of-the-box installation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 02:21:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 00:21:50 +0000 Subject: [Koha-bugs] [Bug 21820] Zebraqueue should not be added to when only Elasticsearch is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21820 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- (In reply to Fridolin SOMERS from comment #2) > (In reply to Katrin Fischer from comment #1) > > So I think maybe a new preference or option? > > Or a new value to SearchEngine : > ES alone, ES + Zebra, Zebra alone That's probably more trouble than it's worth? I reckon a new system preference makes more sense? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 02:27:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 00:27:25 +0000 Subject: [Koha-bugs] [Bug 26330] jQueryUI tabs don't work with non-Latin-1 characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26330 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 02:28:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 00:28:13 +0000 Subject: [Koha-bugs] [Bug 26341] Database update for bug 21443 is not idempotent and will destroy settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26341 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 02:36:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 00:36:06 +0000 Subject: [Koha-bugs] [Bug 26338] Show tool plugins run in tools home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26338 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #5 from David Cook --- (In reply to Fridolin SOMERS from comment #0) > In tools home there is a link to the table showing tool plugins. > Would be great to be able to run a tool plugin directly from tools home. I've been having the same idea! I think this would be useful from a UX perspective. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 02:53:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 00:53:20 +0000 Subject: [Koha-bugs] [Bug 26356] Search by first and last name takes a long time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26356 --- Comment #8 from Jonathan Cuéllar --- (In reply to David Cook from comment #7) > (In reply to Jonathan Cuéllar from comment #0) > > Currently when performing a search by user in Koha using first and last > > name, the system takes more than 22 minutes to execute the search > > I find it doubtful that it took 22 minutes. Did you mean 22 seconds? > > The web server would typically time out after 5 minutes, so I don't know how > it possibly could have taken 22 minutes for an out-of-the-box installation. The timeout was extended, so it is 22 minutes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 03:16:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 01:16:28 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #266 from David Cook --- OK just one more comment... Why don't we create a metapackage for koha like "koha-standalone" or "koha-small", which requires MySQL, Elasticsearch, and RabbitMQ (and any other external dependencies which should be run on other servers but don't have to be for a small instance). That could offer an easy setup for small Koha libraries, while leaving koha-common for more experienced and well-resourced Koha libraries and Koha support providers? (Side note: Once we have added RabbitMQ and eliminated our dependence on CGI, and maybe packaged static assets separately, we won't have to include Apache with Koha anymore either. The Apache dependency could be added to that metapackage for novice users, but most of us could replace it with Nginx or HAProxy or some other reverse proxy/load balancer.) In my mind, the koha-common package is going to become smaller over time, as we'll need fewer dependencies running on the same server as the Starman application server. So maybe the best compromise is to retain a common/core package and then have a more comprehensive metapackage which also includes that common/core package. That should make everyone happy? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 04:16:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 02:16:54 +0000 Subject: [Koha-bugs] [Bug 26356] Search by first and last name takes a long time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26356 --- Comment #9 from David Cook --- (In reply to Jonathan Cuéllar from comment #8) > The timeout was extended, so it is 22 minutes Thanks for clarifying. So it's not an out-of-the-box installation. On that note, does it take 22 minutes for the search, or does the search timeout after 22 minutes? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 04:27:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 02:27:37 +0000 Subject: [Koha-bugs] [Bug 26356] Search by first and last name takes a long time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26356 --- Comment #10 from David Cook --- I can't replicate your issue using the attachment provided. First, the attachment is invalid SQL. It looks like this is only a fragment of the actual SQL being run (plus it contains a number of syntax errors). Second, when I run the corrected SQL fragment directly against the database, I get a response in about .0131 seconds. So I don't think it's the SQL. I think there's probably more going on with your data and your server than is made clear in this issue report. You may have a genuine issue, but it's not reproducible or even clear what it is at this point. As Owen suggested earlier, I think your issue qualifies as a support issue rather than a bug report. I'd say you probably need to look at getting a paid support provider or dig into the code yourself. Alternatively, you may try to reproduce your own issue, and break down the steps to make it clearer to us what might be happening. For instance, with a freshly installed Koha, does this happen after importing 50,000 borrowers (and making no other changes)? How are those borrowers imported? Can you share the dataset so that someone else more technical can try to reproduce the problem in a technical environment? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 05:55:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 03:55:17 +0000 Subject: [Koha-bugs] [Bug 26361] JS error on returns.tt in 20.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26361 --- Comment #2 from Lucas Gass --- This is the result of a bad rebase of 25940. I rebased with TablesSettings instead if ColumnSettings. TableSettings is not in 20.05 or below -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 05:58:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 03:58:58 +0000 Subject: [Koha-bugs] [Bug 26361] JS error on returns.tt in 20.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26361 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 05:59:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 03:59:01 +0000 Subject: [Koha-bugs] [Bug 26361] JS error on returns.tt in 20.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26361 --- Comment #3 from Lucas Gass --- Created attachment 109568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109568&action=edit Bug 26361: switch TableSettings to ColumnSettings Test Plan: -Be on 20.05.x -Go to returns.tt -See the error Uncaught SyntaxError: expected expression, got keyword 'var'. -Apply patch -Reload returns.tt, no error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 06:15:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 04:15:46 +0000 Subject: [Koha-bugs] [Bug 25005] Admin Rights issue for Suggestion to Purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25005 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |aleisha at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 06:16:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 04:16:03 +0000 Subject: [Koha-bugs] [Bug 25005] Admin Rights issue for Suggestion to Purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25005 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00 |20.05.00, 19.11.10 released in| | --- Comment #9 from Aleisha Amohia --- backported to 19.11.x for 19.11.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 06:51:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 04:51:19 +0000 Subject: [Koha-bugs] [Bug 26362] New: Overdue report shows incorrect branches for patron, holdingbranch, and homebranch Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26362 Bug ID: 26362 Summary: Overdue report shows incorrect branches for patron, holdingbranch, and homebranch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The library columns in the report at /cgi-bin/koha/circ/overdue.pl are completely wrong. This isn't obvious in a single branch environment, but in multibranch environments with items that move around it becomes more obvious. Currently, Patron library = home branch Home library = holding branch Holding library = patron branch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 06:53:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 04:53:30 +0000 Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration to overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #37 from David Cook --- Sorry to say it but this patch actually makes the overdues report (potentially) inaccurate in terms of libraries. See Bug 26362 for the explanation and upcoming patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 06:53:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 04:53:45 +0000 Subject: [Koha-bugs] [Bug 26362] Overdue report shows incorrect branches for patron, holdingbranch, and homebranch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26362 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21852 Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 [Bug 21852] Add more columns and column configuration to overdues report -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 06:53:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 04:53:45 +0000 Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration to overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26362 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26362 [Bug 26362] Overdue report shows incorrect branches for patron, holdingbranch, and homebranch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 07:42:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 05:42:28 +0000 Subject: [Koha-bugs] [Bug 26362] Overdue report shows incorrect branches for patron, holdingbranch, and homebranch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26362 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 07:42:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 05:42:30 +0000 Subject: [Koha-bugs] [Bug 26362] Overdue report shows incorrect branches for patron, holdingbranch, and homebranch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26362 --- Comment #1 from David Cook --- Created attachment 109569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109569&action=edit Bug 26362: Show correct libraries in overdues report Currently the overdues report does the following display: Patron library = home branch Home library = holding branch Holding library = patron branch This patch corrects the display of libraries in the overdues report. To test: 0) Do not apply patch 1) Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 2) Go to http://localhost:8081/cgi-bin/koha/circ/set-library.pl 3) Choose "Troy" 4) http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 5) Checkout "39999000004571" with due date of "09/01/2019 23:59" Note the facts: Patron library = Centerville Home library = Fairview Holding library = Troy 6) Go to http://localhost:8081/cgi-bin/koha/circ/overdue.pl 7) Change "Columns" visibility to show Holding and Home libraries 8) Note that the libraries are incorrect: Patron library appears to be: Fairview Home library appears to be: Troy Holding library appears to be: Centerville 9) Apply the patch 10) koha-plack --restart kohadev 11) Go to http://localhost:8081/cgi-bin/koha/circ/overdue.pl 12) Change "Columns" visibility to show Holding and Home libraries 13) Note that the libraries are correct: Patron library appears to be: Centerville Home library appears to be: Fairview Holding library appears to be: Troy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 08:13:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 06:13:15 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #267 from Marcel de Rooy --- (In reply to David Cook from comment #263) > Right now, Koha - even when running Plack - depends on CGI. Using RabbitMQ > provides a standard way of breaking our remaining dependency on CGI scripts > for long-running tasks. I am not following this argument. We are not introducing a MQ to eliminate CGI. Imo this is really another topic, not in the scope of this report. > As time passes, more and more of Koha will use the message queue as well. > There are many long-running jobs, which would benefit from being placed into > the background. > This change is about building capacity and improving performance. So we have an architectural reason for a MQ. And the question is: do we want an optional introduction needing additional fallback code, or dont we postpone making it mandatory (since it will be one day)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 08:28:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 06:28:35 +0000 Subject: [Koha-bugs] [Bug 26362] Overdue report shows incorrect branches for patron, holdingbranch, and homebranch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26362 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109569|0 |1 is obsolete| | CC| |emmi.takkinen at outlook.com --- Comment #2 from Emmi Takkinen --- Created attachment 109570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109570&action=edit Bug 26362: Show correct libraries in overdues report Currently the overdues report does the following display: Patron library = home branch Home library = holding branch Holding library = patron branch This patch corrects the display of libraries in the overdues report. To test: 0) Do not apply patch 1) Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 2) Go to http://localhost:8081/cgi-bin/koha/circ/set-library.pl 3) Choose "Troy" 4) http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 5) Checkout "39999000004571" with due date of "09/01/2019 23:59" Note the facts: Patron library = Centerville Home library = Fairview Holding library = Troy 6) Go to http://localhost:8081/cgi-bin/koha/circ/overdue.pl 7) Change "Columns" visibility to show Holding and Home libraries 8) Note that the libraries are incorrect: Patron library appears to be: Fairview Home library appears to be: Troy Holding library appears to be: Centerville 9) Apply the patch 10) koha-plack --restart kohadev 11) Go to http://localhost:8081/cgi-bin/koha/circ/overdue.pl 12) Change "Columns" visibility to show Holding and Home libraries 13) Note that the libraries are correct: Patron library appears to be: Centerville Home library appears to be: Fairview Holding library appears to be: Troy Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 08:30:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 06:30:28 +0000 Subject: [Koha-bugs] [Bug 26362] Overdue report shows incorrect branches for patron, holdingbranch, and homebranch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26362 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 08:37:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 06:37:53 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #268 from Julian Maurice --- (In reply to Marcel de Rooy from comment #267) > > As time passes, more and more of Koha will use the message queue as well. > > There are many long-running jobs, which would benefit from being placed into > > the background. > > This change is about building capacity and improving performance. > > So we have an architectural reason for a MQ. And the question is: do we want > an optional introduction needing additional fallback code, or dont we > postpone making it mandatory (since it will be one day)? My point was that we can run jobs in background without a message queue and without adding new dependencies. But since everyone want a message queue anyway, please ignore my comments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 08:42:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 06:42:10 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108718|0 |1 is obsolete| | --- Comment #94 from Martin Renvoize --- Created attachment 109571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109571&action=edit Bug 23091: Database update This patch updates the 'refund' circulation rule to be called 'lostreturn' and populates the value with 'refund' where appropriate. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 08:42:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 06:42:14 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108719|0 |1 is obsolete| | --- Comment #95 from Martin Renvoize --- Created attachment 109572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109572&action=edit Bug 23091: Update unit test This patch updates the unit test for get_lostreturn_policy to reflect the rule_name and return code changes. Test plan: 1/ Read the code changes in t/db_dependant/Koha/CirculationRules and t/db_dependant/Koha/IssuingRules and confirm they make sense. 2/ Run the updated tests and ensure they pass. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 08:42:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 06:42:19 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108720|0 |1 is obsolete| | --- Comment #96 from Martin Renvoize --- Created attachment 109573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109573&action=edit Bug 23091: Add handling for new lostreturn rules This patch adds handing for the new values available for the lostreturn policy settings. * undef - Do nothing, leave fees and fines as they were at the point of lose. * refund - Refund the lost item fee only * charge - Refund the lost item fee and charge a fresh overdue fine dated for a return on the date the item is 'found' * restore - Refund the lost item fee and restore the original overdue fine (dated for a 'return' on the date the item was 'lost' Test plan 1/ apply patch 2/ updatedatabase, restart_all 3/ verify finesmode and CalculateFinesOnReturn and WhenLostChargeReplacementFee are on 4/ verify WhenLostForgiveFine is set to "Forgive" 5/ verify circ rules include fines 6/ set Default lost item fee refund on return policy to "Refund lost item charge" 7/ create 4 overdue checkouts that will incur fines 8/ run fines.pl 9/ confirm 4 items checked out with accruing fines 10/ confirm all 4 items have a replacement price Item 1 11/ mark the first item lost 12/ verify that fine is gone and lost fee has been charged 13/ check item in 14/ verify that lost fee is gone and overdue charge has not returned Item 2 15/ set Default lost item fee refund on return policy to "Refund lost item charge and charge new overdue fine" 16/ mark second item lost 17/ verify that fine is gone and lost fee has been charged 18/ check item in 19/ verify that lost fee is gone and a new overdue charge has been made Item 3 20/ set Default lost item fee refund on return policy to "Refund lost item charge and restore overdue fine" 21/ mark third item lost 22/ verify that fine is gone and lost fee has been charged 23/ check item in 24/ verify that lost fee is gone and the old overdue charge has been restored Item 4 25/ set Default lost item fee refund on return policy to "Leave lost item charge" 26/ mark fourth item lost 27/ verify that fine is gone and lost fee has been charged 28/ check item in 29/ verify that lost fee remains and the overdue charge is still gone Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 08:42:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 06:42:23 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108721|0 |1 is obsolete| | --- Comment #97 from Martin Renvoize --- Created attachment 109574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109574&action=edit Bug 23091: Add tests for _RestoreOverdueForLostAndFound This patch adds unit tests for the newly introduced _RestoreOverdueForLostAndFound method in C4::Circulation. Test plan 1/ Read the new tests added to t/db_dependent/Circuation.t to ensure they make sense 2/ Run the tests and verify they pass 3/ Signoff Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 08:42:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 06:42:27 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108722|0 |1 is obsolete| | --- Comment #98 from Martin Renvoize --- Created attachment 109575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109575&action=edit Bug 23091: Make relations more explicit This patch simply makes the queries built for the ->debits and ->credits relations in Koha::Account::Line more explicit. Test plan 1/ Ensure tests continue to pass 2/ Run tests with DBIC_TRACE=1 DBIC_TRACE_PROFILE=console and note that the related queries not include 'credit.' and 'debit.' as appropriate. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 08:42:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 06:42:32 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108723|0 |1 is obsolete| | --- Comment #99 from Martin Renvoize --- Created attachment 109576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109576&action=edit Bug 23091: Add template handling for new messages This patch adds handling for the display of the two new messages added by this patchset in the returns screen. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 08:42:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 06:42:36 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108724|0 |1 is obsolete| | --- Comment #100 from Martin Renvoize --- Created attachment 109577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109577&action=edit Bug 23091: Outline of tests to be written Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 08:48:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 06:48:25 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 08:50:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 06:50:26 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 --- Comment #101 from Martin Renvoize --- Last outstanding work is to write the outlined tests from the final patch attached. The patchset does, however, now apply again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 08:50:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 06:50:50 +0000 Subject: [Koha-bugs] [Bug 26268] Remove items.paidfor once and for all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 08:57:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 06:57:48 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #269 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #267) > (In reply to David Cook from comment #263) > > Right now, Koha - even when running Plack - depends on CGI. Using RabbitMQ > > provides a standard way of breaking our remaining dependency on CGI scripts > > for long-running tasks. > > I am not following this argument. We are not introducing a MQ to eliminate > CGI. Imo this is really another topic, not in the scope of this report. The background job processes are running in CGI mode % grep ProxyPass debian/templates/apache-shared-intranet-plack.conf > > As time passes, more and more of Koha will use the message queue as well. > > There are many long-running jobs, which would benefit from being placed into > > the background. > > This change is about building capacity and improving performance. > > So we have an architectural reason for a MQ. And the question is: do we want > an optional introduction needing additional fallback code, or dont we > postpone making it mandatory (since it will be one day)? Once it's pushed, koha-testing-docker will want to run it on a separate container for sure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 09:02:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 07:02:45 +0000 Subject: [Koha-bugs] [Bug 26363] New: Provide a systemd unit file for background_jobs_worker Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 Bug ID: 26363 Summary: Provide a systemd unit file for background_jobs_worker Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: dcook at prosentient.com.au Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 22417 We need a systemd service’s unit file to start/stop misc/background_jobs_worker.pl, like we do with the debian packages in debian/scripts/koha-worker Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 [Bug 22417] Add a task queue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 09:02:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 07:02:45 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26363 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 [Bug 26363] Provide a systemd unit file for background_jobs_worker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 09:03:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 07:03:46 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #270 from Jonathan Druart --- (In reply to David Cook from comment #262) > (In reply to Julian Maurice from comment #243) > > What about non-package installs ? > > It's probably not possible to automate everything, but a minimal systemd > > service file for the worker would be a good start I think. So when you > > update/install Koha you just have to copy the file to /etc/systemd/system > > and adjust paths/users/.. It has certainly helped me in the past with other > > softwares I installed. > > Can be done in another bug report, but what do you think about this ? > > As I've noted elsewhere, I'm already using RabbitMQ with Koha locally, and I > use a systemd template service definition, which makes it really easy to set > up individual systemd units per Koha instance. > > I'm happy to contribute a community friendly version of this. > > But I think we can do that as a high-priority follow-up. I've opened bug 26363 and assigned it to you ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 09:10:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 07:10:11 +0000 Subject: [Koha-bugs] [Bug 26231] bulkmarcimport.pl does not import authority if it already has a 001 field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26231 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #2 from Fridolin SOMERS --- Looks logical. Maybe just log that value of 001 will be lost no ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 09:16:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 07:16:42 +0000 Subject: [Koha-bugs] [Bug 26361] JS error on returns.tt in 20.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26361 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25940 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25940 [Bug 25940] Two separate print dialogs when checking in/transferring an item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 09:16:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 07:16:42 +0000 Subject: [Koha-bugs] [Bug 25940] Two separate print dialogs when checking in/transferring an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25940 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26361 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26361 [Bug 26361] JS error on returns.tt in 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 09:27:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 07:27:26 +0000 Subject: [Koha-bugs] [Bug 26309] Elasticsearch cxn_pool must be configurable (again) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26309 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |fridolin.somers at biblibre.co | |m --- Comment #3 from Fridolin SOMERS --- Bug 25273 moved t/Koha/SearchEngine/Elasticsearch.t to t/db_dependent/Koha/SearchEngine/Elasticsearch.t but patch still applies ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 09:27:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 07:27:48 +0000 Subject: [Koha-bugs] [Bug 26309] Elasticsearch cxn_pool must be configurable (again) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26309 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 09:31:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 07:31:00 +0000 Subject: [Koha-bugs] [Bug 26363] Provide a systemd unit file for background_jobs_worker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 09:33:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 07:33:19 +0000 Subject: [Koha-bugs] [Bug 26309] Elasticsearch cxn_pool must be configurable (again) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26309 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 09:33:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 07:33:22 +0000 Subject: [Koha-bugs] [Bug 26309] Elasticsearch cxn_pool must be configurable (again) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26309 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109237|0 |1 is obsolete| | --- Comment #4 from Fridolin SOMERS --- Created attachment 109578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109578&action=edit Bug 26309: Unit tests Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 09:33:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 07:33:42 +0000 Subject: [Koha-bugs] [Bug 26309] Elasticsearch cxn_pool must be configurable (again) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26309 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109238|0 |1 is obsolete| | --- Comment #5 from Fridolin SOMERS --- Created attachment 109579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109579&action=edit Bug 26309: Make cxn_pool configurable In get_elasticsearch_params we set the conf to static if undefined, but we never defined it To test: 1 - Apply unit test patch 2 - prove -v t/Koha/SearchEngine/Elasticsearch.t 3 - It fails 4 - Apply this patch 5 - It succeeds Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 09:33:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 07:33:55 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #271 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #269) > The background job processes are running in CGI mode > % grep ProxyPass debian/templates/apache-shared-intranet-plack.conf I know. But it is not the main point of this discussion. > Once it's pushed, koha-testing-docker will want to run it on a separate > container for sure. Yes, I already asked for that. But that does not tell us if we should handle Koha without MQ (where Julian is asking for). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 09:46:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 07:46:22 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #272 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #271) > (In reply to Jonathan Druart from comment #269) > > The background job processes are running in CGI mode > > % grep ProxyPass debian/templates/apache-shared-intranet-plack.conf > > I know. But it is not the main point of this discussion. This patchset is about moving these scripts out of CGI mode (bug 15032). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 09:47:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 07:47:17 +0000 Subject: [Koha-bugs] [Bug 26361] JS error on returns.tt in 20.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26361 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 09:47:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 07:47:20 +0000 Subject: [Koha-bugs] [Bug 26361] JS error on returns.tt in 20.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26361 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109568|0 |1 is obsolete| | --- Comment #4 from Fridolin SOMERS --- Created attachment 109580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109580&action=edit Bug 26361: switch TableSettings to ColumnSettings Test Plan: -Be on 20.05.x -Go to returns.tt -See the error Uncaught SyntaxError: expected expression, got keyword 'var'. -Apply patch -Reload returns.tt, no error Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 09:48:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 07:48:17 +0000 Subject: [Koha-bugs] [Bug 26361] JS error on returns.tt in 20.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26361 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin SOMERS --- Backport error indeed. Also needed to 19.11.x -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 09:50:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 07:50:53 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #273 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #272) > (In reply to Marcel de Rooy from comment #271) > > (In reply to Jonathan Druart from comment #269) > > > The background job processes are running in CGI mode > > > % grep ProxyPass debian/templates/apache-shared-intranet-plack.conf > > > > I know. But it is not the main point of this discussion. > > This patchset is about moving these scripts out of CGI mode (bug 15032). We're talking different languages here. Never mind. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 09:53:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 07:53:51 +0000 Subject: [Koha-bugs] [Bug 26263] Style error on OPAC search results when item-level_itypes is set to bibliographic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26263 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 09:55:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 07:55:13 +0000 Subject: [Koha-bugs] [Bug 26031] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26031 --- Comment #17 from Jonathan Druart --- Master_D10_Deps #64 Docker_3 16:45:29 koha_1 | # ===DIAG=== 16:45:29 koha_1 | # XSLTResultsDisplay is default 16:45:29 koha_1 | # /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl exists 16:45:29 koha_1 | # ========== -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 09:55:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 07:55:37 +0000 Subject: [Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 09:55:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 07:55:40 +0000 Subject: [Koha-bugs] [Bug 25504] Wrong API spec breaks plack without meaningful error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25504 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 09:55:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 07:55:41 +0000 Subject: [Koha-bugs] [Bug 26250] Test suite does not pass if Elastic is used as search engine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26250 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 09:55:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 07:55:43 +0000 Subject: [Koha-bugs] [Bug 25360] Use secure flag for CGISESSID cookie In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25360 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:16:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:16:47 +0000 Subject: [Koha-bugs] [Bug 26331] svc/letters/preview is not executable which prevents CGI functioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26331 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:16:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:16:50 +0000 Subject: [Koha-bugs] [Bug 26331] svc/letters/preview is not executable which prevents CGI functioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26331 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109387|0 |1 is obsolete| | --- Comment #2 from Fridolin SOMERS --- Created attachment 109581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109581&action=edit Bug 26331: Make svc/letters/preview executable Without this patch, you can't preview letters when running Koha in CGI mode. To test: 1. Run Koha as CGI (and not Plack) 2. Go to /cgi-bin/koha/tools/letter.pl?op=add_form&branchcode=&module=circulation&code=CHECKIN 3. Try to preview the notice (using a valid barcode) 4. Note in the browser console that svc/letters/preview is generating a 500 error Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:17:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:17:45 +0000 Subject: [Koha-bugs] [Bug 26331] svc/letters/preview is not executable which prevents CGI functioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26331 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #3 from Fridolin SOMERS --- Trivial ;) Looks like its the only file missing permission : find svc -not -perm -755 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:20:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:20:49 +0000 Subject: [Koha-bugs] [Bug 23634] Privilege escalation vulnerability for staff users with 'edit_borrowers' permission and 'OpacResetPassword' enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23634 --- Comment #75 from Jonathan Druart --- Created attachment 109582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109582&action=edit Bug 23634: Make is_superlibrarian return 1 or 0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:22:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:22:19 +0000 Subject: [Koha-bugs] [Bug 26271] Call to /api/v1/patrons//account returns 500 error if manager_id is NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26271 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:22:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:22:22 +0000 Subject: [Koha-bugs] [Bug 26271] Call to /api/v1/patrons//account returns 500 error if manager_id is NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26271 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108821|0 |1 is obsolete| | --- Comment #3 from Fridolin SOMERS --- Created attachment 109583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109583&action=edit Bug 26271: Add null to the list of accepted account_line data types The database schema for accountlines table allows the manager_id/user_id column to be NULL. If request to /api/v1/patrons//account returns such an accountline where it is NULL we get 500 error as response. Adding NULL to allowed data types fixes this issue. To test: 1) Run prove t/db_dependent/api/v1/patrons_accounts.t and notice it doesn't fail Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:22:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:22:51 +0000 Subject: [Koha-bugs] [Bug 26271] Call to /api/v1/patrons//account returns 500 error if manager_id is NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26271 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108820|0 |1 is obsolete| | --- Comment #4 from Fridolin SOMERS --- Created attachment 109584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109584&action=edit Bug 26271: Add failing test to reveal issue with patrons API endpoint When manager_id is null/undef the API returns error code 500. To test: 1) Notice failure when running prove t/db_dependent/api/v1/patrons_accounts.t Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:23:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:23:02 +0000 Subject: [Koha-bugs] [Bug 26271] Call to /api/v1/patrons//account returns 500 error if manager_id is NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26271 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109583|0 |1 is obsolete| | --- Comment #5 from Fridolin SOMERS --- Created attachment 109585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109585&action=edit Bug 26271: Add null to the list of accepted account_line data types The database schema for accountlines table allows the manager_id/user_id column to be NULL. If request to /api/v1/patrons//account returns such an accountline where it is NULL we get 500 error as response. Adding NULL to allowed data types fixes this issue. To test: 1) Run prove t/db_dependent/api/v1/patrons_accounts.t and notice it doesn't fail Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:23:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:23:25 +0000 Subject: [Koha-bugs] [Bug 26271] Call to /api/v1/patrons//account returns 500 error if manager_id is NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26271 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS --- Looks perfect ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:23:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:23:54 +0000 Subject: [Koha-bugs] [Bug 26361] JS error on returns.tt in 20.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26361 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- Lucas, you need to setup a pre-push hook to catch occurrences of TableSettings in template files. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:24:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:24:23 +0000 Subject: [Koha-bugs] [Bug 26128] Proxy Error while importing a large number of patrons (e.g. 6000 patrons) with Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26128 --- Comment #7 from Ulrich Kleiber --- We use Debian packages and the Apache configuration is correct. We are happy with our solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:25:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:25:49 +0000 Subject: [Koha-bugs] [Bug 23634] Privilege escalation vulnerability for staff users with 'edit_borrowers' permission and 'OpacResetPassword' enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23634 --- Comment #76 from Martin Renvoize --- I agree with this followup.. it makes a lot of sense to enforce a boolean return as aposed to leaking the hash as has_permission does. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:31:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:31:08 +0000 Subject: [Koha-bugs] [Bug 26236] log viewer does not translate the interface properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26236 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:31:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:31:11 +0000 Subject: [Koha-bugs] [Bug 26236] log viewer does not translate the interface properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26236 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108506|0 |1 is obsolete| | --- Comment #2 from Fridolin SOMERS --- Created attachment 109586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109586&action=edit Bug 25872: Fix translating interface from DB term to readable term When viewing the logs we try to swith the db values like 'cron' to friendly terms like 'Cron job' The values we use for building the selectors on the page ar eupper case, but DB values are lower case If we simply force upper case in the comparison we can ensure we always match correctly To test: 1 - Enable some 'Logs' setting in System preferences 2 - Perform some action in koha that will log Run a cronjob Change a syspref etc. 3 - Browse to Tools-> Log viewer 4 - Click 'Submit' to see all logs 5 - Note the 'Interface' column contains lower case DB values 6 - Apply patch 7 - Reload the page 8 - Values in interface are now Camel cased and more friendly https://bugs.koha-community.org/show_bug.cgi?id=26236 Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:31:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:31:29 +0000 Subject: [Koha-bugs] [Bug 26236] log viewer does not translate the interface properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26236 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #3 from Fridolin SOMERS --- Good catch ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:38:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:38:33 +0000 Subject: [Koha-bugs] [Bug 26361] JS error on returns.tt in 20.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26361 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:38:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:38:36 +0000 Subject: [Koha-bugs] [Bug 26361] JS error on returns.tt in 20.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26361 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109580|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 109587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109587&action=edit Bug 26361: switch TableSettings to ColumnSettings Test Plan: -Be on 20.05.x -Go to returns.tt -See the error Uncaught SyntaxError: expected expression, got keyword 'var'. -Apply patch -Reload returns.tt, no error Signed-off-by: Fridolin Somers Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:39:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:39:23 +0000 Subject: [Koha-bugs] [Bug 26361] JS error on returns.tt in 20.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26361 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:39:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:39:36 +0000 Subject: [Koha-bugs] [Bug 26361] JS error on returns.tt in 20.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26361 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:40:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:40:23 +0000 Subject: [Koha-bugs] [Bug 23634] Privilege escalation vulnerability for staff users with 'edit_borrowers' permission and 'OpacResetPassword' enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23634 --- Comment #77 from Jonathan Druart --- Nothing to worry for stable branches, it will not change anything. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:41:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:41:52 +0000 Subject: [Koha-bugs] [Bug 23634] Privilege escalation vulnerability for staff users with 'edit_borrowers' permission and 'OpacResetPassword' enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23634 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.05.14, 19.11.09 |20.11.00, 19.05.14, released in| |19.11.09 --- Comment #78 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:42:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:42:32 +0000 Subject: [Koha-bugs] [Bug 17801] 'Top Most-circulated items' gives wrong results when filtering by checkout date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:42:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:42:34 +0000 Subject: [Koha-bugs] [Bug 17801] 'Top Most-circulated items' gives wrong results when filtering by checkout date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109246|0 |1 is obsolete| | --- Comment #4 from Fridolin SOMERS --- Created attachment 109588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109588&action=edit Bug 17801: Use issuedate for limits in Most Circulated Items To test: 1 - Have two checkouts in old_issues issue 1: timestamp 2020-08-01 00:00:00, issuedate 2019-08-01 00:00:00 issue 2: timestamp 2020-07-01 00:00:00, issuedate 2019-07-01 00:00:00 2 - Perform a Most Circulated Items search for checkout dates 2020-06-01 to 2020-09-01. Both checkouts appear in search 3 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Neither checkout appears in search 4 - apply patch, restart all 5 - Repeat search with checkout dates 2020-06-01 to 2020-09-01. Neither checkout appears in search 6 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Both checkouts appears in search Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:42:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:42:49 +0000 Subject: [Koha-bugs] [Bug 23634] Privilege escalation vulnerability for staff users with 'edit_borrowers' permission and 'OpacResetPassword' enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23634 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 19.05.14, |20.11.00, 20.05.03, released in|19.11.09 |19.11.09, 19.05.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:43:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:43:11 +0000 Subject: [Koha-bugs] [Bug 24663] OPACPublic must be tested for all opac scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24663 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.05.14, 19.11.09 |20.11.00, 20.05.03, released in| |19.11.09, 19.05.14 --- Comment #48 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:43:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:43:13 +0000 Subject: [Koha-bugs] [Bug 17801] 'Top Most-circulated items' gives wrong results when filtering by checkout date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin SOMERS --- Indeed, timestamp can not be trusted. Nice work ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:43:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:43:15 +0000 Subject: [Koha-bugs] [Bug 25360] Use secure flag for CGISESSID cookie In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25360 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.05.14, 19.11.09 |20.11.00, 20.05.03, released in| |19.11.09, 19.05.14 --- Comment #38 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:53:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:53:01 +0000 Subject: [Koha-bugs] [Bug 26309] Elasticsearch cxn_pool must be configurable (again) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26309 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109578|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 109589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109589&action=edit Bug 26309: Unit tests Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:53:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:53:04 +0000 Subject: [Koha-bugs] [Bug 26309] Elasticsearch cxn_pool must be configurable (again) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26309 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109579|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 109590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109590&action=edit Bug 26309: Make cxn_pool configurable In get_elasticsearch_params we set the conf to static if undefined, but we never defined it To test: 1 - Apply unit test patch 2 - prove -v t/Koha/SearchEngine/Elasticsearch.t 3 - It fails 4 - Apply this patch 5 - It succeeds Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:54:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:54:08 +0000 Subject: [Koha-bugs] [Bug 26309] Elasticsearch cxn_pool must be configurable (again) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26309 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize --- Works as expected, tests pass and QA script passes. Passing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:56:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:56:16 +0000 Subject: [Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #19 from Jonathan Druart --- There are merge marker conflicts left in the last patch koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt:<<<<<<< HEAD koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt:<<<<<<< HEAD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 10:57:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 08:57:40 +0000 Subject: [Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 --- Comment #20 from Jonathan Druart --- I think the patches should be squashed. The first patch contain a lot of merge marker conflicts, that will make further conflicts a nightmare to resolve. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:00:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:00:34 +0000 Subject: [Koha-bugs] [Bug 26271] Call to /api/v1/patrons//account returns 500 error if manager_id is NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26271 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109584|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 109591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109591&action=edit Bug 26271: Add failing test to reveal issue with patrons API endpoint When manager_id is null/undef the API returns error code 500. To test: 1) Notice failure when running prove t/db_dependent/api/v1/patrons_accounts.t Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:00:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:00:40 +0000 Subject: [Koha-bugs] [Bug 26271] Call to /api/v1/patrons//account returns 500 error if manager_id is NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26271 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109585|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 109592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109592&action=edit Bug 26271: Add null to the list of accepted account_line data types The database schema for accountlines table allows the manager_id/user_id column to be NULL. If request to /api/v1/patrons//account returns such an accountline where it is NULL we get 500 error as response. Adding NULL to allowed data types fixes this issue. To test: 1) Run prove t/db_dependent/api/v1/patrons_accounts.t and notice it doesn't fail Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:01:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:01:02 +0000 Subject: [Koha-bugs] [Bug 26271] Call to /api/v1/patrons//account returns 500 error if manager_id is NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26271 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize --- Works as expected, well spotted. Passing QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:01:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:01:08 +0000 Subject: [Koha-bugs] [Bug 26271] Call to /api/v1/patrons//account returns 500 error if manager_id is NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26271 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:01:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:01:43 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105656|0 |1 is obsolete| | --- Comment #12 from Fridolin SOMERS --- Created attachment 109593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109593&action=edit Bug 15156: Get all Borrowers with pending/unpaid fines/accountlines This patch adds method to fetch all borrowers with unpaid fines. To test: prove t/db_dependent/Koha/Patrons.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:02:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:02:03 +0000 Subject: [Koha-bugs] [Bug 26332] Koha::Account::pay incorrectly defaults to '0' for manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26332 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26271 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:02:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:02:03 +0000 Subject: [Koha-bugs] [Bug 26271] Call to /api/v1/patrons//account returns 500 error if manager_id is NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26271 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26332 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:02:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:02:27 +0000 Subject: [Koha-bugs] [Bug 26332] Koha::Account::pay incorrectly defaults to '0' for manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26332 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:04:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:04:21 +0000 Subject: [Koha-bugs] [Bug 26331] svc/letters/preview is not executable which prevents CGI functioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26331 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109581|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 109594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109594&action=edit Bug 26331: Make svc/letters/preview executable Without this patch, you can't preview letters when running Koha in CGI mode. To test: 1. Run Koha as CGI (and not Plack) 2. Go to /cgi-bin/koha/tools/letter.pl?op=add_form&branchcode=&module=circulation&code=CHECKIN 3. Try to preview the notice (using a valid barcode) 4. Note in the browser console that svc/letters/preview is generating a 500 error Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:04:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:04:37 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Needs Signoff |Signed Off --- Comment #13 from Fridolin SOMERS --- Can really be usefull, signing. Just a note : Since account is not only for fines (there can be copy fees, subscription payement ...) maybe use a more generic name for the method "search_patrons_with_unpaid_fines". With "owing" maybe, like in C4::Members : $flaginfo{'message'} = sprintf 'Patron owes %.02f', $owing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:04:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:04:43 +0000 Subject: [Koha-bugs] [Bug 26331] svc/letters/preview is not executable which prevents CGI functioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26331 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Good catch, trivial patch.. Passing QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:06:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:06:45 +0000 Subject: [Koha-bugs] [Bug 26312] Add some error handling during Elasticsearch indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26312 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #2 from Fridolin SOMERS --- Very nice. Why add "use Try::Tiny" in misc/search_tools/rebuild_elasticsearch.pl ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:07:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:07:24 +0000 Subject: [Koha-bugs] [Bug 26236] log viewer does not translate the interface properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26236 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109586|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 109595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109595&action=edit Bug 25872: Fix translating interface from DB term to readable term When viewing the logs we try to swith the db values like 'cron' to friendly terms like 'Cron job' The values we use for building the selectors on the page ar eupper case, but DB values are lower case If we simply force upper case in the comparison we can ensure we always match correctly To test: 1 - Enable some 'Logs' setting in System preferences 2 - Perform some action in koha that will log Run a cronjob Change a syspref etc. 3 - Browse to Tools-> Log viewer 4 - Click 'Submit' to see all logs 5 - Note the 'Interface' column contains lower case DB values 6 - Apply patch 7 - Reload the page 8 - Values in interface are now Camel cased and more friendly Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:07:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:07:38 +0000 Subject: [Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 --- Comment #21 from Jonathan Druart --- Also can you confirm the following 3 errors are not valid? FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt FAIL forbidden patterns forbidden pattern: Do *not* include full path to js files, use the Asset TT plugin (bug 20538) (line 1174) forbidden pattern: Do *not* include full path to js files, use the Asset TT plugin (bug 20538) (line 1180) FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt FAIL forbidden patterns forbidden pattern: Do *not* include full path to js files, use the Asset TT plugin (bug 20538) (line 625) FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt FAIL forbidden patterns forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 124) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:08:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:08:17 +0000 Subject: [Koha-bugs] [Bug 26236] log viewer does not translate the interface properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26236 --- Comment #5 from Martin Renvoize --- Created attachment 109596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109596&action=edit Bug 26236: Fix translating interface from DB term to readable term When viewing the logs we try to swith the db values like 'cron' to friendly terms like 'Cron job' The values we use for building the selectors on the page ar eupper case, but DB values are lower case If we simply force upper case in the comparison we can ensure we always match correctly To test: 1 - Enable some 'Logs' setting in System preferences 2 - Perform some action in koha that will log Run a cronjob Change a syspref etc. 3 - Browse to Tools-> Log viewer 4 - Click 'Submit' to see all logs 5 - Note the 'Interface' column contains lower case DB values 6 - Apply patch 7 - Reload the page 8 - Values in interface are now Camel cased and more friendly Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:08:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:08:32 +0000 Subject: [Koha-bugs] [Bug 26236] log viewer does not translate the interface properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26236 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Attachment #109595|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:09:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:09:23 +0000 Subject: [Koha-bugs] [Bug 26236] log viewer does not translate the interface properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26236 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize --- Good catch, simple fix. I corrected the bug number in the commit message to match the bug here. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:12:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:12:32 +0000 Subject: [Koha-bugs] [Bug 17801] 'Top Most-circulated items' gives wrong results when filtering by checkout date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109588|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 109597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109597&action=edit Bug 17801: Use issuedate for limits in Most Circulated Items To test: 1 - Have two checkouts in old_issues issue 1: timestamp 2020-08-01 00:00:00, issuedate 2019-08-01 00:00:00 issue 2: timestamp 2020-07-01 00:00:00, issuedate 2019-07-01 00:00:00 2 - Perform a Most Circulated Items search for checkout dates 2020-06-01 to 2020-09-01. Both checkouts appear in search 3 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Neither checkout appears in search 4 - apply patch, restart all 5 - Repeat search with checkout dates 2020-06-01 to 2020-09-01. Neither checkout appears in search 6 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Both checkouts appears in search Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:13:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:13:52 +0000 Subject: [Koha-bugs] [Bug 17801] 'Top Most-circulated items' gives wrong results when filtering by checkout date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize --- Another nice old one to have squelched. Works well, trivial patch.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:16:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:16:25 +0000 Subject: [Koha-bugs] [Bug 10188] Top Most-circulated items doesn't count current loans In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10188 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Depends on|12628 |17801 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12628 [Bug 12628] reports/cat_issues_top.pl incorrect checkout range query https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 [Bug 17801] 'Top Most-circulated items' gives wrong results when filtering by checkout date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:16:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:16:27 +0000 Subject: [Koha-bugs] [Bug 26362] Overdue report shows incorrect branches for patron, holdingbranch, and homebranch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26362 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109570|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 109598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109598&action=edit Bug 26362: Show correct libraries in overdues report Currently the overdues report does the following display: Patron library = home branch Home library = holding branch Holding library = patron branch This patch corrects the display of libraries in the overdues report. To test: 0) Do not apply patch 1) Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 2) Go to http://localhost:8081/cgi-bin/koha/circ/set-library.pl 3) Choose "Troy" 4) http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 5) Checkout "39999000004571" with due date of "09/01/2019 23:59" Note the facts: Patron library = Centerville Home library = Fairview Holding library = Troy 6) Go to http://localhost:8081/cgi-bin/koha/circ/overdue.pl 7) Change "Columns" visibility to show Holding and Home libraries 8) Note that the libraries are incorrect: Patron library appears to be: Fairview Home library appears to be: Troy Holding library appears to be: Centerville 9) Apply the patch 10) koha-plack --restart kohadev 11) Go to http://localhost:8081/cgi-bin/koha/circ/overdue.pl 12) Change "Columns" visibility to show Holding and Home libraries 13) Note that the libraries are correct: Patron library appears to be: Centerville Home library appears to be: Fairview Holding library appears to be: Troy Signed-off-by: Emmi Takkinen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:16:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:16:25 +0000 Subject: [Koha-bugs] [Bug 12628] reports/cat_issues_top.pl incorrect checkout range query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12628 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10188 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10188 [Bug 10188] Top Most-circulated items doesn't count current loans -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:16:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:16:25 +0000 Subject: [Koha-bugs] [Bug 17801] 'Top Most-circulated items' gives wrong results when filtering by checkout date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10188 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10188 [Bug 10188] Top Most-circulated items doesn't count current loans -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:17:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:17:02 +0000 Subject: [Koha-bugs] [Bug 26362] Overdue report shows incorrect branches for patron, holdingbranch, and homebranch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26362 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- I'm amazed this hasn't been picked up before! Trivial patch, works as expected. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:17:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:17:04 +0000 Subject: [Koha-bugs] [Bug 17801] 'Top Most-circulated items' gives wrong results when filtering by checkout date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 --- Comment #8 from Fridolin SOMERS --- > Side note: the report does also not seem to count current checkouts as it avoids the issues table? See Bug 10188 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:18:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:18:01 +0000 Subject: [Koha-bugs] [Bug 12628] reports/cat_issues_top.pl incorrect checkout range query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12628 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS --- *** This bug has been marked as a duplicate of bug 17801 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:18:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:18:01 +0000 Subject: [Koha-bugs] [Bug 17801] 'Top Most-circulated items' gives wrong results when filtering by checkout date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |micah.bucy at eternalsword.com --- Comment #9 from Fridolin SOMERS --- *** Bug 12628 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:28:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:28:53 +0000 Subject: [Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 --- Comment #22 from Jonathan Druart --- 1. https://snipboard.io/9kNAL8.jpg Don't you think the login inputs are too wide? 2. https://snipboard.io/TlIkcu.jpg The relevance dropdown is too wide 3. https://snipboard.io/apKe35.jpg Why did you change the order of the filters at the bottom of the adv search page? 4. https://snipboard.io/vq2I57.jpg The [+][i] links don't behave correctly. This is the screen after 1 click on [+] 5. https://snipboard.io/H3xOZK.jpg I was surprised by the brightness of the green and noticed that there is a change. Compare the "Go" button (in the header): background-color: #85ca11; background-image: linear-gradient(180deg,#85ca11,#77b50f); background-position: 0; With now: background-color: #71ac0e; background-image: linear-gradient(180deg,#7dbf0f,#71ac0e); border-color: #61940c; box-shadow: 0 0 0 1px #7dbf0f; Is that expected? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:29:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:29:03 +0000 Subject: [Koha-bugs] [Bug 10188] Top Most-circulated items doesn't count current loans In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10188 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:33:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:33:12 +0000 Subject: [Koha-bugs] [Bug 21670] t/db_dependent/Plugins.t is failing randomly on Jenkins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21670 --- Comment #5 from Jonathan Druart --- Koha_Master_U16 #57 (Docker_2) 10:56:49 koha_1 | Could not unlink /tmp/v0mm3n9/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm.pm: No such file or directory at /kohadevbox/koha/Koha/Plugins/Handler.pm line 106. 10:56:49 koha_1 | 10:56:49 koha_1 | # Failed test 'Koha::Plugins::Handler::delete works correctly.' 10:56:49 koha_1 | # at t/db_dependent/Koha/Plugins/Plugins.t line 270. 10:56:49 koha_1 | # Looks like you failed 1 test of 53. 10:56:49 koha_1 | [08:56:49] t/db_dependent/Koha/Plugins/Plugins.t ................................... 10:56:49 koha_1 | Dubious, test returned 1 (wstat 256, 0x100) 10:56:49 koha_1 | Failed 1/53 subtests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:42:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:42:45 +0000 Subject: [Koha-bugs] [Bug 25384] Label maker font list is not configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #15 from Fridolin SOMERS --- Nice job ;) Since default font in koha-conf.xml is "DejaVu", shouldn't we define it as default for font names, instead of MS-non-opensource fonts "Times-Roman", ... ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:43:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:43:09 +0000 Subject: [Koha-bugs] [Bug 10188] Top Most-circulated items doesn't count current loans In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10188 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:47:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:47:13 +0000 Subject: [Koha-bugs] [Bug 26350] Librarians can request discharge on behalf of patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Passed QA |In Discussion --- Comment #7 from Jonathan Druart --- Hi Dobrica, good to see you around :) Can you explain the use case please, I am not sure I understand it. If a librarian wants to let a patron download their discharge from the OPAC, the librarian can generate the discharge from the staff interface. The patron will then see a "Get your discharge" link on their account. I don't see the point of this extra step actually: a librarian request a discharge which will need to be approved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:53:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:53:13 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #274 from Marcel de Rooy --- Completely other observation: Just noticing on my test server that process beam.smp used quite a bit CPU at some point while there was nothing going on in terms of background processes. Googling beam.smp brings you right to such things. Reason for being more cautious? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:53:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:53:37 +0000 Subject: [Koha-bugs] [Bug 26364] New: XISBN.t makes a bad assumption about return values Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26364 Bug ID: 26364 Summary: XISBN.t makes a bad assumption about return values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org 75 eval { $results_thingisbn = C4::XISBN::get_xisbns($isbn1,$biblionumber3); }; 76 SKIP: { 77 skip "Problem retrieving ThingISBN", 1 78 unless $@ eq ''; 79 is( $results_thingisbn->[0]->{biblionumber}, 80 undef, 81 "Doesn't get biblionumber if the biblionumber matches the one passed to the sub." ); 82 } Here we are testing that we don't get the same book that we passed into the sub in the list that is returned, however, we shouldn't assume that we get nothing, we should just check that it is not the biblionumber we passed in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:56:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:56:04 +0000 Subject: [Koha-bugs] [Bug 26365] New: Koha/Acquisition/Order.t is failing with MySQL 8 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26365 Bug ID: 26365 Summary: Koha/Acquisition/Order.t is failing with MySQL 8 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org t/db_dependent/Koha/Acquisition/Order.t .. 10/11 No method count found for Koha::Acquisition::Orders DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Incorrect DATE value: '0000-00-00' [for Statement "SELECT COUNT( * ) FROM `aqorders` `me` WHERE ( ( ( `datecancellationprinted` IS NULL OR `datecancellationprinted` = ? ) AND `ordernumber` IN ( ?, ?, ? ) ) )" with ParamValues: 0='0000-00-00', 1=23, 2=24, 3=25] at /kohadevbox/koha/Koha/Objects.pm line 597 We must remove the comparison with 0000-00-00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:56:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:56:22 +0000 Subject: [Koha-bugs] [Bug 26365] Koha/Acquisition/Order.t is failing with MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26365 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23166 --- Comment #1 from Jonathan Druart --- Highlighted by bug 23166. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 [Bug 23166] Simplify code related to orders in catalogue/*detail.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:56:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:56:22 +0000 Subject: [Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26365 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26365 [Bug 26365] Koha/Acquisition/Order.t is failing with MySQL 8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:56:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:56:33 +0000 Subject: [Koha-bugs] [Bug 26365] Koha/Acquisition/Order.t is failing with MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26365 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23996 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 [Bug 23996] MySQL 8 support [Omnibus] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:56:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:56:33 +0000 Subject: [Koha-bugs] [Bug 23996] MySQL 8 support [Omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26365 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26365 [Bug 26365] Koha/Acquisition/Order.t is failing with MySQL 8 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:59:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:59:23 +0000 Subject: [Koha-bugs] [Bug 26364] XISBN.t makes a bad assumption about return values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26364 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:59:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:59:27 +0000 Subject: [Koha-bugs] [Bug 26364] XISBN.t makes a bad assumption about return values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26364 --- Comment #1 from Nick Clemens --- Created attachment 109599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109599&action=edit Bug 26364: Check that return value isn't the value we don't want. Don't check for undef It seems sometimes we get an ISBN returned that matches a book in the sample data. One of the Harry Potter books was matching the ISBN. Our real concern is not that we get nothing, but that we don't get the same value we pass in. We should test for that To test: 1 - prove -v t/db_dependent/XISBN.t 2 - The failures are not consistent, so read the code and ensure we are making sense -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:59:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:59:54 +0000 Subject: [Koha-bugs] [Bug 26365] Koha/Acquisition/Order.t is failing with MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26365 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 11:59:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 09:59:57 +0000 Subject: [Koha-bugs] [Bug 26365] Koha/Acquisition/Order.t is failing with MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26365 --- Comment #2 from Jonathan Druart --- Created attachment 109600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109600&action=edit Bug 26365: Remove comparison with 0000-00-00 for datecancellationprinted Using MySQL 8: t/db_dependent/Koha/Acquisition/Order.t .. 10/11 No method count found for Koha::Acquisition::Orders DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Incorrect DATE value: '0000-00-00' [for Statement "SELECT COUNT( * ) FROM `aqorders` `me` WHERE ( ( ( `datecancellationprinted` IS NULL OR `datecancellationprinted` = ? ) AND `ordernumber` IN ( ?, ?, ? ) ) )" with ParamValues: 0='0000-00-00', 1=23, 2=24, 3=25] at /kohadevbox/koha/Koha/Objects.pm line 597 We must remove the comparison with 0000-00-00 Highlighted by bug 23166. I wanted to provide a DB rev but we (obviously) cannot: MySQL [koha_kohadev]> UPDATE aqorders SET datecancellationprinted=NULL WHERE datecancellationprinted="0000-00-00"; ERROR 1292 (22007): Incorrect date value: '0000-00-00' for column 'datecancellationprinted' at row 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 12:06:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 10:06:48 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #275 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #274) > Completely other observation: Just noticing on my test server that process > beam.smp used quite a bit CPU at some point while there was nothing going on > in terms of background processes. Googling beam.smp brings you right to such > things. Reason for being more cautious? Looks like it's coming from the client. Did you play with rabbitmq "manually" or only via the Koha interface? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 12:13:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 10:13:43 +0000 Subject: [Koha-bugs] [Bug 25969] Checking in a found hold at a different branch then confirming the hold causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25969 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |nick at bywatersolutions.com --- Comment #7 from Nick Clemens --- (In reply to Sally from comment #6) > This patch works if you check in using the the 'check in' function in the > main search bar. > > However, if you use the check in at: cgi-bin/koha/circ/returns.pl - then you > still get the same ISE as before the patch is applied: > > Can't call method "biblio" on an undefined value at > /kohadevbox/koha/circ/returns.pl line 148 > in (eval) at /kohadevbox/koha/circ/returns.pl line 148 > 145: my $cancel_reserve = $query->pa I cannot recreate this, can you test again and explain the steps? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 12:15:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 10:15:13 +0000 Subject: [Koha-bugs] [Bug 26366] New: system preperence no option usekohaplugin enable/disable option Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26366 Bug ID: 26366 Summary: system preperence no option usekohaplugin enable/disable option Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: librarian at sageuniversity.in QA Contact: testopia at bugs.koha-community.org Dear Sir I am use koha version 20.05 but no option enable/disable system preference.please check -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 12:21:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 10:21:13 +0000 Subject: [Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109155|0 |1 is obsolete| | Attachment #109156|0 |1 is obsolete| | Attachment #109157|0 |1 is obsolete| | Attachment #109158|0 |1 is obsolete| | Attachment #109159|0 |1 is obsolete| | Attachment #109160|0 |1 is obsolete| | Attachment #109161|0 |1 is obsolete| | Attachment #109162|0 |1 is obsolete| | Attachment #109163|0 |1 is obsolete| | Attachment #109164|0 |1 is obsolete| | Attachment #109165|0 |1 is obsolete| | Attachment #109166|0 |1 is obsolete| | Attachment #109167|0 |1 is obsolete| | Attachment #109168|0 |1 is obsolete| | Attachment #109169|0 |1 is obsolete| | Attachment #109170|0 |1 is obsolete| | --- Comment #145 from Kyle M Hall --- Created attachment 109601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109601&action=edit Bug 22343: Add a new table to store SMTP servers configs This patch adds a new table to store SMTP servers configs. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 12:21:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 10:21:42 +0000 Subject: [Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #146 from Kyle M Hall --- Created attachment 109602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109602&action=edit Bug 22343: Add parameters => manage_smtp_servers subpermission This patch introduces a new subpermission for managing SMTP servers, for granularity. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 12:21:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 10:21:51 +0000 Subject: [Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #147 from Kyle M Hall --- Created attachment 109603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109603&action=edit Bug 22343: Add new tables schema file Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 12:21:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 10:21:54 +0000 Subject: [Koha-bugs] [Bug 26271] Call to /api/v1/patrons//account returns 500 error if manager_id is NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26271 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |joonas.kylmala at helsinki.fi |ity.org | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 12:22:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 10:22:01 +0000 Subject: [Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #148 from Kyle M Hall --- Created attachment 109604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109604&action=edit Bug 22343: DBIx::Class schema updates [DO NOT PUSH] Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 12:22:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 10:22:08 +0000 Subject: [Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #149 from Kyle M Hall --- Created attachment 109605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109605&action=edit Bug 22343: Add classes for handling SMTP servers This patch introduces classes to handle SMTP servers. It is done in a way that a default server can be set, and then per-library ones can be set. All should be done with Koha::SMTP::Servers methods, that take care of overwriting library-specific configs, and handle the defaults retrieval and setting correctly. To test: 1. Apply this patches 2. Run: $ kshell $ perl installer/data/mysql/updatedatabase.pl => SUCCESS: Atomic update is ok, smtp_servers table created 3. Run: k$ prove t/db_dependent/Koha/SMTP/ => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 12:22:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 10:22:14 +0000 Subject: [Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #150 from Kyle M Hall --- Created attachment 109606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109606&action=edit Bug 22343: Add Koha::Library->smtp_server Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 12:22:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 10:22:18 +0000 Subject: [Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #151 from Kyle M Hall --- Created attachment 109607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109607&action=edit Bug 22343: Update cpanfile Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 12:22:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 10:22:27 +0000 Subject: [Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #152 from Kyle M Hall --- Created attachment 109608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109608&action=edit Bug 22343: API routes for SMTP servers CRUD This patch introduces API routes for handling SMTP servers. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 12:22:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 10:22:36 +0000 Subject: [Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #153 from Kyle M Hall --- Created attachment 109609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109609&action=edit Bug 22343: Add CRUD page for SMTP servers This patch introduces a way to define SMTP servers either globally or per-library. To test: 1. Apply this patch 2. Find the SMTP servers entry in the admin page 3. Play with adding/removing SMTP servers => SUCCESS: All works as expected 4. Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 12:22:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 10:22:44 +0000 Subject: [Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #154 from Kyle M Hall --- Created attachment 109610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109610&action=edit Bug 22343: Revamped Koha::Email class This patch completely rewrites the Koha::Email class, inheriting from Email::Stuffer. The latter suits well the use by Email::Sender, which is to replace Mail::Sendmail on this patchset. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/Email.t => SUCCESS: Tests pass! 3. Verify all conditional codepaths are covered 4. Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 12:22:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 10:22:49 +0000 Subject: [Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #155 from Kyle M Hall --- Created attachment 109611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109611&action=edit Bug 22343: Make C4::Letters use the new SMTP server config This patch makes the different methods in C4::Letters use: - Koha::SMTP::Servers: to get the effective SMTP server for the library or the fallback default if no library in context. - New Koha::Email->create method for crafting the email envelope for sending. The tests are adapted so they behave the same way, but the trapped (in the mock) $email object has the right type and its attributes are accessed correctly. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Letters.t => SUCCESS: Tests pass. YAY! 3. Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 12:22:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 10:22:54 +0000 Subject: [Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #156 from Kyle M Hall --- Created attachment 109612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109612&action=edit Bug 22343: Adapt Koha::Illrequest This patch makes Koha::Illrequest use the new syntax for Koha::Email and sending the email. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 12:23:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 10:23:07 +0000 Subject: [Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #157 from Kyle M Hall --- Created attachment 109613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109613&action=edit Bug 22343: Adapt controller scripts This patch adapts controller scripts that used sendmail. Also the syntax for Koha::Email has changed and this patch adapts it. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 12:23:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 10:23:19 +0000 Subject: [Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #158 from Kyle M Hall --- Created attachment 109614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109614&action=edit Bug 22343: Adapt runreport.pl This script gets adapted to use the new Koha::Email syntax and SMTP transport. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 12:23:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 10:23:24 +0000 Subject: [Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #159 from Kyle M Hall --- Created attachment 109615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109615&action=edit Bug 22343: Prevent passing password to the UI Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 12:23:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 10:23:33 +0000 Subject: [Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #160 from Kyle M Hall --- Created attachment 109616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109616&action=edit Bug 22343: Allow choosing an SMTP server in branches.pl The missing piece on this patchset is choosing the desired SMTP server for each library. This patch adds the option on editing the library. The default one is picked for existing libraries, and you can pick the one you want. To test: 1. Apply the patchset 2. Run: $ updatedatabase => SUCCESS: Things go smooth 3. Notice the new permission for managing SMTP servers 4. Notice the entry in the admin page 5. Add/have a few SMTP servers defined. 6. Edit a library => SUCCESS: The 'Default' SMTP server is picked 7. Choose any server and save => SUCCESS: Saving doesn't explode 8. Edit the server => SUCCESS: Your selection is kept (this can also be checked on the DB, the library_smtp_server table) 9. Try (7) with many different options => SUCCESS: It works 10. Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 12:25:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 10:25:41 +0000 Subject: [Koha-bugs] [Bug 26350] Librarians can request discharge on behalf of patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 --- Comment #8 from Dobrica Pavlinusic --- That is true for the first discharge. After that, Generate discharge will always return just last discharge. If patron restriction is removed, patrons can request another discharge on opac, but librarians can't do that in current implementation. We are discharging students at the end of every year and sending discharges to the student services, so that students can enroll in next year. For us, it's essential to be able to generate discharge even if there is existing one, without the need for a student to do anything since we do have students with special needs which are unable to use opac (or web at all). After students enroll in the next year, we remove patron restriction and repeat the whole process for each year they are with us. Does this make more sense now? For us, librarians who request discharges are not the same ones who will allow it. We have local changes that also track librarian borrowernumber to be able to print name of a librarian who approved a discharge, but that will require cleanup (and implementation of permissions) before we can submit that part. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 12:56:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 10:56:01 +0000 Subject: [Koha-bugs] [Bug 25786] Holds Queue building may target the wrong item for item level requests that match holds queue priority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25786 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #11 from Nick Clemens --- (In reply to Aleisha Amohia from comment #10) > can backport once the tests are fixed on Bug 25783 Hi Alicia, Kyle fixed the tests on 25783 - can you test? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 13:05:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 11:05:37 +0000 Subject: [Koha-bugs] [Bug 26271] Call to /api/v1/patrons//account returns 500 error if manager_id is NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26271 --- Comment #10 from Jonathan Druart --- That is something I was expected for a while. We are going to face this problem again and again. We need a test to compare the API definition and the DB schema (datatype and nullable). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 13:15:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 11:15:42 +0000 Subject: [Koha-bugs] [Bug 26290] Allow setting default SMTP parameters in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26290 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 13:15:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 11:15:46 +0000 Subject: [Koha-bugs] [Bug 26290] Allow setting default SMTP parameters in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26290 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109035|0 |1 is obsolete| | Attachment #109036|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 109617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109617&action=edit Bug 26290: Add option forsetting default SMTP parameters in koha-conf.xml This patch adds an entry to koha-conf.xml for setting a default SMTP server config. 'koha-create' gets option switches for all options. To test: 1. Use the tweaked script to crete a new instance 2. Notice it contains entries for smtp_server and they respect your options. 3. If you don't choose any option, it sets the current default. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 13:16:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 11:16:11 +0000 Subject: [Koha-bugs] [Bug 26290] Allow setting default SMTP parameters in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26290 --- Comment #4 from Kyle M Hall --- Created attachment 109618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109618&action=edit Bug 26290: Make Koha::SMTP::Servers->get_default use koha-conf.xml This patch makes the mentioned method use the configured entry in koha-conf.xml if present, instead of the hardcoded one, which is kept for people that carries an old koha-conf.xml Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 13:16:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 11:16:40 +0000 Subject: [Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 13:18:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 11:18:18 +0000 Subject: [Koha-bugs] [Bug 25712] Add plugin hooks to transform patron and item barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25712 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26351 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 13:18:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 11:18:18 +0000 Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25712 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 13:18:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 11:18:22 +0000 Subject: [Koha-bugs] [Bug 26309] Elasticsearch cxn_pool must be configurable (again) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26309 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |21974, 24823 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21974 [Bug 21974] cxn_pool must be configurable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823 [Bug 24823] Drop Catmandu dependency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 13:18:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 11:18:22 +0000 Subject: [Koha-bugs] [Bug 21974] cxn_pool must be configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21974 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26309 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26309 [Bug 26309] Elasticsearch cxn_pool must be configurable (again) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 13:18:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 11:18:22 +0000 Subject: [Koha-bugs] [Bug 24823] Drop Catmandu dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26309 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26309 [Bug 26309] Elasticsearch cxn_pool must be configurable (again) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 13:20:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 11:20:18 +0000 Subject: [Koha-bugs] [Bug 26331] svc/letters/preview is not executable which prevents CGI functioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26331 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 13:20:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 11:20:26 +0000 Subject: [Koha-bugs] [Bug 19382] Add ability to block guarantees based on fees owed by guarantor and other guarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 13:27:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 11:27:05 +0000 Subject: [Koha-bugs] [Bug 26299] Help text for OPAC SMS number should be less North American-centric In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109183|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 13:28:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 11:28:41 +0000 Subject: [Koha-bugs] [Bug 26299] Help text for OPAC SMS number should be less North American-centric In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #9 from Jonathan Druart --- (In reply to David Cook from comment #7) > (In reply to Nick Clemens from comment #6) > > (In reply to Jonathan Druart from comment #4) > > > Nick, are you ok with this? > > > > I checked with our educators - their concern is that it not start with 1, > > which is the indicator of 'long distance' calls here. > > > > 9785550123 would be better as it won't end up being a real phone number > > https://en.wikipedia.org/wiki/555_(telephone_number) > > That's an interesting point. > > Maybe we should just change the wording (in both interfaces) to something > like... > > "Please enter numbers only. Prefix the number with + if including the > country code." > > After that, the Javascript validation messages should provide enough > formatting information? I think this is the best solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 13:32:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 11:32:33 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #276 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #275) > (In reply to Marcel de Rooy from comment #274) > > Completely other observation: Just noticing on my test server that process > > beam.smp used quite a bit CPU at some point while there was nothing going on > > in terms of background processes. Googling beam.smp brings you right to such > > things. Reason for being more cautious? > > Looks like it's coming from the client. Did you play with rabbitmq > "manually" or only via the Koha interface? Not exactly sure anymore. Nothing noteworthy, I guess. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 13:47:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 11:47:11 +0000 Subject: [Koha-bugs] [Bug 26041] Accessibility: The date picker calendar is not keyboard accessible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26041 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #18 from Jonathan Druart --- 2 Questions: 1. Why is this change only affecting the OPAC? 2. To me it's still not really "accessible", if you create a new account the current date is selected. How do you pick a date from, say, year 1980? Select year dropdown list still cannot be selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 14:02:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 12:02:51 +0000 Subject: [Koha-bugs] [Bug 25384] Label maker font list is not configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 --- Comment #16 from Chris Nighswonger --- (In reply to Fridolin SOMERS from comment #15) > Nice job ;) > > Since default font in koha-conf.xml is "DejaVu", shouldn't we define it as > default for font names, instead of MS-non-opensource fonts "Times-Roman", > ... ? DejaVu does not appear to be one of the 14 base fonts. Be careful about making this change before understanding how PDFs and these fonts relate. Here are a couple of resources: https://kbpdfstudio.qoppa.com/standard-14-pdf-fonts/ https://www.adobe.com/devnet/font.html Switching to a non-base font could cause problems on some systems. The pdf code in Koha is set to embed fonts which should avoid most potential issues. But we should be aware that defaulting to a non-base font "might" introduce an issue depending on the system used to open the resulting PDF. FTR: This is not an objection to Fridolin's suggestion. I'm all for cutting MS out of the picture altogether whenever possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 14:10:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 12:10:15 +0000 Subject: [Koha-bugs] [Bug 24197] Custom destination for failed overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 --- Comment #21 from Jonathan Druart --- Not blocker but: shouldn't have it been defined at library level instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 14:11:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 12:11:44 +0000 Subject: [Koha-bugs] [Bug 26367] New: Warn in HoldsQueue if request itemtype set but request is not item specific Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 Bug ID: 26367 Summary: Warn in HoldsQueue if request itemtype set but request is not item specific Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com To recreate: 0 - set AllowHoldItemTypeSelection to 'Allow' 1 - Place a title level hold for a record with an item from Library A for delivery at Library A for a patron from Library A with an itemtype specified 2 - perl misc/cronjobs/holds/build_holds_queue.pl 3 - There are warns: Use of uninitialized value in hash element at /kohadevbox/koha/C4/HoldsQueue.pm line 523. Use of uninitialized value in string eq at /kohadevbox/koha/C4/HoldsQueue.pm line 523. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 14:12:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 12:12:37 +0000 Subject: [Koha-bugs] [Bug 23682] Add ability to manually import EDI invoices as an alternative to automatic importing on download In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23682 --- Comment #21 from Jonathan Druart --- Created attachment 109619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109619&action=edit Bug 23682: Fix use Koha::Plugins::Handler statements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 14:15:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 12:15:56 +0000 Subject: [Koha-bugs] [Bug 20804] Sanitize input of timeout syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20804 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #4 from Fridolin SOMERS --- > 1. Fill the timeout syspref with "5m" But minutes are not supported, only days and hours. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 14:19:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 12:19:29 +0000 Subject: [Koha-bugs] [Bug 26367] Warn in HoldsQueue if request itemtype set but request is not item specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 14:19:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 12:19:32 +0000 Subject: [Koha-bugs] [Bug 26367] Warn in HoldsQueue if request itemtype set but request is not item specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 --- Comment #1 from Nick Clemens --- Created attachment 109620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109620&action=edit Bug 26367: Unit test This warn only appears when: The borrower and item branches match AND The hold fulfillment policy is any or the pickupbranch matches the items branch specified by hold_fulfillment_policy AND The request has an itemtype set To trigger we simply add some itemtype to existing hold requests in the test To test: 1 - prove -v t/db_dependent/HoldsQueue.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 14:19:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 12:19:36 +0000 Subject: [Koha-bugs] [Bug 26367] Warn in HoldsQueue if request itemtype set but request is not item specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 --- Comment #2 from Nick Clemens --- Created attachment 109621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109621&action=edit Bug 26367: Prevent warn about undefined values when record level hold has an itemtype To test: 1 - set AllowHoldItemTypeSelection to 'Allow' 2 - Find a patron from Library A 3 - Find a record with an item from Library A 4 - Place a title level hold with itemtype specified for a delivery at Library A for patron and record above 5 - perl misc/cronjobs/holds/build_holds_queue.pl 6 - There are warns: Use of uninitialized value in hash element at /kohadevbox/koha/C4/HoldsQueue.pm line 523. Use of uninitialized value in string eq at /kohadevbox/koha/C4/HoldsQueue.pm line 523 7 - Apply this patch 8 - perl misc/cronjobs/holds/build_holds_queue.pl 9 - No more warns! 10 - prove -v t/db_dependent/HoldsQueue.t 11 - All tests pass! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 14:20:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 12:20:25 +0000 Subject: [Koha-bugs] [Bug 26367] Warn in HoldsQueue if request itemtype set but request is not item specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 14:29:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 12:29:04 +0000 Subject: [Koha-bugs] [Bug 20804] Sanitize input of timeout syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20804 --- Comment #5 from Fridolin SOMERS --- Also if invalid value, warn will be logged at each page. I'd say we better tell default behavior in system preference description. Also add in the description you can use h/H for hours. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 14:33:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 12:33:59 +0000 Subject: [Koha-bugs] [Bug 19382] Add ability to block guarantees based on fees owed by guarantor and other guarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382 --- Comment #30 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #29) > This is confusing to me. > First, child_1 is not a guarantor so only_this_guarantor should not modify > the returned value. Then, in the same logic, only_this_guarantor should not > have any effects if include_guarantors is not set. > > Asking Tomas and Martin for additional feedbacks. Shouldn't we just throw an exception on bad combination of parameters? If patron is not a guarantor, we should throw a Koha::Exception::BadParameter if 'only_this_guarantor' is passed, right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 14:37:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 12:37:36 +0000 Subject: [Koha-bugs] [Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974 --- Comment #64 from Nick Clemens --- FWIW - the atomicupdate here is not idempotent, possibly too late, but noting in case anyone is hit by this -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 14:45:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 12:45:31 +0000 Subject: [Koha-bugs] [Bug 26368] New: Add support for OCLC Encoding level values Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26368 Bug ID: 26368 Summary: Add support for OCLC Encoding level values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl https://www.oclc.org/bibformats/en/fixedfield/elvl.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 14:47:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 12:47:42 +0000 Subject: [Koha-bugs] [Bug 23475] Search context is lost when simple search leads to a single record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #11 from Fridolin SOMERS --- Nice work. In my opinion cookie name "pulldown_selection" is too generic. I propose you use a prefix like "cat_search". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 14:53:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 12:53:24 +0000 Subject: [Koha-bugs] [Bug 26368] Add support for OCLC Encoding level values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26368 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 14:53:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 12:53:28 +0000 Subject: [Koha-bugs] [Bug 26368] Add support for OCLC Encoding level values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26368 --- Comment #1 from Nick Clemens --- Created attachment 109622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109622&action=edit Bug 26368: Add OCLC options to marc21_leader.tt See documentation at: https://www.oclc.org/bibformats/en/fixedfield/elvl.html To test: 1 - Apply patch 2 - Edit a record 3 - Edit the leader 4 - Note the new options 5 - Set the value of encodign level to the new options and save 6 - Edit again 7 - Confirm the value is displayed correctly selected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 14:55:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 12:55:33 +0000 Subject: [Koha-bugs] [Bug 26137] Warn on malformed param on log viewer (viewlog.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26137 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #2 from Fridolin SOMERS --- > my $subscriptionsnumber = CountSubscriptionFromBiblionumber(scalar $input->param('object')); Why not CountSubscriptionFromBiblionumber($object) ? And if object is empty maybe not call this method. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:04:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:04:06 +0000 Subject: [Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:04:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:04:10 +0000 Subject: [Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 --- Comment #77 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:04:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:04:14 +0000 Subject: [Koha-bugs] [Bug 17801] 'Top Most-circulated items' gives wrong results when filtering by checkout date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:04:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:04:18 +0000 Subject: [Koha-bugs] [Bug 17801] 'Top Most-circulated items' gives wrong results when filtering by checkout date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 --- Comment #10 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:04:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:04:21 +0000 Subject: [Koha-bugs] [Bug 23682] Add ability to manually import EDI invoices as an alternative to automatic importing on download In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23682 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:04:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:04:25 +0000 Subject: [Koha-bugs] [Bug 23682] Add ability to manually import EDI invoices as an alternative to automatic importing on download In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23682 --- Comment #22 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:04:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:04:27 +0000 Subject: [Koha-bugs] [Bug 24197] Custom destination for failed overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:04:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:04:30 +0000 Subject: [Koha-bugs] [Bug 24197] Custom destination for failed overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 --- Comment #22 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:04:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:04:33 +0000 Subject: [Koha-bugs] [Bug 25541] Add ability to prevent checkin via SIP of items with holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:04:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:04:36 +0000 Subject: [Koha-bugs] [Bug 25541] Add ability to prevent checkin via SIP of items with holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 --- Comment #17 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:04:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:04:39 +0000 Subject: [Koha-bugs] [Bug 26041] Accessibility: The date picker calendar is not keyboard accessible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26041 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:04:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:04:42 +0000 Subject: [Koha-bugs] [Bug 26041] Accessibility: The date picker calendar is not keyboard accessible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26041 --- Comment #19 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:04:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:04:45 +0000 Subject: [Koha-bugs] [Bug 26236] log viewer does not translate the interface properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26236 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:04:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:04:49 +0000 Subject: [Koha-bugs] [Bug 26236] log viewer does not translate the interface properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26236 --- Comment #7 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:04:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:04:51 +0000 Subject: [Koha-bugs] [Bug 26271] Call to /api/v1/patrons//account returns 500 error if manager_id is NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26271 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:04:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:04:54 +0000 Subject: [Koha-bugs] [Bug 26271] Call to /api/v1/patrons//account returns 500 error if manager_id is NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26271 --- Comment #11 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:04:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:04:56 +0000 Subject: [Koha-bugs] [Bug 26309] Elasticsearch cxn_pool must be configurable (again) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26309 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:04:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:04:59 +0000 Subject: [Koha-bugs] [Bug 26309] Elasticsearch cxn_pool must be configurable (again) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26309 --- Comment #9 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:05:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:05:02 +0000 Subject: [Koha-bugs] [Bug 26313] "Show analytics" and "Show volumes" links don't work with Elasticsearch and UseControlNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:05:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:05:04 +0000 Subject: [Koha-bugs] [Bug 26313] "Show analytics" and "Show volumes" links don't work with Elasticsearch and UseControlNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 --- Comment #10 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:05:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:05:07 +0000 Subject: [Koha-bugs] [Bug 26331] svc/letters/preview is not executable which prevents CGI functioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26331 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:05:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:05:10 +0000 Subject: [Koha-bugs] [Bug 26331] svc/letters/preview is not executable which prevents CGI functioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26331 --- Comment #6 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:05:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:05:12 +0000 Subject: [Koha-bugs] [Bug 26362] Overdue report shows incorrect branches for patron, holdingbranch, and homebranch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26362 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:05:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:05:14 +0000 Subject: [Koha-bugs] [Bug 26362] Overdue report shows incorrect branches for patron, holdingbranch, and homebranch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26362 --- Comment #5 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:05:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:05:33 +0000 Subject: [Koha-bugs] [Bug 26369] New: Set use_zebra_facets to 0 in the templates Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26369 Bug ID: 26369 Summary: Set use_zebra_facets to 0 in the templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com bug 13665 points out performance issues of zebra facets, let's not enable them by default -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:06:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:06:53 +0000 Subject: [Koha-bugs] [Bug 26369] Set use_zebra_facets to 0 in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26369 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:06:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:06:55 +0000 Subject: [Koha-bugs] [Bug 26369] Set use_zebra_facets to 0 in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26369 --- Comment #1 from Nick Clemens --- Created attachment 109623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109623&action=edit Bug 26369: Set use_zebra_facets to 0 in templates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:21:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:21:48 +0000 Subject: [Koha-bugs] [Bug 23475] Search context is lost when simple search leads to a single record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 --- Comment #12 from Nick Clemens --- Created attachment 109624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109624&action=edit Bug 23475: Make cookie name more explicit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:29:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:29:12 +0000 Subject: [Koha-bugs] [Bug 26361] JS error on returns.tt in 20.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26361 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:35:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:35:39 +0000 Subject: [Koha-bugs] [Bug 26299] Help text for OPAC SMS number should be less North American-centric In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:35:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:35:44 +0000 Subject: [Koha-bugs] [Bug 26299] Help text for OPAC SMS number should be less North American-centric In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109191|0 |1 is obsolete| | --- Comment #10 from Nick Clemens --- Created attachment 109625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109625&action=edit Bug 26299: Use same SMS number help text in OPAC as staff interface The SMS number help text in the OPAC follows a North American phone number style. It should be more generic. To that end, this patch makes the OPAC use the same help text for SMS numbers as the staff interface To test: 1) Apply the patch 2) Set "SMSSendDriver" to "Anything" in global system preferences 3) Go to the following link and note the help text by SMS number http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 4) Go to http://localhost:8080/cgi-bin/koha/opac-messaging.pl 5) Note that the help text in both interfaces uses the same wording -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:37:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:37:36 +0000 Subject: [Koha-bugs] [Bug 26312] Add some error handling during Elasticsearch indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26312 --- Comment #3 from Nick Clemens --- (In reply to Fridolin SOMERS from comment #2) > Very nice. > > Why add "use Try::Tiny" in misc/search_tools/rebuild_elasticsearch.pl ? Otherwise the try/catch doesn't work with the values returned from Indexer.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:47:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:47:46 +0000 Subject: [Koha-bugs] [Bug 26312] Add some error handling during Elasticsearch indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26312 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109241|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 109626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109626&action=edit Bug 26312: Catch ES Client errors, log, and continue indexing when error encountered This catches a timeout response from the ES server, logs this, and continues the indexing To test: 1 - perl misc/search_tools/rebuild_elasticsearch.pl 2 - Make the ES server timeout (I don't have good instruction yet) 3 - Watch the job crash 4 - Apply patches 5 - perl misc/search_tools/rebuild_elasticsearch.pl 6 - Make the server timeout 7 - Note the job reports failed commit, and continues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 15:50:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 13:50:27 +0000 Subject: [Koha-bugs] [Bug 26364] XISBN.t makes a bad assumption about return values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26364 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 16:00:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 14:00:34 +0000 Subject: [Koha-bugs] [Bug 26323] Not_for_loan, damaged, location and ccode values must be retrieved from the correct AV category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal Status|NEW |ASSIGNED Assignee|didier.gautheron at biblibre.c |jonathan.druart at bugs.koha-c |om |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org Summary|NOT_LOAN is hard-code in |Not_for_loan, damaged, |templates but many UNIMARC |location and ccode values |installs are using ETAT as |must be retrieved from the |authorized values category |correct AV category --- Comment #1 from Jonathan Druart --- Looks like this is also needed for LOC, DAMAGED, LOC and CCODE. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 16:05:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 14:05:01 +0000 Subject: [Koha-bugs] [Bug 26361] JS error on returns.tt in 20.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26361 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Who signed the| |20.05.04 patch off| | --- Comment #8 from Lucas Gass --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 16:09:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 14:09:14 +0000 Subject: [Koha-bugs] [Bug 26323] Not_for_loan, damaged, location and ccode values must be retrieved from the correct AV category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 16:09:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 14:09:18 +0000 Subject: [Koha-bugs] [Bug 26323] Not_for_loan, damaged, location and ccode values must be retrieved from the correct AV category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 --- Comment #2 from Jonathan Druart --- Created attachment 109627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109627&action=edit Bug 26323: Retrieve the correct NOT_LOAN value >From the template we are assuming that items.notforloan is mapped with the NOT_LOAN authorised value category, but that is not necessarily the case. We must retrieve the correct AV category -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 16:09:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 14:09:24 +0000 Subject: [Koha-bugs] [Bug 26323] Not_for_loan, damaged, location and ccode values must be retrieved from the correct AV category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 --- Comment #3 from Jonathan Druart --- Created attachment 109628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109628&action=edit Bug 26323: Retrieve the correct values for LOC, DAMAGED, LOC and CCODE Same as previously -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 16:11:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 14:11:00 +0000 Subject: [Koha-bugs] [Bug 26323] Not_for_loan, damaged, location and ccode values must be retrieved from the correct AV category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 --- Comment #4 from Jonathan Druart --- This will be tricky to test, that's why I hadn't provided a test plan. You should test some of the modified occurrences and confirmed it displays the correct value. Also read the diff and search for typos! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 16:13:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 14:13:30 +0000 Subject: [Koha-bugs] [Bug 26364] XISBN.t makes a bad assumption about return values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26364 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |nick at bywatersolutions.com --- Comment #2 from Jonathan Druart --- Can you explain? Is it an alternative patch for bug 26270? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 16:13:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 14:13:47 +0000 Subject: [Koha-bugs] [Bug 26364] XISBN.t makes a bad assumption about return values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26364 --- Comment #3 from Jonathan Druart --- Where did you see it fail? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 16:16:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 14:16:49 +0000 Subject: [Koha-bugs] [Bug 26305] Warn IE users of Staff Interface that it is no longer supported and to use a support browser instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26305 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109217|0 |1 is obsolete| | --- Comment #4 from PTFS Europe Sandboxes --- Created attachment 109629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109629&action=edit Bug 26305: Detect Internet Explorer and show warning in Staff Interface Koha no longer works with Internet Explorer. Since this change, and Microsoft's own dropping of support for IE is quite recent, let us show a banner warning staff interface users, so they can understand why Koha does not work as expected when they try to use it in IE. This patch detects a Microsoft property in the window object, and displays an alert banner, when one uses Koha's staff interface in Internet Explorer. To test: 1) Go to http://localhost:8081 in Internet Explorer 2) Note the banner that says the following: "Koha no longer supports the Internet Explorer browser. Please use a supported browser such as Firefox, Chrome, or Edge." Signed-off-by: Henry Bolshaw -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 16:19:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 14:19:18 +0000 Subject: [Koha-bugs] [Bug 26305] Warn IE users of Staff Interface that it is no longer supported and to use a support browser instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26305 Henry Bolshaw changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh at parliament.uk Status|Needs Signoff |Signed Off --- Comment #5 from Henry Bolshaw --- Tested on sandbox. I can confirm that the warning banner appeared in IE but did not appear in Chrome, Edge or Firefox. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 16:20:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 14:20:08 +0000 Subject: [Koha-bugs] [Bug 26162] Prevent Selenium's StaleElementReferenceException In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26162 --- Comment #15 from Jonathan Druart --- So, this approach did not fix the problem. We got another failure: https://jenkins.koha-community.org/job/Koha_Master_U18/886/consoleFull Screenshot is: https://snipboard.io/nxYFhq.jpg 15:20:58 selenium_1 | 06:20:58.918 INFO - Executing: [click: 35 [[FirefoxDriver: firefox on LINUX (67a62258-11cc-423b-b6e7-0e9e8b66997a)] -> xpath: //div[@class="main container-fluid"]//a[contains(@href, "/admin/branches.pl?op=add_form&branchcode=UT_BC")]]]) 15:21:19 selenium_1 | 06:21:19.815 WARN - Exception thrown 15:21:19 selenium_1 | org.openqa.selenium.StaleElementReferenceException: Element not found in the cache - perhaps the page has changed since it was looked up 15:21:40 koha_1 | STRACE: /usr/share/perl5/Try/Tiny.pm:123 in Selenium::Remote::Driver::catch {...} 15:21:40 koha_1 | /usr/local/share/perl/5.26.1/Selenium/Remote/Driver.pm:353 in Try::Tiny::try 15:21:40 koha_1 | (eval 1579):1 in Selenium::Remote::Driver::__ANON__ 15:21:40 koha_1 | (eval 1581):2 in Selenium::Remote::Driver::__ANON__ 15:21:40 koha_1 | /usr/local/share/perl/5.26.1/Selenium/Remote/Driver.pm:1330 in Selenium::Remote::Driver::_execute_command 15:21:40 koha_1 | /usr/local/share/perl/5.26.1/Selenium/Remote/Driver.pm:1330 in (eval) 15:21:40 koha_1 | /kohadevbox/koha/t/lib/Selenium.pm:126 in Selenium::Remote::Driver::find_element 15:21:40 koha_1 | t/db_dependent/selenium/administration_tasks.t:137 in t::lib::Selenium::fill_form That's getting really (really!) annoying... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 16:37:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 14:37:13 +0000 Subject: [Koha-bugs] [Bug 26090] Catalog by itemtype report fails if SQL strict mode is on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26090 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.04 released in| | --- Comment #6 from Lucas Gass --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 16:38:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 14:38:38 +0000 Subject: [Koha-bugs] [Bug 26370] New: Add ability to disable demagnitizing items via SIP2 for arbitrary patron categories Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370 Bug ID: 26370 Summary: Add ability to disable demagnitizing items via SIP2 for arbitrary patron categories Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 16:38:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 14:38:47 +0000 Subject: [Koha-bugs] [Bug 26370] Add ability to disable demagnetizing items via SIP2 for arbitrary patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to disable |Add ability to disable |demagnitizing items via |demagnetizing items via |SIP2 for arbitrary patron |SIP2 for arbitrary patron |categories |categories -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 16:38:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 14:38:51 +0000 Subject: [Koha-bugs] [Bug 26370] Add ability to disable demagnetizing items via SIP2 for arbitrary patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 16:41:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 14:41:29 +0000 Subject: [Koha-bugs] [Bug 26370] Add ability to disable demagnetizing items via SIP2 for arbitrary patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370 --- Comment #1 from Kyle M Hall --- Some libraries have certain patron categories that can only do in house checkouts via SIP self check machines. In these cases, the items should not be demagnetized since the items cannot leave the library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 16:42:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 14:42:05 +0000 Subject: [Koha-bugs] [Bug 26370] Add ability to disable demagnetizing items via SIP2 for arbitrary patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370 --- Comment #2 from Kyle M Hall --- Created attachment 109630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109630&action=edit Bug 26370: Add ability to disable demagnetizing items via SIP2 for arbitrary patron categories Some libraries have certain patron categories that can only do in house checkouts via SIP self check machines. In these cases, the items should not be demagnetized since the items cannot leave the library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 16:42:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 14:42:48 +0000 Subject: [Koha-bugs] [Bug 26078] "Item returns to issuing library" creates infinite transfer loop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26078 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.03 released in| | Status|Pushed to master |Pushed to stable CC| |lucas at bywatersolutions.com --- Comment #11 from Lucas Gass --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 16:56:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 14:56:48 +0000 Subject: [Koha-bugs] [Bug 26364] XISBN.t makes a bad assumption about return values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26364 --- Comment #4 from Nick Clemens --- (In reply to Jonathan Druart from comment #3) > Where did you see it fail? It was failing on our package builds, but not locally It seemed that the ISBN previously returned nothing, but now had an ISBN that matched one in our system The change makes sense though, we just need to confirm we don't get the biblionumber, not that we get nothing ThingISBN can change and makes no guarantees, so our tests must be explicit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 17:01:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 15:01:15 +0000 Subject: [Koha-bugs] [Bug 26361] JS error on returns.tt in 20.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26361 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.04 released in| | CC| |joy at bywatersolutions.com Who signed the|20.05.04 | patch off| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 17:15:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 15:15:20 +0000 Subject: [Koha-bugs] [Bug 26182] Clearly pair UpdateItemWhenLostFromHoldList and CanMarkHoldsToPullAsLost system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26182 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 17:15:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 15:15:38 +0000 Subject: [Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #23 from Owen Leonard --- (In reply to Jonathan Druart from comment #21) > Also can you confirm the following 3 errors are not valid? > > FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt > FAIL forbidden patterns > FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt > FAIL forbidden patterns These templates contain links to external (non-Koha) JavaScript assets: LibraryThing and Babeltheque. > FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt > FAIL forbidden patterns > forbidden pattern: Font Awesome icons need the aria-hidden > attribute for accessibility purpose (see bug 25166) (line 124) That's a valid warning and has been corrected. (In reply to Jonathan Druart from comment #22) > 1. https://snipboard.io/9kNAL8.jpg > Don't you think the login inputs are too wide? I've added a max-width to the form. > 2. https://snipboard.io/TlIkcu.jpg > The relevance dropdown is too wide Fixed. > 3. https://snipboard.io/apKe35.jpg > Why did you change the order of the filters at the bottom of the adv search > page? I made a lot of changes when working on the responsive behavior of this page. I think the change in the order is unintentional. > 4. https://snipboard.io/vq2I57.jpg > The [+][i] links don't behave correctly. Fixed. > 5. https://snipboard.io/H3xOZK.jpg > I was surprised by the brightness of the green and noticed that there is a > change. > Compare the "Go" button (in the header): I made changes across the board to buttons to make them more consistent with each other. The buttons in your example screenshot have been made to match the style of the "Go" button in the header. Other buttons, like the "Search" buttons on the advanced search page, have been styled the same where previously they used out-of-the-box Bootstrap "btn-success" colors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 17:27:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 15:27:14 +0000 Subject: [Koha-bugs] [Bug 26127] When reporting an Error from the OPAC, the URL does not display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26127 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.04 released in| | CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #14 from Lucas Gass --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 17:31:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 15:31:32 +0000 Subject: [Koha-bugs] [Bug 26119] Patron attribute option to display in OPAC is not compatible with PatronSelfRegistrationVerifyByEmail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26119 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.04 released in| | CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #6 from Lucas Gass --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 17:38:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 15:38:39 +0000 Subject: [Koha-bugs] [Bug 25872] Advanced search on OPAC with limiter but no search term fails when re-sorted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25872 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.03 released in| | --- Comment #12 from Lucas Gass --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 17:44:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 15:44:46 +0000 Subject: [Koha-bugs] [Bug 25750] Fallback to ecost_tax_included, ecost_tax_excluded not happening when no 'Actual cost' entered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25750 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.04 released in| | CC| |lucas at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #11 from Lucas Gass --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 17:45:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 15:45:47 +0000 Subject: [Koha-bugs] [Bug 26364] XISBN.t makes a bad assumption about return values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26364 --- Comment #5 from Nick Clemens --- (In reply to Nick Clemens from comment #4) > (In reply to Jonathan Druart from comment #3) > > Where did you see it fail? > > It was failing on our package builds, but not locally > > It seemed that the ISBN previously returned nothing, but now had an ISBN > that matched one in our system > > The change makes sense though, we just need to confirm we don't get the > biblionumber, not that we get nothing > > ThingISBN can change and makes no guarantees, so our tests must be explicit bug 26270 skips if the normalized ISBNs are equal to the xisbns it should only do so if the biblionumber is the same - isbn_bib1 = 0590353403 isbn_bib2 = 0684843897 isbn_bib3 = 043936213X i.e. we send 043936213X, thing ISBN returns 0590353403 with 26270 we skip the results because normalized 0590353403 = 0590353403 but that is ok the test before failed because it said 043936213X returned nothing ThingISBN now returns 0590353403 for 043936213X so we get bib1 - as long as we don't get bib3 then things are working -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 17:47:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 15:47:33 +0000 Subject: [Koha-bugs] [Bug 26364] XISBN.t makes a bad assumption about return values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26364 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109599|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 109631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109631&action=edit Bug 26364: Check that return value isn't the value we don't want. Don't check for undef It seems sometimes we get an ISBN returned that matches a book in the sample data. One of the Harry Potter books was matching the ISBN. Our real concern is not that we get nothing, but that we don't get the same value we pass in. We should test for that To test: 1 - prove -v t/db_dependent/XISBN.t 2 - The failures are not consistent, so read the code and ensure we are making sense -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 17:52:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 15:52:11 +0000 Subject: [Koha-bugs] [Bug 26364] XISBN.t makes a bad assumption about return values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26364 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26270 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26270 [Bug 26270] XISBN.t is failing since today -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 17:52:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 15:52:11 +0000 Subject: [Koha-bugs] [Bug 26270] XISBN.t is failing since today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26270 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26364 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26364 [Bug 26364] XISBN.t makes a bad assumption about return values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 18:10:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 16:10:32 +0000 Subject: [Koha-bugs] [Bug 26371] New: Prevent MARC tags from import when using Z39.50 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26371 Bug ID: 26371 Summary: Prevent MARC tags from import when using Z39.50 Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: barbara.johnson at bedfordtx.gov QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl We get brief bib records when we order from our vendor. When the item is received we overlay the brief bib with a full MARC record via Z39.50. Sometimes the incoming record has tags that we do not want in our bibs (local 9XX tags, 852, local 59x notes, etc.) We'd like a way to prevent those tags from being imported instead of having to delete them from every incoming record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 18:13:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 16:13:52 +0000 Subject: [Koha-bugs] [Bug 26162] Prevent Selenium's StaleElementReferenceException In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26162 --- Comment #16 from Jonathan Druart --- Master_D10 #342 (Docker_3) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 18:15:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 16:15:11 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #102 from Martin Renvoize --- I think this needs a little more work.. Whilst working on writing the tests I decided there were more cases I need to cover :(... Setting back to assigned whilst I deal with them Highlights: * Move '_Restore' routine into the Koha::Item trigger * Handle AutoReconcile case * Prevent failure when borrower has been deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 18:16:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 16:16:59 +0000 Subject: [Koha-bugs] [Bug 26372] New: Retain specific MARC tags in original bib record when overlaying a record using Z39.50 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26372 Bug ID: 26372 Summary: Retain specific MARC tags in original bib record when overlaying a record using Z39.50 Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: barbara.johnson at bedfordtx.gov QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl We include some local ordering info in the bib records when we order from our vendor. When we overly the brief bib record with the full record via Z39.50 we lose the local info in those tags. We would like a way to define specific tags in the original record that will not be overlayed by the incoming Z39.50 record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 18:24:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 16:24:15 +0000 Subject: [Koha-bugs] [Bug 26373] New: Add ability to used different font color or background color for specific MARC tags in Advanced Editor Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26373 Bug ID: 26373 Summary: Add ability to used different font color or background color for specific MARC tags in Advanced Editor Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: barbara.johnson at bedfordtx.gov QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In the Advanced Editor it would be helpful to be able to to highlight (a different font color, a background color, etc.) specific MARC tags so info in those tags is easily seen during cataloging. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 18:26:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 16:26:19 +0000 Subject: [Koha-bugs] [Bug 8437] Large database backups and large exports from export.pl fail under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 18:26:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 16:26:29 +0000 Subject: [Koha-bugs] [Bug 8437] Large database backups and large exports from export.pl fail under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 --- Comment #30 from Nick Clemens --- Created attachment 109632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109632&action=edit Bug 8437: Exclude export.pl from plack When attempting to download large files from Koha plack can timeout Excluding the script from plack is a simple fix until we have a more permanent fix for this issue. To test: 1 - Try to export your entire DB from Tools->Export 2 - If big enough, it fails 3 - Apply patch, copy changes to /etc/koha/apache-shared-intranet-plack.conf 4 - Restart all the things 5 - Repeat export, it succeeds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 18:27:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 16:27:12 +0000 Subject: [Koha-bugs] [Bug 26041] Accessibility: The date picker calendar is not keyboard accessible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26041 --- Comment #20 from Martin Renvoize --- (In reply to Jonathan Druart from comment #18) > 2 Questions: > 1. Why is this change only affecting the OPAC? Currently, I'm only working through accessibility issues raised in a report which was carried out against the OPAC. There is also a report being written currently for the staff client I believe at which time hopefully I can work through issue there as their own piece of work. > 2. To me it's still not really "accessible", if you create a new account the > current date is selected. How do you pick a date from, say, year 1980? > Select year dropdown list still cannot be selected. Fair point, though the 'up' and 'down' arrows can be used to quickly scroll between months, it's still not ideal. I'll work on some additional improvements. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 18:31:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 16:31:40 +0000 Subject: [Koha-bugs] [Bug 26041] Accessibility: The date picker calendar is not keyboard accessible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26041 --- Comment #21 from Martin Renvoize --- Actually.. those cases are already covered by default keybindings for the jQuery UI datepicker.. PAGE UP: Move to the previous month. PAGE DOWN: Move to the next month. CTRL + PAGE UP: Move to the previous year. CTRL + PAGE DOWN: Move to the next year. CTRL + HOME: Open the datepicker if closed. CTRL/COMMAND + HOME: Move to the current month. CTRL/COMMAND + LEFT: Move to the previous day. CTRL/COMMAND + RIGHT: Move to the next day. CTRL/COMMAND + UP: Move to the previous week. CTRL/COMMAND + DOWN: Move the next week. ENTER: Select the focused date. CTRL/COMMAND + END: Close the datepicker and erase the date. ESCAPE: Close the datepicker without selection. What my patch does is allow the existing SHIFT + ARROW to continue working whilst also mapping it to allow for just ARROW for more natural navigation.. The real issue here, is that there's not a universally agreed upon standard set of keyboard navigation keys for accessible calendar widgets so we're just trying to support a sensible variety. It may well be worth documenting these keyboard shortcuts somewhere though.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 18:35:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 16:35:37 +0000 Subject: [Koha-bugs] [Bug 26374] New: Update for 19974 is not idempotent Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26374 Bug ID: 26374 Summary: Update for 19974 is not idempotent Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 18:36:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 16:36:39 +0000 Subject: [Koha-bugs] [Bug 26374] Update for 19974 is not idempotent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26374 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 18:36:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 16:36:42 +0000 Subject: [Koha-bugs] [Bug 26374] Update for 19974 is not idempotent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26374 --- Comment #1 from Nick Clemens --- Created attachment 109633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109633&action=edit Bug 26374: update from bug 19974 is not idempotent -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 18:59:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 16:59:05 +0000 Subject: [Koha-bugs] [Bug 25969] Checking in a found hold at a different branch then confirming the hold causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25969 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Andrew Fuerste-Henry --- I'm also getting an error. To recreate: - Log in at Library A - Place hold on item at Library A, for pickup at Library A - Check item in at Library A - Click "Confirm hold" - Set library to Library B - Check item in again - Click "Confirm hold and transfer" - get error: Can't call method "biblio" on an undefined value at /kohadevbox/koha/circ/returns.pl line 147 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 18:59:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 16:59:33 +0000 Subject: [Koha-bugs] [Bug 26374] Update for 19974 is not idempotent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26374 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 19:07:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 17:07:24 +0000 Subject: [Koha-bugs] [Bug 26323] Not_for_loan, damaged, location and ccode values must be retrieved from the correct AV category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 --- Comment #5 from Katrin Fischer --- All our documentation lists the authorised values, they are used in the default frameworks you are not supposed to change etc. Do we really need to support that they can be anything? I think we would make developer's and support staff's life easier if we kept expecting specific codes. Even with this patch, we will still do that in a lot of other places where there is no mapping table for lookup (TERM, SUGG, etc.) My first thought here would actually be to fix the ETAT ones to be NOT_LOAN instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 19:15:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 17:15:37 +0000 Subject: [Koha-bugs] [Bug 24197] Custom destination for failed overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 --- Comment #23 from Martin Renvoize --- (In reply to Jonathan Druart from comment #21) > Not blocker but: shouldn't have it been defined at library level instead? I did wonder that myself when testing, but then decided that we have a pattern of introducing a system level default and then enhancing later with library level refinement if it proves useful. I'm still keen to overhaul how library emails get associated at some point but didn't think that should hold this piece up either. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 20:06:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 18:06:04 +0000 Subject: [Koha-bugs] [Bug 25265] Elasticsearch - Batch editing items on a biblio can lead to incorrect index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25265 Michael Sutherland changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sudrland at vt.edu --- Comment #16 from Michael Sutherland --- This should be a higher priority particularly for large institutions. I have 1.3 million bib records and close to 2 million items. I have, on occasion, needed to delete large batches of records. I should not be able to 'break' the catalog because of the indexing and I remove 20K bib records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 20:13:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 18:13:17 +0000 Subject: [Koha-bugs] [Bug 25265] Elasticsearch - Batch editing items on a biblio can lead to incorrect index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25265 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 20:25:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 18:25:38 +0000 Subject: [Koha-bugs] [Bug 26366] system preperence no option usekohaplugin enable/disable option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26366 --- Comment #1 from Katrin Fischer --- Hi Govind, This is more of a support style request. Can you please bring it up on the mailing list? Also: do you have the permissions for accessing the Administration module? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 20:27:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 18:27:31 +0000 Subject: [Koha-bugs] [Bug 19382] Add ability to block guarantees based on fees owed by guarantor and other guarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 20:27:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 18:27:40 +0000 Subject: [Koha-bugs] [Bug 19382] Add ability to block guarantees based on fees owed by guarantor and other guarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109210|0 |1 is obsolete| | Attachment #109211|0 |1 is obsolete| | Attachment #109349|0 |1 is obsolete| | Attachment #109357|0 |1 is obsolete| | --- Comment #31 from Kyle M Hall --- Created attachment 109634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109634&action=edit Bug 19382: Add ability to block guarantees based on fees owed by guarantor and other guarantees Some libraries would like to not only block the circulation of a guarantor based on fines owed by guarantees, but would also like to block circulation for all guarantees as well. Basically, if a family as a whole reaches a certain threshold of fines, the entire family will be blocked from checking out items. Test Plan: 1) Apply this patch 2) Set NoIssuesChargeGuarantorsWithGuarantees to $14 3) Create a family of four ( 2 guarantors, 2 guarantees ) where the parents guarantee both children 4) Give 3 of the 4 a $5 fine 5) None of them should be able to check out items Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 20:27:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 18:27:56 +0000 Subject: [Koha-bugs] [Bug 19382] Add ability to block guarantees based on fees owed by guarantor and other guarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382 --- Comment #32 from Kyle M Hall --- Created attachment 109635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109635&action=edit Bug 19382: Add blocking of ability to checkout on circulation.pl Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 20:28:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 18:28:02 +0000 Subject: [Koha-bugs] [Bug 19382] Add ability to block guarantees based on fees owed by guarantor and other guarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382 --- Comment #33 from Kyle M Hall --- Created attachment 109636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109636&action=edit Bug 19382: (QA follow-up) Throw exception if only_this_guarantor is set for a non-guarantor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 20:28:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 18:28:50 +0000 Subject: [Koha-bugs] [Bug 26368] Add support for OCLC Encoding level values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26368 --- Comment #2 from Katrin Fischer --- If these are no MARC standard and OCLC is only used by a quite small percentage of libraries using Koha - could we make displaying these optional? Maybe we could introduce a second plugin that can be linked in frameworks or a general "OCLC participant" pref to switch on such things -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 20:30:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 18:30:04 +0000 Subject: [Koha-bugs] [Bug 26368] Add support for OCLC Encoding level values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26368 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Katrin Fischer --- Especially since the options are currently not marked as OCLC specific - I think they should be. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 20:32:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 18:32:52 +0000 Subject: [Koha-bugs] [Bug 26375] New: SIP checkout message does not renew item Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26375 Bug ID: 26375 Summary: SIP checkout message does not renew item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com To recreate: - Find or create a checked out item with 1 or more available renewals - Via SIP CLI, send a checkout message for the same patron and item - Receive error "Item checked out to another patron" This should result in a renewal, if one is available. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 20:33:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 18:33:14 +0000 Subject: [Koha-bugs] [Bug 26375] SIP checkout message does not renew item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26375 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25808 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 [Bug 25808] Renewal via the SIP 'checkout' message gives incorrect message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 20:33:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 18:33:14 +0000 Subject: [Koha-bugs] [Bug 25808] Renewal via the SIP 'checkout' message gives incorrect message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26375 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26375 [Bug 26375] SIP checkout message does not renew item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 20:34:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 18:34:49 +0000 Subject: [Koha-bugs] [Bug 26376] New: Add itemnumber to writeoffs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26376 Bug ID: 26376 Summary: Add itemnumber to writeoffs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org See: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894#c8 After careful consideration our position on this has changed. We believe we should be recording the itemnumber for writeoffs where we can, libraries use this information for reporting and tracking -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 20:35:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 18:35:06 +0000 Subject: [Koha-bugs] [Bug 26376] Add itemnumber to writeoffs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26376 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 20:57:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 18:57:56 +0000 Subject: [Koha-bugs] [Bug 25476] Uploaded files can't be easily browsed via upload.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25476 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 20:57:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 18:57:56 +0000 Subject: [Koha-bugs] [Bug 25476] Uploaded files can't be easily browsed via upload.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25476 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 20:57:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 18:57:56 +0000 Subject: [Koha-bugs] [Bug 25476] Uploaded files can't be easily browsed via upload.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25476 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 20:58:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 18:58:36 +0000 Subject: [Koha-bugs] [Bug 25475] upload.pl should provide a "Copy link" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25475 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 20:58:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 18:58:36 +0000 Subject: [Koha-bugs] [Bug 25475] upload.pl should provide a "Copy link" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25475 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 21:19:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 19:19:33 +0000 Subject: [Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 21:19:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 19:19:44 +0000 Subject: [Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109266|0 |1 is obsolete| | --- Comment #39 from Agustín Moyano --- Created attachment 109637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109637&action=edit Bug 23019: (follow-up) Fix usability issues This patch place profile buttons in the bottom of the page, next to "Stage for import" It removes the "Update profile" button, and changes "Add profile" to "Save profile". Save profile can be used to add and to update a profile. It also adds feedback when a profile was saved or deleted. Last, it also replaces input-batch-profile endpoint name for input_batch_profile, which is more aligned with other endpoint names. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 21:20:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 19:20:07 +0000 Subject: [Koha-bugs] [Bug 26377] New: Clearly label parts of subscription-add.pl that relate to optional item records Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377 Bug ID: 26377 Summary: Clearly label parts of subscription-add.pl that relate to optional item records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com On the first screen of subscription-add.pl, there are several fields that set values to be applied to created items. They're only needed if you are creating item records when receiving serials. It'd be very helpful to move these so that they are all grouped together and clearly labeled. It might even be reasonable to hide them if not set to create item records. These fields relate to the item record: - Call number - Library - Location - item type - item type for older issues -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Sep 3 21:21:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Sep 2020 19:21:06 +0000 Subject: [Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 --- Comment #40 from Agustín Moyano --- (In reply to Nick Clemens from comment #38) > This did not work in my testing, whenever I click 'Save profile' I get an > error: > An error occurred > > [object Object] > > in console: > Uncaught (in promise) > {…} > ​ > abort: function abort(a) > ​ > always: function always() > ​ > complete: function add() > ​ > done: function add() > ​ > error: function add() > ​ > fail: function add() > ​ > getAllResponseHeaders: function getAllResponseHeaders() > ​ > getResponseHeader: function getResponseHeader(a) > ​ > overrideMimeType: function overrideMimeType(a) > ​ > pipe: function pipe() > ​ > progress: function add() > ​ > promise: function promise(a) > ​ > readyState: 4 > ​ > responseText: "\n\n\n > \n Page not found (development mode)\n http-equiv=\"Pragma\" content=\"no-cache\">\n http-equiv=\"Expires\" content=\"-1\">\n \n \n href=\"/mojo/prettify/prettify-mojo-dark.css\" rel=\"stylesheet\">\n >