[Koha-bugs] [Bug 26268] Remove items.paidfor once and for all

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Katrin Fischer from comment #12)
> I see that there is a lot of history here, but I am not quite following yet.
> 
> 1) Before dropping the column: Did we move the information stored there in
> previous developments?

Nope, we didn't drop the data.. we just started using the fields it used to be
populated by inconsistently to construct the display on on the fly. The data in
the field is no longer maintained and historically wasn't accurate so I think
we should be OK to drop it regardless.

> 
> If we didn't, we might just want to print a warning if there is any content
> to be found in the db and ask people to drop themselves. It has been done in
> the past with some of the columns in borrowers (ethnicity?) I think. If
> there is no data, we can drop it in the update.
> 
> 2) Looking for "paidfor" I found some more references this patch is not
> taking care of:

As noted above, this is where we now construct the data on the fly.
`$item->{paidfor} = { patron => $patron, created_on =>
$payment_offset->created_on }` is an assignment for the template rather than a
getter or setter for the DB data.

> 
> catalogue/moredetail.pl:    # Add paidfor info
> catalogue/moredetail.pl:                $item->{paidfor} = { patron =>
> $patron, created_on => $payment_offset->created_on };
> 
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt:            
> [% IF ( ITEM_DAT.paidfor ) %]<li><span class="label">Paid for?:</span> [%
> INCLUDE 'patron-title.inc' patron=ITEM_DAT.paidfor.patron
> hide_patron_infos_if_needed=1 %] on [% ITEM_DAT.paidfor.created_on |
> $KohaDates %]</li>[% END %]

-- 
You are receiving this mail because:
You are watching all bug changes.