[Koha-bugs] [Bug 26364] New: XISBN.t makes a bad assumption about return values

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26364

            Bug ID: 26364
           Summary: XISBN.t makes a bad assumption about return values
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

75 eval { $results_thingisbn = C4::XISBN::get_xisbns($isbn1,$biblionumber3); };
 76 SKIP: {
 77     skip "Problem retrieving ThingISBN", 1
 78         unless $@ eq '';
 79     is( $results_thingisbn->[0]->{biblionumber},
 80         undef,
 81         "Doesn't get biblionumber if the biblionumber matches the one
passed to the sub." );
 82 }


Here we are testing that we don't get the same book that we passed into the sub
in the list that is returned, however, we shouldn't assume that we get nothing,
we should just check that it is not the biblionumber we passed in

-- 
You are receiving this mail because:
You are watching all bug changes.