[Koha-bugs] [Bug 26364] XISBN.t makes a bad assumption about return values

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26364

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Nick Clemens from comment #4)
> (In reply to Jonathan Druart from comment #3)
> > Where did you see it fail?
> 
> It was failing on our package builds, but not locally
> 
> It seemed that the ISBN previously returned nothing, but now had an ISBN
> that matched one in our system
> 
> The change makes sense though, we just need to confirm we don't get the
> biblionumber, not that we get nothing
> 
> ThingISBN can change and makes no guarantees, so our tests must be explicit

bug 26270 skips if the normalized ISBNs are equal to the xisbns
it should only do so if the biblionumber is the same -

isbn_bib1 = 0590353403
isbn_bib2 = 0684843897
isbn_bib3 = 043936213X

i.e. we send 043936213X, thing ISBN returns 0590353403
with 26270 we skip the results because normalized 0590353403 = 0590353403
but that is ok

the test before failed because it said 043936213X returned nothing

ThingISBN now returns 0590353403 for 043936213X so we get bib1 - as long as we
don't get bib3 then things are working

-- 
You are receiving this mail because:
You are watching all bug changes.