[Koha-bugs] [Bug 10921] You can edit an order even when it is in a closed basket

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10921

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107624|0                           |1
        is obsolete|                            |

--- Comment #5 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 109639
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109639&action=edit
Bug 10921: Prevent an order from a closed basket to be edited

We don't allow editing of orders that are part of a closed basket, but
we don't enforce the rule in the controller file.

This patch use output_and_exit to stop the script and display an error
to the end user.

Test plan:
Create a basket, add an order
On the basket view you see the "Modify" link, open it in a separate tab
=> You can edit the basket
Keep this tab open, get back to the other one and close the basket
Reload the tab with the order edition form
=> You cannot longer edit the basket

QA: Do we need a check in addorder.pl as well?

Signed-off-by: Henry Bolshaw <bolshawh at parliament.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.