[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343

--- Comment #179 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This code looks great and I'm happy to SO as is (with the couple of very minor
followups I've added).

I have a few points/questions/suggestions

* You introduce a 'debug' mode you can set at the smtp server level.. I like
this, but at present I can't see any references to it anywhere.. it would be
nice to see it used to enable/disable additional logging in at least one place
with this patchset to give it a purpose and example of use.
* With the above debug mode, I'd like to see that state somehow highlighted in
the smtp-servers page table if it's enabled (so it's obvious to an admin when
it's turned on) (bold/italic row perhaps, similar to the 'default' hinting in
cash registers)
* Final note about the debug mode.. it would be awesome as a later followup to
expose a 'Send test mail' action into the smpt servers table to allow the
immediate send of a test mail from that server with defaults set for
from/replyo etc.

* It would be nice to see a list of attached branches as one fo the columns in
the smtp servers table.
* Should deletes be blocked/warned about if the smtp server is being utilised
by any libraries?
* The 'delete' was slow for me, which meant I could easily double submit the
modal form (we should prevent the double submit)

* It would be nice to add the smtp server name as an optional column to display
in the libraries table.

* Another enhancement for the future would be to support library groups


Generally, I really like this and it's a huge improvement.

-- 
You are receiving this mail because:
You are watching all bug changes.