[Koha-bugs] [Bug 26405] New: Circulation.t fails on 'AddRenewal left both fines'

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26405

            Bug ID: 26405
           Summary: Circulation.t fails on 'AddRenewal left both fines'
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: emmi.takkinen at outlook.com
        QA Contact: testopia at bugs.koha-community.org

Running prove t/db_dependent/Circulation.t, I receive following error:

t/db_dependent/Circulation.t .. 1/48 
    #   Failed test 'AddRenewal left both fines'
    #   at t/db_dependent/Circulation.t line 591.
    #          got: '1'
    #     expected: '2'
    # Looks like you planned 83 tests but ran 28.
    # Looks like you failed 1 test of 28 run.
t/db_dependent/Circulation.t .. 15/48 
#   Failed test 'CanBookBeRenewed tests'
#   at t/db_dependent/Circulation.t line 1255.
Can't call method "status" on an undefined value at
t/db_dependent/Circulation.t line 593.

Adding t::lib::Mocks::mock_preference('CalculateFinesOnReturn', 1) solved
problem since bug 23051 added following to Circulation.pm: 

if ( !$skipfinecalc && C4::Context->preference('CalculateFinesOnReturn') ) {
            _CalculateAndUpdateFine( { issue => $issue, item =>
$item_unblessed, borrower => $patron_unblessed } );
        }

However I'm unsure if this is appropriate solution or are those tests invalid
at this point.

-- 
You are receiving this mail because:
You are watching all bug changes.