[Koha-bugs] [Bug 25969] Checking in a found hold at a different branch then confirming the hold causes internal server error

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25969

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #109678|0                           |1
        is obsolete|                            |

--- Comment #12 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 109756
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109756&action=edit
Bug 25969: Don't set itemnumber as reserve->itemnumber

When a hold is checked in at the wrong destination we revert the found status
For a title level hold this means we return it to a title level hold, with no
itemnumber

When we checkin the item we find the hold, but won't set the itemnumber in the
hold until it is confirmed

In the script we were setting the itemnumber param, but then setting it again
using the reserve itemnumber.
In all conditions before the itemnumber has been set, we don't need to set it
again, especially when we do
so incorrectly

To test:
- Log in at Library A
- Place hold on item at Library A, for pickup at Library A
- Check item in at Library A
- Click "Confirm hold"
- Set library to Library B
- Check item in again (try with both the box on reutrns.pl and the box in the
header)
- Click "Confirm hold and transfer"
- get error: Can't call method "biblio" on an undefined value at
/kohadevbox/koha/circ/returns.pl line 147
- apply patch
- repeat
- success!
- confirm trappings of holds works as normally otherwise too

Signed-off-by: Daniel Gaghan <daniel.gaghan at pueblolibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.