[Koha-bugs] [Bug 26230] Move translatable strings out of item_search_fields.tt and into item_search_fields.js

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26230

Alexis Ripetti <alexis.ripetti at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #108415|0                           |1
        is obsolete|                            |

--- Comment #2 from Alexis Ripetti <alexis.ripetti at inLibro.com> ---
Created attachment 109773
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109773&action=edit
Bug 26230: Move translatable strings out of item_search_fields.tt and into
item_search_fields.js

This patch removes the definition of translatable strings out of
templates and into the corresponding JavaScript file, using the new JS
i81n function.

To test:

- Apply the patch, go to Administration -> Item search fields.
- If necessary, add a new search field.
- From the table of search fields, click the "Delete" button for one of
  the fields.
- You should get a confirmation: "Are you sure you want to delete this
  field?"

TESTING TRANSLATABILITY

- Update a translation, e.g. fr-FR:

> cd misc/translator
> perl translate update fr-FR

- Open the corresponding .po file for JavaScript strings, e.g.
  misc/translator/po/fr-FR-messages-js.po
- Locate the string pulled from
  koha-tmpl/intranet-tmpl/prog/js/item_search_fields.js for translation:

  #: koha-tmpl/intranet-tmpl/prog/js/item_search_fields.js:18
  msgid "Are you sure you want to delete this field?"
  msgstr ""

- Edit the "msgstr" string however you want (it's just for testing).
- Install the updated translation:

  > perl translate install fr-FR

- Switch to your newly translated language in the staff client
  and repeat the test plan above. The translated strings should
  appear.

Signed-off-by: Alexis Ripetti <alexis.ripetti at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.