[Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
It took a little getting my head around, but I believe this is all correct.

For reference, the commit adding the defer_marc_save option had the message:

====
item rework: replaced AddBiblioAndItems

Replace C4::Biblio::AddBiblioAndItems with two
things:

* An option to C4::Biblio::AddBiblio to defer writing
  biblioitems.marc and biblioitems.marcxml.  This
  option was created to give a significant
  speed boost to bulkmarcimport.pl, but is *not*
  recommended for general use.
* C4::Items::AddItemBatchFromMarc

This refactoring removes the need to have functions
in C4::Biblio and C4::Items that call each other's
private functions.

Signed-off-by: Chris Cormack <crc at liblime.com>
Signed-off-by: Joshua Ferraro <jmf at liblime.com>
====

I believe it is no defunk as David suggests. I tried a few runs of
bulkmarcimport with and without the patch and found no really noticeable
slowdown in performance (though performance of this script really isn't very
good these days :( )

Signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.