[Koha-bugs] [Bug 26323] Not_for_loan, damaged, location and ccode values must be retrieved from the correct AV category

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Sep 11 08:23:32 CEST 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #5)
> All our documentation lists the authorised values, they are used in the
> default frameworks you are not supposed to change etc. Do we really need to
> support that they can be anything? I think we would make developer's and
> support staff's life easier if we kept expecting specific codes. Even with
> this patch, we will still do that in a lot of other places where there is no
> mapping table for lookup (TERM, SUGG, etc.)

Replacing hardcoded values is normally the right thing to do.
But I may understand your point. Think that we can still refer to specific
codes as they are the values loaded by the default setup. Someone who changes
the authorised values and kohafield mappings, should know what they do.

That said, I dont see why we should not move on this path. (Knowing that we
will be on the road for some time ;)

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list