[Koha-bugs] [Bug 10744] ExpireReservesMaxPickUpDelay works with hold(s) over report

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744

Emmi Takkinen <emmi.takkinen at outlook.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #106446|0                           |1
        is obsolete|                            |

--- Comment #10 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
Created attachment 110031
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110031&action=edit
Bug 10744 - ExpireReservesMaxPickUpDelay works with hold(s) over report

Hold(s) over -report at circ/waitingreserves.pl doesn't work because
ExpireReservesMaxPickup removes reserves from the koha.reserves-table to the
koha.old_reserves-table.

This patch adds a new column koha.reserves.pickupexpired telling when/if the
reserve has got it's pickup duration expired.

This date is used to pull old reserves to the waitingreserves-view.

syspref 'PickupExpiredHoldsOverReportDuration' controls how many days after
expiration old reserves are displayed on the report, and the values respect
Koha::Calendar holidays

To test:
1) Apply patch.
2) Enable 'ExpireReservesMaxPickUpDelay'.
3) Set some value to 'ReservesMaxPickUpDelay' and
'PickupExpiredHoldsOverReportDuration' (e.g. 2 and 7).
4) Find or create hold(s) waiting pickup and set their expiration date so it
exceeds 'ReservesMaxPickUpDelay'
but not 'PickupExpiredHoldsOverReportDuration'.
5) Confirm hold(s) are moved to 'Holds waiting over ...' list.
6) Run misc/cronjobs/holds/cancel_expired_holds.pl.
7) Confirm hold(s) are still displayed on the list.
8) Confirm from db that hold(s) have 'pickupexpired' set same as
'expirationdate'.
9) Set new value to 'PickupExpiredHoldsOverReportDuration' so it no longer
covers hold(s) expiration date(s).
10) Confirm that hold(s) are no longer displayed in waiting list

Also prove t/db_depentent/Koha/Old.t

-- 
You are receiving this mail because:
You are watching all bug changes.