[Koha-bugs] [Bug 23485] Holds to pull (pendingreserves.pl) should list barcodes

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23485

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 110246
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110246
Bug 23485: Show barcode in holds to pull

Review of attachment 110246:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23485&attachment=110246)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt
@@ +105,5 @@
>          <td>
> +            [% IF ( reserveloo.barcode ) %]
> +            [% IF ( reserveloo.itemnumber ) %]Only[% END %]
> +                <ul>
> +                    [% FOREACH barcode IN reserveloo.barcode.first %]

Not sure this makes sense.. does reserveloo.barcord.first really return an
array to loop on?

I would think you could simplify to just [% reserveloo.barcode.first %]

Also.. I'm not sure this needs to be nested in a list..

I think I'd expect simply

[% IF ( reserveloo.itemnumber ) %]Only [% reserveloo.barcode.first %][% ELSE
%][% reserveloo.barcode.first %] or any available[% END %]

With the filters added in where appropriate of course ;)

Does that make sense, or am I misunderstanding the logic

-- 
You are receiving this mail because:
You are watching all bug changes.