[Koha-bugs] [Bug 26518] New: Adding a record can succeed even if adding the biblioitem fails

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518

            Bug ID: 26518
           Summary: Adding a record can succeed even if adding the
                    biblioitem fails
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

We can end up creating biblios in the catalog that are malformed

To test:
1 - Add new record with field 010:
    ThisisgoingtobetoomanycharactersfortheLCCNfield
2 - Check the logs, note the error about failure to create biblioitem:
DBD::mysql::st execute failed: Data too long for column 'lccn' at row 1 [for
Statement "INSERT INTO biblioitems SET
        biblionumber    = ?,
        volume          = ?,
        number          = ?,
        itemtype        = ?,
        isbn            = ?,
        issn            = ?,
        publicationyear = ?,
        publishercode   = ?,
        volumedate      = ?,
        volumedesc      = ?,
        collectiontitle = ?,
        collectionissn  = ?,
        collectionvolume= ?,
        editionstatement= ?,
        editionresponsibility = ?,
        illus           = ?,
        pages           = ?,
        notes           = ?,
        size            = ?,
        place           = ?,
        lccn            = ?,
        url             = ?,
        cn_source       = ?,
        cn_class        = ?,
        cn_item         = ?,
        cn_suffix       = ?,
        cn_sort         = ?,
        totalissues     = ?,
        ean             = ?,
        agerestriction  = ?
        " with ParamValues: 0='1681', 1=undef, 2=undef, 3=undef, 4=undef,
5=undef, 6=undef, 7=undef, 8=undef, 9=undef, 10=undef, 11=undef, 12=undef,
13=undef, 14=undef, 15=undef, 16=undef, 17=undef, 18=undef, 19=undef, 20="This
is the ongest field i can think of", 21=undef, 22=undef, 23=undef, 24=undef,
25=undef, 26='', 27=undef, 28=undef, 29=undef] at /kohadevbox/koha/C4/Biblio.pm
line 2926.
ERROR in _koha_add_biblioitem INSERT INTO biblioitems SET

3 - Record saves successfully otherwise
4 - Attempt to add an item:
Can't call method "biblioitemnumber" on an undefined value at
/kohadevbox/koha/Koha/Item.pm line 83.
 at /kohadevbox/koha/Koha/Item.pm line 82

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.