[Koha-bugs] [Bug 26529] Holds rules enforced incorrectly when not set at library level

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26529

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 110695
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110695&action=edit
Bug 26529: Define some rules as not able to be blank

This patch uses the existing hash that controls the scope of rules and adds a
new parameter 'can_be_blank'

To test:
1 - Goto to Admin -> Circulation and fines rules and select a library
2 - Under "Default checkout, hold, and return policy" set:
    Total current checkouts allowed: 1
    Hold policy: Not set
    Hold pickup library match: Not set
    Return policay: Not set
3 - Save the rule
4 - Check the DB
    SELECT * FROM circulation_rules WHERE branchcode = 'BRANCHCODE'
    using the branchcode for the library you chode
5 - Note holdallowed, returnbranch, and hold_fulfillment_policy rules exist
with blank value
6 - Apply patch and restart all the things
7 - Reload the page and save the rules as before
8 - Check the DB and note the rules no longer exist
9 - pr0ve -v t/db_dependent/Koha/CirculationRules.t

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.