[Koha-bugs] [Bug 11176] Purchase suggestions should respect the 'active' switch on budgets

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11176

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #110659|0                           |1
        is obsolete|                            |

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 110699
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110699&action=edit
Bug 11176: Add active switch on budgets select in suggestions

When creating a new purchase suggestion, all funds display and are available
for selection.
The behaviour of this drop-down menu should mirror that of those drop-down
menus elsewhere in acquisitions,
where only funds that are linked to active budgets display to the user.

This patch add the active switch based on what exists in acqui/invoice.tt and
acqui/invoice.pl.

Looks like actually in suggestion.pl budgets list was fetches with
GetBudgets().
But this is for the filter in 'Acquisition information'.
Budgets selection on suggestion creation/edition must use GetBudgetHierarchy(),
like in acqui/invoice.pl,
in order to have the actif status.

Test plan :
1) Create a budget periods active B1 with a fund F1
2) Create a budget periods inactive B2 with a fund F2
3) Go to suggestions module
4) Create a new suggestion
5) Check you see only active fund F1
6) Click on 'Show inactive'
7) Check you see also 'F2 (inactive)'
8) Choose fund F1 and save
9) Select the suggestion and edit
10) Check fund F1 is selected
11) Come back to suggestion table
12) Check filter 'Book fund' under 'Acquisition information' contains all funds

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.