[Koha-bugs] [Bug 25460] Update OAI set (and optionally embed item information) when adding/editing/deleting items

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25460

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |david at davidnind.com

--- Comment #12 from David Nind <david at davidnind.com> ---
Hi Alex.

I retested, but the tests failed for me:

root at kohadevbox:koha(bz25460)$ prove t/db_dependent/OAI/Sets.t
t/db_dependent/OAI/Sets.t .. 1/153 C4::OAI::Sets::AddOAISetsBiblios(): DBI
Exception: DBD::mysql::st execute failed: Duplicate entry '444-7' for key
'PRIMARY' [for Statement "
        INSERT INTO oai_sets_biblios (set_id, biblionumber)
        VALUES (?,?)
    " with ParamValues: 0='7', 1=444] at t/db_dependent/OAI/Sets.t line 370
# Looks like your test exited with 255 just after 100.
t/db_dependent/OAI/Sets.t .. Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 53/153 subtests 

Test Summary Report
-------------------
t/db_dependent/OAI/Sets.t (Wstat: 65280 Tests: 100 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 153 tests but ran 100.
Files=1, Tests=100,  2 wallclock secs ( 0.03 usr  0.01 sys +  1.50 cusr  0.15
csys =  1.69 CPU)
Result: FAIL

Note:
1. If I apply the patch on a clean setup and don't enable the OAI-PMH system
preferences the tests pass.
2. If I apply the patch on a clean setup and enable the OAI-PMH system
preferences the test fail.

Also, a really minor thing - there is an unnecessary " at the end of the
description note for the new system preference.

-- 
You are receiving this mail because:
You are watching all bug changes.