[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #106808|0                           |1
        is obsolete|                            |
 Attachment #110514|0                           |1
        is obsolete|                            |

--- Comment #50 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 110763
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110763&action=edit
Bug 14784: Fix checkin message for debarred patrons

After thinking about it I changed the code's behavior to always display a
reminder if the patron was previously debarred.
This makes sense to me (it's only a reminder) and it correctly stacks with
other messages.

--

Test plan:
Before

1) Select a user with active restrictions (manual restriction works)
2) Make sure finesday=0 for the user category. See [1]
3) Checkout and return an item (not overdue)
   A previous restriction reminder will appear
4) Checkout and return an overdue item (change the date at cehckout)
   No previous restriction reminder will appear

After applying patch:
Same steps, but a reminder should appear for step 4)

I've also tested with finesday=1 with "no overdue", "grace period overdue" and
"long overdue" test
cases. The appropriate nessage appeared for each test.

[1] The "finesday" setting is called "Suspension in days" in the web interface,
if you're searching
for it like I did...

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Victor Grousset <victor.grousset at biblibre.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.