[Koha-bugs] [Bug 26506] Koha::Account::pay will fail if $userenv is not set

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Whilst I agree with this patch and will PQA it once back at a computer, I do
feel it perhaps highlight some issues with the plugin code in question (as I
highlighted on my version of the bug and it prompted me to fix my own payments
plugin).

Lots of Koha functions still exist that expect a userenv to always be present
so in general I feel developers should always attempt to set at least the
minimum of branch code and interface in a skeleton userenv if they can't catch
an existing environment.

Just some food for though Matthias 😉.  For an example of this see my commit on
one of the payment plugins we maintain:
https://github.com/PTFS-Europe/koha-plugin-wpm-online_payments/commit/0a0ee1ae7dd2477d1b55d40f974a2c0dcf4e621a

-- 
You are receiving this mail because:
You are watching all bug changes.