[Koha-bugs] [Bug 24724] Add plugin hook for new SQL report export formats

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Sep 29 14:15:01 CEST 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24724

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

--- Comment #4 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Ah really nice hook.

I think it could be useful for many other exports (checkouts table, ...).

Use of those plugins will only be implemented only for sql reports, but can be
implemented somewhere else in a second time.

So I propose you some changes :

1)
Only one format per plugin. 2 formats = create 2 plugins ;)
Will make code more clear I bet.

2)
Change methods :
    sub sql_report_get_export_format
    sub sql_report_process_data
to :
    export_format
    process_export

3)
Better add a method to Koha/Template/Plugin/KohaPlugins.pm to fetch the plugins
you need.

PS : you need to remove call to UseKohaPlugins system preference

Let me know if you need help.

Best regards,

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list