[Koha-bugs] [Bug 26515] Add Koha::Acquisition::Order->cancel

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26515

--- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Ok, this is my fourth round.

This time I decided to make it:
- Survive errors deleting items and the biblio
- Rely on bug 26555 to notify the caller about those problems
- Moved some of the checks we do in basket.pl and cancelorder.pl here to
centralize and properly test those situations with regression tests.

This will provide a good starting point for improvements in this area without
introducing regressions.

Note: as with any Koha bit, what you find is you need to rewrite all the
things, including C4::Biblio to make things 'perfect'. This implementation
tries to be clean, and sane. It also is fully tested and provides a path for
improvement without regressions, moving checks from controllers to the right
place.

Caveat: I still think we should explode on any error, but it collides with
'keep the current behaviour' and 'do not rewrite all the UI'. The pattern I
introduce in bug 26555 seems to be a good starting point for many of this
situations. But I'm sure it will be a moving target until we feel comfortable
with THE solution we collectively develop.

-- 
You are receiving this mail because:
You are watching all bug changes.