[Koha-bugs] [Bug 26583] Unnecessary code in AddIssue

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Sep 30 20:07:24 CEST 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26583

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 111008
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111008&action=edit
Bug 26583: Remove unneccessary code in AddIssue

The lines to calc due date are doubled

ModDateLastSeen is not needed as we set the item not lost and we can set
the date as we do for date last borrowed and save a DB store

We should not have an existing issue, either we did and the borrower was the
same so we renewed,
or we did and the borrower didn't match, so we returned it

Largely this is reading the code and confirming the changes make sense

To test:
1 - Apply patch
2 - Check out items, confirm it works as before
3 - prove -v t/db_dependent/Circulation.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list