From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 00:49:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Mar 2021 22:49:01 +0000 Subject: [Koha-bugs] [Bug 28022] MARC subfield 9 not honoring visibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28022 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #4 from David Cook --- As Martin mentioned on the listserv, if you can use git-bz to attach a patch here (https://wiki.koha-community.org/wiki/Git_bz_configuration), then we can move things along. At a glance, this is looking OK. I'm sure between Katrin, Martin, and myself that we can get this done quickly. Since the change only targets the addbiblio.pl script, there shouldn't really be any implications for other parts of Koha. The only scenario I can think that could be a problem would be where someone has added a thesaurus to a subfield other than $a and they've hidden the $a but that's quite an edge case and they are already arguably doing the wrong thing there... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 09:13:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 07:13:01 +0000 Subject: [Koha-bugs] [Bug 26312] Add some error handling during Elasticsearch indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26312 --- Comment #21 from Joonas Kylmälä --- Hi, you can download and import for example https://ia600208.us.archive.org/22/items/marc_western_washington_univ/wwu_bibs.mrc_revrev.mrc to kohadevbox and after few thousand of those are in start indexing with: > koha-elasticsearch -v -p 5 --commit 1000 --rebuild kohadev and also > docker exec -it koha_es_1 bash > vi config/jvm.options and modify the JVM heap size to 50Mb: > -Xms50m > -Xmx50m and then > docker restart koha_es_1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 09:46:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 07:46:06 +0000 Subject: [Koha-bugs] [Bug 27724] Use lenient also in Elasticsearch authorities search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 09:46:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 07:46:09 +0000 Subject: [Koha-bugs] [Bug 27724] Use lenient also in Elasticsearch authorities search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116997|0 |1 is obsolete| | --- Comment #4 from Séverine Queune --- Created attachment 119062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119062&action=edit Bug 27724: Use lenient also in Elasticsearch authorities search In Elasticsearch, query for biblios uses lenient=true. This is also needed for authorities search. In case a search field is defined as type numeric. Test plan : 1) Use Elasticsearch searchengine 2) Define a search field 'local-number' as type 'Number' 3) Be sure to us 'local-number' in autorities mapping 4) Rebuild autorities 5) Performe a search for autorities with 'Search entire record' and 'contains' with term '123' => Without patch you get error : [query_shard_exception] Can only use prefix queries on keyword and text fields - not on [local-number] which is of type [integer] Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 09:56:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 07:56:56 +0000 Subject: [Koha-bugs] [Bug 28053] Warning in C4::Members::patronflags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28053 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 09:57:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 07:57:00 +0000 Subject: [Koha-bugs] [Bug 28053] Warning in C4::Members::patronflags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28053 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118995|0 |1 is obsolete| | --- Comment #3 from Joonas Kylmälä --- Created attachment 119063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119063&action=edit Bug 28053: Squash warning in C4::Members This patch sets guarantess_non_issues_charges to '0' upon creation of the variable and thus prevents 'Use of uninitialized value $guarantees_non_issues_charges in numeric gt (>) at /home/martin/kohaclone/C4/Members.pm line 183.' being thrown when the patron has guaruntees without any charges. Test plan 1. Run t/db_dependant/SIP/SIPServer.t and note the warning above is thrown at least once. 2. Apply the patch 3. Run the test again and note the warning has gone. Signed-off-by: Petro Vashchuk Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 09:57:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 07:57:51 +0000 Subject: [Koha-bugs] [Bug 28053] Warning in C4::Members::patronflags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28053 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi --- Comment #4 from Joonas Kylmälä --- It was not mentioned in the test plan but NoIssuesChargeGuarantees needs to be defined for the warning to trigger. Passing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 09:59:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 07:59:04 +0000 Subject: [Koha-bugs] [Bug 28053] Warning in C4::Members::patronflags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28053 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |joonas.kylmala at helsinki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 10:12:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 08:12:54 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |severine.queune at bulac.fr --- Comment #33 from Séverine Queune --- Falling back to patching base and 3-way merge... Auto-merging virtualshelves/sendshelf.pl CONFLICT (content): Merge conflict in virtualshelves/sendshelf.pl Auto-merging virtualshelves/downloadshelf.pl CONFLICT (modify/delete): t/Koha_Email.t deleted in HEAD and modified in Bug 13345: Allow patrons to choose format on sending basket/list by email. Version Bug 13345: Allow patrons to choose format on sending basket/list by email of t/Koha_Email.t left in tree. Auto-merging opac/opac-sendshelf.pl CONFLICT (content): Merge conflict in opac/opac-sendshelf.pl Auto-merging opac/opac-sendbasket.pl CONFLICT (content): Merge conflict in opac/opac-sendbasket.pl Auto-merging opac/opac-downloadshelf.pl Auto-merging opac/opac-downloadcart.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasketform.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadcart.tt Auto-merging basket/sendbasket.pl CONFLICT (content): Merge conflict in basket/sendbasket.pl Auto-merging basket/downloadcart.pl Auto-merging basket/basket.pl Auto-merging Koha/Email.pm CONFLICT (content): Merge conflict in Koha/Email.pm Auto-merging C4/Biblio.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 13345: Allow patrons to choose format on sending basket/list by email The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-13345-Allow-patrons-to-choose-format-on-sendin-QUTNYW.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 10:20:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 08:20:15 +0000 Subject: [Koha-bugs] [Bug 24023] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #16 from Séverine Queune --- Argh... Sorry Julian... Falling back to patching base and 3-way merge... Auto-merging tools/inventory.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql Auto-merging circ/returns.pl Auto-merging catalogue/detail.pl Auto-merging admin/columns_settings.yml Auto-merging C4/Items.pm Auto-merging C4/Biblio.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 24023: Add ability to create bundles of items The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-24023-Add-ability-to-create-bundles-of-items-nCjUy1.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 10:34:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 08:34:33 +0000 Subject: [Koha-bugs] [Bug 5242] Import patrons directly from Excel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5242 --- Comment #5 from Pascale Nalon --- This bug is obsolete, patrons' import had been added to koha for a long time ... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 10:37:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 08:37:03 +0000 Subject: [Koha-bugs] [Bug 5242] Import patrons directly from Excel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5242 --- Comment #6 from Pascale Nalon --- I think this bug is not really one ... this one could be closed -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 10:44:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 08:44:52 +0000 Subject: [Koha-bugs] [Bug 27607] Add the ability to compare patron records during merge process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27607 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 10:44:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 08:44:55 +0000 Subject: [Koha-bugs] [Bug 27607] Add the ability to compare patron records during merge process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27607 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117124|0 |1 is obsolete| | --- Comment #12 from Séverine Queune --- Created attachment 119064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119064&action=edit Bug 27607: Add the ability to compare patron records during merge process This patch adds an option to compare two patron records during the patron merge process. It can't work with more than two patrons, so the option only appears if one has selected only two patrons to merge. This patch also adds links to the patron names for opening the patron record in a new tab. To test, apply the patch and perform a search for patrons in the staff client Patrons module. - Select two patrons in the list of search results and click "Merge selected patrons." - On the merge patron records page, confirm that the two patron names are links which, when clicked, open the patron details in another tab. - Click a radio button to select the patron whose record will be the basis of the merge. The "Compare patrons" button and "Merge patrons" should go from disabled to enabled. - Click the "Compare patrons" button. A modal window should display highlighting the differences in some selected values in the patron record. The patron you selected as the basis for the merge should appear on the left. - Close the modal and select the other patron as the basis of the merge. "Compare patrons" again. The other patron should now appear in the left pane of the comparison. - Test that the "Merge patrons" button in the modal window works correctly to submit the merge form and that the correct patron is used as the basis for merging. - Repeat the same process above but select more than two patrons for merging. The "Compare patrons" button should not appear. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 10:44:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 08:44:58 +0000 Subject: [Koha-bugs] [Bug 27607] Add the ability to compare patron records during merge process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27607 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117125|0 |1 is obsolete| | --- Comment #13 from Séverine Queune --- Created attachment 119065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119065&action=edit Bug 27607: (QA follow-up) Make label match patron form: ZIP/Postal code Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 10:47:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 08:47:56 +0000 Subject: [Koha-bugs] [Bug 27724] Use lenient also in Elasticsearch authorities search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr --- Comment #5 from Séverine Queune --- Sorry, I missed the first patch during the signoff, I correct that in a second ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 10:49:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 08:49:21 +0000 Subject: [Koha-bugs] [Bug 27724] Use lenient also in Elasticsearch authorities search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116996|0 |1 is obsolete| | --- Comment #6 from Séverine Queune --- Created attachment 119066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119066&action=edit Bug 27724: Add unit test Run t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 10:49:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 08:49:24 +0000 Subject: [Koha-bugs] [Bug 27724] Use lenient also in Elasticsearch authorities search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27724 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119062|0 |1 is obsolete| | --- Comment #7 from Séverine Queune --- Created attachment 119067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119067&action=edit Bug 27724: Use lenient also in Elasticsearch authorities search In Elasticsearch, query for biblios uses lenient=true. This is also needed for authorities search. In case a search field is defined as type numeric. Test plan : 1) Use Elasticsearch searchengine 2) Define a search field 'local-number' as type 'Number' 3) Be sure to us 'local-number' in autorities mapping 4) Rebuild autorities 5) Performe a search for autorities with 'Search entire record' and 'contains' with term '123' => Without patch you get error : [query_shard_exception] Can only use prefix queries on keyword and text fields - not on [local-number] which is of type [integer] Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 11:01:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 09:01:22 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #152 from Koha Team University Lyon 3 --- Some more details : I tried a daily frequency with the following data : 05/04/2021 to 11/04/2021 (french notation = 5 april 2021 to 11 april 2021) first issue 05/04/2021 subs start : idem issues 7 subs end : 11/04/2021 wednesday and thursday are checked as irregulars multireceiving 5 items renewing : wednesday and thursday are still checked. That's OK but when I submit the form, the following message is displayed : "Renewing is cancelled, contact the administrator" Going back to Editing subscription, in Test pattern it's said : End date is not consistent with subscription length. Indeed end date is remained on 11/04/2021 I decided to delete enddate and let it making itself but when saving I get again the error message "The method Koha::Subscriptions->startdate is not covered by tests!" Olivier -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 11:02:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 09:02:56 +0000 Subject: [Koha-bugs] [Bug 27884] Add html mail support for email report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi Status|Signed Off |Failed QA --- Comment #6 from Joonas Kylmälä --- Looks good but an automated test is still needed for this in t/db_dependent/Reports/Guided.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 11:05:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 09:05:06 +0000 Subject: [Koha-bugs] [Bug 27884] Add html mail support for email report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 --- Comment #7 from Joonas Kylmälä --- The bug number was also not right in the patch title. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 11:12:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 09:12:37 +0000 Subject: [Koha-bugs] [Bug 24564] The adding of new subfields according to IFLA updates doesn't respect existing tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24564 --- Comment #2 from Julian Maurice --- Created attachment 119068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119068&action=edit Bug 24564: Use the same tab as the other subfields within a field For each subfield added, we check if other subfields exists in the same field. If that's the case we use the same tab as the first subfield found. Test plan: 1. Find a biblio subfield in misc/migration_tools/ifla/data/biblio/default.yml that doesn't exist in your default biblio MARC framework (or delete one). The field should exist and have other subfields with a tab set. 2. Change the tab of all subfields within that field it's different from what's in the .yml file 3. Run misc/migration_tools/ifla/update.pl 4. Verify that the subfield has been added and have the same tab as others subfields 5. Do the same for authorities (files are in misc/migration_tools/ifla/data/auth/) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 11:16:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 09:16:19 +0000 Subject: [Koha-bugs] [Bug 27937] Date of birth entered without correct format causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27937 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |joonas.kylmala at helsinki.fi |y.org | CC| |joonas.kylmala at helsinki.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 11:25:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 09:25:27 +0000 Subject: [Koha-bugs] [Bug 27937] Date of birth entered without correct format causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27937 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 11:25:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 09:25:30 +0000 Subject: [Koha-bugs] [Bug 27937] Date of birth entered without correct format causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27937 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118368|0 |1 is obsolete| | --- Comment #6 from Joonas Kylmälä --- Created attachment 119069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119069&action=edit Bug 27937: Set datepicker when date is valid When validating dates in JavaScript it is acceptable to have single digit days or months e.g,: 2011-6-16 When parsing in Koha::DateUtils->dt_from_string we die on these This patch uses JS to set the datepicker which normalizes the date as Koha expects To test: 1 - Add new patron 2 - Enter birthdate as 2/11/1986 3 - Complete required fields 4 - Save 5 - Get ISE The given date (2/11/1986) does not match the date format (us) at /kohadevbox/koha/Koha/DateUtils.pm line 175 6 - Apply patch 7 - Repeat 1-2 8 - Note that when you change focus (click on another field) the date is formatted as '02/11/1986' 9 - Save patron, success! 10 - Edit patron, try setting DOB to 2/1/1986 11 - Change focus and note date is formatted as '02/01/1986', save 12 - Repeat with other settings of system preference 'dateformat' Signed-off-by: Donna Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 11:25:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 09:25:34 +0000 Subject: [Koha-bugs] [Bug 27937] Date of birth entered without correct format causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27937 --- Comment #7 from Joonas Kylmälä --- Created attachment 119070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119070&action=edit Bug 27937: (QA follow-up) Fix indentation Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 12:33:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 10:33:30 +0000 Subject: [Koha-bugs] [Bug 27916] Fee paid message can crash SIP server if paying fee that is not "renewable" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27916 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi --- Comment #7 from Joonas Kylmälä --- I hope also that we could get unit test for this, i wasn't able to trigger the error manually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 13:05:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 11:05:13 +0000 Subject: [Koha-bugs] [Bug 11825] Hide shelving locations from advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11825 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com Component|OPAC |System Administration Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 13:42:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 11:42:18 +0000 Subject: [Koha-bugs] [Bug 27916] Fee paid message can crash SIP server if paying fee that is not "renewable" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27916 --- Comment #8 from Kyle M Hall --- (In reply to Martin Renvoize from comment #6) > Any chance of a unit test here Kyle? I'll see what I can do! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 13:47:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 11:47:01 +0000 Subject: [Koha-bugs] [Bug 27869] QotD CSV upload JavaScript errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27869 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 13:47:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 11:47:05 +0000 Subject: [Koha-bugs] [Bug 27869] QotD CSV upload JavaScript errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27869 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117949|0 |1 is obsolete| | --- Comment #6 from Joonas Kylmälä --- Created attachment 119071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119071&action=edit Bug 27869: let user know something went wrong with csv upload To test: -attempt to upload a malformed CSV file -nothing happens, check the console and see the error: Uncaught TypeError: arrData[(arrData.length - 1)] is undefined -apply patch -try again -now you should at least see a warning that something went wrong -attempt to upload a good CSV file, it should work Signed-off-by: David Nind Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 13:47:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 11:47:21 +0000 Subject: [Koha-bugs] [Bug 27869] QotD CSV upload JavaScript errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27869 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |joonas.kylmala at helsinki.fi |y.org | CC| |joonas.kylmala at helsinki.fi -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 13:52:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 11:52:19 +0000 Subject: [Koha-bugs] [Bug 28056] Add Koha::Exceptions::Patron::MissingMandatoryExtendedAttribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28056 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 13:52:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 11:52:21 +0000 Subject: [Koha-bugs] [Bug 28056] Add Koha::Exceptions::Patron::MissingMandatoryExtendedAttribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28056 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119051|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 119072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119072&action=edit Bug 28056: Unit tests Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 13:52:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 11:52:24 +0000 Subject: [Koha-bugs] [Bug 28056] Add Koha::Exceptions::Patron::MissingMandatoryExtendedAttribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28056 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119052|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 119073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119073&action=edit Bug 28056: Add Koha::Exceptions::Patron::MissingMandatoryExtendedAttribute This trivial patch adds a new exception for more fine-grained control on the errors when dealing with patrons and their extended attributes. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/Koha/Exceptions.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 14:01:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 12:01:05 +0000 Subject: [Koha-bugs] [Bug 20390] Elasticsearch - Mappings for UNIMARC (updates existing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20390 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87720|0 |1 is obsolete| | Attachment #88925|0 |1 is obsolete| | --- Comment #21 from Alex Arnaud --- Created attachment 119074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119074&action=edit Unimarc mappings evolution for Elasticsearch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 14:01:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 12:01:50 +0000 Subject: [Koha-bugs] [Bug 20390] Elasticsearch - Mappings for UNIMARC (updates existing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20390 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com --- Comment #22 from Alex Arnaud --- Patches rebased and squashed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 14:21:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 12:21:14 +0000 Subject: [Koha-bugs] [Bug 27773] Hide unique holidays and exceptions which have passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27773 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Séverine Queune --- Sorry Owen, the patch doesn't apply :/ Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27773: Hide unique holidays and exceptions which have passed error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt). error: could not build fake ancestor Patch failed at 0001 Bug 27773: Hide unique holidays and exceptions which have passed The copy of the patch that failed is found in: .git/rebase-apply/patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 14:40:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 12:40:12 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #20 from Martin Renvoize --- I've somewhat lost track of this one I'm afraid.. I'll try to take a look next week.. do you think we're still aiming for 21.05 for it Jonathan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 14:42:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 12:42:50 +0000 Subject: [Koha-bugs] [Bug 26635] Expand authorised values in REST API call In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 --- Comment #22 from Martin Renvoize --- (In reply to Tomás Cohen Arazi from comment #21) > (In reply to Tomás Cohen Arazi from comment #18) > > (In reply to Martin Renvoize from comment #17) > > > I'm not sure we need the full AV object expanded.. and I'm thinking if would > > > be 'nicer' to access it directly rather than have to do a subsequent lookup > > > in JS? > > > > I would go for an $av->to_api object, that names things better: lib/lib_opac > > => description, picking the right one according to the caller context. > > What do you think, Agustín? I'm onboard with this... embedding them and using to_api to make the naming clear.. I reckon we could be onto a winner -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 14:44:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 12:44:43 +0000 Subject: [Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #36 from Martin Renvoize --- Any QA people interested here.. this is a significant cleanup piece and would be great to see it progress. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 14:45:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 12:45:08 +0000 Subject: [Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 14:46:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 12:46:03 +0000 Subject: [Koha-bugs] [Bug 12362] Branch transfer records orphaned on cancelled holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12362 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118607|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 14:55:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 12:55:05 +0000 Subject: [Koha-bugs] [Bug 18912] Show more item information when using itemBarcodeFallbackSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18912 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117110|0 |1 is obsolete| | --- Comment #6 from Victor Grousset/tuxayo --- Created attachment 119075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119075&action=edit Bug 18912: Display more info when using itemBarcodeFallbackSearch Using itemBarcodeFallbackSearch entering a barcode on checkout will do a keyword search and provide you with a list of items matching the search term for checkout. This allows checking out items, where there is no barcode in the item (you still need a dummy barcode in Koha). At the moment the table of items to choose from will only chow the title and the dummy barcode. In order to make it more useful and easier to identify the correct item, we should show more information here: - callnumber (952$o) - serial enumeration (952$h) - copy number (952$t) - inventory number (952$i) (description copier from comment 0) Test plan: - Turn on itemBarcodeFallbackSearch (If you have ES you need bug 27597) - Check an item out using "street" or a search that will return several items - Note that you have now more info about the items Signed-off-by: Owen Leonard Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 14:55:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 12:55:08 +0000 Subject: [Koha-bugs] [Bug 18912] Show more item information when using itemBarcodeFallbackSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18912 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117111|0 |1 is obsolete| | --- Comment #7 from Victor Grousset/tuxayo --- Created attachment 119076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119076&action=edit Bug 18912: (follow-up) Add even more information This follow-up proposes that we add even more information (collection code, item type) and puts the new information in to table columns. Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 14:55:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 12:55:16 +0000 Subject: [Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr --- Comment #16 from Séverine Queune --- No problem pllying the patchs, but I don't have any alert in the script. Maybe the problem comes from my side, I prefer not updating the status and let someone else try. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 14:56:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 12:56:51 +0000 Subject: [Koha-bugs] [Bug 18912] Show more item information when using itemBarcodeFallbackSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18912 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #8 from Victor Grousset/tuxayo --- Tried to QA, couldn't get a good grasp of the code but at least here is another signoff :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 15:00:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 13:00:30 +0000 Subject: [Koha-bugs] [Bug 12362] Branch transfer records orphaned on cancelled holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12362 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 15:01:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 13:01:26 +0000 Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #45 from Séverine Queune --- Needs rebase once more... CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt Auto-merging C4/Reserves.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 16787: 'Too many holds' message appears inappropriately and is missing data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 15:02:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 13:02:59 +0000 Subject: [Koha-bugs] [Bug 27773] Hide unique holidays and exceptions which have passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27773 Pascale Nalon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pascale.nalon at ensmp.fr, | |pascale.nalon at mines-pariste | |ch.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 15:03:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 13:03:52 +0000 Subject: [Koha-bugs] [Bug 15104] Batch Record Modification Performance Improvement In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15104 Pascale Nalon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pascale.nalon at ensmp.fr, | |pascale.nalon at mines-pariste | |ch.fr, | |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 15:24:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 13:24:25 +0000 Subject: [Koha-bugs] [Bug 26940] debarred comment in borrowers table is lost on patron modifications in memberentry.pl page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26940 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr --- Comment #23 from Séverine Queune --- Jonathan and Katrin, I don't know if you're waiting for a specific sign off from Didier, but to me everything works fine. Here are the results of the different requests, wich seem consistent to me : mysql> SELECT d.borrowernumber, GROUP_CONCAT(comment SEPARATOR '\n') AS comment FROM borrower_debarments d JOIN borrowers b ON b.borrowernumber=d.borrowernumber WHERE (b.debarredcomment IS NULL OR b.debarredcomment = '') AND ( expiration > CURRENT_DATE() OR expiration IS NULL ) GROUP BY d.borrowernumber; +----------------+---------+ | borrowernumber | comment | +----------------+---------+ | 70 | NULL | +----------------+---------+ 1 row in set (0.00 sec) mysql> SELECT COUNT(*) FROM (SELECT 1 FROM borrower_debarments d JOIN borrowers b ON b.borrowernumber=d.borrowernumber WHERE (b.debarredcomment IS NULL ) AND ( expiration > CURRENT_DATE() OR expiration IS NULL ) GROUP BY d.borrowernumber) as e; +----------+ | COUNT(*) | +----------+ | 1 | +----------+ 1 row in set (0.01 sec) mysql> SELECT COUNT(*) FROM (SELECT 1 FROM borrower_debarments d JOIN borrowers b ON b.borrowernumber=d.borrowernumber WHERE (b.debarredcomment IS NULL OR b.debarredcomment = '' ) AND ( expiration > CURRENT_DATE() OR expiration IS NULL ) AND (comment IS NOT NULL OR comment <> '') GROUP BY d.borrowernumber) as e; +----------+ | COUNT(*) | +----------+ | 0 | +----------+ 1 row in set (0.00 sec) Let me know if you need I sign it ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 15:36:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 13:36:28 +0000 Subject: [Koha-bugs] [Bug 27773] Hide unique holidays and exceptions which have passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27773 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 15:36:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 13:36:32 +0000 Subject: [Koha-bugs] [Bug 27773] Hide unique holidays and exceptions which have passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27773 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117260|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 119077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119077&action=edit Bug 27773: Hide unique holidays and exceptions which have passed This patch modifies the display of unique holidays and holiday exceptions so that dates in the past are hidden by default. A corresponding "Show past entries" checkbox can be checked to show the hidden entries. This patch also moves the inline CSS to a separate file because I want to. To test you should have some unique holidays and holiday exceptions in your system from the past and in the future. - Apply the patch and go to Tools -> Calendar - In the tables of existing holidays, check that no dates in the past appear in the "Exceptions" or "Unique holidays" tables. - Checking the checkbox at the top of each of these tables should trigger the display of the hidden rows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 15:37:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 13:37:15 +0000 Subject: [Koha-bugs] [Bug 27773] Hide unique holidays and exceptions which have passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27773 --- Comment #4 from Owen Leonard --- (In reply to Séverine Queune from comment #2) > Sorry Owen, the patch doesn't apply :/ My fault, I forgot to squash two patches! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 15:43:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 13:43:32 +0000 Subject: [Koha-bugs] [Bug 28069] New: Can't sort lists on 'Contents' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28069 Bug ID: 28069 Summary: Can't sort lists on 'Contents' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: severine.queune at bulac.fr QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl On staff client, it's not possible to sort lists by 'Contents'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 15:47:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 13:47:34 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103433|0 |1 is obsolete| | Attachment #103434|0 |1 is obsolete| | Attachment #103435|0 |1 is obsolete| | --- Comment #34 from Julian Maurice --- Created attachment 119078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119078&action=edit Bug 13345: Allow patrons to choose format on sending basket/list by email It is already possible to download a basket(cart) or a list using different format. But by email, only iso2709 is possible. This patch adds the ability to select a format for the file attached to the email when sending the basket/list content. Test plan: 1/ At the OPAC, add some records to your basket and send it by email using different formats (RIS, BibTeX, MARC and the CSV profiles defined). 2/ At the OPAC, add some records to a list and send it by email using the different formats. 3/ Redo step 1 at the intranet 4/ Redo step 2 at the intranet Note that subtitles are not displayed in all these cases. Note for QA: This patch refactors 2 main things: 1/ Template side: the dropdown list to select the format is now in an include file (indeed, this list is used in 4 templates, this will make easier further changes). The include files are named 'download-export-available-formats.inc', feel free to suggest something better. The are used in: [opac-]sendbasket.tt, [opac-]sendshelf.tt, [opac-]downloadbasket.tt and [opac-]downloadshelf.tt. 2/ Build records data and the records file This job was done in 4 scripts: - opac/opac-sendbasket.pl - opac/opac-sendshelf.pl - basket/sendbasket.pl - virtualshelves/sendshelf.pl Now it's done in C4::Biblio::BuildBiblioDataForExport and tests are provided in t/db_dependent/Biblio/BuildBiblioDataForExport.t Note that a similar job is done in [opac-]downloadcart.pl and [opac-]downloadshelf.pl Sponsored-by: Mines Paristech Signed-off-by: Nicole C. Engard Signed-off-by: Bernardo Gonzalez Kriegel Test pass and mail sent, no errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 15:48:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 13:48:20 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 15:51:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 13:51:36 +0000 Subject: [Koha-bugs] [Bug 26312] Add some error handling during Elasticsearch indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26312 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 15:51:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 13:51:39 +0000 Subject: [Koha-bugs] [Bug 26312] Add some error handling during Elasticsearch indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26312 --- Comment #22 from Nick Clemens --- Created attachment 119079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119079&action=edit Bug 26312: (follow-up) Fix passing of exception messages 'error' has special meaning in exceptions so naming the fields: type, details Rather than only dealing with a single exception type, we generically get the ES exception info and pass it up. I could not recreate timeout still, however, I simply restarted the ES docker during commit stage to cause NoNodes exceptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 15:53:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 13:53:21 +0000 Subject: [Koha-bugs] [Bug 28070] New: Ability to batch delete lists Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28070 Bug ID: 28070 Summary: Ability to batch delete lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: severine.queune at bulac.fr QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl On staff client, a great option would be to batch delete private and (for those allowed) public lists (aka virtualshelves). It can be especially uefull to easily clean some (very) old lists, which can be for now a quite hard job to do ! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 15:57:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 13:57:33 +0000 Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through Stage Marc Record Import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Pascale Nalon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pascale.nalon at ensmp.fr --- Comment #5 from Pascale Nalon --- In the test plan,is it necessary to set matching rules in administration page ? Without one, the only choice in "Record matching rule" line is "Don't look for matching records" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 15:59:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 13:59:58 +0000 Subject: [Koha-bugs] [Bug 20424] New UNIMARC ZEBRA indexes according to last IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119053|0 |1 is obsolete| | --- Comment #10 from Alex Arnaud --- Created attachment 119080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119080&action=edit Bug 20424: (Followup) Add new zebra indexes for the last IFLA updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 16:00:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 14:00:06 +0000 Subject: [Koha-bugs] [Bug 20424] New UNIMARC ZEBRA indexes according to last IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119054|0 |1 is obsolete| | --- Comment #11 from Alex Arnaud --- Created attachment 119081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119081&action=edit Bug 20424: provides biblio-zebra-indexdefs.xsl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 16:00:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 14:00:56 +0000 Subject: [Koha-bugs] [Bug 27873] Make display of patron restrictions, charges, notes, etc. consistent for check out and patron details screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27873 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 16:02:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 14:02:07 +0000 Subject: [Koha-bugs] [Bug 28071] New: Ability to batch remove titles from a list Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28071 Bug ID: 28071 Summary: Ability to batch remove titles from a list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: severine.queune at bulac.fr QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Sometimes, lists can have a quite large number of titles. With the export option, it's easy to work on this corpus, and, sometimes, find some titles we finally don't want in that list. If they are numerous, it's for now quite painful to find and delete them. A useful option could be, as it exists with the button "Add items", to be able to remove several titles at a time using barcode or biblionumber. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 16:07:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 14:07:40 +0000 Subject: [Koha-bugs] [Bug 22992] When you merge records in a list there is no way to return to the list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22992 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 16:07:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 14:07:41 +0000 Subject: [Koha-bugs] [Bug 7676] Barcode Prefixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7676 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX CC| |kyle at bywatersolutions.com Status|In Discussion |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 16:09:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 14:09:18 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 16:14:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 14:14:01 +0000 Subject: [Koha-bugs] [Bug 24564] The adding of new subfields according to IFLA updates doesn't respect existing tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24564 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119068|0 |1 is obsolete| | --- Comment #3 from Julian Maurice --- Created attachment 119082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119082&action=edit Bug 24564: Use the same tab as the other subfields within a field For each subfield added, we check if other subfields exists in the same field. If that's the case we use the same tab as the first subfield found. Test plan: 1. Find a biblio subfield in misc/migration_tools/ifla/data/biblio/default.yml that doesn't exist in your default biblio MARC framework (or delete one). The field should exist and have other subfields with a tab set. 2. Change the tab of all subfields within that field it's different from what's in the .yml file 3. Run misc/migration_tools/ifla/update.pl 4. Verify that the subfield has been added and have the same tab as others subfields 5. Do the same for authorities (files are in misc/migration_tools/ifla/data/auth/) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 16:59:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 14:59:48 +0000 Subject: [Koha-bugs] [Bug 27773] Hide unique holidays and exceptions which have passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27773 --- Comment #5 from Pascale Nalon --- Test done this day on a ptfs sandbox : everything works fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 17:08:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 15:08:00 +0000 Subject: [Koha-bugs] [Bug 28054] SIPServer.pm is a program and requires a shebang In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28054 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26673 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe. |ity.org |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26673 [Bug 26673] Remove Perl shebangs from Perl modules -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 17:08:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 15:08:00 +0000 Subject: [Koha-bugs] [Bug 26673] Remove Perl shebangs from Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26673 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28054 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28054 [Bug 28054] SIPServer.pm is a program and requires a shebang -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 17:08:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 15:08:06 +0000 Subject: [Koha-bugs] [Bug 27869] QotD CSV upload JavaScript errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27869 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 17:10:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 15:10:21 +0000 Subject: [Koha-bugs] [Bug 27869] QotD CSV upload JavaScript errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27869 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch handles release notes| |malformed CSV errors by | |producing a warning on the | |page letting users know | |that the CSV filed uploaded | |has errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 17:11:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 15:11:48 +0000 Subject: [Koha-bugs] [Bug 26970] Add row highlight on drag in Elasticsearch mapping template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26970 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 17:11:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 15:11:51 +0000 Subject: [Koha-bugs] [Bug 26970] Add row highlight on drag in Elasticsearch mapping template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26970 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113302|0 |1 is obsolete| | --- Comment #3 from Séverine Queune --- Created attachment 119083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119083&action=edit Bug 26970: Add row highlight on drag in Elasticsearch mapping template In Elasticsearch mapping tables : In order to better see which row is currently in drag-an-drop, add an highlight color like in circulation and fine rules when editing a row. Test plan : 1) Go to Administration > Search engine configuration (Elasticsearch) 2) In each table : biblio, authorities, facets 3) Clik on a row to start a drag => See row turning orange 4) Release to drop => See row turning back to original color https://bugs.koha-community.org/show_bug.cgi?id=26970 Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 17:16:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 15:16:23 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #65 from Séverine Queune --- Sorry Agustín, the patch needs a new rebase... CONFLICT (content): Merge conflict in t/db_dependent/Koha/Item.t error: Failed to merge in the changes. Patch failed at 0001 Bug 8179: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 17:32:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 15:32:04 +0000 Subject: [Koha-bugs] [Bug 26955] Allow macros in Advanced Cataloging Editor to be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26955 Heather changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 17:34:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 15:34:40 +0000 Subject: [Koha-bugs] [Bug 26373] Add ability to used different font color or background color for specific MARC tags in Advanced Editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26373 Holly changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc at interleaf.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 17:41:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 15:41:56 +0000 Subject: [Koha-bugs] [Bug 28072] New: Z39.50/SRU servers would be a great addition to Mana KB Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28072 Bug ID: 28072 Summary: Z39.50/SRU servers would be a great addition to Mana KB Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Mana-kb Assignee: koha-bugs at lists.koha-community.org Reporter: jrobb at sekls.org CC: alex.arnaud at biblibre.com It would be very helpful if Mana KB allowed libraries to share, search, and import targets for copy cataloging. It could be added to Koha's Z39.50/SRU servers administration page. Search filters might include type of library, language, maybe a way to find a target with specialized collections like medical or law. It might also be good to have a way to handle targets that stop working - like a way to test them prior to import and/or a way to flag them for review/removal. There are various websites around where you can pick up new targets, but often you have to trial and error your way to identify if the target works at all, and if the target has the kinds of records you're seeking. Having those categorized better and imported at the push of a button would save time and effort. With enough collaboration from the Koha community, this could also lead to a much more robust centralized collection of targets than anything currently available. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 17:43:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 15:43:21 +0000 Subject: [Koha-bugs] [Bug 28072] Z39.50/SRU servers would be a great addition to Mana KB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28072 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 17:58:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 15:58:41 +0000 Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Attachment #118708|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:01:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:01:08 +0000 Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #7 from Jonathan Druart --- We are removing the password from the notice template for new installations only, for existing installations the generated notices will be "password: ". I don't think we should remove the password key in the controller script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:02:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:02:52 +0000 Subject: [Koha-bugs] [Bug 26705] System preference NoticeBcc not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26705 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:05:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:05:30 +0000 Subject: [Koha-bugs] [Bug 27937] Date of birth entered without correct format causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27937 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119069|0 |1 is obsolete| | Attachment #119070|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 119084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119084&action=edit Bug 27937: Set datepicker when date is valid When validating dates in JavaScript it is acceptable to have single digit days or months e.g,: 2011-6-16 When parsing in Koha::DateUtils->dt_from_string we die on these This patch uses JS to set the datepicker which normalizes the date as Koha expects To test: 1 - Add new patron 2 - Enter birthdate as 2/11/1986 3 - Complete required fields 4 - Save 5 - Get ISE The given date (2/11/1986) does not match the date format (us) at /kohadevbox/koha/Koha/DateUtils.pm line 175 6 - Apply patch 7 - Repeat 1-2 8 - Note that when you change focus (click on another field) the date is formatted as '02/11/1986' 9 - Save patron, success! 10 - Edit patron, try setting DOB to 2/1/1986 11 - Change focus and note date is formatted as '02/01/1986', save 12 - Repeat with other settings of system preference 'dateformat' Signed-off-by: Donna Signed-off-by: Joonas Kylmälä Bug 27937: (QA follow-up) Fix indentation Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:13:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:13:45 +0000 Subject: [Koha-bugs] [Bug 26705] System preference NoticeBcc not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26705 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The Email::Stuffer library release notes| |we use, doesn't handle Bcc | |as Mail::Sendmail does. So | |Bcc handling wasn't working | |as expected. This patchset | |adds support for explicitly | |handling Bcc (including the | |NoticeBcc feature) to our | |Koha::Email library. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:21:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:21:05 +0000 Subject: [Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Passed QA |In Discussion --- Comment #7 from Jonathan Druart --- I don't manage to convince myself it's correct. There is an edge case, looking at the code: The patron iterator is set before the ITEM loop. On the second item, it won't be reset and we won't iterate over all the patrons. Nick and/or Joonas, can you double check it please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:23:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:23:58 +0000 Subject: [Koha-bugs] [Bug 28043] Some patron clubs operations don't work from later pages of results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28043 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Attachment #118883|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:28:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:28:07 +0000 Subject: [Koha-bugs] [Bug 27738] Set fallback for unset DefaultCountryField008 to |||, "no attempt to code" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27738 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- + - " Empty defaults to ||| for No attempt to code." Is the uppercase expected ("No")? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:34:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:34:33 +0000 Subject: [Koha-bugs] [Bug 27726] OPACProblemReports cuts off message text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #13 from Jonathan Druart --- I am getting an error: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: BLOB/TEXT column 'content' can't have a default value [for Statement "ALTER TABLE problem_reports MODIFY content TEXT NOT NULL DEFAULT ''"] at /usr/share/perl5/DBIx/Class/Schema.pm line 1118. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:41:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:41:42 +0000 Subject: [Koha-bugs] [Bug 26836] Add ability to assign Z39.50 servers to groups for searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26836 Jason Robb changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb at sekls.org --- Comment #1 from Jason Robb --- Agreed this would be a great addition and especially helpful in a consortium setting where each library does their own cataloging. For example, we have some targets that use conventions very similar to ours for DVD records, but that target's book records end up needing more edits. So if we could place that target in a "Good Audiovisual Records" group and leave them out of the "Good Book Records" group, then we could avoid some of the extra work needed to fix bad book records that are pulled in from the good AV target. For the interface/usability design, it might be nice to borrow from the user permissions page, where the groups are top-level checkboxes and the individual targets are collapsed inside, but you could still expand the groups to check and uncheck individual targets within a group if you wanted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:45:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:45:53 +0000 Subject: [Koha-bugs] [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 |27636 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27636 [Bug 27636] Replace Koha::Account::pay with a simpler method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:45:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:45:53 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|27927 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:45:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:45:53 +0000 Subject: [Koha-bugs] [Bug 27636] Replace Koha::Account::pay with a simpler method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27636 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27927 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 [Bug 27927] longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:46:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:46:56 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #21 from Jonathan Druart --- (In reply to Martin Renvoize from comment #20) > I've somewhat lost track of this one I'm afraid.. I'll try to take a look > next week.. do you think we're still aiming for 21.05 for it Jonathan? Yes, I am still willing to push it for 21.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:48:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:48:18 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #22 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #21) > (In reply to Martin Renvoize from comment #20) > > I've somewhat lost track of this one I'm afraid.. I'll try to take a look > > next week.. do you think we're still aiming for 21.05 for it Jonathan? > > Yes, I am still willing to push it for 21.05. I'm playing with this at the moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:53:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:53:21 +0000 Subject: [Koha-bugs] [Bug 21260] Improve the Availability line of OPAC XSLT search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21260 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:53:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:53:23 +0000 Subject: [Koha-bugs] [Bug 21260] Improve the Availability line of OPAC XSLT search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21260 --- Comment #36 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:53:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:53:25 +0000 Subject: [Koha-bugs] [Bug 21958] _check_valid_auth_link checks too many subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21958 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:53:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:53:28 +0000 Subject: [Koha-bugs] [Bug 21958] _check_valid_auth_link checks too many subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21958 --- Comment #19 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:53:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:53:31 +0000 Subject: [Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:53:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:53:33 +0000 Subject: [Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 --- Comment #20 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:53:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:53:36 +0000 Subject: [Koha-bugs] [Bug 26517] Avoid deleting patrons with permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26517 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:53:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:53:39 +0000 Subject: [Koha-bugs] [Bug 26517] Avoid deleting patrons with permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26517 --- Comment #18 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:53:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:53:40 +0000 Subject: [Koha-bugs] [Bug 27726] OPACProblemReports cuts off message text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 --- Comment #14 from Martin Renvoize --- (In reply to Jonathan Druart from comment #13) > I am getting an error: > > {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: BLOB/TEXT column > 'content' can't have a default value [for Statement "ALTER TABLE > problem_reports MODIFY content TEXT NOT NULL DEFAULT ''"] at > /usr/share/perl5/DBIx/Class/Schema.pm line 1118. Interesting.. that's a super easy fix, just drop the default as it doesn't make sense anyway.. but I'm surprised you got that.. what SQL server are you using? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:53:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:53:41 +0000 Subject: [Koha-bugs] [Bug 26705] System preference NoticeBcc not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26705 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:53:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:53:43 +0000 Subject: [Koha-bugs] [Bug 26705] System preference NoticeBcc not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26705 --- Comment #29 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:53:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:53:46 +0000 Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some types of automatic code cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:53:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:53:48 +0000 Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some types of automatic code cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942 --- Comment #15 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:53:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:53:50 +0000 Subject: [Koha-bugs] [Bug 26999] "Any library" not translatable on the hold list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26999 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:53:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:53:52 +0000 Subject: [Koha-bugs] [Bug 26999] "Any library" not translatable on the hold list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26999 --- Comment #8 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:53:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:53:54 +0000 Subject: [Koha-bugs] [Bug 27397] Serials: The description input field when defining numbering patterns is too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27397 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:53:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:53:57 +0000 Subject: [Koha-bugs] [Bug 27397] Serials: The description input field when defining numbering patterns is too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27397 --- Comment #12 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:54:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:54:00 +0000 Subject: [Koha-bugs] [Bug 27566] CSS rule not applying to HTML select / option - displays with serif font ignoring rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:54:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:54:02 +0000 Subject: [Koha-bugs] [Bug 27566] CSS rule not applying to HTML select / option - displays with serif font ignoring rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 --- Comment #14 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:54:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:54:04 +0000 Subject: [Koha-bugs] [Bug 27610] Accessibility: OPAC -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:54:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:54:07 +0000 Subject: [Koha-bugs] [Bug 27610] Accessibility: OPAC -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610 --- Comment #41 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:54:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:54:10 +0000 Subject: [Koha-bugs] [Bug 27742] Accessibility: OPAC - Page titles should have unique information first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27742 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:54:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:54:12 +0000 Subject: [Koha-bugs] [Bug 27742] Accessibility: OPAC - Page titles should have unique information first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27742 --- Comment #9 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:54:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:54:14 +0000 Subject: [Koha-bugs] [Bug 27807] API DataTables Wrapper fails for ordered on multiple columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27807 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:54:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:54:17 +0000 Subject: [Koha-bugs] [Bug 27807] API DataTables Wrapper fails for ordered on multiple columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27807 --- Comment #12 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:54:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:54:19 +0000 Subject: [Koha-bugs] [Bug 27846] Accessibility: Staff Client - Breadcrumbs should be more accessible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27846 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:54:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:54:21 +0000 Subject: [Koha-bugs] [Bug 27846] Accessibility: Staff Client - Breadcrumbs should be more accessible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27846 --- Comment #72 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:54:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:54:24 +0000 Subject: [Koha-bugs] [Bug 27869] QotD CSV upload JavaScript errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27869 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:54:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:54:26 +0000 Subject: [Koha-bugs] [Bug 27869] QotD CSV upload JavaScript errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27869 --- Comment #7 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:54:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:54:29 +0000 Subject: [Koha-bugs] [Bug 27881] Markup error in masthead-langmenu.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27881 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:54:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:54:31 +0000 Subject: [Koha-bugs] [Bug 27881] Markup error in masthead-langmenu.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27881 --- Comment #7 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:54:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:54:33 +0000 Subject: [Koha-bugs] [Bug 27921] Timestamp in holds log is out of date when a hold is marked as waiting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27921 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:54:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:54:35 +0000 Subject: [Koha-bugs] [Bug 27921] Timestamp in holds log is out of date when a hold is marked as waiting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27921 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:54:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:54:38 +0000 Subject: [Koha-bugs] [Bug 27928] FindDuplicate is hardcoded to use Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27928 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:54:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:54:40 +0000 Subject: [Koha-bugs] [Bug 27928] FindDuplicate is hardcoded to use Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27928 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:54:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:54:42 +0000 Subject: [Koha-bugs] [Bug 27936] AllowItemsOnHoldCheckoutSIP does not allow checkout of items currently waiting for a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27936 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:54:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:54:45 +0000 Subject: [Koha-bugs] [Bug 27936] AllowItemsOnHoldCheckoutSIP does not allow checkout of items currently waiting for a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27936 --- Comment #15 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:54:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:54:47 +0000 Subject: [Koha-bugs] [Bug 27937] Date of birth entered without correct format causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27937 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:54:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:54:50 +0000 Subject: [Koha-bugs] [Bug 27937] Date of birth entered without correct format causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27937 --- Comment #9 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:54:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:54:52 +0000 Subject: [Koha-bugs] [Bug 27940] Fix missing email in OpacMaintenance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27940 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:54:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:54:54 +0000 Subject: [Koha-bugs] [Bug 27940] Fix missing email in OpacMaintenance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27940 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:54:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:54:57 +0000 Subject: [Koha-bugs] [Bug 27963] touch_all_items.pl script is not working at all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27963 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:54:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:54:59 +0000 Subject: [Koha-bugs] [Bug 27963] touch_all_items.pl script is not working at all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27963 --- Comment #14 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:55:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:55:01 +0000 Subject: [Koha-bugs] [Bug 27993] Koha::Item::Transfer->in_transit should not count cancelled transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27993 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:55:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:55:04 +0000 Subject: [Koha-bugs] [Bug 27993] Koha::Item::Transfer->in_transit should not count cancelled transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27993 --- Comment #8 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:55:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:55:07 +0000 Subject: [Koha-bugs] [Bug 27999] Display the description of authorized values category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27999 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:55:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:55:09 +0000 Subject: [Koha-bugs] [Bug 27999] Display the description of authorized values category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27999 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:55:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:55:12 +0000 Subject: [Koha-bugs] [Bug 28003] Invoice adjustments using inactive budgets do not indicate that status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28003 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:55:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:55:14 +0000 Subject: [Koha-bugs] [Bug 28003] Invoice adjustments using inactive budgets do not indicate that status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28003 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:55:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:55:16 +0000 Subject: [Koha-bugs] [Bug 28004] Incomplete breadcrumbs in authorized valued In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28004 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:55:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:55:19 +0000 Subject: [Koha-bugs] [Bug 28004] Incomplete breadcrumbs in authorized valued In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28004 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:55:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:55:21 +0000 Subject: [Koha-bugs] [Bug 28017] Allow non-FQDN and IP addresses in emails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28017 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:55:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:55:23 +0000 Subject: [Koha-bugs] [Bug 28017] Allow non-FQDN and IP addresses in emails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28017 --- Comment #16 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:55:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:55:26 +0000 Subject: [Koha-bugs] [Bug 28023] Typo in Reply-To header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:55:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:55:28 +0000 Subject: [Koha-bugs] [Bug 28023] Typo in Reply-To header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28023 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:55:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:55:30 +0000 Subject: [Koha-bugs] [Bug 28032] Button corrections in point of sale pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28032 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:55:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:55:32 +0000 Subject: [Koha-bugs] [Bug 28032] Button corrections in point of sale pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28032 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:55:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:55:34 +0000 Subject: [Koha-bugs] [Bug 28042] Button corrections in OAI set mappings template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28042 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:55:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:55:36 +0000 Subject: [Koha-bugs] [Bug 28042] Button corrections in OAI set mappings template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28042 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:55:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:55:39 +0000 Subject: [Koha-bugs] [Bug 28043] Some patron clubs operations don't work from later pages of results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28043 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:55:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:55:41 +0000 Subject: [Koha-bugs] [Bug 28043] Some patron clubs operations don't work from later pages of results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28043 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:55:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:55:44 +0000 Subject: [Koha-bugs] [Bug 28052] keys omitted in check for system preference override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28052 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:55:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:55:46 +0000 Subject: [Koha-bugs] [Bug 28052] keys omitted in check for system preference override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28052 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:55:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:55:48 +0000 Subject: [Koha-bugs] [Bug 28053] Warning in C4::Members::patronflags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28053 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:55:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:55:50 +0000 Subject: [Koha-bugs] [Bug 28053] Warning in C4::Members::patronflags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28053 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:55:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:55:52 +0000 Subject: [Koha-bugs] [Bug 28054] SIPServer.pm is a program and requires a shebang In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28054 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:55:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:55:55 +0000 Subject: [Koha-bugs] [Bug 28054] SIPServer.pm is a program and requires a shebang In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28054 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 18:57:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 16:57:13 +0000 Subject: [Koha-bugs] [Bug 27846] Accessibility: Staff Client - Breadcrumbs should be more accessible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27846 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #73 from Jonathan Druart --- Congratulations for your first patches pushed, Wainui! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 19:31:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 17:31:05 +0000 Subject: [Koha-bugs] [Bug 27738] Set fallback for unset DefaultCountryField008 to |||, "no attempt to code" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27738 --- Comment #7 from Phil Ringnalda --- Fun question! To me, it's clearly a quote of the formal description of the fill character from the spec, where no is always capitalized. However, when I went looking for an example in the spec, I realized that the spec editors very carefully duck the question: they'll use the actual term from descriptions when it is at the start of a sentence, but otherwise they'll use other phrases like "when no attempt has been made to code." The single example of using the actual term I found in the 008 spec was 15-17 - Place of publication, production, or execution Two- or three-character alphabetic code that indicates the place of publication, production, or execution. which argues that I'm wrong. Perhaps " Empty defaults to ||| - No attempt to code." (which is a copy-paste from the spec, including the dash) would be more correct, but I'd be just as happy with a lowercase no. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 19:47:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 17:47:35 +0000 Subject: [Koha-bugs] [Bug 27889] Form fields in OPAC are "out of shape" and pull downs in wrong font In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 --- Comment #11 from David Nind --- Created attachment 119085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119085&action=edit Buge 27889 - Screenshots if more options display Hi Owen. Before and after screenshots showing what I tried to explain! After an advanced search option is selected it does not display to the full width of the option text. David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 19:48:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 17:48:15 +0000 Subject: [Koha-bugs] [Bug 27889] Form fields in OPAC are "out of shape" and pull downs in wrong font In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27889 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119085|Buge 27889 - Screenshots if |Buge 27889 - Screenshots of description|more options display |more options display -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 20:06:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 18:06:24 +0000 Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #8 from Kyle M Hall --- (In reply to Jonathan Druart from comment #7) > We are removing the password from the notice template for new installations > only, for existing installations the generated notices will be "password: ". > I don't think we should remove the password key in the controller script. I disagree. This is a security bug. We should not allow patron's security to be compromised in the future just because we've allowed it to be compromised in the past. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 20:07:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 18:07:44 +0000 Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 --- Comment #9 from Kyle M Hall --- (In reply to Kyle M Hall from comment #8) > (In reply to Jonathan Druart from comment #7) > > We are removing the password from the notice template for new installations > > only, for existing installations the generated notices will be "password: ". > > I don't think we should remove the password key in the controller script. > > I disagree. This is a security bug. We should not allow patron's security to > be compromised in the future just because we've allowed it to be compromised > in the past. Would you like me to add a follow-up to modify the templates in the database? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 20:16:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 18:16:44 +0000 Subject: [Koha-bugs] [Bug 28055] Convert DataTables option names to current version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28055 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 20:16:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 18:16:47 +0000 Subject: [Koha-bugs] [Bug 28055] Convert DataTables option names to current version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28055 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119004|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 119086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119086&action=edit Bug 28055: Convert DataTables option names to current version This patch makes changes the two global DataTables files in the staff interface, replacing older 1.9.x option names with the current 1.10.x version. To test, apply the patch and confirm that default DataTables behaviors continue to work correctly: Table information, "Show XX entries" controls, pagination, search. - Test tables which use the default DataTables configuration from datatables.js: - Administration -> Z39.50/SRU servers - Administration -> MARC frameworks -> MARC structure - Test tables which use the DataTables configuration in columns_settings.inc, including column visibility and export controls. - Administration -> Libraries - Patrons -> Patron search results - Circulation -> Holds queue Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 21:21:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 19:21:51 +0000 Subject: [Koha-bugs] [Bug 27873] Make display of patron restrictions, charges, notes, etc. consistent for check out and patron details screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27873 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 21:21:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 19:21:54 +0000 Subject: [Koha-bugs] [Bug 27873] Make display of patron restrictions, charges, notes, etc. consistent for check out and patron details screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27873 --- Comment #4 from Owen Leonard --- Created attachment 119087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119087&action=edit Bug 27873: Improve message consistency: checkout and patron detail pages This patch creates a new include for showing circulation and patron-related messages on both the checkout page and the patron detail page. This allows the two pages to be consistent with each other. The patch also makes some minor CSS adjustments, including the addition of an SVG to replace an old GIF, arrow-bullet.gif. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - View both the checkout and patron details page for patrons in the staff interface, confirming that the information is displayed in the same way, including: - Pending modifications - Pending expiration - Expired - Address in doubt - Card lost - Restricted (indefinite and with expiration) - Outstanding overdues - Outstanding return claims - Patron age incorrect for their category - Outstanding charges - Account credit - Waiting holds (at logged-in library or other library) - Circulation note (from borrowers.borrowernotes) - Messages (added at logged-in library or other library) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 21:24:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 19:24:15 +0000 Subject: [Koha-bugs] [Bug 27979] Multiple item URIs break redirect if TrackClicks enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27979 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 21:24:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 19:24:19 +0000 Subject: [Koha-bugs] [Bug 27979] Multiple item URIs break redirect if TrackClicks enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27979 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118448|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 119088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119088&action=edit Bug 27979: Modify TrackClicks to verify URL exists in DB when multiple uri To test: 1) Go to Admin -> system preferences and enable the TrackClicks syspref (set to Track or Track anonymously) 2) Find a record in the staff client with an item. Edit the item and put two external URLs in the Uniform Resource Identifier field, e.g. "https://www.google.com/ | https://twitter.com/" 3) Search for that record in the OPAC. Notice the two links in the holdings table. 4) Click a link and confirm that you are directed to a 404. 5) Apply the patch and refresh the page 6) Click a link and confirm that you are directed to the page as expected 7) Go back to edit the record in the staff client and remove one of the links from the URI field 8) Go back to the OPAC and confirm you can still access the link as expected when there is only one URI Sponsored-by: Catalyst IT Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 21:32:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 19:32:07 +0000 Subject: [Koha-bugs] [Bug 27873] Make display of patron restrictions, charges, notes, etc. consistent for check out and patron details screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27873 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119087|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 119089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119089&action=edit Bug 27873: Improve message consistency: checkout and patron detail pages This patch creates a new include for showing circulation and patron-related messages on both the checkout page and the patron detail page. This allows the two pages to be consistent with each other. The patch also makes some minor CSS adjustments, including the addition of an SVG to replace an old GIF, arrow-bullet.gif. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - View both the checkout and patron details page for patrons in the staff interface, confirming that the information is displayed in the same way, including: - Pending modifications - Pending expiration - Expired - Address in doubt - Card lost - Restricted (indefinite and with expiration) - Outstanding overdues - Outstanding return claims - Patron age incorrect for their category - Outstanding charges - Account credit - Waiting holds (at logged-in library or other library) - Circulation note (from borrowers.borrowernotes) - Messages (added at logged-in library or other library) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 23:12:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 21:12:39 +0000 Subject: [Koha-bugs] [Bug 27873] Make display of patron restrictions, charges, notes, etc. consistent for check out and patron details screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27873 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28073 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 [Bug 28073] Patron modifications should auto-open panel for referring patron record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 1 23:12:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 21:12:39 +0000 Subject: [Koha-bugs] [Bug 28073] New: Patron modifications should auto-open panel for referring patron record Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 Bug ID: 28073 Summary: Patron modifications should auto-open panel for referring patron record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 27873 The "Pending patron modifications" link from the checkout or patron details page should pass the borrowernumber so that the patron update page can expand the correct panel. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27873 [Bug 27873] Make display of patron restrictions, charges, notes, etc. consistent for check out and patron details screens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 00:49:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 22:49:03 +0000 Subject: [Koha-bugs] [Bug 28074] New: Browse controls in staff details are sometimes weird Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28074 Bug ID: 28074 Summary: Browse controls in staff details are sometimes weird Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The browse control feature doesn't work quite right in the OPAC detail. 1. If you do a search with 3-4 results, go to the record and use the browse controls, when you get to the last record if you attempt to go to the 'next' you'll end up on a page which says 'record not found'. 2. Do a search with exactly 10 results. Click on the first record, the 'next' arrow is not a link, you cannot move to the next result. This is because in js/browser.js, if you look at the current_search Object and specifically at current_search.offset you will see that current_search.offset is a string. We try to do calculations with that variable and JavaScript performs string concatenation instead of addtion. For example: current_search.offset + me.curPos == current_search.total When the offset is '1' and we add it to 0, the result is 10. Therefore if the offset is the first and the total is 10, it thinks we are on the last result (10) and doesn't let use move forward. Converting current_search.offset to an integer solves the problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 00:53:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 22:53:18 +0000 Subject: [Koha-bugs] [Bug 28074] Browse controls in staff details are sometimes weird In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28074 --- Comment #1 from Lucas Gass --- When I said OPAC detail, I meant staff detail -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 00:54:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 22:54:02 +0000 Subject: [Koha-bugs] [Bug 28074] Browse controls in staff details are sometimes weird In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28074 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 00:54:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 22:54:05 +0000 Subject: [Koha-bugs] [Bug 28074] Browse controls in staff details are sometimes weird In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28074 --- Comment #2 from Lucas Gass --- Created attachment 119090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119090&action=edit Bug 28074: Make current_search.offset an integer instead of string To test: 1. do a search with 3-4 results, go to the record and use the browse controls, when you get to the last record if you attempt to go to the 'next' you'll end up on a page which says 'record not found'.2. Do a search with exactly 10 results. Click on the first record, the 'next' arrow is not a link, you cannot move to the next result 3. Apply patch 4. repeat steps 1-2 and the problems should be gone -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 01:27:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 23:27:13 +0000 Subject: [Koha-bugs] [Bug 27961] External track clicks links should get uri filtered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27961 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 01:27:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Apr 2021 23:27:16 +0000 Subject: [Koha-bugs] [Bug 27961] External track clicks links should get uri filtered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27961 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118256|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 119091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119091&action=edit Bug 27961: Ensure external URLs are filtered TT variables are used to build the link in items.uri . This is a problem particularly when TrackClicks is enabled because the items.uri value doesn't get escaped, resulting in a 404. To test: 1) Enable the TrackClicks system preference (set to Track or Track anonymously) 2) Find a record with an item 3) Edit the item and put an external URL under the Uniform Resource Identifier field 4) Go to that record in the OPAC 5) Click on Link to resource 6) Confirm you are not redirected to the URL and instead see a 404 7) Apply the patch and refresh the page 8) Click on Link to resource 9) Confirm you are redirected as expected 10) Go back to the staff client to edit your item. This time put two URLs in the Uniform Resource Identifier field, separated by ' | '. (Don't forget the spaces around the pipe, and don't forget to add a trailing slash to the URL). 11) Go back to the OPAC and refresh the page. 12) Confirm both URLs redirect as expected. Sponsored-by: Parliamentary Library New Zealand Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 04:32:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 02:32:01 +0000 Subject: [Koha-bugs] [Bug 27739] Advanced editor should use DefaultCountryField008 system preference rather than hardcoding xxu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27739 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 04:32:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 02:32:04 +0000 Subject: [Koha-bugs] [Bug 27739] Advanced editor should use DefaultCountryField008 system preference rather than hardcoding xxu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27739 --- Comment #1 from Phil Ringnalda --- Created attachment 119092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119092&action=edit Bug 27739: Advanced editor should use DefaultCountryField008 preference Uses the system preference DefaultCountryField008, falling back to ||| (no attempt to code) if it is not set, for 008/15-17 place of publication in the advanced cataloging editor.. Test plan: 1) Apply patch and restart all the things, something's over-cached here 2) Administration - Toggle the preference EnableAdvancedCatalogingEditor to "Enable", verify the preference DefaultCountryField008 is empty 3) Cataloging - Advanced editor 4) In field 008, verify that the three characters after the two sets of four blank spaces are ||| 5) Administration - Set DefaultCountryField008 to fr 6) Cataloging - Advanced editor 7) In field 008, verify that the three characters after the two sets of four blank spaces are "fr " (including the space, so following characters haven't shifted left, and the last character is still d) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 07:13:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 05:13:07 +0000 Subject: [Koha-bugs] [Bug 27852] Link YES_NO authorized value category to 942$n in Default framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Hi Caroline. I had a go at testing this, and thanks for the clarification for step 1! I get this message after deleting the entries in the database and reloading the yaml file: root at kohadevbox:koha(bz27852)$ ./misc/load_yaml.pl -f ./installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml --load C4::Installer::load_sql returned the following errors while attempting to load ./installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml: DBD::mysql::db do failed: Duplicate entry 'ACQ' for key 'PRIMARY' at /kohadevbox/koha/C4/Installer.pm line 572. It does seem to work though as the$942n now has a Yes/ or No option, with No as the default. Not sure what affect the error message will have... David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 07:29:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 05:29:05 +0000 Subject: [Koha-bugs] [Bug 27656] misc/cronjobs/longoverdue.pl better error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27656 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 07:29:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 05:29:08 +0000 Subject: [Koha-bugs] [Bug 27656] misc/cronjobs/longoverdue.pl better error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27656 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116510|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 119093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119093&action=edit Bug 27656: misc/cronjobs/longoverdue.pl better error message There are two ways of configuring misc/cronjobs/longoverdue.pl : use --lost arg or system preferencies DefaultLongOverdueLostValue and DefaultLongOverdueDays. Actually if you don't use any of it, you get a message : "ERROR: No --lost (-l) option defined" Should also say something about preferencies : "ERROR: No --lost (-l) option nor system preferencies DefaultLongOverdueLostValue/DefaultLongOverdueDays defined" Test plan: 1) Set empty preferences DefaultLongOverdueLostValue and DefaultLongOverdueDays 2) Run : misc/cronjobs/longoverdue.pl --maxdays 365 3) You see error message 4) Set DefaultLongOverdueLostValue = 1 and DefaultLongOverdueDays = 90 5) Run : misc/cronjobs/longoverdue.pl --maxdays 365 6) You don't see error message Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 07:30:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 05:30:46 +0000 Subject: [Koha-bugs] [Bug 27656] misc/cronjobs/longoverdue.pl better error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27656 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- A minor suggestion would be to change the error message from: ..option nor system preferencies.. to ..option or system preferences.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 08:41:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 06:41:34 +0000 Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #4 from Marcel de Rooy --- Hi Augustin, I have some questions here: The tab is called Requested, but since all entries are requests, wouldnt it be more logical to call it New ? If I pick a request to process, it would be handy to move it to Processing immediately from the New tab? Instead of an additional move thru Pending. Can you explain the mail for a move to Pending? Since the patron gets an email when he submitted the request and will have an email when we hit Processing, does this mail saying 'We are doing nothing yet' make him happy :) ? Please run qa tools. I see this failure: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt FAIL valid_template Attempt to reload Koha/Template/Plugin/Biblio.pm aborted. Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Plugins.pm line 206. => Is this related to biblio-view-menu.inc ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 09:31:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 07:31:43 +0000 Subject: [Koha-bugs] [Bug 24023] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114855|0 |1 is obsolete| | --- Comment #17 from Julian Maurice --- Created attachment 119094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119094&action=edit Bug 24023: Add ability to create bundles of items This patch adds the ability to link items to a biblio to create bundles of items that can be reserved and checked out like a regular item. A withdrawn status will be set to linked items so that they can't be checked out while they are part of a bundle. When returning a bundle, the list of items that are part of this bundle will be displayed, allowing the librarian to verify that all items are there. Bundles can also be used in the inventory tool as a filter. Test plan: 0. Apply the patch, run updatedatabase + update_dbix_class_files 1. Create a biblio record with at least a title. Create an item for this biblio record 2. In the biblio 'Edit' menu you have a new option: 'Link elements'. Click on it 3. Enter a list of valid and invalid barcodes in the textarea, select a withdrawn status and click on 'Continue' 4. Verify that new fields have been added to the MARC record (462 for UNIMARC, 774 otherwise) 5. Verify that the withdrawn status has been correctly set for the items you have linked 6. Verify that, for item created at step 1, items.materials has been updated with the number of items contained in the bundle 7. Edit the biblio record and remove one of the 462/774 fields 8. Verify that the corresponding item's withdrawn status has been reset 9. Checkout and checkin the item created at step 1 10. You should see the list of items contained in the bundle. Click on 'Confirm checkin without verifying'. Verify that the item has been returned 11. Checkout and checkin the item created at step 1 again 12. Now click on 'Verify items bundle contents'. A textarea lets you enter barcodes. Enter some (but not all) barcodes that are in the bundle. Select a 'lost' status and click on 'Confirm checkin and mark missing items as lost' 13. Verify that the items corresponding to barcodes you did not type in the textarea are now marked as lost with the lost status you chose 14. Go to the inventory tool, use the bundle filter and verify that it works Sponsored-by: Bibliothèque Départementale de l'Yonne -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 09:32:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 07:32:02 +0000 Subject: [Koha-bugs] [Bug 24023] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #18 from Julian Maurice --- Patch rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 09:43:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 07:43:14 +0000 Subject: [Koha-bugs] [Bug 27773] Hide unique holidays and exceptions which have passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27773 Pascale Nalon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Pascale Nalon --- Test plan done : - Apply the patch and go to Tools -> Calendar - In the tables of existing holidays, check that no dates in the past appear in the "Exceptions" or "Unique holidays" tables. - Checking the checkbox at the top of each of these tables should trigger the display of the hidden rows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 10:12:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 08:12:48 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118554|0 |1 is obsolete| | --- Comment #246 from Maryse Simard --- Created attachment 119095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119095&action=edit Bug 17015: DiscreteCalendar UI, Back-End and necessary scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 10:12:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 08:12:50 +0000 Subject: [Koha-bugs] [Bug 27120] Send biblio to Koha plugins hook 'intranet_catalog_biblio_tab' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27120 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 10:12:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 08:12:54 +0000 Subject: [Koha-bugs] [Bug 27120] Send biblio to Koha plugins hook 'intranet_catalog_biblio_tab' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27120 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118085|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 119096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119096&action=edit Bug 27120: Send biblio to Koha plugins hook 'intranet_catalog_biblio_tab' Koha plugins hook 'intranet_catalog_biblio_tab' should have the datas of the current biblio record. Koha::Biblio is aleady in template, send it with hooks call. This will be very usefull to be able to fetch external datas (wikipedia, youtube, ...) depending on current biblio record. Test plan : 1) Enable Koha plugins 2) Install plugin attached to this bug 3) Go to staff interface on a biblio record details page 4) Check you see tab 1 containing 'Tab for record {title}' 5) Check you see tab 2 containing 'Tab for record {isbn}' Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 10:12:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 08:12:55 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118555|0 |1 is obsolete| | --- Comment #247 from Maryse Simard --- Created attachment 119097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119097&action=edit Bug 17015: Install scripts for DiscreteCalendar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 10:13:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 08:13:00 +0000 Subject: [Koha-bugs] [Bug 27120] Send biblio to Koha plugins hook 'intranet_catalog_biblio_tab' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27120 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118086|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 119098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119098&action=edit Bug 27120: (follow-up) also send biblionumber Like in after_biblio_action hook Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 10:13:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 08:13:02 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118556|0 |1 is obsolete| | --- Comment #248 from Maryse Simard --- Created attachment 119099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119099&action=edit Bug 17015: Schema file for new discrete_calendar table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 10:13:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 08:13:08 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118557|0 |1 is obsolete| | --- Comment #249 from Maryse Simard --- Created attachment 119100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119100&action=edit Bug 17015: Tests for DiscreteCalendar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 10:13:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 08:13:14 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118558|0 |1 is obsolete| | --- Comment #250 from Maryse Simard --- Created attachment 119101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119101&action=edit Bug 17015: When using book drop mode, set check in time as closing hours -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 10:13:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 08:13:20 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118559|0 |1 is obsolete| | --- Comment #251 from Maryse Simard --- Created attachment 119102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119102&action=edit Bug 17015: Automatically update calendar when creating or deleting a branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 10:14:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 08:14:19 +0000 Subject: [Koha-bugs] [Bug 24564] The adding of new subfields according to IFLA updates doesn't respect existing tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24564 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119032|0 |1 is obsolete| | --- Comment #4 from Koha Team University Lyon 3 --- Created attachment 119103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119103&action=edit Bug 24564: Do not modify the tab of existing subfield in ifla/update.pl Test plan: 1. Find a biblio subfield in misc/migration_tools/ifla/data/biblio/default.yml that you have in your default biblio MARC framework (or create one). 2. Change the tab of this subfield so that it's different from what's in the .yml file 3. Run misc/migration_tools/ifla/update.pl --force 4. Verify that the tab of this subfield has not been changed. 5. Do the same for authorities (files are in misc/migration_tools/ifla/data/auth/) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 10:14:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 08:14:22 +0000 Subject: [Koha-bugs] [Bug 24564] The adding of new subfields according to IFLA updates doesn't respect existing tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24564 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119082|0 |1 is obsolete| | --- Comment #5 from Koha Team University Lyon 3 --- Created attachment 119104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119104&action=edit Bug 24564: Use the same tab as the other subfields within a field For each subfield added, we check if other subfields exists in the same field. If that's the case we use the same tab as the first subfield found. Test plan: 1. Find a biblio subfield in misc/migration_tools/ifla/data/biblio/default.yml that doesn't exist in your default biblio MARC framework (or delete one). The field should exist and have other subfields with a tab set. 2. Change the tab of all subfields within that field it's different from what's in the .yml file 3. Run misc/migration_tools/ifla/update.pl 4. Verify that the subfield has been added and have the same tab as others subfields 5. Do the same for authorities (files are in misc/migration_tools/ifla/data/auth/) Signed-off-by: Koha team -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 10:17:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 08:17:59 +0000 Subject: [Koha-bugs] [Bug 27120] Send biblio to Koha plugins hook 'intranet_catalog_biblio_tab' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27120 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #8 from David Nind --- Note: For steps 4 and 5 the new tabs contain "This is content for tab 1" and "This is content for tab 2". Have signed-off on the basis that this is what was expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 10:18:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 08:18:04 +0000 Subject: [Koha-bugs] [Bug 27240] Export basket: remove spaces and don't export links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27240 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 10:18:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 08:18:07 +0000 Subject: [Koha-bugs] [Bug 27240] Export basket: remove spaces and don't export links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27240 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114408|0 |1 is obsolete| | --- Comment #2 from Séverine Queune --- Created attachment 119105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119105&action=edit Bug 2740: Basket export cleanup. Remove spaces and irrelevant links. Test plan: 1 - Create a basket 2 - Export it in excel 3 - There's a lot of spaces in Order column and irrelevant 'Add internal note' 4 - Apply patch 5 - Export file 6 - It's tidier, fewer spaces and no useless Add/edit note links https://bugs.koha-community.org/show_bug.cgi?id=27240 Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 10:18:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 08:18:34 +0000 Subject: [Koha-bugs] [Bug 24564] The adding of new subfields according to IFLA updates doesn't respect existing tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24564 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Koha Team University Lyon 3 --- I have followed the test plan and the script works correctly now. If we tried to add new subfields in an existing field, it checks in which tab are the existing fields and add it in the same tab. Tested for biblios and authorities. Thanks ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 10:20:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 08:20:01 +0000 Subject: [Koha-bugs] [Bug 27240] Export basket: remove spaces and don't export links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27240 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr --- Comment #3 from Séverine Queune --- No more useless notes informations, and less spaces so works fine for me. I just noticed a typo in the patch number (2740 instead of 27240), but I don't know how to correct that. Thank you Didier ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 11:18:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 09:18:28 +0000 Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through Stage Marc Record Import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #6 from Pascale Nalon --- I've set concordance rule in my sandbox and play 2nd step of the test plan : it's OK. At the step 3, I don't understand where radio buttons should to be ? I can't see no radio buttons, before or after importing the new file. Is the patch really applied on this sandbox http://sandboxes.ptfs-europe.co.uk/provision_log/bz22785 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 11:22:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 09:22:48 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #153 from Alex Arnaud --- Created attachment 119106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119106&action=edit Bug 17656: use Koha::Subscription->startdate instead of Koha::Subscriptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 11:33:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 09:33:11 +0000 Subject: [Koha-bugs] [Bug 27900] regression: add from existing record with null results deadends In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27900 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 11:33:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 09:33:15 +0000 Subject: [Koha-bugs] [Bug 27900] regression: add from existing record with null results deadends In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27900 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118126|0 |1 is obsolete| | --- Comment #4 from Séverine Queune --- Created attachment 119107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119107&action=edit Bug 27900: Add a link back to the basket view if no result Since bug 24347 the neworderbiblio view has been removed and we now display the usual search result. When adding a new order from a search, if there is no result we should let the user get back to the basket view. Test plan: Add to basket from an existing record Do a search with no results and confirm that there is a new "Go to the basket view" link Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 11:34:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 09:34:17 +0000 Subject: [Koha-bugs] [Bug 27900] regression: add from existing record with null results deadends In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27900 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr --- Comment #5 from Séverine Queune --- I never noticed that problem, nice catch Donna, and thank you Jonathan for fixing it, to me it works fine ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 11:36:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 09:36:42 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109184|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 119108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119108&action=edit Bug 26302: OPAC XSLT Results: List variable number of itemcallnumbers We define a local preference resultsMaxItems and add it to the xml passed to the results XSLT (in C4::XSLT). Instead of showing one item, we add this number of items for the available for loan and reference segments. Test plan: Play with the value of local pref resultsMaxItems. Check if it matches with displayed callnumbers. Try home and holdingbranch for results location. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 11:36:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 09:36:46 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #7 from Marcel de Rooy --- Created attachment 119109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119109&action=edit Bug 26302: Add syspref resultsMaxItemsUnavailable This is the number of call numbers displayed for unavailable categories in the results XSLT. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 11:36:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 09:36:50 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #8 from Marcel de Rooy --- Created attachment 119110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119110&action=edit Bug 26302: Use resultsMaxItemsUnavailable in stylesheet We start here with Checked out until On hold. Not sure if we should do exactly the same for the remaining not for loan categories. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 11:38:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 09:38:52 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Allows customizing the release notes| |number of call numbers | |listed on the OPAC search | |results by changing the | |prefs: | |resultsMaxItems | |resultsMaxItemsUnavailable | |The latter now applies to | |the categories Checked out, | |Damaged, ..., On hold. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 11:40:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 09:40:07 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com --- Comment #9 from Marcel de Rooy --- @Nick: Would this address your concerns about hiding call numbers for certain unavailable categories? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 11:41:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 09:41:47 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119110|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy --- Comment on attachment 119110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119110 Bug 26302: Use resultsMaxItemsUnavailable in stylesheet Resubmitting.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 11:43:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 09:43:34 +0000 Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #11 from Marcel de Rooy --- Created attachment 119111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119111&action=edit Bug 26302: Use resultsMaxItemsUnavailable in stylesheet We start here with Checked out until On hold. Not sure if we should do exactly the same for the remaining not for loan categories. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 11:46:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 09:46:19 +0000 Subject: [Koha-bugs] [Bug 28075] New: Add missing UNIMARC for coded data 135a Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28075 Bug ID: 28075 Summary: Add missing UNIMARC for coded data 135a Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: MARC Bibliographic data support Assignee: didier.gautheron at biblibre.com Reporter: didier.gautheron at biblibre.com QA Contact: testopia at bugs.koha-community.org Value are missing in unimarc_field_135a.tt cf: https://www.transition-bibliographique.fr/wp-content/uploads/2018/07/B135-6-2010.pdf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 11:53:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 09:53:40 +0000 Subject: [Koha-bugs] [Bug 27465] Add column visibility to the admin/cities.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27465 Pascale Nalon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pascale.nalon at ensmp.fr --- Comment #2 from Pascale Nalon --- Test on PTFS sandbox : First step is OK : Columns can be hide or show, by clicking in the popup "columns" in admin/cities.pl page Second step works partially : - some default settings can be set from the admin/columns_settings.pl#cities page. - Not toggled functionality works on the admin/cities.pl page, the choosen columns doesn't shown anymore in the popup - BUT hidding columns by default doesn't work in the admin/cities.pl page : the chosen columns are ever shown, even after refreshing or reloading the page, or cleaning cookies and cache of the internet browser. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 11:59:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 09:59:24 +0000 Subject: [Koha-bugs] [Bug 27465] Add column visibility to the admin/cities.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27465 Pascale Nalon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pascale.nalon at mines-pariste | |ch.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 11:59:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 09:59:56 +0000 Subject: [Koha-bugs] [Bug 28076] New: SIP should optionally ignore external auth when logging in the server account Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28076 Bug ID: 28076 Summary: SIP should optionally ignore external auth when logging in the server account Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When setting up a SIP user in Koha, they aere often a local user and don't exist in external identity managers - i.e. for sites using SSO via LDAP / CAS / SHIB the SIP user does not exist in the external DB It would be nice to have a switch to avoid checking SIP user against LDAP etc. This would be useful in the case where LDAP is down but self checks could remain operational. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 12:00:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 10:00:24 +0000 Subject: [Koha-bugs] [Bug 28076] SIP should optionally ignore external auth when logging in the server account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28076 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |liz at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 12:09:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 10:09:38 +0000 Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through Stage Marc Record Import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Pascale Nalon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pascale.nalon at mines-pariste | |ch.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 12:14:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 10:14:06 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 12:14:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 10:14:13 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112931|0 |1 is obsolete| | --- Comment #14 from David Nind --- Created attachment 119112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119112&action=edit Bug 26860: facets.inc refactor availability facet To prepare new facet, this patch refactors the availability facet, without any change in restult. Appart from an id 'facet-availability', like other facets. Test plan: 1) Perform a search in staff interface 2) Check availability facet displays well 3) Click on it 4) Check availability facet displays well Signed-off-by: Séverine QUEUNE Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 12:14:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 10:14:18 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112932|0 |1 is obsolete| | --- Comment #15 from David Nind --- Created attachment 119113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119113&action=edit Bug 26860: Add without items facet Many libraries ask for a way to search biblio records without items. In order to clean the catalogue or acquire items. I propose to add a search limit and facet. Only in staff interface for start. I choose to use homebranch index, should always be defined on items. Looks like itemnumber index can not be used because of its configuration in ccl.properties. Test plan : 1) Check with both Zebra and Elasticsearch 2) Perform a search on staff interface returning some records with and some without items 3) Click on 'Limit to records without items' 4) Check you see only records without items 5) Click on 'Show all records' 6) Check you see all records again Signed-off-by: Séverine QUEUNE Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 12:14:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 10:14:23 +0000 Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113220|0 |1 is obsolete| | --- Comment #16 from David Nind --- Created attachment 119114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119114&action=edit Bug 26860: (follow-up) case requesting zebra with ccl query When calling a ccl syntax query, code must be added like for availability facet. See Bug 17278: Use available limit when requesting zebra when ccl query is used This patch also changes "grep {!/^available$/} @limits" to use "grep { $_ ne 'available' } @limits". Following the logic of : Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} Test plan : 1) Use Zebra search engine 2) Perform a search on staff interface with explicit index, for example 'ti:history' 3) This search must return some records with and some without items 4) Click on 'Limit to records without items' 5) Check you see only records without items 6) Click on 'Show all records' 7) Check you see all records again 8) Check availability facet is also working Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 12:16:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 10:16:53 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |severine.queune at bulac.fr --- Comment #3 from Séverine Queune --- (In reply to Lucas Gass from comment #2) > Owen, > > In testing this I found something wrong with OPACSuggestionMandatoryFields. > > I have: > > -applied the patch > -updatedatabase (a few times) > -by default title is set as required on /cgi-bin/koha/opac-suggestions.pl > -in OPACSuggestionMandatoryFields I set something othen than title to > mandatory. > -title then becomes NOT required > -Since title isn't in the modal for OPACSuggestionMandatoryFields I now have > no way of making it required. I noticed the same problems Lucas described. I add that required field are not anymore displayed in red. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 12:17:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 10:17:38 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA --- Comment #4 from Séverine Queune --- Oups, wrong status... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 12:27:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 10:27:30 +0000 Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #51 from Séverine Queune --- Sorry Aleisha, i'd be happy to test if you can rebase ! CONFLICT (content): Merge conflict in cataloguing/addbiblio.pl Auto-merging C4/Biblio.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 14367: Add MARC record history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 12:43:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 10:43:14 +0000 Subject: [Koha-bugs] [Bug 27827] Authority type input field for new authority types should be wider In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 12:43:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 10:43:19 +0000 Subject: [Koha-bugs] [Bug 27827] Authority type input field for new authority types should be wider In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117474|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 119115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119115&action=edit Bug 27827: make the 'Authority type:' input field wider When adding a new authority type in the Staff client, the 'Authority type' input field is too narrow. If you enter something like "OOP_CORPUS" inside the textbox, you will have to scroll right and left inside the textbox in order to view its contents. This patch fixes that. Test plan: 1) Try to add a new authority type with name "OOP_CORPUS". Notice how the input field is too narrow and cannot contain the entire string. 2) Apply this patch. 3) Repeat step 1), this time the input field has been widened and can accommodate the entire string. Signed-off-by: Petro Vashchuk Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 12:43:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 10:43:23 +0000 Subject: [Koha-bugs] [Bug 27827] Authority type input field for new authority types should be wider In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118741|0 |1 is obsolete| | --- Comment #9 from David Nind --- Created attachment 119116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119116&action=edit Bug 27827: (follow-up) add a hint for clarification When adding a new authority type, there is no indication of how big the authority type code can be (auth_types.authtypecode in the DB has a maximum length of 10 characters). This patch fixes that. To test, apply the patch and notice the hint appearing right above the "Authority type:" text box as you add a new authority type: it should display "10 characters maximum" in grey colour. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 12:50:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 10:50:12 +0000 Subject: [Koha-bugs] [Bug 28075] Add missing UNIMARC for coded data 135a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28075 Didier Gautheron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 12:50:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 10:50:15 +0000 Subject: [Koha-bugs] [Bug 28075] Add missing UNIMARC for coded data 135a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28075 --- Comment #1 from Didier Gautheron --- Created attachment 119117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119117&action=edit Bug 28075: Add missing UNIMARC coded data 135a To test: 1) Apply patch to an UNIMARC system 2) Add a notice 3) Use 135 field tag editor 4) plugin is working with new value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 12:52:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 10:52:28 +0000 Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through Stage Marc Record Import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #7 from Nick Clemens --- (In reply to Pascale Nalon from comment #6) > I've set concordance rule in my sandbox and play 2nd step of the test plan : > it's OK. > At the step 3, I don't understand where radio buttons should to be ? I can't > see no radio buttons, before or after importing the new file. > > Is the patch really applied on this sandbox > http://sandboxes.ptfs-europe.co.uk/provision_log/bz22785 ? Checking the git log it only appears the dependency was applied - you can click 'Apply patches' under 'Actions' to apply the patches from this bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 13:16:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 11:16:57 +0000 Subject: [Koha-bugs] [Bug 28073] Patron modifications should auto-open panel for referring patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 13:17:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 11:17:00 +0000 Subject: [Koha-bugs] [Bug 28073] Patron modifications should auto-open panel for referring patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 --- Comment #1 from Owen Leonard --- Created attachment 119118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119118&action=edit Bug 28073: Patron modifications should auto-open panel for referring patron record This patch makes it possible to link directly to the correct panel on the "Update patron records" page. The link on the checkout and patron details screen has been updated to read "Patron has pending modifications." Also changed: Moved the "Patron's address in doubt" message so that it is above the table of changed fields. To test, apply the patch and if necessary submit patron modification requests from multiple patrons via the OPAC. - Open the checkout page for one of these patrons. - If you are logged in as a user with permission to edit patron records you should see a message, "Pending modifications: Review pending modifications," which links to the pending modifications page. - Clicking the link should open the page for reviewing pending patron modifications, and the correct panel should be automatically expanded. - If you are logged in as a user without permission to edit patrons you should see the message "Pending modifications: Patron has pending modifications," which isn't linked. - The process should work exactly the same from the patron detail page. - Following the "Pending modifications" link from the staff interface home page or the patrons home page should work as before: The page opens with the first panel expanded. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 14:12:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 12:12:12 +0000 Subject: [Koha-bugs] [Bug 28077] New: Missing colon on suggestion modification page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28077 Bug ID: 28077 Summary: Missing colon on suggestion modification page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: severine.queune at bulac.fr QA Contact: testopia at bugs.koha-community.org On the 'Edit purchase suggestion' page, a colon is missing after the 'Reason' label. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 14:12:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 12:12:44 +0000 Subject: [Koha-bugs] [Bug 28077] Missing colon on suggestion modification page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28077 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |severine.queune at bulac.fr |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 14:29:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 12:29:26 +0000 Subject: [Koha-bugs] [Bug 28077] Missing colon on suggestion modification page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28077 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 14:29:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 12:29:28 +0000 Subject: [Koha-bugs] [Bug 28077] Missing colon on suggestion modification page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28077 --- Comment #1 from Séverine Queune --- Created attachment 119119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119119&action=edit Bug 28077: Add a colon after the 'Reason' label on edit suggestion page This patch corrects the missing colon on the 'Edit purchase suggestion' page. To test : - go to Acquistions > Suggestions - edit a suggestion - on 'Suggestion management' bloc, see the colon missing after the 'Reason' label - apply patch - refresh the page - colon should now be displayed Happy sign off ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 14:42:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 12:42:12 +0000 Subject: [Koha-bugs] [Bug 20390] Elasticsearch - Mappings for UNIMARC (updates existing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20390 --- Comment #23 from Alex Arnaud --- Created attachment 119120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119120&action=edit Bug 20390: mappings according to last IFLA updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 14:45:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 12:45:32 +0000 Subject: [Koha-bugs] [Bug 28077] Missing colon on suggestion modification page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28077 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 14:45:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 12:45:35 +0000 Subject: [Koha-bugs] [Bug 28077] Missing colon on suggestion modification page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28077 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119119|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 119121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119121&action=edit Bug 28077: Add a colon after the 'Reason' label on edit suggestion page This patch corrects the missing colon on the 'Edit purchase suggestion' page. To test : - go to Acquistions > Suggestions - edit a suggestion - on 'Suggestion management' bloc, see the colon missing after the 'Reason' label - apply patch - refresh the page - colon should now be displayed Happy sign off ! Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 15:03:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 13:03:05 +0000 Subject: [Koha-bugs] [Bug 18493] Add more languages to advanced search languages dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18493 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- This would be useful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 15:22:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 13:22:13 +0000 Subject: [Koha-bugs] [Bug 28074] Browse controls in staff details are sometimes weird In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28074 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 15:22:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 13:22:15 +0000 Subject: [Koha-bugs] [Bug 28074] Browse controls in staff details are sometimes weird In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28074 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119090|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 119122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119122&action=edit Bug 28074: Make current_search.offset an integer instead of string To test: 1. Do a search with 3-4 results, go to the record and use the browse controls, when you get to the last record if you attempt to go to the 'next' you'll end up on a page which says 'record not found.' 2. Do a search with exactly 10 results. Click on the first record, the 'next' arrow is not a link, you cannot move to the next result. 3. Apply patch 4. Repeat steps 1-2 and the problems should be gone. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 15:30:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 13:30:31 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #154 from Koha Team University Lyon 3 --- Hello, I testes this time on Ptfx Sandbox. no more message "Renewal cancelled". Sorry, I think this was template problem on my instance. It's OK now for startdate error message. Everything works as expected as for daily and monthly frequencies. Exceptions are kept. date are skipped when receiving as well. But unfortunately weekly frequency does not work. Irregularities are not retained : my parameters : first issue publ. date 01/01/2021 startdate 01/01/2021 issues 52 enddate 31/12/2021 I checked 8 and 15 feb 2021 They are recorded ok I multireceived 50 issues and click on Renew button but no weeks are no more checked on the form. Olivier -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 15:30:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 13:30:38 +0000 Subject: [Koha-bugs] [Bug 28073] Patron modifications should auto-open panel for referring patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr Status|Needs Signoff |Failed QA --- Comment #2 from Séverine Queune --- > - Open the checkout page for one of these patrons. > - If you are logged in as a user with permission to edit patron > records you should see a message, "Pending modifications: Review > pending modifications," which links to the pending modifications > page. On the checkout page, the message (without link) is the same for users with and without the patron modification permission. Except that point, the patch works correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 15:31:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 13:31:40 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #155 from Katrin Fischer --- Thx for all the testing going on here! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 15:36:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 13:36:00 +0000 Subject: [Koha-bugs] [Bug 20596] Error Zoom 20003 when import authority marc file (koha/tools/manage-marc-import.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 --- Comment #4 from Katrin Fischer --- Hi Marjorie, this should be the only file listing all indexes for the authorities. You might have local changes of course. And maybe it falls back to a keyword search if the index is unknown or so? I have no proof of this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 15:36:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 13:36:31 +0000 Subject: [Koha-bugs] [Bug 27726] OPACProblemReports cuts off message text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 --- Comment #15 from Owen Leonard --- Same error: DEV atomic update: bug_27726.perl Atomic update generated errors: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: BLOB/TEXT column 'content' can't have a default value [for Statement "ALTER TABLE problem_reports MODIFY content TEXT NOT NULL DEFAULT ''"] at /usr/share/perl5/DBIx/Class/Schema.pm line 1118. DBIx::Class::Schema::throw_exception(Koha::Schema=HASH(0x562f6298c240), "DBI Exception: DBD::mysql::db do failed: BLOB/TEXT column 'co"...) called at /usr/share/perl5/DBIx/Class/Storage.pm line 113 DBIx::Class::Storage::throw_exception(DBIx::Class::Storage::DBI::mysql=HASH(0x562f62b267c8), "DBI Exception: DBD::mysql::db do failed: BLOB/TEXT column 'co"...) called at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1501 DBIx::Class::Storage::DBI::__ANON__("DBD::mysql::db do failed: BLOB/TEXT column 'content' can't ha"..., DBI::db=HASH(0x562f631329c0), undef) called at (eval 1457) line 3 eval '$DBversion = \'XXX\'; # will be replaced by the RM if( CheckVersion( $DBversion ) ) { $dbh->do("ALTER TABLE problem_reports MODIFY content TEXT NOT NULL DEFAULT \'\'"); NewVersion( $DBversion, 27726, "Increase field size for problem_reports.content"); } ' called at /kohadevbox/koha/installer/data/mysql/updatedatabase.pl line 23755 Server version: 10.1.48-MariaDB-1~bionic mariadb.org binary distribution -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 15:43:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 13:43:20 +0000 Subject: [Koha-bugs] [Bug 28073] Patron modifications should auto-open panel for referring patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Owen Leonard --- (In reply to Séverine Queune from comment #2) > On the checkout page, the message (without link) is the same for users with > and without the patron modification permission. I can't reproduce this problem. Can you double-check that the "edit_borrowers" permission is the one you're setting, and that you're logging that user out and back in after changing permissions? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 15:50:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 13:50:32 +0000 Subject: [Koha-bugs] [Bug 16628] Patrons requesting modifications link behaves differently on the home page than the members-home.pl page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16628 --- Comment #1 from Owen Leonard --- Is this bug still valid? Here's how I tested: - Turn on IndependentBranches - Set IndependentBranchesPatronModifications to "Yes" - Log in as a non-superlibrarian - On the staff interface home page I see "Patrons requesting modifications: 2" - On the patron module home page I see "Patrons requesting modifications: 2" Both links take me to a page which shows the 2 patrons requesting modification out of a 4 total for all libraries. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 15:50:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 13:50:42 +0000 Subject: [Koha-bugs] [Bug 16628] Patrons requesting modifications link behaves differently on the home page than the members-home.pl page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16628 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.22 |master Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 16:17:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 14:17:21 +0000 Subject: [Koha-bugs] [Bug 28022] MARC subfield 9 not honoring visibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28022 --- Comment #5 from Thomas Klausner --- Created attachment 119123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119123&action=edit only show subfield "9" if subfield "a" is visibile (bug 28022) Amend the workaround (from but 2206) to only show subfield "9" in editor if subfield "a" has the editor-visibility bit set -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 16:28:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 14:28:46 +0000 Subject: [Koha-bugs] [Bug 28078] New: Add option to ignore hold counts when checking CanItemBeReserved Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 Bug ID: 28078 Summary: Add option to ignore hold counts when checking CanItemBeReserved Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In 'CanBookBeRenewed' we call 'CanItemBeReserved' to see if an item is available to fill a hold - this doesn't work because: 1 - We call it wrong (bug 28013) 2 - We count the current hold against the limit This bug adds an optional param 'ignore_hold_counts' to the routine, while still forbidding holds when 0 are allowed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 16:29:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 14:29:01 +0000 Subject: [Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Blocks| |28013 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 [Bug 28013] Improvements to CanBookBeRenewed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 16:29:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 14:29:01 +0000 Subject: [Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28078 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 16:31:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 14:31:43 +0000 Subject: [Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 16:31:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 14:31:45 +0000 Subject: [Koha-bugs] [Bug 28078] Add option to ignore hold counts when checking CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 --- Comment #1 from Nick Clemens --- Created attachment 119124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119124&action=edit Bug 28078 - Add 'ignore_hold_counts' param to CanItemBeReserved This patch adds an optional param 'ignore_hold_counts' to the routine, while still forbidding holds when 0 are allowed To test: 1 - prove -v t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 16:36:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 14:36:34 +0000 Subject: [Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 16:36:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 14:36:37 +0000 Subject: [Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 --- Comment #8 from Nick Clemens --- Created attachment 119125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119125&action=edit Bug 28013: (follow-up) Correct and update call to CanItemBeReserved The current call checks for truth against a returned hash, we need to check the 'status' value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 16:36:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 14:36:41 +0000 Subject: [Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 --- Comment #9 from Nick Clemens --- Created attachment 119126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119126&action=edit Bug 28013: Unit tests Cover the case of multiple patrons and multiple items that can fill them -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 16:36:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 14:36:44 +0000 Subject: [Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 --- Comment #10 from Nick Clemens --- Created attachment 119127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119127&action=edit Bug 28013: (follow-up) Reset the patron loop To test: 1 - Apply all other patches and dependencies 2 - prove -v t/db_dependent/Circulation.t 3 - It fails 4 - Apply this patch 5 - It passes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 16:39:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 14:39:57 +0000 Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 --- Comment #10 from Katrin Fischer --- > Would you like me to add a follow-up to modify the templates in the database? I think this is meant well but won't really work for translated notices - so we can't really fix this automatically. But I agree with Kyle about the need to remove this 'non-feature', so we just need to figure out how to do it best. - Change the default notice templates - check! - Are we sure we will remove all translated installers? Then they can be ignored. - Deal with existing installations using the feature - Add well visible note to the release notes - Make sure the notices are still processed, just password will not be output - Add a note to the pref? - Remove password from field list to add to a notice template? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 16:42:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 14:42:07 +0000 Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #11 from Katrin Fischer --- Another thing: I believe you currently need to fill in password in order to have the notice generated at all - we should remove that check as well if I am correct. Thinking about this line: https://git.koha-community.org/Koha-community/Koha/src/commit/02d82b142d998f1544fbab6e7f35f6f0fceef084/members/memberentry.pl#L468 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 16:58:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 14:58:58 +0000 Subject: [Koha-bugs] [Bug 27917] Make it clear that standing orders cannot create items at point of ordering In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27917 --- Comment #5 from Katrin Fischer --- Hope I understood it all correctly: - The standing order checkbox needs to remain editable in the basket. At the moment I know of no other way to "close" out a standing order than to make it no longer a standing order first. - It makes sense to only offer cataloguing and on receive as options when standing order is checked. Should we include a database update maybe to set all the standing orders with "on order" to "cataloguing"? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:00:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:00:19 +0000 Subject: [Koha-bugs] [Bug 28073] Patron modifications should auto-open panel for referring patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119118|0 |1 is obsolete| | --- Comment #4 from PTFS Europe Sandboxes --- Created attachment 119128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119128&action=edit Bug 28073: Patron modifications should auto-open panel for referring patron record This patch makes it possible to link directly to the correct panel on the "Update patron records" page. The link on the checkout and patron details screen has been updated to read "Patron has pending modifications." Also changed: Moved the "Patron's address in doubt" message so that it is above the table of changed fields. To test, apply the patch and if necessary submit patron modification requests from multiple patrons via the OPAC. - Open the checkout page for one of these patrons. - If you are logged in as a user with permission to edit patron records you should see a message, "Pending modifications: Review pending modifications," which links to the pending modifications page. - Clicking the link should open the page for reviewing pending patron modifications, and the correct panel should be automatically expanded. - If you are logged in as a user without permission to edit patrons you should see the message "Pending modifications: Patron has pending modifications," which isn't linked. - The process should work exactly the same from the patron detail page. - Following the "Pending modifications" link from the staff interface home page or the patrons home page should work as before: The page opens with the first panel expanded. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:01:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:01:40 +0000 Subject: [Koha-bugs] [Bug 28073] Patron modifications should auto-open panel for referring patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Séverine Queune --- Problem was on my devbox, works perfectly on sandbox ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:02:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:02:20 +0000 Subject: [Koha-bugs] [Bug 27940] Fix missing email in OpacMaintenance page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27940 --- Comment #6 from Katrin Fischer --- I'd like to open a new bug here - could we agree to display the address from ReplytoDefault when set instead of KohaAdminEmailAdress? In some setups the KohaAdminEmailAdress nees to be set to noreply (same known issue as always with some mail servers being very strict about possible spam) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:14:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:14:07 +0000 Subject: [Koha-bugs] [Bug 28063] Minor change to OpacAuthorities description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28063 --- Comment #1 from Katrin Fischer --- The options on the advanced search for subject and author search in the bibliographic data by text and not in any authority data. They are completely independent of using authorities. Unless we are talking about different things? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:14:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:14:42 +0000 Subject: [Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013 --- Comment #11 from Nick Clemens --- (In reply to Jonathan Druart from comment #7) > I don't manage to convince myself it's correct. > There is an edge case, looking at the code: > > The patron iterator is set before the ITEM loop. On the second item, it > won't be reset and we won't iterate over all the patrons. > > Nick and/or Joonas, can you double check it please? Indeed, simply resetting after the loop should cover that. Adding test to prove that, however, uncovered additional problems. I filed bug 28078 and updated code here. I set to SO for another QA round to check what I added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:17:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:17:23 +0000 Subject: [Koha-bugs] [Bug 25709] Rename systempreference from NotesBlacklist to NotesToHide In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldoldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:17:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:17:24 +0000 Subject: [Koha-bugs] [Bug 25708] [OMNIBUS] Use allow/disallow terminology in code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25708 Bug 25708 depends on bug 25709, which changed state. Bug 25709 Summary: Rename systempreference from NotesBlacklist to NotesToHide https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:18:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:18:00 +0000 Subject: [Koha-bugs] [Bug 17127] Can't blacklist MARC21 500 with NotesToHide In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can't blacklist MARC21 500 |Can't blacklist MARC21 500 |with NotesBlacklist |with NotesToHide -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:18:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:18:09 +0000 Subject: [Koha-bugs] [Bug 28067] Syspref NotestoHide - some notes still appear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28067 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 17127 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:18:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:18:09 +0000 Subject: [Koha-bugs] [Bug 17127] Can't blacklist MARC21 500 with NotesToHide In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.genty at biblibre.com --- Comment #5 from Katrin Fischer --- *** Bug 28067 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:19:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:19:00 +0000 Subject: [Koha-bugs] [Bug 17906] Add possibility to hide MARC subfield with NotesToHide In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17906 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add possibility to |Add possibility to hide |blacklist MARC subfield |MARC subfield with |with notesblacklist |NotesToHide -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:19:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:19:38 +0000 Subject: [Koha-bugs] [Bug 9495] Split NotesToHide in to two prefs for staff and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9495 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Split NotesBlacklist in to |Split NotesToHide in to two |two prefs for staff and |prefs for staff and OPAC |OPAC | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:20:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:20:37 +0000 Subject: [Koha-bugs] [Bug 23243] Allow filtering out of historic subscription expirations in the check expiration of serials page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:20:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:20:39 +0000 Subject: [Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can't blacklist MARC21 500 |Can't hide MARC21 500 and |with NotesToHide |others with NotesToHide -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:20:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:20:41 +0000 Subject: [Koha-bugs] [Bug 23243] Allow filtering out of historic subscription expirations in the check expiration of serials page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105491|0 |1 is obsolete| | --- Comment #13 from Séverine Queune --- Created attachment 119129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119129&action=edit Bug 23243: Restore filtering out historic expired subscriptions The 'Check Expiration' page in Serials is now hardcoded to display all expired subscriptions before the entered date. This patch restores the ability to limit the results to just those expiring between 'today' and the date entered. Original code taken from bug 6968 autored by Maxime Pelletier, rebased by Charles Farmer and then moved to a new report and rebased again by Martin Renvoize. Test plan: 1) Without the patch any results after a search from this page will result in matches both before after todays date (but before the date you entered). 2) With the patch you should see a 'Show historic expirations' checkbox which will allow you to limit the results to just those that expire between the date you enter and today. Sponsored-by: CCSR Rescued-by: Charles Farmer Rescued-by: Martin Renvoize Signed-off-by: Martin Renvoize Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:20:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:20:45 +0000 Subject: [Koha-bugs] [Bug 23243] Allow filtering out of historic subscription expirations in the check expiration of serials page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105492|0 |1 is obsolete| | --- Comment #14 from Séverine Queune --- Created attachment 119130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119130&action=edit Bug 23243: Adjust previous patch Signed-off-by: Martin Renvoize Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:20:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:20:49 +0000 Subject: [Koha-bugs] [Bug 23243] Allow filtering out of historic subscription expirations in the check expiration of serials page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105493|0 |1 is obsolete| | --- Comment #15 from Séverine Queune --- Created attachment 119131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119131&action=edit Bug 23243: (follow-up) Update wording as requested Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:21:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:21:21 +0000 Subject: [Koha-bugs] [Bug 28068] Cash register should not record writeoff as cash received In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28068 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:22:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:22:23 +0000 Subject: [Koha-bugs] [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:24:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:24:06 +0000 Subject: [Koha-bugs] [Bug 28060] Point of sale debits should not automatically sort when edited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28060 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- Hi Esther, I belive this has been fixed quite recently with bug 27776. *** This bug has been marked as a duplicate of bug 27776 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:24:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:24:06 +0000 Subject: [Koha-bugs] [Bug 27776] Point of Sale 'This sale' table should not be sorted by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27776 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |estherm at sodaspringsid.com --- Comment #12 from Katrin Fischer --- *** Bug 28060 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:35:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:35:22 +0000 Subject: [Koha-bugs] [Bug 5242] Import patrons directly from Excel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5242 --- Comment #7 from Katrin Fischer --- (In reply to Pascale Nalon from comment #6) > I think this bug is not really one ... this one could be closed As you had filed it, you are also ok to close it :) Just move it to RESOLVED and pick one of the reasons shown. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:37:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:37:04 +0000 Subject: [Koha-bugs] [Bug 28077] Missing colon on suggestion modification page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28077 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:38:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:38:22 +0000 Subject: [Koha-bugs] [Bug 28077] Missing colon on suggestion modification page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28077 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:38:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:38:26 +0000 Subject: [Koha-bugs] [Bug 28077] Missing colon on suggestion modification page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28077 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119121|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 119132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119132&action=edit Bug 28077: Add a colon after the 'Reason' label on edit suggestion page This patch corrects the missing colon on the 'Edit purchase suggestion' page. To test : - go to Acquistions > Suggestions - edit a suggestion - on 'Suggestion management' bloc, see the colon missing after the 'Reason' label - apply patch - refresh the page - colon should now be displayed Happy sign off ! Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:38:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:38:42 +0000 Subject: [Koha-bugs] [Bug 28077] Missing colon on suggestion modification page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28077 --- Comment #4 from Katrin Fischer --- Thx Severine! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:39:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:39:40 +0000 Subject: [Koha-bugs] [Bug 28073] Patron modifications should auto-open panel for referring patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:40:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:40:21 +0000 Subject: [Koha-bugs] [Bug 28073] Patron modifications should auto-open panel for referring patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 --- Comment #6 from Katrin Fischer --- Sorry, this is BLOCKED right now, we still need a sign-off on bug 27873! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:40:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:40:27 +0000 Subject: [Koha-bugs] [Bug 28073] Patron modifications should auto-open panel for referring patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28073 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:43:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:43:40 +0000 Subject: [Koha-bugs] [Bug 27900] regression: add from existing record with null results deadends In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27900 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:45:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:45:58 +0000 Subject: [Koha-bugs] [Bug 28079] New: Set focus to search box field when adding an order to basket Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28079 Bug ID: 28079 Summary: Set focus to search box field when adding an order to basket Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: severine.queune at bulac.fr QA Contact: testopia at bugs.koha-community.org When adding an order to a basket, you have to click in the input box before searching for an existing record. It could be usefull if the cursor was focused on the search box. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 17:57:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 15:57:35 +0000 Subject: [Koha-bugs] [Bug 27873] Make display of patron restrictions, charges, notes, etc. consistent for check out and patron details screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27873 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #6 from Caroline Cyr La Rose --- So I added a restriction to my user, with the patch in the Details tab, there is no restriction, but in the Checkout tab, there is a restriction. To test : 1) WITHOUT the patch, add a manual restriction to a user. 2) In the details page, click on the Restrictions tab, the tab should say 1 Restriction and the restriction should appear 3) In the checkout page, click on the Restrictions tab, the tab should say 1 Restriction and the restriction should appear 4) Apply the patch and rebuild yarn + Ctrl+F5 5) In the details page, click on the Restrictions tab, the tab should only says "Restrictions" (no number) and the restriction is not in the tab 6) In the checkout page, click on the Restrictions tab, the tab should only says "Restrictions" (no number) but the restriction is in the tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 18:02:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 16:02:24 +0000 Subject: [Koha-bugs] [Bug 27852] Link YES_NO authorized value category to 942$n in Default framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 --- Comment #4 from Caroline Cyr La Rose --- Hi David! Thanks for testing this! I think I forgot to add that you have to also delete the frameworks... sorry about that Here's the updated test plan, hopefully this time it works! 1) Apply patch 2) In the database delete from marc_subfield_structure where frameworkcode = ""; delete from marc_subfield_structure where frameworkcode = "ACQ"; delete from marc_tag_structure where frameworkcode = ""; delete from marc_tag_structure where frameworkcode = "ACQ"; delete from biblio_framework where frameworkcode in ("", "ACQ"); 2) Load the yaml file ./misc/load_yaml.pl -f installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml --load 3) In Koha, go to cataloging and open an empty cataloging form using the Default framework 4) Go to 942$n: the value should read No and there should be a drop down choice between Yes and No -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 18:11:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 16:11:20 +0000 Subject: [Koha-bugs] [Bug 27900] regression: add from existing record with null results deadends In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27900 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 18:11:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 16:11:25 +0000 Subject: [Koha-bugs] [Bug 27900] regression: add from existing record with null results deadends In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27900 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119107|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 119133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119133&action=edit Bug 27900: Add a link back to the basket view if no result Since bug 24347 the neworderbiblio view has been removed and we now display the usual search result. When adding a new order from a search, if there is no result we should let the user get back to the basket view. Test plan: Add to basket from an existing record Do a search with no results and confirm that there is a new "Go to the basket view" link Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 18:11:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 16:11:30 +0000 Subject: [Koha-bugs] [Bug 27900] regression: add from existing record with null results deadends In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27900 --- Comment #7 from Katrin Fischer --- Created attachment 119134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119134&action=edit Bug 27900: (QA follow-up) Add missing filter Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 18:11:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 16:11:34 +0000 Subject: [Koha-bugs] [Bug 27900] regression: add from existing record with null results deadends In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27900 --- Comment #8 from Katrin Fischer --- Created attachment 119135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119135&action=edit Bug 27900: (QA follow-up) Rephrase link text See discussion on IRC from today :) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 18:15:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 16:15:27 +0000 Subject: [Koha-bugs] [Bug 27773] Hide unique holidays and exceptions which have passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27773 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer --- Owen, can you please check? FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt FAIL filters asset_must_be_raw at line 8 ([% Asset.css("css/calendar.css") %]) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 18:18:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 16:18:51 +0000 Subject: [Koha-bugs] [Bug 24564] The adding of new subfields according to IFLA updates doesn't respect existing tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24564 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119103|0 |1 is obsolete| | --- Comment #7 from PTFS Europe Sandboxes --- Created attachment 119136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119136&action=edit Bug 24564: Do not modify the tab of existing subfield in ifla/update.pl Test plan: 1. Find a biblio subfield in misc/migration_tools/ifla/data/biblio/default.yml that you have in your default biblio MARC framework (or create one). 2. Change the tab of this subfield so that it's different from what's in the .yml file 3. Run misc/migration_tools/ifla/update.pl --force 4. Verify that the tab of this subfield has not been changed. 5. Do the same for authorities (files are in misc/migration_tools/ifla/data/auth/) Signed-off-by: sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 18:18:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 16:18:55 +0000 Subject: [Koha-bugs] [Bug 24564] The adding of new subfields according to IFLA updates doesn't respect existing tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24564 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119104|0 |1 is obsolete| | --- Comment #8 from PTFS Europe Sandboxes --- Created attachment 119137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119137&action=edit Bug 24564: Use the same tab as the other subfields within a field For each subfield added, we check if other subfields exists in the same field. If that's the case we use the same tab as the first subfield found. Test plan: 1. Find a biblio subfield in misc/migration_tools/ifla/data/biblio/default.yml that doesn't exist in your default biblio MARC framework (or delete one). The field should exist and have other subfields with a tab set. 2. Change the tab of all subfields within that field it's different from what's in the .yml file 3. Run misc/migration_tools/ifla/update.pl 4. Verify that the subfield has been added and have the same tab as others subfields 5. Do the same for authorities (files are in misc/migration_tools/ifla/data/auth/) Signed-off-by: Koha team Signed-off-by: sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 18:19:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 16:19:10 +0000 Subject: [Koha-bugs] [Bug 28044] Calendar: Tables with closed days are no longer color coded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28044 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 18:19:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 16:19:13 +0000 Subject: [Koha-bugs] [Bug 28044] Calendar: Tables with closed days are no longer color coded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28044 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119058|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 119138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119138&action=edit Bug 28044: Increase specificity of calendar tables CSS This patch adds increased specificity to the CSS which should add colors to the tables of holidays. The default DataTable CSS was overriding the custom color-coding. This patch also moves the calendar CSS into a separate file. To test, apply the patch and go to Tools -> Calendar. If necessary, add at least one of the following: - Unique holiday - Holiday repeating weekly - Holiday repeating monthly - Holiday exception In the table listing each kind of holiday, the color of the table header should match the colors in the "Key" section under Hints. The color should be correct regardless of how the table is sorted. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 18:39:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 16:39:52 +0000 Subject: [Koha-bugs] [Bug 28066] Remove select tag's size attribute where it is 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28066 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 2 18:39:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Apr 2021 16:39:56 +0000 Subject: [Koha-bugs] [Bug 28066] Remove select tag's size attribute where it is 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28066 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119049|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 119139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119139&action=edit Bug 28066: Remove select tag's size attribute where it is 1 This patch removes the "size" attribute from tags without a size attribute while preserving the desired behavior of