[Koha-bugs] [Bug 28013] Improvements to CanBookBeRenewed

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28013

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #7)
> I don't manage to convince myself it's correct.
> There is an edge case, looking at the code:
> 
> The patron iterator is set before the ITEM loop. On the second item, it
> won't be reset and we won't iterate over all the patrons.
> 
> Nick and/or Joonas, can you double check it please?

Indeed, simply resetting after the loop should cover that.

Adding test to prove that, however, uncovered additional problems. I filed bug
28078 and updated code here.

I set to SO for another QA round to check what I added.

-- 
You are receiving this mail because:
You are watching all bug changes.