[Koha-bugs] [Bug 28097] t/db_dependent/Koha/Account/Line.t test fails with FinesMode set to calculate

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28097

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This is a side effect of bug 8338.

With finesMode set to 'production' and CalculateFinesOnReturn set to 'enabled'
upon return we will first re-calculate the fine amount (in this case that would
result in a '0' amount fine).. we then call '_FixOverduesOnReturn' which
subsequently fines the '0' amount fine and deletes it on the assumption it's a
backdated return which had resulted in an errant fine.

I wonder if, rather than delete the original fine, we should void it which
would give a more thorough audit trail (and fix this bug).. However, I think
such a VOID would still appear on the patrons account in the OPAC and that was
what I believe people wanted to avoid with bug 8338.

The easy fix here is to adjust the test to mock the two preferences to ensure
they are disabled for the test case.

-- 
You are receiving this mail because:
You are watching all bug changes.