[Koha-bugs] [Bug 28058] Move javascript out of columns_settings.inc into separate file
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Thu Apr 8 14:32:45 CEST 2021
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058
--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 119321
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119321&action=edit
Bug 28058: (follow-up) Make same change in the OPAC; Use "table_settings" as
file name
This patch moves the JavaScript contained in a <script> block inside
columns_settings.inc in the OPAC into a separate file.
The new JavaScript file, table_settings.js, contains some corrections to
minor errors highlighted by eslint (missing semicolons, undeclared
variables, etc).
This patch also moves template include files and corresponding
JavaScript files to the name "table_settings" instead of
"columns_settings." Updated are all files where "columns_settings.inc"
was referenced.
To test, apply the patch and test pages in the OPAC and staff interface
that use the table_settings include file, e.g.
Staff interface:
- Administration -> Libraries
- Circulation -> Check out
OPAC:
- Course reserves
- Logged in patron -> "Your summary"
In all cases DataTable should display correctly, with all associated
controls. Changes made to the tables' configuration via 'Administration
-> Table settings' should be reflected in the corresponding page.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list