[Koha-bugs] [Bug 25760] Holds Ratio report is not reporting on records with 1 hold

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25760

Frank Hansen <frank.hansen at ub.lu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #114978|0                           |1
        is obsolete|                            |

--- Comment #14 from Frank Hansen <frank.hansen at ub.lu.se> ---
Created attachment 119324
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119324&action=edit
Bug 25760: [Alternate] (bug 15422 follow-up) Display record with hold ratio
greater than or equal to the value entered

On bug 15422 we made it so that only holds with copies to buy to acheive the
holds ratio
showed

Users have reported that they want to see record where there are 0 copies to
buy i.e.
the holds ration matches the value entered

This patch changes the criteria for returning holds to be if the ratio for a
given title
is equal to or greater then the ratio specified in the form

I also renamed 'ratiocalc' to 'copies_to_buy' since that is what is contains

Test plan:
1. Create bibliographic records with 1, 2 and 3 items
2. Place 1 hold on each of them
3. Go to the Hold ratios report and search with ratio = 1, 2 then 3
4. You expect to see:
   the title with 1 item with ratio 1
   nothing otherwise
5. Place another hold on each of the record
6. Repeat 3 you expect to see:
   titles with 1 or 2 items with ratio 1
   title with 1 item for ratio 2
   nothing with ratio 3
7. Place another hold on each of the record
8. Repeat 3 you expect to see:
   titles with 1 or 2 or 3 items with ratio 1
   title with 1 item or 2 items for ratio 2
   nothing with ratio 3
9. Make sure there is no regression in the test plan of bug 15422

Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se>

I was able to apply the patch and test it.

Some comments.
When I adding the third hold on each record in step 7, It will result in
the following result:

titles with 1 or 2 or 3 items with ratio 1
title with 1 items with ratio 2 because the title with 2 items will get
a ratio of 1.50 and not 2.
title with 1 items with with ratio 3

-- 
You are receiving this mail because:
You are watching all bug changes.