[Koha-bugs] [Bug 28104] New: last line of sitemapindex.xml lacks EOL

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28104

            Bug ID: 28104
           Summary: last line of sitemapindex.xml lacks EOL
 Change sponsored?: ---
           Product: Koha
           Version: 20.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: bargioni at pusc.it
        QA Contact: testopia at bugs.koha-community.org
                CC: jonathan.druart at bugs.koha-community.org,
                    robin at catalyst.net.nz
                CC: jonathan.druart at bugs.koha-community.org

$ /usr/sbin/koha-sitemap --generate instance
generates file 
/var/lib/koha/instance/sitemap/sitemapindex.xml
without the EOL of the last line. 

XML parsers can complain, e.g.:
$ xmllint --format /var/lib/koha/instance/sitemap/sitemapindex.xml 
/var/lib/koha/instance/sitemap/sitemapindex.xml:22: parser error : expected '>'
</sitemapindex>
         ^
/var/lib/koha/instance/sitemap/sitemapindex.xml:22: parser error : Premature
end of data in tag sitemapindex line 3
</sitemapindex>
               ^

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I don't recreate the problem. Can you provide more detail please?

$ perl debian/scripts/koha-sitemap --enable kohadev
Sitemap enabled for kohadev
$ perl debian/scripts/koha-sitemap --generate  kohadev                          
Sitemap directory for kohadev doesn't exist. Creating.

$ xmllint --format /var/lib/koha/kohadev/sitemap/sitemapindex.xml               
<?xml version="1.0" encoding="UTF-8"?>
<sitemapindex xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
  <sitemap>
    <loc>http://kohadev.myDNSname.org:8080/sitemap0001.xml</loc>
    <lastmod>2021-04-09</lastmod>
  </sitemap>
</sitemapindex>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.