[Koha-bugs] [Bug 28028] fix_onloan.pl broken by bug 23463

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28028

--- Comment #8 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
(In reply to Joonas Kylmälä from comment #7)
> Hmm, strange:
> 
> If I look ModItem() subroutine on revision
> 0c8d8e867b18b61f39381d2061cd2124fe1c5ed3 (which is just before it was
> deleted from codebase it has not fetched issues.date_due value as far as I
> can see, I checked all the code paths in ModItem() to my best ability.
> 
> So this would conflict with what both Martin and Katrin are remembering.

Yup, I now checked out Koha version just before Bug 23463 was merged:

$ git reset --hard f04e77c7e5411ca7dcf761e7e1177d7362a10654

and the fix_onloan.pl script didn't update the items.onloan value to be same as
in issues table.

Here is the steps I used to test this:

> $ git reset --hard f04e77c7e5411ca7dcf761e7e1177d7362a10654
> $ reset_all
> # Checkout an item to patron and then:
> $ koha-mysql kohadev
> > update items SET onloan = "2020-01-01" WHERE itemnumber=549
> $ koha-shell kohadev
> $ (inside koha-shell) perl fix_onloan.pl
> $ koha-mysql kohadev
> > select * from items WHERE itemnumber=549 # and notice it didn't update

So I strongly think this script has been doing nothing after bug 5579 has been
merged and we stopped storing items in MARC format.

-- 
You are receiving this mail because:
You are watching all bug changes.