[Koha-bugs] [Bug 24154] No indication that Default checkout, hold and return policy are set if values are blank

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24154

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 119767
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119767&action=edit
Bug 24154: Get rules rather than values to determine if set or not

Template plugin CirculationRules.Search returns "" if a rule doesn't exist or
if
the rule exists but is set to ""

To get more info, we add a 'want_rule' parameter and use that to test if
defined but
blank

To test:
1 - In circulation rules set the 'Default checkout, hold and return policy'
without setting values
2 - Unset it
3 - Notice there is no visual difference
4 - Apply patch
5 - Reload the page
6 - note there is no 'Unset button' and first column says 'Not set'
7 - Save the rule with no values
8 - Now 'Defaults' is displayed and the unset button exists

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.