[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703

--- Comment #101 from wainuiwitikapark at catalyst.net.nz ---
(In reply to Henry Bolshaw from comment #98)
> Wainui and Martin, most of these all look great but I think there are two
> minor outstanding issues:
> 
> 1) I'm getting an error page when I click on Budgets or Funds
> (koha/admin/aqbudgets.pl)
> 
> This is the error message:
> 
> "Template process failed: file error - parse error -
> /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt
> line 8: unexpected token (END)
>   [% END %] at /kohadevbox/koha/C4/Templates.pm line 122"
> 
> I think there's something wrong with the title field in aqbudgets.tt:
> 
>  <title>[% IF ( budget_id ) %]Modify fund[% IF ( budget_name ) %] '[%
> budget_name | html %]'[% END %][% ELSE %]Add fund [% END %][    % END %]
> › Funds[% IF op == 'add_form' %] › Administration ›
> Koha</title>
> 
> Should it look something like this instead? 
> 
> <title>[% IF op == 'add_form' %][% IF ( budget_id ) %]Modify fund[% IF (
> budget_name ) %] '[% budget_name | html %]'[% END %][% ELSE %]Add fund[% END
> %][% END %]› Funds › Administration › Koha</title>
> 
> 2) There's a typo in the the currency.pl title
> 
> I think it should be "Currencies › Currencies & Exchange rates ›
> Administration › Koha" rather than 
> "Currencies › Exchange rates › Currencies & Administration › Koha"

Hi Henry! Thanks so much for pointing these out. I have added 2 follow-up
patches to correct these.

-- 
You are receiving this mail because:
You are watching all bug changes.