[Koha-bugs] [Bug 28169] New: Text value of holdallowed rendered without quotes in JS

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28169

            Bug ID: 28169
           Summary: Text value of holdallowed rendered without quotes in
                    JS
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: nugged at gmail.com
          Reporter: nugged at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, joonas.kylmala at helsinki.fi,
                    kyle.m.hall at gmail.com, stalkernoid at gmail.com
        Depends on: 27069

There is code in request.tt:

    homebranch: "[% To.json( Branches.GetName( itemloo.homebranch ) ) | $raw
%]",
    holdallowed: [% itemloo.holdallowed | html %]

which earlier rendered itemloo.holdallowed ony digits for itemloo.holdallowed
but now it has string, for example 'from_any_library', so it should be in
quotes now.

To reproduce the problem:
1. Add circulation rules which allow 1 hold to the itemtype
2. Make 1 hold to patron
3. Make sure AllowHoldPolicyOverride syspref enabled
4. Make hold waiting and click revert button, you should see now JS error

I am providing a fix today.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27069
[Bug 27069] Change holdallowed values from numbers to strings
-- 
You are receiving this mail because:
You are watching all bug changes.