[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979

--- Comment #13 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
(In reply to Nick Clemens from comment #12)
> This certainly improves things, however, the initial problem reported still
> exists - a search for '1st to die' searches the isbn field

The internal server problem here reported initially is gone but maybe you mean
that the search result still doesn't make any sense here? If we look at the
code the WHERE clause is buggy still. With these patches applied and with the
search string '1st to die' we will look for biblios with title '1st to die' OR
biblios with author and isbn both being '1st to die' so that doesn't sound like
it will provide very good results. The first patch here, Bug 17979: Fix
cataloguing search if ISBN 13 is passed should be obsoleted I think. However,
still searching for an author whose name is ISBN code makes this fail.

For the AND and OR precedence see for example:
https://dev.mysql.com/doc/refman/8.0/en/operator-precedence.html

-- 
You are receiving this mail because:
You are watching all bug changes.